--- loncom/interface/lonmsgdisplay.pm	2008/06/06 22:50:41	1.88
+++ loncom/interface/lonmsgdisplay.pm	2008/10/23 10:15:37	1.94
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Routines for messaging display
 #
-# $Id: lonmsgdisplay.pm,v 1.88 2008/06/06 22:50:41 bisitz Exp $
+# $Id: lonmsgdisplay.pm,v 1.94 2008/10/23 10:15:37 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -733,9 +733,12 @@ sub groupmail_sent {
 
 sub discrit {
     my $r=shift;
-    my $header = '<h1><font color="red">'.&mt('Critical Messages').'</font></h1>'.
-        '<form action="/adm/email" method="POST">'.
-        '<input type="hidden" name="confirm" value="true" />';
+    my $header = '<h1>'.&mt('Critical Messages').'</h1>'
+                .'<div class="LC_warning">'
+                .&mt('Access to other pages will be prevented until you have moved all critical messages to your inbox.')
+                .'</div><br />'
+                .'<form action="/adm/email" method="POST">'
+                .'<input type="hidden" name="confirm" value="true" />';
     my %what=&Apache::lonnet::dump('critical');
     my $result = '';
     foreach my $key (sort(keys(%what))) {
@@ -1236,7 +1239,11 @@ sub compout {
     my $dismsg='';
     my $disbase='';
     my $attachrow;
-    my $func=&mt('Send New');
+    my $func1='Send'; # do not translate here!
+    my %func2=( # do not translate here!
+               'ma'  => 'Message',
+               'msg' => 'Messages',
+              );
     my %lt=&Apache::lonlocal::texthash('us'  => 'Username',
 				       'do'  => 'Domain',
 				       'ad'  => 'Additional Recipients',
@@ -1244,8 +1251,6 @@ sub compout {
                                        'ar'  => 'Allow replies',
 				       'sb'  => 'Subject',
 				       'ca'  => 'Cancel',
-				       'ma'  => 'Mail',
-                                       'msg' => 'Messages',
                                        'gen' => 'Generate messages from a file',
                                        'gmt' => 'General message text',
                                        'tff' => 'The file format for the uploaded portion of the message is',
@@ -1253,7 +1258,7 @@ sub compout {
                                        'atta' => 'Attachment',
                                       );
     my %attachmax = (
-                     text => '(128 KB max size)',
+                     text => &mt('(128 KB max size)'),
                      num  => 131072,
                     );
     if (!$forwarding && !$multiforward) {
@@ -1293,7 +1298,7 @@ sub compout {
 	%content=&Apache::lonmsg::unpackagemsg($message{$forwarding},$folder);
 	$dispcrit.='<input type="hidden" name="forwid" value="'.
 	    $forwarding.'" />';
-	$func=&mt('Forward');
+	$func1='Forward'; # do not translate here!
 	
 	$dissub=&mt('Forwarding').': '.$content{'subject'};
 	$dismsg=&mt('Forwarded message from').' '.
@@ -1307,7 +1312,7 @@ sub compout {
 	%content=&Apache::lonmsg::unpackagemsg($message{$replying},$folder);
 	$dispcrit.='<input type="hidden" name="replyid" value="'.
 	    $replying.'" />';
-	$func=&mt('Send Reply to');
+	$func1='Send Reply to'; # do not translate here!
 	
 	$dissub=&mt('Reply').': '.$content{'subject'};       
 	$dismsg='> '.$content{'message'};
@@ -1418,7 +1423,7 @@ ENDREPSCRIPT
                   &mt('Unless you choose otherwise:').'<ul><li>'.
         &mt("The subject in each forwarded message will be <i>'Forwarding:'</i> followed by the original subject.").'</li><li>'.
         &mt("The message itself will begin with a first line: <i>'Forwarded message from'</i> followed by the original sender's name.").'</li></ul></td></tr>');
-        $func=&mt('Forward');
+        $func1='Forward'; # do not translate here!
         $dissub = &mt('Forwarding').': ';
         $subj_size = '10';
         my $extra = '&lt;'.&mt('original subject').'&gt;&nbsp;&nbsp;&nbsp;'.
@@ -1437,7 +1442,7 @@ $latexHelp.
         foreach my $msg (@to_forward) {
             $r->print('<input type="hidden" name="delmark" value="'.$msg.'" />');
         }
-        $r->print(&submit_button_row($folder,$dismode,$func.' '.$lt{'msg'},
+        $r->print(&submit_button_row($folder,$dismode,&mt($func1.' '.$func2{'msg'}),
                                      \%lt));
     } elsif ($broadcast ne 'upload') {
         $subj_size = '50';
@@ -1459,7 +1464,7 @@ $attachrow
 $dispcrit
 $disbase
 ENDCOMP
-        $r->print(&submit_button_row($folder,$dismode,$func.' '.$lt{'ma'},
+        $r->print(&submit_button_row($folder,$dismode,&mt($func1.' '.$func2{'ma'}),
                                      \%lt));
         $r->print($citation);
         if (exists($env{'form.ref'})) {
@@ -2093,7 +2098,6 @@ sub displaymessage {
     my %message=&Apache::lonnet::get('nohist_email'.$suffix,[$msgid]);
     my %content=&Apache::lonmsg::unpackagemsg($message{$msgid});
     my $counter=0;
-    $r->print('<pre>');
     my $escmsgid=&escape($msgid);
     foreach (@messages) {
 	if ($_->[5] eq $escmsgid){
@@ -2101,7 +2105,6 @@ sub displaymessage {
 	}
 	$counter++;
     }
-    $r->print('</pre>');
 
     my $see_anonymous;
     my $from_student = 0;
@@ -2152,18 +2155,33 @@ sub displaymessage {
         $symb=&Apache::lonnet::symbread($content{'baseurl'});
     }
     if ($env{'user.adv'}) {
-	my $adv_actions;
-	$r->print('<table border="2" width="100%"><tr bgcolor="#FFAAAA"><td>'.&mt('Currently available actions (will open extra window)').':</td>');
+        my $actionlist='';
 	if (&Apache::lonnet::allowed('vgr',$env{'request.course.id'})) {
-		$r->print('<td><b>'.&Apache::loncommon::track_student_link(&mt('View recent activity'),$content{'sendername'},$content{'senderdomain'},'check').'</b></td>');
-	    }
+		$actionlist.='<td><b>'
+                            .&Apache::loncommon::track_student_link(
+                                 &mt('View recent activity'),$content{'sendername'},$content{'senderdomain'},'check')
+                            .'</b></td>';
+	}
 	if (&Apache::lonnet::allowed('opa',$env{'request.course.id'}) && $symb) {
-	    $r->print('<td><b>'.&Apache::loncommon::pprmlink(&mt('Set/Change parameters'),$content{'sendername'},$content{'senderdomain'},$symb,'check').'</b></td>');
+	    $actionlist.='<td><b>'
+                        .&Apache::loncommon::pprmlink(
+                             &mt('Set/Change parameters'),$content{'sendername'},$content{'senderdomain'},$symb,'check')
+                        .'</b></td>';
 	}
 	if (&Apache::lonnet::allowed('mgr',$env{'request.course.id'}) && $symb) {
-	    $r->print('<td><b>'.&Apache::loncommon::pgrdlink(&mt('Set/Change grades'),$content{'sendername'},$content{'senderdomain'},$symb,'check').'</b></td>');
+	    $actionlist.='<td><b>'
+                       .&Apache::loncommon::pgrdlink(
+                            &mt('Set/Change grades'),$content{'sendername'},$content{'senderdomain'},$symb,'check')
+                       .'</b></td>';
 	}
-	$r->print('</tr></table>');
+        if ($actionlist) {
+            $r->print('<table border="2" width="100%">'
+                     .'<tr bgcolor="#FFAAAA"><td>'
+                     .&mt('Currently available actions (will open extra window):')
+                     .'</td>'
+                     .$actionlist
+                     .'</tr></table>');
+        }
     }
     my ($tolist,$cclist);
     my (@recipients,@ccs);
@@ -2196,46 +2214,83 @@ sub displaymessage {
 	$r->print(&Apache::loncommon::student_image_tag($content{'senderdomain'},$content{'sendername'}));
     }
 
-    $r->print('<br /><b>'.&mt('Subject').':</b> '.$content{'subject'});
+    # Display LON-CAPA Message (Start)
+    # Subject
+    $r->print('<br />'
+             .&Apache::lonhtmlcommon::start_pick_box()
+             .&Apache::lonhtmlcommon::row_title(&mt('Subject'))
+             .$content{'subject'}
+             .&Apache::lonhtmlcommon::row_closure()
+    );
     if ($folder eq 'sent') {
-        $r->print('<br /><b>'.&mt('To').':</b> '.$tolist);
+        # To
+        $r->print(&Apache::lonhtmlcommon::row_title(&mt('To'))
+                 .$tolist
+                 .&Apache::lonhtmlcommon::row_closure()
+        );
         if ($content{'replytoaddr'}) {
             my ($replytoname,$replytodom) = split(/:/,$content{'replytoaddr'});
             if ($replytoname ne '' && $replytodom ne '') {
-                $r->print('<br /><b>'.&mt('Reply To').':</b> '.
-                          $replytoname.' '.&mt('at').' '.$replytodom);
+                $r->print(&Apache::lonhtmlcommon::row_title(&mt('Reply To'))
+                         .&mt('[_1] at [_2]',$replytoname,$replytodom)
+                         .&Apache::lonhtmlcommon::row_closure()
+                );
             }
         }
     } else {
-        $r->print('<br /><b>'.&mt('From').':</b> '.
-	      &Apache::loncommon::aboutmewrapper(
-						 &Apache::loncommon::plainname($content{'sendername'},$content{'senderdomain'}),
-						 $content{'sendername'},$content{'senderdomain'}));
+        # From, Reply
+        $r->print(&Apache::lonhtmlcommon::row_title(&mt('From'))
+                 .&Apache::loncommon::aboutmewrapper(
+                     &Apache::loncommon::plainname($content{'sendername'},$content{'senderdomain'}),
+                                                 $content{'sendername'},$content{'senderdomain'})
+        );
         if ($content{'noreplies'}) {
-            $r->print(' ('.&mt('No replies to sender').')'); 
+            $r->print(' ('.&mt('No replies to sender').')'
+                     .&Apache::lonhtmlcommon::row_closure()
+            ); 
         } else {
             if ($content{'replytoaddr'}) {
                 my ($replytoname,$replytodom) = split(/:/,$content{'replytoaddr'});
                 if ($replytoname ne '' && $replytodom ne '') {
-                    $r->print('<br /><b>'.&mt('Reply To').':</b> '.
-                              $replytoname.' '.&mt('at').' '.$replytodom);
+                    $r->print(&Apache::lonhtmlcommon::row_closure()
+                             .&Apache::lonhtmlcommon::row_title(&mt('Reply To'))
+                             .&mt('[_1] at [_2]',$replytoname,$replytodom)
+                             .&Apache::lonhtmlcommon::row_closure()
+                    );
+                } else {
+                    $r->print(&Apache::lonhtmlcommon::row_closure());
                 }
             } else {
-                $r->print(' ('.$content{'sendername'}.' '.&mt('at').' '.
-                          $content{'senderdomain'}.') ');
+                $r->print(' ('.&mt('[_1] at [_2]',$content{'sendername'},$content{'senderdomain'}).') '
+                         .&Apache::lonhtmlcommon::row_closure()
+                );
             }
             if ($cclist) {
-                $r->print('<br /><b>'.&mt('Cc').':</b> '.$cclist);
+                $r->print(&Apache::lonhtmlcommon::row_title(&mt('Cc'))
+                         .$cclist
+                         .&Apache::lonhtmlcommon::row_closure()
+                    );
+
             }
-        } 
+        }
     }
+
+    # Course
     if ($content{'courseid'}) {
-        $r->print('<br /><b>'.&mt($crstype).':</b> '.$courseinfo{'description'});
+        $r->print(&Apache::lonhtmlcommon::row_title(&mt($crstype))
+                 .$courseinfo{'description'}
+        );
         if ($content{'coursesec'}) {
             $r->print(' ('.&mt('Section').': '.$content{'coursesec'}.')');
         }
+        $r->print(&Apache::lonhtmlcommon::row_closure());
     }
-    $r->print('<br /><b>'.&mt('Time').':</b> '.$content{'time'});
+    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Time'))
+             .$content{'time'}
+             .&Apache::lonhtmlcommon::row_closure()
+    );
+
+    # Refers to
     if ($baseurl) {
         if (defined($content{'courseid'}) && defined($env{'request.course.id'})) {
             if ($content{'courseid'} eq $env{'request.course.id'}) {
@@ -2253,7 +2308,10 @@ sub displaymessage {
                 if ($encrypturl =~ /^yes$/i && !$env{'request.role.adv'}) {
                     $showurl = $baseurl;
                 }
-                $r->print('<br /><b>'.&mt('Refers to').':</b> <a href="'.$showurl.$symblink.'">'.$restitle.'</a>');
+                $r->print(&Apache::lonhtmlcommon::row_title(&mt('Refers to'))
+                         .'<a href="'.$showurl.$symblink.'">'.$restitle.'</a>'
+                         .&Apache::lonhtmlcommon::row_closure()
+                );
                 $refers_to = 1;
             }
         }
@@ -2266,25 +2324,41 @@ sub displaymessage {
                                                         $content{'courseid'});
                         if ($unencurl ne '') {
                             if (&Apache::lonnet::allowed('bre',$unencurl)) {
-                                $r->print('<br /><b>'.&mt('Refers to').
-                                          ':</b> <a href="'.$unencurl.'">'.
-                                          $restitle.'</a>');
+                                $r->print(&Apache::lonhtmlcommon::row_title(&mt('Refers to'))
+                                         .'<a href="'.$unencurl.'">'.$restitle.'</a>'
+                                         .&Apache::lonhtmlcommon::row_closure()
+                                );
                             }
                         }
                     }
                 }
             } else {
                 if (&Apache::lonnet::allowed('bre',$baseurl)) {
-                    $r->print('<br /><b>'.&mt('Refers to').
-                              ':</b> <a href="'.$baseurl.
-                              '">'.$restitle.'</a>');
+                    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Refers to'))
+                             .'<a href="'.$baseurl.'">'.$restitle.'</a>'
+                             .&Apache::lonhtmlcommon::row_closure()
+                    );
+
                 }
             }
         }
     }
-    $r->print('<p><pre>'.
-	      &Apache::lontexconvert::msgtexconverted($content{'message'},1).
-	      '</pre><hr />'.&displayresource(%content).'</p>');
+
+    # Message
+    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Message'))
+             .'<pre>'
+	     .&Apache::lontexconvert::msgtexconverted($content{'message'},1)
+	     .'</pre>'
+    );
+    if (&displayresource(%content)) {
+        $r->print(&Apache::lonhtmlcommon::row_closure()
+                 .&Apache::lonhtmlcommon::row_title(&mt('Resource Details'))
+                 .&displayresource(%content)
+        );
+    } 
+    $r->print(&Apache::lonhtmlcommon::row_closure(1).
+              &Apache::lonhtmlcommon::end_pick_box());
+    # Display LON-CAPA Message (End)
     return;
 }