--- loncom/interface/lonparmset.pm	2006/04/18 18:10:55	1.293
+++ loncom/interface/lonparmset.pm	2006/05/01 19:37:33	1.298
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.293 2006/04/18 18:10:55 www Exp $
+# $Id: lonparmset.pm,v 1.298 2006/05/01 19:37:33 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -117,7 +117,6 @@ sub parmval {
 sub parmval_by_symb {
     my ($what,$symb,$def,$uname,$udom,$csec,$cgroup,$courseopt)=@_;
 # load caches
-
     &cacheparmhash();
 
     my $useropt=&Apache::lonnet::get_userresdata($uname,$udom);
@@ -650,8 +649,7 @@ sub startpage {
 				       &page_js(),
 				       {'add_entries' => \%loaditems,});
     my $breadcrumbs = 
-	&Apache::lonhtmlcommon::breadcrumbs(undef,
-					    'Table Mode Parameter Setting');
+	&Apache::lonhtmlcommon::breadcrumbs('Table Mode Parameter Setting');
     $r->print(<<ENDHEAD);
 $start_page
 $breadcrumbs
@@ -1416,7 +1414,6 @@ sub assessparms {
     my $uhome;
     my $csec;
     my $cgroup;
-    my $grouplist;
     my @usersgroups = ();
  
     my $coursename=$env{'course.'.$env{'request.course.id'}.'.description'};
@@ -1522,16 +1519,12 @@ sub assessparms {
 			.$name{'lastname'}.' '.$name{'generation'}.
 			    "<br>\n".&mt('ID').": ".$name{'id'}.'<p>';
 	    }
-            $grouplist = &Apache::lonnet::get_users_groups(
+            @usersgroups = &Apache::lonnet::get_users_groups(
                                        $udom,$uname,$env{'request.course.id'});
-            if ($grouplist) {
-                @usersgroups = &Apache::lonnet::sort_course_groups($grouplist,
-                                                    $env{'request.course.id'});
+            if (@usersgroups > 0) {
                 unless (grep/^\Q$cgroup\E$/,@usersgroups) {
                     $cgroup = $usersgroups[0];
-                } 
-            } else {
-                $cgroup = '';
+                }
             }
         }
     }
@@ -1990,8 +1983,8 @@ sub crsenv {
     my $r=shift;
     my $setoutput='';
 
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,
-						    'Edit Course Environment');
+    my $breadcrumbs = 
+	&Apache::lonhtmlcommon::breadcrumbs('Edit Course Environment');
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
 
@@ -2094,7 +2087,8 @@ sub crsenv {
     }
 # ------------------------- Re-init course environment entries for this session
 
-    &Apache::lonnet::coursedescription($env{'request.course.id'});
+    &Apache::lonnet::coursedescription($env{'request.course.id'}
+				       {'freshen_cache' => 1});
 
 # -------------------------------------------------------- Get parameters again
 
@@ -2333,7 +2327,7 @@ sub tablestart {
 	return '';
     } else {
 	$tableopen=1;
-	return '<table border="2"><tr><th>'.&mt('Parameter').'</th><th>'.
+	return &Apache::loncommon::start_data_table().'<tr><th>'.&mt('Parameter').'</th><th>'.
 	    &mt('Delete').'</th><th>'.&mt('Set to ...').'</th></tr>';
     }
 }
@@ -2341,7 +2335,7 @@ sub tablestart {
 sub tableend {
     if ($tableopen) {
 	$tableopen=0;
-	return '</table>';
+	return &Apache::loncommon::end_data_table();
     } else {
 	return'';
     }
@@ -2592,7 +2586,9 @@ sub listdata {
 #
 # Ready to print
 #
-	    $r->print(&tablestart().'<tr><td><b>'.&standard_parameter_names($name).
+	    $r->print(&tablestart().
+		      &Apache::loncommon::start_data_table_row().
+		      '<td><b>'.&standard_parameter_names($name).
 		      '</b></td><td><input type="checkbox" name="del_'.
 		      $thiskey.'" /></td><td>');
 	    $foundkeys++;
@@ -2638,7 +2634,7 @@ sub listdata {
 	    }
 	    $r->print('<input type="hidden" name="typeof_'.$thiskey.'" value="'.
 		      $thistype.'">');
-	    $r->print('</td></tr>');
+	    $r->print('</td>'.&Apache::loncommon::end_data_table_row());
 	}
     }
     return $foundkeys;
@@ -2650,7 +2646,7 @@ sub newoverview {
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $start_page = &Apache::loncommon::start_page('Set Parameters');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Overview');
     $r->print(<<ENDOVER);
 $start_page
 $breadcrumbs
@@ -2804,7 +2800,7 @@ sub overview {
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
 
     my $start_page=&Apache::loncommon::start_page('Modify Parameters');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Overview');
     $r->print(<<ENDOVER);
 $start_page
 $breadcrumbs
@@ -3094,8 +3090,7 @@ sub setrestrictmeta {
     my $put_result;
     
     $r->print(&Apache::loncommon::start_page('Restrict Metadata'));
-    $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
-						    'Restrict Metadata'));
+    $r->print(&Apache::lonhtmlcommon::breadcrumbs('Restrict Metadata'));
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $key_base = $env{'course.'.$env{'request.course.id'}.'.'};
@@ -3126,7 +3121,8 @@ sub setrestrictmeta {
             }
         }
     }
-    &Apache::lonnet::coursedescription($env{'request.course.id'});
+    &Apache::lonnet::coursedescription($env{'request.course.id'},
+				       {'freshen_cache' => 1});
     my %metadata_fields = &Apache::lonmeta::fieldnames('portfolio');
     foreach my $field (sort(keys(%metadata_fields))) {
         &Apache::lonnet::logthis ($field);
@@ -3151,7 +3147,7 @@ sub defaultsetter {
 
     my $start_page = 
 	&Apache::loncommon::start_page('Parameter Setting Default Actions');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Defaults');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Defaults');
     $r->print(<<ENDDEFHEAD);
 $start_page
 $breadcrumbs
@@ -3359,55 +3355,49 @@ sub parm_change_log {
     my %parmlog=&Apache::lonnet::dump('nohist_parameterlog',
 				      $env{'course.'.$env{'request.course.id'}.'.domain'},
 				      $env{'course.'.$env{'request.course.id'}.'.num'});
-    my %exetime=();
-    foreach my $key (keys(%parmlog)) {
-	if ($key=~/^(.+)\_exe\_time$/) {
-	    $exetime{$1}=$parmlog{$key};
-	}
-    }    
     my $courseopt=&Apache::lonnet::get_courseresdata($env{'course.'.$env{'request.course.id'}.'.num'},
 						     $env{'course.'.$env{'request.course.id'}.'.domain'});
     $r->print('<table border="2">');
     my $bgcolor='#EEEEEE';
-    foreach my $id (sort { $exetime{$b}<=>$exetime{$a} } (keys(%exetime))) {
+    foreach my $id (sort { $parmlog{$b}{'exe_time'}<=>$parmlog{$a}{'exe_time'} } (keys(%parmlog))) {
 	if ($bgcolor eq '#EEEEEE') { $bgcolor='#FFFFCC'; } else { $bgcolor='#EEEEEE'; }
-        my @changes=keys(%{$parmlog{$id.'_logentry'}});
+        my @changes=keys(%{$parmlog{$id}{'logentry'}});
 	my $count=$#changes+1;
 	my $time =
-	    &Apache::lonlocal::locallocaltime($parmlog{$id.'_exe_time'});
+	    &Apache::lonlocal::locallocaltime($parmlog{$id}{'exe_time'});
 	my $plainname = 
-	    &Apache::loncommon::plainname($parmlog{$id.'_exe_uname'},
-					  $parmlog{$id.'_exe_udom'});
+	    &Apache::loncommon::plainname($parmlog{$id}{'exe_uname'},
+					  $parmlog{$id}{'exe_udom'});
 	my $about_me_link = 
 	    &Apache::loncommon::aboutmewrapper($plainname,
-					       $parmlog{$id.'_exe_uname'},
-					       $parmlog{$id.'_exe_udom'});
+					       $parmlog{$id}{'exe_uname'},
+					       $parmlog{$id}{'exe_udom'});
 	my $send_msg_link='';
-	if ((($parmlog{$id.'_exe_uname'} ne $env{'user.name'}) 
-	     || ($parmlog{$id.'_exe_udom'} ne $env{'user.domain'}))) {
+	if ((($parmlog{$id}{'exe_uname'} ne $env{'user.name'}) 
+	     || ($parmlog{$id}{'exe_udom'} ne $env{'user.domain'}))) {
 	    $send_msg_link ='<br />'.
 		&Apache::loncommon::messagewrapper(&mt('Send message'),
-						   $parmlog{$id.'_exe_uname'},
-						   $parmlog{$id.'_exe_udom'});
+						   $parmlog{$id}{'exe_uname'},
+						   $parmlog{$id}{'exe_udom'});
 	}
 	$r->print('<tr bgcolor="'.$bgcolor.'"><td rowspan="'.$count.'">'.$time.'</td>
                        <td rowspan="'.$count.'">'.$about_me_link.
-		  '<br /><tt>'.$parmlog{$id.'_exe_uname'}.
-			          ':'.$parmlog{$id.'_exe_udom'}.'</tt>'.
+		  '<br /><tt>'.$parmlog{$id}{'exe_uname'}.
+			          ':'.$parmlog{$id}{'exe_udom'}.'</tt>'.
 		  $send_msg_link.'</td>');
 	my $makenewrow=0;
 	my %istype=();
 	foreach my $changed (reverse(sort(@changes))) {
-            my $value=$parmlog{$id.'_logentry'}->{$changed};
+            my $value=$parmlog{$id}{'logentry'}->{$changed};
             my ($realm,$section,$parmname,$part,$typeflag,$what,$middle,$uname,$udom,$issection)=
-		&components($changed,$parmlog{$id.'_uname'},$parmlog{$id.'_udom'});
+		&components($changed,$parmlog{$id}{'uname'},$parmlog{$id}{'udom'});
 	    if ($typeflag) { $istype{$parmname}=$value; }
 	    if ($makenewrow) { $r->print('<tr bgcolor="'.$bgcolor.'">'); } else { $makenewrow=1; }
 	    $r->print('<td>'.$realm.'</td><td>'.$section.'</td><td>'.
 		      &standard_parameter_names($parmname).'</td><td>'.
 		      ($part?&mt('Part: [_1]',$part):&mt('All Parts')).'</td><td>');
 	    my $stillactive=0;
-	    if ($parmlog{$id.'_deleteflag'}) {
+	    if ($parmlog{$id}{'deleteflag'}) {
 		$r->print(&mt('Deleted'));
 	    } else {
 		if ($typeflag) {
@@ -3508,8 +3498,7 @@ sub handler {
 
         } elsif (! exists($env{'form.action'})) {
             $r->print(&header());
-            $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
-							 'Parameter Manager'));
+            $r->print(&Apache::lonhtmlcommon::breadcrumbs('Parameter Manager'));
             &print_main_menu($r,$parm_permission);
         } elsif ($env{'form.action'} eq 'crsenv' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=crsenv',
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 root@localhost to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
</body></html>