--- loncom/interface/lonparmset.pm	2006/04/18 20:35:47	1.294
+++ loncom/interface/lonparmset.pm	2006/05/09 14:38:10	1.299
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.294 2006/04/18 20:35:47 www Exp $
+# $Id: lonparmset.pm,v 1.299 2006/05/09 14:38:10 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -117,7 +117,6 @@ sub parmval {
 sub parmval_by_symb {
     my ($what,$symb,$def,$uname,$udom,$csec,$cgroup,$courseopt)=@_;
 # load caches
-
     &cacheparmhash();
 
     my $useropt=&Apache::lonnet::get_userresdata($uname,$udom);
@@ -650,8 +649,7 @@ sub startpage {
 				       &page_js(),
 				       {'add_entries' => \%loaditems,});
     my $breadcrumbs = 
-	&Apache::lonhtmlcommon::breadcrumbs(undef,
-					    'Table Mode Parameter Setting');
+	&Apache::lonhtmlcommon::breadcrumbs('Table Mode Parameter Setting');
     $r->print(<<ENDHEAD);
 $start_page
 $breadcrumbs
@@ -1126,14 +1124,11 @@ sub usermenu {
                  $env{'course.'.$env{'request.course.id'}.'.num'},
 					 \%sectionhash);
     my $groups;
-    my %grouphash;
-    my $numgrp = &Apache::loncommon::coursegroups(
-                 \%grouphash,
-                 $env{'course.'.$env{'request.course.id'}.'.domain'},
-                 $env{'course.'.$env{'request.course.id'}.'.num'});
+    my %grouphash = &Apache::loncommon::coursegroups();
+
     if ($numsec > 0) {
         $sections=$lt{'se'}.': <select name="csec"';
-        if ($numsec && $numgrp && $parmlev ne 'full') {
+        if (%grouphash && $parmlev ne 'full') {
             $sections .= qq| onchange="group_or_section('csec')" |;
         }
         $sections .= '>';
@@ -1144,7 +1139,7 @@ sub usermenu {
         }
         $sections.='</select>';
     }
-    if ($numsec && $numgrp && $parmlev ne 'full') {
+    if ($numsec && %grouphash && $parmlev ne 'full') {
         $sections .= '&nbsp;or&nbsp;';
         $sections .= qq|
 <script type="text/javascript">
@@ -1170,9 +1165,10 @@ function group_or_section(caller) {
 </script>
 |;
     } 
-    if ($numgrp > 0) {
+
+    if (%grouphash) {
         $groups=$lt{'gr'}.': <select name="cgroup"';
-        if ($numsec && $numgrp && $env{'form.action'} eq 'settable') {
+        if ($numsec && $env{'form.action'} eq 'settable') {
             $groups .= qq| onchange="group_or_section('cgroup')" |;
         }
         $groups .= '>';
@@ -1273,25 +1269,21 @@ sub sectionmenu {
 
 sub groupmenu {
     my ($r,$selectedgroups)=@_;
-    my %grouphash;
-    my $numgrp = &Apache::loncommon::coursegroups(
-                 \%grouphash,
-                 $env{'course.'.$env{'request.course.id'}.'.domain'},
-                 $env{'course.'.$env{'request.course.id'}.'.num'});
-    if ($numgrp) {
-        $r->print('<select name="Group" multiple="true" size="8" >');
-        foreach my $group (sort(keys(%grouphash))) {
-            $r->print('    <option value="'.$group.'"');
-            foreach (@{$selectedgroups}) {
-                if ($group eq $_) {
-                    $r->print(' selected');
-                    last;
-                }
-            }
-            $r->print('>'.$group."</option>\n");
-        }
-        $r->print("</select>\n");
+    my %grouphash = &Apache::loncommon::coursegroups();
+    return if (!%grouphash);
+
+    $r->print('<select name="Group" multiple="true" size="8" >');
+    foreach my $group (sort(keys(%grouphash))) {
+	$r->print('    <option value="'.$group.'"');
+	foreach (@{$selectedgroups}) {
+	    if ($group eq $_) {
+		$r->print(' selected');
+		last;
+	    }
+	}
+	$r->print('>'.$group."</option>\n");
     }
+    $r->print("</select>\n");
 }
 
 
@@ -1416,7 +1408,6 @@ sub assessparms {
     my $uhome;
     my $csec;
     my $cgroup;
-    my $grouplist;
     my @usersgroups = ();
  
     my $coursename=$env{'course.'.$env{'request.course.id'}.'.description'};
@@ -1522,16 +1513,12 @@ sub assessparms {
 			.$name{'lastname'}.' '.$name{'generation'}.
 			    "<br>\n".&mt('ID').": ".$name{'id'}.'<p>';
 	    }
-            $grouplist = &Apache::lonnet::get_users_groups(
+            @usersgroups = &Apache::lonnet::get_users_groups(
                                        $udom,$uname,$env{'request.course.id'});
-            if ($grouplist) {
-                @usersgroups = &Apache::lonnet::sort_course_groups($grouplist,
-                                                    $env{'request.course.id'});
+            if (@usersgroups > 0) {
                 unless (grep/^\Q$cgroup\E$/,@usersgroups) {
                     $cgroup = $usersgroups[0];
-                } 
-            } else {
-                $cgroup = '';
+                }
             }
         }
     }
@@ -1990,8 +1977,8 @@ sub crsenv {
     my $r=shift;
     my $setoutput='';
 
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,
-						    'Edit Course Environment');
+    my $breadcrumbs = 
+	&Apache::lonhtmlcommon::breadcrumbs('Edit Course Environment');
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
 
@@ -2094,7 +2081,8 @@ sub crsenv {
     }
 # ------------------------- Re-init course environment entries for this session
 
-    &Apache::lonnet::coursedescription($env{'request.course.id'});
+    &Apache::lonnet::coursedescription($env{'request.course.id'}
+				       {'freshen_cache' => 1});
 
 # -------------------------------------------------------- Get parameters again
 
@@ -2333,7 +2321,7 @@ sub tablestart {
 	return '';
     } else {
 	$tableopen=1;
-	return '<table border="2"><tr><th>'.&mt('Parameter').'</th><th>'.
+	return &Apache::loncommon::start_data_table().'<tr><th>'.&mt('Parameter').'</th><th>'.
 	    &mt('Delete').'</th><th>'.&mt('Set to ...').'</th></tr>';
     }
 }
@@ -2341,7 +2329,7 @@ sub tablestart {
 sub tableend {
     if ($tableopen) {
 	$tableopen=0;
-	return '</table>';
+	return &Apache::loncommon::end_data_table();
     } else {
 	return'';
     }
@@ -2592,7 +2580,9 @@ sub listdata {
 #
 # Ready to print
 #
-	    $r->print(&tablestart().'<tr><td><b>'.&standard_parameter_names($name).
+	    $r->print(&tablestart().
+		      &Apache::loncommon::start_data_table_row().
+		      '<td><b>'.&standard_parameter_names($name).
 		      '</b></td><td><input type="checkbox" name="del_'.
 		      $thiskey.'" /></td><td>');
 	    $foundkeys++;
@@ -2638,7 +2628,7 @@ sub listdata {
 	    }
 	    $r->print('<input type="hidden" name="typeof_'.$thiskey.'" value="'.
 		      $thistype.'">');
-	    $r->print('</td></tr>');
+	    $r->print('</td>'.&Apache::loncommon::end_data_table_row());
 	}
     }
     return $foundkeys;
@@ -2650,7 +2640,7 @@ sub newoverview {
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $start_page = &Apache::loncommon::start_page('Set Parameters');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Overview');
     $r->print(<<ENDOVER);
 $start_page
 $breadcrumbs
@@ -2804,7 +2794,7 @@ sub overview {
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
 
     my $start_page=&Apache::loncommon::start_page('Modify Parameters');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Overview');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Overview');
     $r->print(<<ENDOVER);
 $start_page
 $breadcrumbs
@@ -3094,8 +3084,7 @@ sub setrestrictmeta {
     my $put_result;
     
     $r->print(&Apache::loncommon::start_page('Restrict Metadata'));
-    $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
-						    'Restrict Metadata'));
+    $r->print(&Apache::lonhtmlcommon::breadcrumbs('Restrict Metadata'));
     my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'};
     my $crs = $env{'course.'.$env{'request.course.id'}.'.num'};
     my $key_base = $env{'course.'.$env{'request.course.id'}.'.'};
@@ -3126,7 +3115,8 @@ sub setrestrictmeta {
             }
         }
     }
-    &Apache::lonnet::coursedescription($env{'request.course.id'});
+    &Apache::lonnet::coursedescription($env{'request.course.id'},
+				       {'freshen_cache' => 1});
     my %metadata_fields = &Apache::lonmeta::fieldnames('portfolio');
     foreach my $field (sort(keys(%metadata_fields))) {
         &Apache::lonnet::logthis ($field);
@@ -3151,7 +3141,7 @@ sub defaultsetter {
 
     my $start_page = 
 	&Apache::loncommon::start_page('Parameter Setting Default Actions');
-    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs(undef,'Defaults');
+    my $breadcrumbs = &Apache::lonhtmlcommon::breadcrumbs('Defaults');
     $r->print(<<ENDDEFHEAD);
 $start_page
 $breadcrumbs
@@ -3502,8 +3492,7 @@ sub handler {
 
         } elsif (! exists($env{'form.action'})) {
             $r->print(&header());
-            $r->print(&Apache::lonhtmlcommon::breadcrumbs(undef,
-							 'Parameter Manager'));
+            $r->print(&Apache::lonhtmlcommon::breadcrumbs('Parameter Manager'));
             &print_main_menu($r,$parm_permission);
         } elsif ($env{'form.action'} eq 'crsenv' && $parm_permission) {
             &Apache::lonhtmlcommon::add_breadcrumb({href=>'/adm/parmset?action=crsenv',