--- loncom/interface/lonparmset.pm	2006/07/03 12:59:58	1.319
+++ loncom/interface/lonparmset.pm	2006/08/09 20:40:16	1.328
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.319 2006/07/03 12:59:58 foxr Exp $
+# $Id: lonparmset.pm,v 1.328 2006/08/09 20:40:16 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -508,21 +508,26 @@ sub storeparm_by_symb_inner {
 
 Format a value for output.
 
-Inputs:  $value, $type
+Inputs:  $value, $type, $editable
 
 Returns: $value, formatted for output.  If $type indicates it is a date,
 localtime($value) is returned.
+$editable will return an icon to click on
 
 =cut
 
 ##################################################
 ##################################################
 sub valout {
-    my ($value,$type)=@_;
+    my ($value,$type,$editable)=@_;
     my $result = '';
     # Values of zero are valid.
     if (! $value && $value ne '0') {
-	$result = '  ';
+	if ($editable) {
+	    $result = '<span class="LC_clickhere">*</span>';
+	} else {
+	    $result='&nbsp;';
+	}
     } else {
         if ($type eq 'date_interval') {
             my ($sec,$min,$hour,$mday,$mon,$year)=gmtime($value);
@@ -590,7 +595,7 @@ sub plink {
     return '<table width="100%"><tr valign="top" align="right"><td><a name="'.$marker.'" /></td></tr><tr><td align="center">'.
 	'<a href="javascript:pjump('."'".$type."','".$dis."','".$winvalue."','"
 	    .$marker."','".$return."','".$call."','".$hour."','".$min."','".$sec."'".');">'.
-		&valout($value,$type).'</a></td></tr></table>';
+		&valout($value,$type,1).'</a></td></tr></table>';
 }
 
 sub page_js {
@@ -655,7 +660,7 @@ sub startpage {
 				       &page_js(),
 				       {'add_entries' => \%loaditems,});
     my $breadcrumbs = 
-	&Apache::lonhtmlcommon::breadcrumbs('Table Mode Parameter Setting');
+	&Apache::lonhtmlcommon::breadcrumbs('Table Mode Parameter Setting','Table_Mode');
     $r->print(<<ENDHEAD);
 $start_page
 $breadcrumbs
@@ -2305,7 +2310,7 @@ sub crsenv {
 	'</script>';
     
     my $start_page = 
-	&Apache::loncommon::start_page('Set Course Environment Parameters',
+	&Apache::loncommon::start_page('Set Course Environment',
 				       $browse_js);
     my $end_page = 
 	&Apache::loncommon::end_page();
@@ -2584,15 +2589,6 @@ sub listdata {
 		$oldpart=$part;
 	    }
 #
-# Preset defaults?
-#
-            my ($hour,$min,$sec,$val)=('','','','');
-	    unless ($$resourcedata{$thiskey}) {
-		my ($parmname)=($thiskey=~/\.(\w+)$/);
-		($hour,$min,$sec,$val)=&preset_defaults($parmname);
-	    }
-
-#
 # Ready to print
 #
 	    $r->print(&tablestart().
@@ -2608,7 +2604,7 @@ sub listdata {
 			  &Apache::lonhtmlcommon::date_setter('parmform',
 							      $jskey,
 						      $$resourcedata{$thiskey},
-							      '',1,'','',$hour,$min,$sec).
+							      '',1,'','').
 '<input type="hidden" name="datepointer_'.$thiskey.'" value="'.$jskey.'" />'.
 &date_sanity_info($$resourcedata{$thiskey})
 			  );
@@ -2616,8 +2612,6 @@ sub listdata {
 		my $showval;
 		if (defined($$resourcedata{$thiskey})) {
 		    $showval=$$resourcedata{$thiskey};
-		} else {
-		    $showval=$val;
 		}
 		$r->print('<label><input type="radio" name="set_'.$thiskey.
 			  '" value="yes"');
@@ -2635,8 +2629,6 @@ sub listdata {
 		my $showval;
 		if (defined($$resourcedata{$thiskey})) {
 		    $showval=$$resourcedata{$thiskey};
-		} else {
-		    $showval=$val;
 		}
 		$r->print('<input type="text" name="set_'.$thiskey.'" value="'.
 			  $showval.'">');
@@ -3003,10 +2995,12 @@ ENDMAINFORMHEAD
     my $vgr  = &Apache::lonnet::allowed('vgr',$env{'request.course.id'});
 
     my @menu =
-        (
-          { text => 'Set Course Environment Parameters',
+        ( { divider=>'Settings for Your Course',
+	  },
+          { text => 'Set Course Environment',
 	    action => 'crsenv',
             permission => $parm_permission,
+            help => 'Course_Environment',
             },
           { text => 'Set Portfolio Metadata',
 	    action => 'setrestrictmeta',
@@ -3016,29 +3010,34 @@ ENDMAINFORMHEAD
 	    url => '/adm/slotrequest?command=showslots',
 	    permission => $vgr,
             },
-	  { divider => 1,
+          { text => 'Set Parameter Setting Default Actions',
+            action => 'setdefaults',
+            permission => $parm_permission,
+            },          
+	  { divider => 'New and Existing Parameter Settings for Your Resources',
 	    },
           { text => 'Set/Modify Resource Parameters - Helper Mode',
             url => '/adm/helper/parameter.helper',
             permission => $parm_permission,
+            help => 'Parameter_Helper',
             },
-          { text => 'Modify Resource Parameters - Overview Mode',
-            action => 'setoverview',
-            permission => $parm_permission,
-            },          
-	  { text => 'Set Resource Parameters - Overview Mode',
+ 	  { text => 'Set/Modify Resource Parameters - Overview Mode',
             action => 'newoverview',
             permission => $parm_permission,
+            help => 'Parameter_Overview',
             },
           { text => 'Set/Modify Resource Parameters - Table Mode',
             action => 'settable',
             permission => $parm_permission,
-            help => 'Cascading_Parameters',
+            help => 'Table_Mode',
             },
-          { text => 'Set Parameter Setting Default Actions',
-            action => 'setdefaults',
+           { divider => 'Existing Parameter Settings for Your Resources',
+	  },
+	  { text => 'Modify Resource Parameters - Overview Mode',
+            action => 'setoverview',
             permission => $parm_permission,
-            },          
+            help => 'Parameter_Overview',
+ 	    },          
 	  { text => 'Parameter Change Log and Course Blog Posting/User Notification',
             action => 'parameterchangelog',
             permission => $parm_permission,
@@ -3047,7 +3046,7 @@ ENDMAINFORMHEAD
     my $menu_html = '';
     foreach my $menu_item (@menu) {
 	if ($menu_item->{'divider'}) {
-	    $menu_html .= '<hr />';
+	    $menu_html .= '<h3>'.&mt($menu_item->{'divider'}).'</h3>';
 	    next;
 	}
         next if (! $menu_item->{'permission'});
@@ -3350,27 +3349,29 @@ sub components {
 	    $what,$middle,$uname,$udom,$issection,$realmdescription);
 }
 
+my %standard_parms;
+sub load_parameter_names {
+    open(my $config,"<$Apache::lonnet::perlvar{'lonTabDir'}/packages.tab");
+    while (my $configline=<$config>) {
+	if ($configline !~ /\S/ || $configline=~/^\#/) { next; }
+	chomp($configline);
+	my ($short,$plain)=split(/:/,$configline);
+	my (undef,$name,$type)=split(/\&/,$short,3);
+	if ($type eq 'display') {
+	    $standard_parms{$name} = $plain;
+	}
+    }
+    close($config);
+    $standard_parms{'int_pos'}      = 'Positive Integer';
+    $standard_parms{'int_zero_pos'} = 'Positive Integer or Zero';
+    %standard_parms=&Apache::lonlocal::texthash(%standard_parms);	
+}
+
 sub standard_parameter_names {
     my ($name)=@_;
-    my %standard_parms=&Apache::lonlocal::texthash('duedate' => 'Due Date',
-						   'answerdate' => 'Answer Date',
-						   'opendate' => 'Open Date',
-						   'maxtries' => 'Max. Number of Tries',
-						   'weight' => 'Weight',
-						   'date_start' => 'Starting Date',
-						   'date_end' => 'Ending Date',
-                                                   'interval' => 'Time Interval Length',
-                                                   'tol' => 'Numerical Tolerance',
-                                                   'sig' => 'Significant Digits',
-                                                   'contentopen' => 'Content Opening Date',
-                                                   'contentclose' => 'Content Closing Date',
-                                                   'discussend' => 'End of Discussion Time',
-                                                   'discusshide' => 'Discussion Hidden',
-                                                   'problemstatus' => 'Problem Status Visible',
-						   'int_pos' => 'Positive Integer',
-						   'int_zero_pos' => 'Positive Integer or Zero',
-						   'hinttries' => 'Number of Tries till Hints appear',
-                                                   'numbubbles' => 'Number of Bubbles in Exam Mode');
+    if (!%standard_parms) {
+	&load_parameter_names();
+    }
     if ($standard_parms{$name}) {
 	return $standard_parms{$name}; 
     } else { 
@@ -3385,17 +3386,17 @@ sub standard_parameter_names {
 
 sub parm_change_log {
     my ($r)=@_;
-    &startpage($r);
+    $r->print(&Apache::loncommon::start_page('Parameter Change Log'));
+    $r->print(&Apache::lonhtmlcommon::breadcrumbs('Parameter Change Log'));
+
     my %parmlog=&Apache::lonnet::dump('nohist_parameterlog',
 				      $env{'course.'.$env{'request.course.id'}.'.domain'},
 				      $env{'course.'.$env{'request.course.id'}.'.num'});
 
     if ((keys(%parmlog))[0]=~/^error\:/) { undef(%parmlog); }
 
-    $r->print('<form action="/adm/parmset?action=settable"
-                     method="post" name"parameterlog">
-               <input type="hidden" name="action"
-                      value="parameterchangelog" />');
+    $r->print('<form action="/adm/parmset?action=parameterchangelog"
+                     method="post" name="parameterlog">');
     
     my %saveable_parameters = ('show' => 'scalar',);
     &Apache::loncommon::store_course_settings('parameter_log',
@@ -3409,7 +3410,9 @@ sub parm_change_log {
 				    (&mt('all'),10,20,50,100,1000,10000));
 
     $r->print('<nobr>'.&mt('[_1] Records',$countselect).'</nobr>'.
-	      '<input type="submit" value="'.&mt('Display').'" />');
+              '<label>'.&Apache::lonhtmlcommon::checkbox('includetypes',$env{'form.includetypes'},'1').
+	      ' '.&mt('Include parameter types').'</label>'.
+	      '<input type="submit" value="'.&mt('Display').'" /></form>');
 
     my $courseopt=&Apache::lonnet::get_courseresdata($env{'course.'.$env{'request.course.id'}.'.num'},
 						     $env{'course.'.$env{'request.course.id'}.'.domain'});
@@ -3421,6 +3424,7 @@ sub parm_change_log {
     foreach my $id (sort { $parmlog{$b}{'exe_time'}<=>$parmlog{$a}{'exe_time'} } (keys(%parmlog))) {
         my @changes=keys(%{$parmlog{$id}{'logentry'}});
 	my $count=$#changes+1;
+	if (!$env{'form.includetypes'}) { $count=$count/2; }
 	my $time =
 	    &Apache::lonlocal::locallocaltime($parmlog{$id}{'exe_time'});
 	my $plainname = 
@@ -3450,7 +3454,10 @@ sub parm_change_log {
             my $value=$parmlog{$id}{'logentry'}->{$changed};
             my ($realm,$section,$parmname,$part,$typeflag,$what,$middle,$uname,$udom,$issection,$realmdescription)=
 		&components($changed,$parmlog{$id}{'uname'},$parmlog{$id}{'udom'});
-	    if ($typeflag) { $istype{$parmname}=$value; }
+	    if ($typeflag) {
+		if (!$env{'form.includetypes'}) { next; } 
+		$istype{$parmname}=$value; 
+	    }
 	    if ($makenewrow) { $r->print($row_start); } else { $makenewrow=1; }
 	    $r->print('<td>'.$realm.'</td><td>'.$section.'</td><td>'.
 		      &standard_parameter_names($parmname).'</td><td>'.
@@ -3500,7 +3507,6 @@ sub parm_change_log {
 	      || $shown<=$env{'form.show'})) { last; }
     }
     $r->print(&Apache::loncommon::end_data_table());
-    $r->print('</form>');
     $r->print(&Apache::loncommon::end_page());
 }
 
@@ -3539,7 +3545,8 @@ sub handler {
     &Apache::lonhtmlcommon::add_breadcrumb({href=>"/adm/parmset",
 					    text=>"Parameter Manager",
 					    faq=>10,
-					    bug=>'Instructor Interface'});
+					    bug=>'Instructor Interface',
+                                            help => 'Parameter_Manager'});
 
 # ----------------------------------------------------- Needs to be in a course
     my $parm_permission =
@@ -3564,6 +3571,8 @@ sub handler {
         #  the table mode
         if ((($env{'form.command'} eq 'set') && ($env{'form.url'})
 	     && (!$env{'form.dis'})) || ($env{'form.symb'})) {
+            &Apache::lonhtmlcommon::add_breadcrumb({help=>'Problem_Parameters',
+						    text=>"Problem Parameters"});
 	    &assessparms($r);
 
         } elsif (! exists($env{'form.action'})) {