--- loncom/interface/lonparmset.pm	2009/06/30 14:30:26	1.463
+++ loncom/interface/lonparmset.pm	2009/07/14 13:53:03	1.467
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.463 2009/06/30 14:30:26 bisitz Exp $
+# $Id: lonparmset.pm,v 1.467 2009/07/14 13:53:03 amueller Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1368,39 +1368,162 @@ ENDSCRIPT
 
     $r->print(&Apache::lonhtmlcommon::row_closure(1));
 }
+# return a hash
+sub categories {
+    return ('time_settings' => 'Time Settings',
+    'grading' => 'Grading',
+    'tries' => 'Tries',
+    'problem_appearance' => 'Problem Appearance',
+    'behaviour_of_input_fields' => 'Behaviour of Input Fields',
+    'hiding' => 'Hiding',
+    'high_level_randomization' => 'High Level Randomization',
+    'slots' => 'Slots',
+    'file_submission' => 'File Submission',
+    'misc' => 'Miscellaneous' ); 
+}
+
+# return a hash. Like a look-up table
+sub lookUpTableParameter {
+ 
+    return ( 
+        'opendate' => 'time_settings',
+        'duedate' => 'time_settings',
+        'answerdate' => 'time_settings',
+        'interval' => 'time_settings',
+        'contentopen' => 'time_settings',
+        'contentclose' => 'time_settings',
+        'discussend' => 'time_settings',
+        'weight' => 'grading',
+        'handgrade' => 'grading',
+        'maxtries' => 'tries',
+        'hinttries' => 'tries',
+        'type' => 'problem_appearance',
+        'problemstatus' => 'problem_appearance',
+        'display' => 'problem_appearance',
+        'ordered' => 'problem_appearance',
+        'numbubbles' => 'problem_appearance',
+        'tol' => 'behaviour_of_input_fields',
+        'sig' => 'behaviour_of_input_fields',
+        'turnoffunit' => 'behaviour_of_input_fields',
+        'hiddenresource' => 'hiding',
+        'hiddenparts' => 'hiding',
+        'discusshide' => 'hiding',
+        'buttonshide' => 'hiding',
+        'turnoffeditor' => 'hiding',
+        'encrypturl' => 'hiding',
+        'randomorder' => 'high_level_randomization',
+        'randompick' => 'high_level_randomization',
+        'available' => 'slots',
+        'useslots' => 'slots',
+        'availablestudent' => 'slots',
+        'uploadedfiletypes' => 'file_submission',
+        'maxfilesize' => 'file_submission',
+        'cssfile' => 'misc',
+        'mapalias' => 'misc',
+        'acc' => 'misc',
+        'maxcollaborators' => 'misc',
+        'scoreformat' => 'misc',
+
+    );    
+}
+
+sub whatIsMyCategory {
+    my $name = shift;
+    my $catList = shift;
+    my @list;
+    my %lookUpList = &lookUpTableParameter; #Initilize the lookupList
+    my $cat = $lookUpList{$name};
+    if (defined($cat)) {
+        if (!defined($$catList{$cat})){
+            push @list, ($name);
+            $$catList{$cat} = \@list;
+        } else {
+            push @{${$catList}{$cat}}, ($name);     
+        }
+    } else {
+        if (!defined($$catList{'misc'})){
+            push @list, ($name);
+            $$catList{'misc'} = \@list;
+        } else {
+            push @{${$catList}{'misc'}}, ($name);     
+        }
+    }        
+}
+
+sub keysindisplayorderCategory {
+    my ($name,$keyorder)=@_;
+    return sort {
+    	$$keyorder{'parameter_0_'.$a} <=> $$keyorder{'parameter_0_'.$b}; 
+    } ( @{$name});
+}
+
+sub category_order {
+    return (
+        'time_settings' => 1,
+        'grading' => 2,
+        'tries' => 3,
+        'problem_appearance' => 4,
+        'hiding' => 5,
+        'behaviour_of_input_fields' => 6,
+        'high_level_randomization'  => 7,
+        'slots' => 8,
+        'file_submission' => 9,
+        'misc' => 10
+    );
+
+}
 
 sub parmboxes {
     my ($r,$allparms,$pscat,$keyorder)=@_;
     my $tempkey;
-
+    my $tempparameter;
+    my %categories = &categories;
+    my %category_order = &category_order();
+    my %categoryList = (
+        'time_settings' => [],
+        'grading' => [],
+        'tries' => [],
+        'problem_appearance' => [],
+        'behaviour_of_input_fields' => [],
+        'hiding' => [],
+        'high_level_randomization' => [],
+        'slots' => [],
+        'file_submission' => [],
+        'misc' => [],
+   );
+    foreach $tempparameter (keys %$allparms) {
+        &whatIsMyCategory($tempparameter, \%categoryList);
+    }
     #part to print the parm-list
     $r->print('<fieldset id="LC_parm_overview_parm_menu" style="display:none">'
-             .'<legend>'.&mt('Parameter').'</legend>'
-             ."\n"
-             .'<table>'
+             .'<legend>'.&mt('Parameter').'</legend>'."\n"
     );
-    my $cnt=0;
 
-    $r->print('<tr>');
-    foreach $tempkey (&keysindisplayorder($allparms,$keyorder)) {
-	$r->print("\n".'<td><label><input type="checkbox" name="pscat" ');
-	$r->print('value="'.$tempkey.'" ');
-        $r->print('onclick="checkboxChecked(\''.$tempkey.'\')"');
-	if ($$pscat[0] eq "all" || grep $_ eq $tempkey, @{$pscat}) {
-	    $r->print(' checked="checked"');
-	}
-        $r->print(' />'.($$allparms{$tempkey}=~/\S/ ? $$allparms{$tempkey}
-                                                  : $tempkey)
-                  .'</label></td>');
- 	$cnt++;
-        if ($cnt==4) {
-	    $r->print("</tr>\n<tr>");
-	    $cnt=0;
-	}
+    #Print parameters
+    for my $key (sort { $category_order{$a} <=> $category_order{$b} } keys %categoryList) {
+        if(@{$categoryList{$key}} == 0) {
+            next;
+        } else { 
+            $r->print('<fieldset>'
+                     .'<legend>'
+                     .&mt($categories{$key})
+                     .'</legend>'."\n");
+            foreach $tempkey (&keysindisplayorderCategory($categoryList{$key},$keyorder)) {
+                    $r->print('<span class="LC_nobreak">'
+                             .'<label><input type="checkbox" name="pscat" ');
+	            $r->print('value="'.$tempkey.'" ');
+                $r->print('onclick="checkboxChecked(\''.$tempkey.'\')"');
+	            if ($$pscat[0] eq "all" || grep $_ eq $tempkey, @{$pscat}) {
+	                $r->print(' checked="checked"');
+	            }
+                $r->print(' />'.($$allparms{$tempkey}=~/\S/ ? $$allparms{$tempkey}
+                                                      : $tempkey)
+                        .'</label></span> ');
+            }
+            $r->print('</fieldset>');
+        }
     }
-    $r->print('</tr>'
-             .'</table>'
-             .'<hr />'
+    $r->print('<hr />'
              .'<a href="javascript:hideParms()">'
              .&mt('Hide')
              .'</a>'
@@ -1636,9 +1759,16 @@ sub mapmenu {
                  .'</label></td>'
                  .&Apache::loncommon::end_data_table_row()
         );
+        my $whitespace = '<img src="'
+                        .&Apache::loncommon::lonhttpdurl("/adm/lonIcons/whitespace_21.gif")
+                        .'" alt="" />';
         foreach my $mapid (@{$tree}) {
+            # Indentation
             my $depth = $treeinfo->{$mapid}->{'depth'};
-            my $indent = ('&nbsp;'x$depth);
+            my $indent;
+            for (my $i = 0; $i < $depth; $i++) {
+                $indent.= $whitespace;
+            }
             $icon =  '<img src="/adm/lonIcons/navmap.folder.open.gif" alt="" />';
             if ($treeinfo->{$mapid}->{'type'} eq 'page') {
                 $icon = '<img src="/adm/lonIcons/navmap.page.open.gif" alt="" />';