--- loncom/interface/lonparmset.pm	2009/06/18 19:43:14	1.462
+++ loncom/interface/lonparmset.pm	2009/08/29 03:06:09	1.469
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.462 2009/06/18 19:43:14 neumanie Exp $
+# $Id: lonparmset.pm,v 1.469 2009/08/29 03:06:09 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1244,6 +1244,10 @@ sub isdateparm {
     return (($type=~/^date/) && (!($type eq 'date_interval')));
 }
 
+#
+# This function prints a list of parameters, which were selected. It also display a link from which you can
+# hide or show the complete parameter list, from which you can choose your parameters. 
+#
 sub parmmenu {
     my ($r,$allparms,$pscat,$keyorder)=@_;
     my $tempkey;
@@ -1330,7 +1334,6 @@ sub parmmenu {
     function checkboxChecked(id) {
         var li = "_li";
         var id_li = id.concat(li);
-
         if (document.getElementById(id_li).style.display == "none") {
             document.getElementById(id_li).style.display = "";
         }
@@ -1368,39 +1371,162 @@ ENDSCRIPT
 
     $r->print(&Apache::lonhtmlcommon::row_closure(1));
 }
+# return a hash
+sub categories {
+    return ('time_settings' => 'Time Settings',
+    'grading' => 'Grading',
+    'tries' => 'Tries',
+    'problem_appearance' => 'Problem Appearance',
+    'behaviour_of_input_fields' => 'Behaviour of Input Fields',
+    'hiding' => 'Hiding',
+    'high_level_randomization' => 'High Level Randomization',
+    'slots' => 'Slots',
+    'file_submission' => 'File Submission',
+    'misc' => 'Miscellaneous' ); 
+}
+
+# return a hash. Like a look-up table
+sub lookUpTableParameter {
+ 
+    return ( 
+        'opendate' => 'time_settings',
+        'duedate' => 'time_settings',
+        'answerdate' => 'time_settings',
+        'interval' => 'time_settings',
+        'contentopen' => 'time_settings',
+        'contentclose' => 'time_settings',
+        'discussend' => 'time_settings',
+        'weight' => 'grading',
+        'handgrade' => 'grading',
+        'maxtries' => 'tries',
+        'hinttries' => 'tries',
+        'type' => 'problem_appearance',
+        'problemstatus' => 'problem_appearance',
+        'display' => 'problem_appearance',
+        'ordered' => 'problem_appearance',
+        'numbubbles' => 'problem_appearance',
+        'tol' => 'behaviour_of_input_fields',
+        'sig' => 'behaviour_of_input_fields',
+        'turnoffunit' => 'behaviour_of_input_fields',
+        'hiddenresource' => 'hiding',
+        'hiddenparts' => 'hiding',
+        'discusshide' => 'hiding',
+        'buttonshide' => 'hiding',
+        'turnoffeditor' => 'hiding',
+        'encrypturl' => 'hiding',
+        'randomorder' => 'high_level_randomization',
+        'randompick' => 'high_level_randomization',
+        'available' => 'slots',
+        'useslots' => 'slots',
+        'availablestudent' => 'slots',
+        'uploadedfiletypes' => 'file_submission',
+        'maxfilesize' => 'file_submission',
+        'cssfile' => 'misc',
+        'mapalias' => 'misc',
+        'acc' => 'misc',
+        'maxcollaborators' => 'misc',
+        'scoreformat' => 'misc',
+
+    );    
+}
+
+sub whatIsMyCategory {
+    my $name = shift;
+    my $catList = shift;
+    my @list;
+    my %lookUpList = &lookUpTableParameter; #Initilize the lookupList
+    my $cat = $lookUpList{$name};
+    if (defined($cat)) {
+        if (!defined($$catList{$cat})){
+            push @list, ($name);
+            $$catList{$cat} = \@list;
+        } else {
+            push @{${$catList}{$cat}}, ($name);     
+        }
+    } else {
+        if (!defined($$catList{'misc'})){
+            push @list, ($name);
+            $$catList{'misc'} = \@list;
+        } else {
+            push @{${$catList}{'misc'}}, ($name);     
+        }
+    }        
+}
+
+sub keysindisplayorderCategory {
+    my ($name,$keyorder)=@_;
+    return sort {
+    	$$keyorder{'parameter_0_'.$a} <=> $$keyorder{'parameter_0_'.$b}; 
+    } ( @{$name});
+}
+
+sub category_order {
+    return (
+        'time_settings' => 1,
+        'grading' => 2,
+        'tries' => 3,
+        'problem_appearance' => 4,
+        'hiding' => 5,
+        'behaviour_of_input_fields' => 6,
+        'high_level_randomization'  => 7,
+        'slots' => 8,
+        'file_submission' => 9,
+        'misc' => 10
+    );
+
+}
 
 sub parmboxes {
     my ($r,$allparms,$pscat,$keyorder)=@_;
     my $tempkey;
-
+    my $tempparameter;
+    my %categories = &categories;
+    my %category_order = &category_order();
+    my %categoryList = (
+        'time_settings' => [],
+        'grading' => [],
+        'tries' => [],
+        'problem_appearance' => [],
+        'behaviour_of_input_fields' => [],
+        'hiding' => [],
+        'high_level_randomization' => [],
+        'slots' => [],
+        'file_submission' => [],
+        'misc' => [],
+   );
+    foreach $tempparameter (keys %$allparms) {
+        &whatIsMyCategory($tempparameter, \%categoryList);
+    }
     #part to print the parm-list
     $r->print('<fieldset id="LC_parm_overview_parm_menu" style="display:none">'
-             .'<legend>'.&mt('Parameter').'</legend>'
-             ."\n"
-             .'<table>'
+             .'<legend>'.&mt('Parameter').'</legend>'."\n"
     );
-    my $cnt=0;
 
-    $r->print('<tr>');
-    foreach $tempkey (&keysindisplayorder($allparms,$keyorder)) {
-	$r->print("\n".'<td><label><input type="checkbox" name="pscat" ');
-	$r->print('value="'.$tempkey.'" ');
-        $r->print('onclick="checkboxChecked(\''.$tempkey.'\')"');
-	if ($$pscat[0] eq "all" || grep $_ eq $tempkey, @{$pscat}) {
-	    $r->print(' checked="checked"');
-	}
-        $r->print(' />'.($$allparms{$tempkey}=~/\S/ ? $$allparms{$tempkey}
-                                                  : $tempkey)
-                  .'</label></td>');
- 	$cnt++;
-        if ($cnt==4) {
-	    $r->print("</tr>\n<tr>");
-	    $cnt=0;
-	}
-    }
-    $r->print('</tr>'
-             .'</table>'
-             .'<hr />'
+    #Print parameters
+    for my $key (sort { $category_order{$a} <=> $category_order{$b} } keys %categoryList) {
+        if(@{$categoryList{$key}} == 0) {
+            next;
+        } else { 
+            $r->print('<fieldset>'
+                     .'<legend>'
+                     .&mt($categories{$key})
+                     .'</legend>'."\n");
+            foreach $tempkey (&keysindisplayorderCategory($categoryList{$key},$keyorder)) {
+                    $r->print('<span class="LC_nobreak">'
+                             .'<label><input type="checkbox" name="pscat" ');
+	            $r->print('value="'.$tempkey.'" ');
+                $r->print('onclick="checkboxChecked(\''.$tempkey.'\')"');
+	            if ($$pscat[0] eq "all" || grep $_ eq $tempkey, @{$pscat}) {
+	                $r->print(' checked="checked"');
+	            }
+                $r->print(' />'.($$allparms{$tempkey}=~/\S/ ? $$allparms{$tempkey}
+                                                      : $tempkey)
+                        .'</label></span> ');
+            }
+            $r->print('</fieldset>');
+        }
+    }
+    $r->print('<hr />'
              .'<a href="javascript:hideParms()">'
              .&mt('Hide')
              .'</a>'
@@ -1409,6 +1535,9 @@ sub parmboxes {
     #&shortCuts($r,$allparms,$pscat,$keyorder);
     $r->print('</fieldset>');
 }
+#
+# This function offers some links on the parameter section to get with one click a group a parameters
+#
 sub shortCuts {
     my ($r,$allparms,$pscat,$keyorder)=@_;
 
@@ -1573,6 +1702,9 @@ function group_or_section(caller) {
                  ,$chooseopt));
 }
 
+#
+# This function shows on table Mode the available Parameters for the selected Resources
+#
 sub displaymenu {
     my ($r,$allparms,$allparts,$pscat,$psprt,$keyorder)=@_;
     $r->print(&Apache::lonhtmlcommon::topic_bar (2,&mt('Select Parameters')));
@@ -1588,7 +1720,8 @@ sub displaymenu {
 }
 
 sub mapmenu {
-    my ($r,$allmaps,$pschp,$maptitles)=@_;
+    my ($r,$allmaps,$pschp,$maptitles, $symbp)=@_;
+    my %allmaps_inverted = reverse %$allmaps;
     my $navmap = Apache::lonnavmaps::navmap->new();
     my $tree=[];
     my $treeinfo={};
@@ -1596,51 +1729,107 @@ sub mapmenu {
         my $it=$navmap->getIterator(undef,undef,undef,1,undef,undef);
         my $curRes;
         my $depth = 0;
-
+        my %parent = ();
+        my $startcount = 5;
+        my $lastcontainer = $startcount;
+# preparing what is to show ...
         while ($curRes = $it->next()) {
             if ($curRes == $it->BEGIN_MAP()) {
                 $depth++;
+                $parent{$depth}= $lastcontainer;
             }
             if ($curRes == $it->END_MAP()) {
                 $depth--;
+                $lastcontainer = $parent{$depth};
             }
             if (ref($curRes)) {
+                my $symb = $curRes->symb();
+                my $ressymb = $symb;
                 if (($curRes->is_sequence()) || ($curRes->is_page())) {
                     my $type = 'sequence';
                     if ($curRes->is_page()) {
                         $type = 'page';
                     }
                     my $id= $curRes->id();
-                    my ($mapid,$resid)=split(/\./,$id);
-                    if(!exists($treeinfo->{$mapid})) {
-                        push(@$tree,$mapid);	    
-                        $treeinfo->{$mapid} = {
+                    my $srcf = $curRes->src();
+                    my $resource_name = &Apache::lonnet::gettitle($srcf);
+                    if(!exists($treeinfo->{$id})) {
+                        push(@$tree,$id);
+                        my $enclosing_map_folder = &Apache::lonnet::declutter($curRes->enclosing_map_src());	    
+                        $treeinfo->{$id} = {
                                     depth => $depth,
                                     type  => $type,
+                                    name  => $resource_name,
+                                    enclosing_map_folder => $enclosing_map_folder,
                                     };
                     }
                 }
             }
         }
     }
-	
+# Show it ...	
     $r->print(&Apache::lonhtmlcommon::row_title(&mt('Select Enclosing Map or Folder')));
     if ((ref($tree) eq 'ARRAY') && (ref($treeinfo) eq 'HASH')) {
         my $icon = '<img src="/adm/lonIcons/navmap.folder.open.gif" alt="" />';
-        $r->print(&Apache::loncommon::start_data_table().&Apache::loncommon::start_data_table_header_row());
-        $r->print('<td>'.$icon.'<label>&nbsp;<input type="radio" name="pschp" checked="checked" value="all"/>'.&mt('All Maps or Folders').'</td>'.&Apache::loncommon::end_data_table_header_row());
-        foreach my $mapid (@{$tree}) {
-            my $depth = $treeinfo->{$mapid}->{'depth'};
-            my $indent = ('&nbsp;'x$depth);
+        $r->print(&Apache::loncommon::start_data_table()
+                 .&Apache::loncommon::start_data_table_row()
+                 .'<td>'.$icon
+                 .'<label>&nbsp;'
+                 .'<input type="radio" name="pschp" checked="checked" value="all" />'
+                 .&mt('All Maps or Folders')
+                 .'</label></td>'
+                 .&Apache::loncommon::end_data_table_row()
+        );
+        my $whitespace = '<img src="'
+                        .&Apache::loncommon::lonhttpdurl("/adm/lonIcons/whitespace_21.gif")
+                        .'" alt="" />';
+        if (exists($$allmaps{1})) {
+            $r->print(&Apache::loncommon::start_data_table_row()
+                .'<td>'.$icon
+                .'<label>&nbsp;'
+                .'<input type="radio" name="pschp" value="1"'
+            );
+            if ($pschp eq 1) {
+                $r->print(' checked="checked"');
+            }
+            $r->print('/>'
+                .$$maptitles{1}
+                .($$allmaps{1} !~/^uploaded/?' ['.$$allmaps{1}.']':'')
+                .'</label>'
+                .'</td>'
+                .&Apache::loncommon::end_data_table_row()
+            );
+        }
+        foreach my $id (@{$tree}) {
+            my ($mapid,$resid)=split(/\./,$id);
+            # Indentation
+            my $depth = $treeinfo->{$id}->{'depth'};
+            my $indent;
+            for (my $i = 0; $i < $depth; $i++) {
+                $indent.= $whitespace;
+            }
             $icon =  '<img src="/adm/lonIcons/navmap.folder.open.gif" alt="" />';
-            if ($treeinfo->{$mapid}->{'type'} eq 'page') {
+            if ($treeinfo->{$id}->{'type'} eq 'page') {
                 $icon = '<img src="/adm/lonIcons/navmap.page.open.gif" alt="" />';
             }
-            $r->print(&Apache::loncommon::start_data_table_header_row().'<td>'.$indent.$icon.'<label>&nbsp;<input type ="radio" name="pschp" value="'.$mapid.'"');
-            if ($pschp eq $mapid) {
+            my $symb_name = $$symbp{$id};
+            my ($front, $tail) = split (/___${resid}___/, $symb_name);
+            $symb_name = $tail;
+            $r->print(&Apache::loncommon::start_data_table_row()
+                     .'<td>'.$indent.$icon
+                     .'<label>&nbsp;'
+                     .'<input type ="radio" name="pschp" value="'.$allmaps_inverted{$symb_name}.'"'
+            );
+            if ($pschp eq $allmaps_inverted{$symb_name}) {
                 $r->print(' checked="checked"');
             }
-            $r->print('/>'.$$maptitles{$mapid}.($$allmaps{$mapid}!~/^uploaded/?' ['.$$allmaps{$mapid}.']':'').'</label></td>'.&Apache::loncommon::end_data_table_header_row());
+            $r->print('/>'
+                     .$treeinfo->{$id}->{name}
+                     .($$allmaps{$mapid}!~/^uploaded/?' ['.$$allmaps{$mapid}.']':'')
+                     .'</label>'
+                     .'</td>'
+                     .&Apache::loncommon::end_data_table_row()
+            );
         }
         $r->print(&Apache::loncommon::end_data_table());
     }
@@ -1823,6 +2012,7 @@ sub assessparms {
     } else {
 	$udom=$r->dir_config('lonDefDomain');
     }
+    
 
     my @pscat=&Apache::loncommon::get_env_multiple('form.pscat');
     my $pschp=$env{'form.pschp'};
@@ -2004,7 +2194,7 @@ ENDPARMSELSCRIPT
         $r->print('<div id="parmsel">');
     }
 
-    # Display parameter selection boxes
+    # Display Unit 1 "General Parameters"
     if (!$pssymb) {
         $r->print(&Apache::lonhtmlcommon::topic_bar (1,&mt('General Parameters')));
         $r->print(&Apache::lonhtmlcommon::start_pick_box());
@@ -2013,12 +2203,12 @@ ENDPARMSELSCRIPT
 
 	if ($parmlev ne 'general') {
             $r->print(&Apache::lonhtmlcommon::row_closure());
-	    &mapmenu($r,\%allmaps,$pschp,\%maptitles);
+	    &mapmenu($r,\%allmaps,$pschp,\%maptitles, \%symbp);
 	}
 
         $r->print(&Apache::lonhtmlcommon::row_closure(1));
         $r->print(&Apache::lonhtmlcommon::end_pick_box());
-       
+    #Display Unit 2 "Select Parameter"   
 	&displaymenu($r,\%allparms,\%allparts,\@pscat,\@psprt,\%keyorder);
     } else {
         my ($map,$id,$resource)=&Apache::lonnet::decode_symb($pssymb);
@@ -4028,7 +4218,7 @@ sub components {
 }
 
 my %standard_parms;
-
+my %standard_parms_types;
 
 sub load_parameter_names {
     open(my $config,"<$Apache::lonnet::perlvar{'lonTabDir'}/packages.tab");
@@ -4039,7 +4229,9 @@ sub load_parameter_names {
 	my (undef,$name,$type)=split(/\&/,$short,3);
 	if ($type eq 'display') {
 	    $standard_parms{$name} = $plain;
-	}
+        } elsif ($type eq 'type') {
+            $standard_parms_types{$name} = $plain;
+        }
     }
     close($config);
     $standard_parms{'int_pos'}      = 'Positive Integer';
@@ -4059,7 +4251,16 @@ sub standard_parameter_names {
     }
 }
 
-
+sub standard_parameter_types {
+    my ($name)=@_;
+    if (!%standard_parms_types) {
+        &load_parameter_names();
+    }
+    if ($standard_parms_types{$name}) {
+        return $standard_parms_types{$name};
+    }
+    return;
+}
 
 sub parm_change_log {
     my ($r)=@_;
@@ -4169,11 +4370,22 @@ sub parm_change_log {
 		} else {
 		    my ($level,@all)=&parmval_by_symb($what,$middle,&Apache::lonnet::metadata($middle,$what),
 						      $uname,$udom,$issection,$issection,$courseopt);
-		    if (&isdateparm($istype{$parmname})) {
-			$output .= &Apache::lonlocal::locallocaltime($value);
-		    } else {
-			$output .= $value;
-		    }
+                    my $showvalue = $value;
+                    if ($istype{$parmname} eq '') {
+                        my $type = &standard_parameter_types($parmname);
+                        if ($type ne '') {
+                            if (&isdateparm($type)) {
+                                $showvalue =
+                                    &Apache::lonlocal::locallocaltime($value);
+                            }
+                        }
+                    } else {
+		        if (&isdateparm($istype{$parmname})) {
+			    $showvalue = 
+                                &Apache::lonlocal::locallocaltime($value);
+		        }
+                    }
+                    $output .= $showvalue;
 		    if ($value ne $all[$level]) {
 			$output .= '<br /><span class="LC_warning">'.&mt('Not active anymore').'</span>';
 		    } else {