--- loncom/interface/lonparmset.pm	2009/11/22 21:07:41	1.486
+++ loncom/interface/lonparmset.pm	2010/06/06 02:40:30	1.496
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set parameters for assessments
 #
-# $Id: lonparmset.pm,v 1.486 2009/11/22 21:07:41 www Exp $
+# $Id: lonparmset.pm,v 1.496 2010/06/06 02:40:30 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -248,37 +248,6 @@ Variables used (guessed by Jeremy):
 
 =item parse_key()
 
-=item check_cloners() :
-
-Checks if new users included in list of allowed cloners
-are valid users.  Replaces supplied list with 
-cleaned list containing only users with valid usernames
-and domains.
-
-Inputs: $clonelist, $oldcloner 
-where $clonelist is ref to array of requested cloners,
-and $oldcloner is ref to array of currently allowed
-cloners.
-
-Returns: string - comma separated list of requested
-cloners (username:domain) who do not exist in system.
-
-=item change_clone() :
-
-Modifies the list of courses a user can clone (stored
-in the user's environment.db file), called when a
-change is made to the list of users allowed to clone
-a course.
-
-Inputs: $action,$cloner
-where $action is add or drop, and $cloner is identity of 
-user for whom cloning ability is to be changed in course. 
-
-
-=item check_cloners()
-
-=item change_clone()
-
 =item header()
 
 Output html header for page
@@ -1361,13 +1330,17 @@ ENDSCRIPT
                  .'</li>'
         );
     }
-    $r->print('</ul>'
-             .'<p><a href="javascript:showParms()">'
-             .&mt('Show detailed Parameter Selection')
-             .'</a></p>'
-    );
+    $r->print('</ul>');
 
+    $r->print('<hr />');
     &shortCuts($r,$allparms,$pscat,$keyorder);
+    $r->print('<hr />');
+
+    $r->print(
+        '<p><a href="javascript:showParms()">'
+       .&mt('Show detailed Parameter Selection')
+       .'</a></p>'
+    );
 
     $r->print(&Apache::lonhtmlcommon::row_closure(1));
 }
@@ -1493,13 +1466,24 @@ sub parmboxes {
         'slots' => [],
         'file_submission' => [],
         'misc' => [],
-   );
+    );
+    my $hidelink =
+        '<p>'
+       .'<a href="javascript:hideParms()">'
+       .&mt('Hide detailed Parameter Selection')
+       .'</a>'
+       .'</p>'
+       ."\n";
+;
     foreach $tempparameter (keys %$allparms) {
         &whatIsMyCategory($tempparameter, \%categoryList);
     }
     #part to print the parm-list
-    $r->print('<fieldset id="LC_parm_overview_parm_menu" style="display:none">'
-             .'<legend>'.&mt('Parameter').'</legend>'."\n"
+    $r->print(
+        '<div id="LC_parm_overview_parm_menu" class="LC_Box" style="display:none">'."\n"
+       .'<h3>'.&mt('Parameter').'</h3>'."\n"
+       .$hidelink
+       .'<div class="LC_columnSection">'."\n"
     );
 
     #Print parameters
@@ -1507,10 +1491,10 @@ sub parmboxes {
         if(@{$categoryList{$key}} == 0) {
             next;
         } else { 
-            $r->print('<fieldset>'
-                     .'<legend>'
+            $r->print('<div class="LC_Box LC_400Box">'
+                     .'<h4 class="LC_hcell">'
                      .&mt($categories{$key})
-                     .'</legend>'."\n");
+                     .'</h4>'."\n");
             foreach $tempkey (&keysindisplayorderCategory($categoryList{$key},$keyorder)) {
                     $r->print('<span class="LC_nobreak">'
                              .'<label><input type="checkbox" name="pscat" ');
@@ -1521,19 +1505,18 @@ sub parmboxes {
                 }
                 $r->print(' />'.($$allparms{$tempkey}=~/\S/ ? $$allparms{$tempkey}
                                                       : $tempkey)
-                        .'</label></span> ');
+                        .'</label></span><br />'."\n");
             }
-            $r->print('</fieldset>');
+            $r->print("</div>\n");
         }
     }
-    $r->print('<hr />'
-             .'<a href="javascript:hideParms()">'
-             .&mt('Hide')
-             .'</a>'
-    );
 
     #&shortCuts($r,$allparms,$pscat,$keyorder);
-    $r->print('</fieldset>');
+    $r->print(
+        "</div>\n"
+       .$hidelink
+       ."</div>\n"
+    );
 }
 #
 # This function offers some links on the parameter section to get with one click a group a parameters
@@ -1541,45 +1524,33 @@ sub parmboxes {
 sub shortCuts {
     my ($r,$allparms,$pscat,$keyorder)=@_;
 
-    #part to print out the shortcuts for parmselection
-    $r->print('<table><tr id="LC_parm_overview_parm_menu_selectors">'
-             .'<td valign="top">'
-             .'<fieldset><legend>'.&mt('Parameter Selection').'</legend>'
-             .'<span class="LC_nobreak">'
-             .'&bull; <a href="javascript:checkall(true, \'pscat\')">'.&mt('Select All').'</a>'
-             .'</span>'
-             .'<br />'
-             .'<span class="LC_nobreak">'
-             .'&bull; <a href="javascript:checkstandard()">'.&mt('Select Common Only').'</a>'
-             .'</span>'
-             .'<br />'
-             .'<span class="LC_nobreak">'
-             .'&bull; <a href="javascript:checkall(false, \'pscat\')">'.&mt('Unselect All').'</a>'
-             .'</span>'
-             .'</fieldset>'
-             .'</td>'
-             .'<td colspan="2" valign="top">'
-             .'<fieldset><legend>'.&mt('Add Selection for...').'</legend>'
-             .'<span class="LC_nobreak">'
-             .'&bull; <a href="javascript:checkdates()">'.&mt('Problem Dates').'</a>'
-             .'</span>'
-             .'<span class="LC_nobreak">'
-             .' &bull; <a href="javascript:checkcontdates()">'.&mt('Content Dates').'</a>'
-             .'</span>'
-#            .'<br />'
-             .'<span class="LC_nobreak">'
-             .' &bull; <a href="javascript:checkdisset()">'.&mt('Discussion Settings').'</a>'
-             .'</span>'
-             .'<span class="LC_nobreak">'
-             .' &bull; <a href="javascript:checkvisi()">'.&mt('Visibilities').'</a>'
-             .'</span>'
-#            .'<br />'
-             .'<span class="LC_nobreak">'
-             .' &bull; <a href="javascript:checkparts()">'.&mt('Part Parameters').'</a>'
-             .'</span>'
-             .'</fieldset>'
-             .'</td>'
-             .'</tr></table>');
+    # Parameter Selection
+    $r->print(
+        &Apache::lonhtmlcommon::start_funclist(&mt('Parameter Selection'))
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkall(true, \'pscat\')">'.&mt('Select All').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkstandard()">'.&mt('Select Common Only').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkall(false, \'pscat\')">'.&mt('Unselect All').'</a>')
+       .&Apache::lonhtmlcommon::end_funclist()
+    );
+
+    # Add Selection for...
+    $r->print(
+        &Apache::lonhtmlcommon::start_funclist(&mt('Add Selection for...'))
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkdates()">'.&mt('Problem Dates').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkcontdates()">'.&mt('Content Dates').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkdisset()">'.&mt('Discussion Settings').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkvisi()">'.&mt('Visibilities').'</a>')
+       .&Apache::lonhtmlcommon::add_item_funclist(
+            '<a href="javascript:checkparts()">'.&mt('Part Parameters').'</a>')
+       .&Apache::lonhtmlcommon::end_funclist()
+    );
 }
 
 sub partmenu {
@@ -1711,11 +1682,6 @@ sub displaymenu {
     &parmmenu($r,$allparms,$pscat,$keyorder);
     $r->print(&Apache::lonhtmlcommon::end_pick_box());
     &parmboxes($r,$allparms,$pscat,$keyorder);
-    $r->print(&Apache::lonhtmlcommon::start_pick_box());
-    $r->print(&Apache::lonhtmlcommon::row_title(&mt('Select Parts to View')));
-    &partmenu($r,$allparts,$psprt);
-    $r->print(&Apache::lonhtmlcommon::row_closure(1));
-    $r->print(&Apache::lonhtmlcommon::end_pick_box());
 }
 
 sub mapmenu {
@@ -2188,7 +2154,6 @@ function parmsel_show() {
 </script>
 ENDPARMSELSCRIPT
     
-    # Display Unit 1 "General Parameters"
     if (!$pssymb) {
         my $parmselhiddenstyle=' style="display:none"';
         if($env{'form.hideparmsel'} eq 'hidden') {
@@ -2197,6 +2162,7 @@ ENDPARMSELSCRIPT
            $r->print('<div id="parmsel">');
         }
 
+        # Step 1
         $r->print(&Apache::lonhtmlcommon::topic_bar(1,&mt('Resource Specification')));
         $r->print(<<COURSECONTENTSCRIPT);
 <script type="text/javascript">
@@ -2219,26 +2185,33 @@ COURSECONTENTSCRIPT
 
         $r->print(&Apache::lonhtmlcommon::start_pick_box());
         &levelmenu($r,\%alllevs,$parmlev);
-        $r->print(&Apache::lonhtmlcommon::row_closure(1));
-        $r->print(&Apache::lonhtmlcommon::end_pick_box());
-        $r->print(&Apache::lonhtmlcommon::start_pick_box());
+        $r->print(&Apache::lonhtmlcommon::row_closure());
         &mapmenu($r,\%allmaps,$pschp,\%maptitles, \%symbp);
+        $r->print(&Apache::lonhtmlcommon::row_closure());
+        $r->print(&Apache::lonhtmlcommon::row_title(&mt('Select Parts to View')));
+        &partmenu($r,\%allparts,\@psprt);
         $r->print(&Apache::lonhtmlcommon::row_closure(1));
         $r->print(&Apache::lonhtmlcommon::end_pick_box());
-        #Display Unit 2 "Select Parameter"   
+
+        # Step 2
         $r->print(&Apache::lonhtmlcommon::topic_bar(2,&mt('Parameter Specification')));
         &displaymenu($r,\%allparms,\%allparts,\@pscat,\@psprt,\%keyorder);
+
+        # Step 3
         $r->print(&Apache::lonhtmlcommon::topic_bar(3,&mt('User Specification (optional)')));
         $r->print(&Apache::lonhtmlcommon::start_pick_box());
         &usermenu($r,$uname,$id,$udom,$csec,$cgroup,$parmlev,\@usersgroups);
         $r->print(&Apache::lonhtmlcommon::row_closure(1));
         $r->print(&Apache::lonhtmlcommon::end_pick_box());
+
+        # Update Display Button
         $r->print('<p>'
              .'<input type="submit" name="dis"'
              .' value="'.&mt('Update Parameter Display').'" />'
              .'<input type="hidden" name="hideparmsel" value="hidden" />'
              .'</p>');
         $r->print('</div>');
+
         # Offer link to display parameter selection again
         $r->print('<p id="parmsellink"');
         if ($env{'form.hideparmsel'} ne 'hidden') {
@@ -3016,7 +2989,7 @@ sub date_interval_selector {
     my %select = ((map {$_ => $_} (0..$max)),
               'select_form_order' => [0..$max]);
     $result .= &Apache::loncommon::select_form($amount,$name.'_'.$thiskey,
-                           %select);
+                           \%select);
     $result .= ' '.&mt($name);
     }
     $result .= '<input type="hidden" name="dateinterval_'.$thiskey.'" />';
@@ -3182,26 +3155,19 @@ ENDOVER
     }
 # Menu to select levels, etc
 
-    #$r->print('<table id="LC_parm_overview_scope">
-    #           <tr><td class="LC_parm_overview_level_menu">');
     $r->print('<div class="LC_Box">');
     #$r->print('<h2 class="LC_hcell">Step 1</h2>');
     $r->print('<div>');
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
     &levelmenu($r,\%alllevs,$parmlev);
     if ($parmlev ne 'general') {
-        #$r->print('<td class="LC_parm_overview_map_menu">');
         $r->print(&Apache::lonhtmlcommon::row_closure());
         &mapmenu($r,\%allmaps,$pschp,\%maptitles,\%symbp);
-        #$r->print('</td>');
     }
     $r->print(&Apache::lonhtmlcommon::row_closure(1));
     $r->print(&Apache::lonhtmlcommon::end_pick_box());
     $r->print('</div></div>');
-    #$r->print('</td></tr></table>');
 
-    #$r->print('<table id="LC_parm_overview_controls">
-    #           <tr><td class="LC_parm_overview_parm_selectors">');
     $r->print('<div class="LC_Box">');
     $r->print('<div>');
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
@@ -3210,7 +3176,6 @@ ENDOVER
     &parmboxes($r,\%allparms,\@pscat,\%keyorder);
     $r->print(&Apache::lonhtmlcommon::start_pick_box());
     $r->print(&Apache::lonhtmlcommon::row_title(&mt('Select Parts to View')));
-    #$r->print('</td><td class="LC_parm_overview_restrictions">'.
     $r->print('<table>'.
               '<tr><th>'.&mt('Parts').'</th><th>'.&mt('Section(s)').
               '</th><th>'.&mt('Group(s)').'</th></tr><tr><td>');
@@ -3507,123 +3472,6 @@ sub parse_key {
 }
 
 
-
-sub extract_cloners {
-    my ($clonelist,$allowclone) = @_;
-    if ($clonelist =~ /,/) {
-        @{$allowclone} = split(/,/,$clonelist);
-    } else {
-        $$allowclone[0] = $clonelist;
-    }
-}
-
-sub check_cloners {
-    my ($clonelist,$oldcloner) = @_;
-    my ($clean_clonelist,%disallowed);
-    my @allowclone = ();
-    &extract_cloners($$clonelist,\@allowclone);
-    foreach my $currclone (@allowclone) {
-        if (!grep(/^\Q$currclone\E$/,@$oldcloner)) {
-            if ($currclone eq '*') {
-                $clean_clonelist .= $currclone.',';
-            } else {
-                my ($uname,$udom) = split(/:/,$currclone);
-                if ($uname eq '*') {
-                    if ($udom =~ /^$match_domain$/) {
-                        if (!&Apache::lonnet::domain($udom)) {
-                            $disallowed{'domain'} .= $currclone.',';
-                        } else {
-                            $clean_clonelist .= $currclone.',';
-                        }
-                    } else {
-                        $disallowed{'format'} .= $currclone.',';
-                    }
-                } elsif ($currclone !~/^($match_username)\:($match_domain)$/) {
-                    $disallowed{'format'} .= $currclone.',';
-                } else {
-                    if (&Apache::lonnet::homeserver($uname,$udom) eq 'no_host') {
-                        $disallowed{'newuser'} .= $currclone.',';
-                    } else {
-                        $clean_clonelist .= $currclone.',';
-                    }
-                }
-            }
-        } else {
-            $clean_clonelist .= $currclone.',';
-        }
-    }
-    foreach my $key (keys(%disallowed)) {
-        $disallowed{$key} =~ s/,$//;
-    }
-    if ($clean_clonelist) {
-        $clean_clonelist =~ s/,$//;
-    }
-    $$clonelist = $clean_clonelist;
-    return %disallowed;
-}
-
-sub change_clone {
-    my ($clonelist,$oldcloner) = @_;
-    my ($uname,$udom);
-    my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
-    my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
-    my $clone_crs = $cnum.':'.$cdom;
-
-    if ($cnum && $cdom) {
-        my @allowclone;
-        &extract_cloners($clonelist,\@allowclone);
-        foreach my $currclone (@allowclone) {
-            if (!grep(/^$currclone$/,@$oldcloner)) {
-                if ($currclone ne '*') {
-                    ($uname,$udom) = split(/:/,$currclone);
-                    if ($uname && $udom && $uname ne '*') {
-                        if (&Apache::lonnet::homeserver($uname,$udom) ne 'no_host') {
-                            my %currclonecrs = &Apache::lonnet::dump('environment',$udom,$uname,'cloneable');
-                            if ($currclonecrs{'cloneable'} !~ /\Q$clone_crs\E/) {
-                                if ($currclonecrs{'cloneable'} eq '') {
-                                    $currclonecrs{'cloneable'} = $clone_crs;
-                                } else {
-                                    $currclonecrs{'cloneable'} .= ','.$clone_crs;
-                                }
-                                &Apache::lonnet::put('environment',\%currclonecrs,$udom,$uname);
-                            }
-                        }
-                    }
-                }
-            }
-        }
-        foreach my $oldclone (@$oldcloner) {
-            if (!grep(/^\Q$oldclone\E$/,@allowclone)) {
-                if ($oldclone ne '*') {
-                    ($uname,$udom) = split(/:/,$oldclone);
-                    if ($uname && $udom && $uname ne '*' ) {
-                        if (&Apache::lonnet::homeserver($uname,$udom) ne 'no_host') {
-                            my %currclonecrs = &Apache::lonnet::dump('environment',$udom,$uname,'cloneable');
-                            my %newclonecrs = ();
-                            if ($currclonecrs{'cloneable'} =~ /\Q$clone_crs\E/) {
-                                if ($currclonecrs{'cloneable'} =~ /,/) {
-                                    my @currclonecrs = split/,/,$currclonecrs{'cloneable'};
-                                    foreach my $crs (@currclonecrs) {
-                                        if ($crs ne $clone_crs) {
-                                            $newclonecrs{'cloneable'} .= $crs.',';
-                                        }
-                                    }
-                                    $newclonecrs{'cloneable'} =~ s/,$//;
-                                } else {
-                                    $newclonecrs{'cloneable'} = '';
-                                }
-                                &Apache::lonnet::put('environment',\%newclonecrs,$udom,$uname);
-                            }
-                        }
-                    }
-                }
-            }
-        }
-    }
-}
-
-
-
 sub header {
     return &Apache::loncommon::start_page('Parameter Manager');
 }
@@ -3651,25 +3499,12 @@ ENDMAINFORMHEAD
     my @menu =
         ( { categorytitle=>"Settings for this $crstype",
         items => [
-          { linktext => "$crstype Configuration",
-            url => '/adm/courseprefs?origin=params',
-            permission => $parm_permission,
-            linktitle => "Edit $lc_crstype configuration."  ,
-            icon => 'preferences-desktop-remote-desktop.png'  ,
-            #help => 'Course_Environment',
-            },
           { linktext => 'Portfolio Metadata',
             url => '/adm/parmset?action=setrestrictmeta',
             permission => $parm_permission,
             linktitle => "Restrict metadata for this $lc_crstype." ,
             icon =>'contact-new.png'   ,
             },
-          { linktext => "Manage $crstype Slots",
-            url => '/adm/slotrequest?command=showslots',
-            permission => $vgr,
-            linktitle => "Manage slots for this $lc_crstype."  ,
-            icon => 'format-justify-fill.png'  ,
-            },
           { linktext => 'Reset Student Access Times',
             url => '/adm/helper/resettimes.helper',
             permission => $mgr,
@@ -3719,7 +3554,7 @@ ENDMAINFORMHEAD
             url => '/adm/parmset?action=parameterchangelog',
             permission => $parm_permission,
             linktitle =>"View parameter and $lc_crstype blog posting/user notification change log."  ,
-            icon => 'emblem-system.png'   ,
+            icon => 'document-properties.png',
             }]}
           );
     $r->print(&Apache::lonhtmlcommon::generate_menu(@menu));
@@ -4629,8 +4464,6 @@ sub handler {
             &date_shift_one($r);
         } elsif ($env{'form.action'} eq 'dateshift2') {
             &date_shift_two($r);
-    } elsif ($env{'form.action'} eq 'categorizecourse') {
-            &assign_course_categories($r);
         }
     } else {
 # ----------------------------- Not in a course, or not allowed to modify parms