--- loncom/interface/lonpickcourse.pm	2005/10/03 23:53:25	1.30
+++ loncom/interface/lonpickcourse.pm	2005/10/14 19:11:56	1.34
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Pick a course
 #
-# $Id: lonpickcourse.pm,v 1.30 2005/10/03 23:53:25 raeburn Exp $
+# $Id: lonpickcourse.pm,v 1.34 2005/10/14 19:11:56 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -111,7 +111,7 @@ ENDDOCUMENT
         $num_sections = &Apache::loncommon::get_sections($cdom,$cnum,\%sections_count);
         my @sections = ();
         if ($num_sections > 0) {
-            @sections = (sort {$a <=> $b} keys %sections_count);
+            @sections = (sort {$a <=> $b} keys(%sections_count));
             $seclist = join('","',@sections);
         }
     }
@@ -160,33 +160,47 @@ function gochoose(cname,cdom,cdesc,multf
     courseCount = 0;
     var courses = '';
     if (multflag) {
-        for (var j=0; j<document.courselist.course_id.length; j++) {
-            if (document.courselist.course_id[j].checked) {
-                courses = courses + document.courselist.course_id[j].value + "&&";
-                courseCount ++;
-            }
-        }
+	if (typeof(document.courselist.course_id.length) == 'undefined') {
+	    // only 1 course checkbox was created
+	    if (document.courselist.course_id.checked) {
+		courses = courses + document.courselist.course_id.value + "&&";
+		courseCount ++;
+	    }
+	} else {
+	    for (var j=0; j<document.courselist.course_id.length; j++) {
+		if (document.courselist.course_id[j].checked) {
+		    courses = courses + document.courselist.course_id[j].value + "&&";
+		    courseCount ++;
+		}
+	    }
+	} 
         opener.document.$env{'form.form'}.coursetotal.value = courseCount;
-        for (var j=0; j<opener.document.$env{'form.form'}.coursepick.length; j++) { 
-            if (opener.document.$env{'form.form'}.coursepick[j].value == 'specific') {  
-                opener.document.$env{'form.form'}.coursepick[j].checked = true;
-            }
-            else {
-                opener.document.$env{'form.form'}.coursepick[j].checked = false;
-            }
-        }
-        if (courseCount > 0) {
-            courses = courses.substr(0,courses.length-2);
-            opener.document.$env{'form.form'}.courselist.value = courses
-        }
-    }
-    else {
+	if (typeof(opener.document.$env{'form.form'}.coursepick.length) ==
+	    'undefined') {
+	    if (opener.document.$env{'form.form'}.coursepick.value == 'specific') {  
+		opener.document.$env{'form.form'}.coursepick.checked = true;
+	    } else {
+		opener.document.$env{'form.form'}.coursepick.checked = false;
+	    }
+	} else {
+	    for (var j=0; j<opener.document.$env{'form.form'}.coursepick.length; j++) { 
+		if (opener.document.$env{'form.form'}.coursepick[j].value == 'specific') {  
+		    opener.document.$env{'form.form'}.coursepick[j].checked = true;
+		} else {
+		    opener.document.$env{'form.form'}.coursepick[j].checked = false;
+		}
+	    }
+	}
+	if (courseCount > 0) {
+	    courses = courses.substr(0,courses.length-2);
+	    opener.document.$env{'form.form'}.courselist.value = courses;
+	}
+    } else {
         $name_code
         opener.document.$env{'form.form'}.$env{'form.cnumelement'}.value=cname;
         if (openerForm == 'cu') {
             opener.document.$env{'form.form'}.$env{'form.cdomelement'}.value=cdom;
-        }
-        else {
+        } else {
             var slct=opener.document.$env{'form.form'}.$env{'form.cdomelement'};
             var i;
             for (i=0;i<slct.length;i++) {
@@ -206,24 +220,21 @@ function setSections() {
         opener.document.$env{"form.form"}.currsec.multiple=false
         opener.document.$env{"form.form"}.currsec.size=1;
         opener.document.$env{"form.form"}.currsec.options[0] = new Option('No existing sections','',false,false)
-    }
-    else {
+    } else {
         if (numSections == 1) {
             opener.document.$env{"form.form"}.currsec.multiple=false;
             opener.document.$env{"form.form"}.currsec.size=1;
             opener.document.$env{"form.form"}.currsec.options[0] = new Option('Select','',true,true);
             opener.document.$env{"form.form"}.currsec.options[1] = new Option('No section','',false,false) 
             opener.document.$env{"form.form"}.currsec.options[2] = new Option(sectionsArray[0],sectionsArray[0],false,false);
-        }
-        else {
+        } else {
             for (var i=0; i<numSections; i++) {
                 opener.document.$env{"form.form"}.currsec.options[i] = new Option(sectionsArray[i],sectionsArray[i],false,false)
             }
             opener.document.$env{"form.form"}.currsec.multiple=true
             if (numSections < 3) {
                 opener.document.$env{"form.form"}.currsec.size=numSections;
-            }
-            else {
+            } else {
                 opener.document.$env{"form.form"}.currsec.size=3;
             }
             opener.document.$env{"form.form"}.currsec.options[0].selected = false
@@ -272,8 +283,8 @@ ENDSCRIPT
 	    ($domainfilter,$descriptfilter,$timefilter,$instcodefilter,$ownerfilter,$coursefilter);
 	$r->print('<form name="courselist">');
 	my %by_descrip;
-        my $numcourses = keys %courses;
-	foreach my $course (keys %courses) {
+        my $numcourses = keys(%courses);
+	foreach my $course (keys(%courses)) {
             my $descr;
             if ($courses{$course} =~ m/^([^:]*):/) {
                 $descr = &Apache::lonnet::unescape($1);
@@ -305,6 +316,7 @@ ENDSCRIPT
                 unless ($owner eq '') {
                     $r->print(", owner - ".&Apache::lonnet::unescape($owner));
                 }
+		if ($multflag) { $r->print("</label>\n"); }
                 $r->print("<br />\n");
             }
 	}
@@ -327,7 +339,7 @@ sub course_chooser {
     my ($multflag,$cdom,$cnum,$cleandesc) = @_;
     my $output; 
     if ($multflag) {
-        $output = '<input type="checkbox" name="course_id" value="'.$cdom.'_'.$cnum.'" />'."\n";
+        $output = '<label><input type="checkbox" name="course_id" value="'.$cdom.'_'.$cnum.'" />'."\n";
     } else {
         $output = '<input type="button" value="Select" onClick="gochoose('.
                   "'".$cnum."','".$cdom."','".$cleandesc."')".'" />'."\n";