--- loncom/interface/lonpopulate.pm 2004/09/13 16:21:30 1.20 +++ loncom/interface/lonpopulate.pm 2005/11/04 21:32:13 1.30 @@ -1,5 +1,5 @@ # automated enrollment configuration handler -# $Id: lonpopulate.pm,v 1.20 2004/09/13 16:21:30 raeburn Exp $ +# $Id: lonpopulate.pm,v 1.30 2005/11/04 21:32:13 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -38,9 +38,10 @@ use LONCAPA::Enrollment; ############################################################### sub header { + my $html=&Apache::lonxml::xmlbegin(); my $bodytag=&Apache::loncommon::bodytag('Classlist Manager'); return(< +$html LON-CAPA Classlist Manager @@ -150,27 +151,8 @@ function process(calling,numauto,nummanu } |; if ($action eq 'viewclass') { + $scripttag .= &Apache::loncommon::check_uncheck_jscript(); $scripttag .= qq| -function checkAll(field) { - if (field.length > 0) { - for (i = 0; i < field.length; i++) { - field[i].checked = true ; - } - } else { - field.checked = true - } -} - -function uncheckAll(field) { - if (field.length > 0) { - for (i = 0; i < field.length; i++) { - field[i].checked = false ; - } - } else { - field.checked = false ; - } -} - function countChecked(field) { var count = 0; if (field.length > 0) { @@ -193,8 +175,9 @@ function countChecked(field) { // End hiding --> |; + my $html=&Apache::lonxml::xmlbegin(); return(< +$html LON-CAPA Classlist Manager $scripttag @@ -205,8 +188,8 @@ ENDHEAD sub print_mainbox { my ($r,$tasklongref,$realm,$reply) = @_; my $action = "information"; - if ( exists($ENV{'form.action'}) ) { - $action = $ENV{'form.action'}; + if ( exists($env{'form.action'}) ) { + $action = $env{'form.action'}; } my $page = ''; if ($action eq "information") { @@ -243,8 +226,8 @@ ENDTHIS sub print_navmenu { my ($r,$tasksref,$tasklongref) = @_; my $action = "information"; - if (exists($ENV{'form.action'}) ) { - $action = $ENV{'form.action'}; + if (exists($env{'form.action'}) ) { + $action = $env{'form.action'}; } $r->print(<  @@ -282,8 +265,8 @@ ENDONE sub print_main_frame { my ($r,$realm,$dom,$crs,$tasktitleref) = @_; my $action = "information"; - if (exists($ENV{'form.action'}) ) { - $action = $ENV{'form.action'}; + if (exists($env{'form.action'}) ) { + $action = $env{'form.action'}; } # Get course settings @@ -502,15 +485,11 @@ ENDTWO ENDTWO } elsif ($action eq "notify") { - my @notified = (); - if ($enrollvar{notifylist} =~ m/,/) { - @notified = split/,/,$enrollvar{notifylist}; - } else { - @notified = $enrollvar{notifylist}; - } + my $notifycount = 0; + my @notified = split(/,/,$enrollvar{notifylist}); my $notifycount = 0; foreach (@notified) { - unless ($_ eq '') { $notifycount ++; } + unless ($_ eq '') { $notifycount ++; } } my $noteset = ''; if ($notifycount) { @@ -557,8 +536,8 @@ ENDTWO my @roleinfo = split/:/,$_; if ($roleinfo[0] eq 'cc') { unless (grep/^$roleinfo[1]\@$roleinfo[2]/,@ccs) { - my $active_cc = &LONCAPA::Enrollment::check_user_status($roleinfo[2],$roleinfo[1],$dom,$crs,'cc'); - if ($active_cc eq 'ok') { + my $active_cc = &Apache::loncommon::check_user_status($roleinfo[2],$roleinfo[1],$dom,$crs,'cc'); + if ($active_cc eq 'active') { push @ccs, "$roleinfo[1]\@$roleinfo[2]"; $pname{"$roleinfo[1]\@$roleinfo[2]"} = &Apache::loncommon::plainname($roleinfo[1],$roleinfo[2]); if (grep/^$roleinfo[1]\@$roleinfo[2]$/,@notified) { @@ -582,10 +561,10 @@ ENDTWO } } } - my $viewer = $ENV{'user.name'}.'@'.$ENV{'user.domain'}; + my $viewer = $env{'user.name'}.'@'.$env{'user.domain'}; unless ( (grep/^$viewer$/,@ccs) || ($viewer eq '') ) { push @ccs,$viewer; - $pname{$viewer} = &Apache::loncommon::plainname($ENV{'user.name'},$ENV{'user.domain'}); + $pname{$viewer} = &Apache::loncommon::plainname($env{'user.name'},$env{'user.domain'}); $notifystate{$viewer} = 0; } @@ -655,11 +634,9 @@ ENDTWO "); } elsif ($action eq "crosslist") { - my @xlists = (); - if ($enrollvar{crosslistings} =~ m/,/) { - @xlists = split/,/,$enrollvar{crosslistings}; - } elsif ($enrollvar{crosslistings} ne '') { - $xlists[0] = $enrollvar{crosslistings}; + my @xlists; + if ($enrollvar{crosslistings} ne '') { + @xlists = split(/,/,$enrollvar{crosslistings}); } my $cross_str = @xlists; $r->print(" @@ -740,14 +717,9 @@ ENDTWO } elsif ($action eq "sections") { my @sections = (); @sections = &Apache::lonnet::auto_get_sections($crs,$dom,$enrollvar{coursecode}); - my @storedsections = (); + my @storedsections = split(/,/,$enrollvar{sectionnums}); my @currsections = (); my %sec_id = (); - if ($enrollvar{sectionnums} =~ m/,/) { - @storedsections = split/,/,$enrollvar{sectionnums}; - } else { - $storedsections[0] = $enrollvar{sectionnums}; - } foreach (@storedsections) { if ($_ =~ m/^(\w+):(\w*)$/) { push @currsections, $1; @@ -998,13 +970,13 @@ Note: Any students previously added manu "); - if (! exists($ENV{'form.sortby'})) { - $ENV{'form.sortby'} = 'username'; + if (! exists($env{'form.sortby'})) { + $env{'form.sortby'} = 'username'; } - if ($ENV{'form.Status'} !~ /^(Any|Expired|Active)$/) { - $ENV{'form.Status'} = 'Active'; + if ($env{'form.Status'} !~ /^(Any|Expired|Active)$/) { + $env{'form.Status'} = 'Active'; } - my $status_select = &Apache::lonhtmlcommon::StatusOptions($ENV{'form.Status'}); + my $status_select = &Apache::lonhtmlcommon::StatusOptions($env{'form.Status'}); # Get current classlist my ($classlist,$keylist)=&Apache::loncoursedata::get_classlist(); if (! defined($classlist)) { @@ -1015,7 +987,7 @@ Note: Any students previously added manu $r->print(''. "\n

\n"); - my ($studentcount,$autocount,$manualcount,$lockcount,$unlockcount) = &Apache::londropadd::show_class_list($r,'autoenroll','nothing',$ENV{'form.Status'},$classlist,$keylist); + my ($studentcount,$autocount,$manualcount,$lockcount,$unlockcount) = &Apache::londropadd::show_class_list($r,'autoenroll','nothing',$env{'form.Status'},$classlist,$keylist); $r->print(" @@ -1244,11 +1216,11 @@ sub print_chgsettings_response { my $autoadds = ''; my $autodrops = ''; - if ( exists($ENV{'form.autoadds'}) ) { - $autoadds=$ENV{'form.autoadds'}; + if ( exists($env{'form.autoadds'}) ) { + $autoadds=$env{'form.autoadds'}; } - if ( exists($ENV{'form.autodrops'}) ) { - $autodrops=$ENV{'form.autodrops'}; + if ( exists($env{'form.autodrops'}) ) { + $autodrops=$env{'form.autodrops'}; } my $response = ""; @@ -1505,33 +1477,28 @@ sub print_notify_response { my %settings = &Apache::lonnet::get('environment',['internal.notifylist','internal.coursecode'],$dom,$crs); my $notifylist = $settings{'internal.notifylist'}; my $coursecode = $settings{'internal.coursecode'}; - my @currpeople = (); + my @currpeople = split(/,/,$notifylist); my $notify = 0; my @people = (); my $peoplestr = ""; my $response = ""; my $noprocess = 0; - if ($notifylist =~ m/,/) { - @currpeople = split/,/,$notifylist; - } else { - $currpeople[0] = $notifylist; - } my $currcount = 0; foreach (@currpeople) { unless ($_ eq '') { $currcount ++; } } - if ( exists($ENV{'form.notify'}) ) { - $notify=$ENV{'form.notify'}; + if ( exists($env{'form.notify'}) ) { + $notify=$env{'form.notify'}; } - if ( exists($ENV{'form.notifyshow'}) ) { - my $notifyshow = $ENV{'form.notifyshow'}; + if ( exists($env{'form.notifyshow'}) ) { + my $notifyshow = $env{'form.notifyshow'}; for (my $i=0; $i<$notifyshow; $i++) { - if ( exists($ENV{"form.note_$i"}) ) { - if ( exists($ENV{"form.notifyname_$i"}) ) { - unless ( $ENV{"form.notifyname_$i"} eq '' ) { - push @people, $ENV{"form.notifyname_$i"}; + if ( exists($env{"form.note_$i"}) ) { + if ( exists($env{"form.notifyname_$i"}) ) { + unless ( $env{"form.notifyname_$i"} eq '' ) { + push @people, $env{"form.notifyname_$i"}; } } } @@ -1591,23 +1558,21 @@ sub print_crosslistings_menu () { my $xliststr = ''; my $response = ''; my $coursecode = $settings{'internal.coursecode'}; - if ($settings{'internal.crosslistings'} =~ m/,/) { - @currxlists = split/,/,$settings{'internal.crosslistings'}; - } elsif ($settings{'internal.crosslistings'} ne '') { - $currxlists[0] = $settings{'internal.crosslistings'}; + if ($settings{'internal.crosslistings'} ne '') { + @currxlists = split(/,/,$settings{'internal.crosslistings'}); } if (@currxlists > 0) { for (my $i=0; $i<@currxlists; $i++) { my $xlist = "cross_".$i; my $gp = "gp_".$i; - if ( exists($ENV{"form.$xlist"}) ) { + if ( exists($env{"form.$xlist"}) ) { my $xlistentry = ''; if ($currxlists[$i] =~ m/^([^:]+)/) { $xlistentry = $1.':'; } - if ( exists($ENV{"form.$gp"}) ) { - $xlistentry .= $ENV{"form.$gp"}; + if ( exists($env{"form.$gp"}) ) { + $xlistentry .= $env{"form.$gp"}; } push @xlists,$xlistentry; $crosscount ++; @@ -1617,11 +1582,8 @@ sub print_crosslistings_menu () { } } - if ($crosscount > 1) { - $xliststr = join(",",@xlists); - } else { - $xliststr = $xlists[0]; - } + $xliststr = join(",",@xlists); + my %cenv = ('internal.crosslistings' => $xliststr); my $reply = &Apache::lonnet::put('environment',\%cenv,$dom,$crs); if ($reply !~ /^ok$/) { @@ -1639,8 +1601,8 @@ sub print_crosslistings_menu () { $response .= "
\n"; } } - if ( exists($ENV{'form.numcross'}) ) { - my $numcross = $ENV{'form.numcross'}; + if ( exists($env{'form.numcross'}) ) { + my $numcross = $env{'form.numcross'}; if ($numcross > 0) { my @bgcolors=("#eeeeee","#cccccc"); $response .= qq(You indicated that you wish to add an additional $numcross crosslisting(s). For each new crosslisting enter the insititutional course section code (e.g., fs03zol101001, for section 001 of zol101 for fs03 semester), and the LON-CAPA section/group ID you wish to assign to students who will be enrolled in your LON-CAPA class as a result of their registration in the crosslisted course section. The LON-CAPA section/group ID can be left blank, if you do not wish to tie a section/group ID to this crosslisting. The institutional course section code should only contain letters and/or numbers, and must be consistent with the scheme adopted by your Domain Coordinator to map course codes (and section numbers) to your institution\'s student information system.

@@ -1699,33 +1661,31 @@ sub print_crosslistings_response () { my $warning = ''; my $warn_prefix = ''; - if ($xliststr =~ m/,/) { - @allxlists = split/,/,$xliststr; - } else { - unless ($xliststr eq '') { $allxlists[0] = $xliststr; } + if ($xliststr ne '') { + @allxlists = split(/,/,$xliststr); } - if ( exists($ENV{'form.numcross'}) ) { - $numcross = $ENV{'form.numcross'}; + if ( exists($env{'form.numcross'}) ) { + $numcross = $env{'form.numcross'}; } if ($numcross > 0) { for (my $i=0; $i<$numcross; $i++) { my $xl = "newcross_".$i; my $gp = "newgroupid_".$i; - if ( exists($ENV{"form.$xl"}) ) { + if ( exists($env{"form.$xl"}) ) { my $coursecheck = ''; - $coursecheck = &Apache::lonnet::auto_validate_courseID($crs,$dom,$ENV{"form.$xl"}); + $coursecheck = &Apache::lonnet::auto_validate_courseID($crs,$dom,$env{"form.$xl"}); if ($coursecheck eq 'ok') { my $addcheck = ''; - $addcheck = &Apache::lonnet::auto_new_course($crs,$dom,$ENV{"form.$xl"},$owner); + $addcheck = &Apache::lonnet::auto_new_course($crs,$dom,$env{"form.$xl"},$owner); if ($addcheck eq 'ok') { - push @xlists,$ENV{"form.$xl"}.":".$ENV{"form.$gp"}; + push @xlists,$env{"form.$xl"}.":".$env{"form.$gp"}; } else { - push @badowner,$ENV{"form.$xl"}.":".$ENV{"form.$gp"}; + push @badowner,$env{"form.$xl"}.":".$env{"form.$gp"}; } } else { - push @badxlists, $ENV{"form.$xl"}.":".$ENV{"form.$gp"}.":".$coursecheck; + push @badxlists, $env{"form.$xl"}.":".$env{"form.$gp"}.":".$coursecheck; } } } @@ -1734,11 +1694,8 @@ sub print_crosslistings_response () { if (@xlists > 0 ) { unless ($xliststr eq '') { $xliststr .= ","; } - if (@xlists > 1) { - $xliststr .= join(",",@xlists); - } else { - $xliststr .= $xlists[0]; - } + $xliststr .= join(",",@xlists); + my %cenv = ('internal.crosslistings' => $xliststr); my $reply = &Apache::lonnet::put('environment',\%cenv,$dom,$crs); if ($reply !~ /^ok$/) { @@ -1753,12 +1710,7 @@ sub print_crosslistings_response () { } } else { if ($xliststr =~ m/:/) { - my @oldxlists = (); - if ($xliststr =~ m/,/) { - @oldxlists = split/,/,$xliststr; - } else { - $oldxlists[0] = $xliststr; - } + my @oldxlists = (split/,/,$xliststr); $response .= "Although no new crosslistings were added, the courses listed below continue to be crosslisted with your LON-CAPA course.
    \n"; foreach (@oldxlists) { my ($xlist,$gp) = split/:/,$_; @@ -1813,42 +1765,40 @@ sub print_sections_menu () { my $warn_prefix = ""; my $coursecode = $settings{'internal.coursecode'}; my $owner = $settings{'internal.courseowner'}; - if ($settings{'internal.sectionnums'} =~ m/,/) { - @currsections = split/,/,$settings{'internal.sectionnums'}; - } elsif ($settings{'internal.sectionnums'} ne '') { - $currsections[0] = $settings{'internal.sectionnums'}; + if ($settings{'internal.sectionnums'} ne '') { + @currsections = split(/,/,$settings{'internal.sectionnums'}); } - if ( exists($ENV{'form.secshow'}) ) { - for (my $i=0; $i<$ENV{'form.secshow'}; $i++) { + if ( exists($env{'form.secshow'}) ) { + for (my $i=0; $i<$env{'form.secshow'}; $i++) { my $gp = "loncapasec_".$i; my $secnum = "secnum_".$i; my $sec = "sec_".$i; - if ( exists( $ENV{"form.$sec"} ) ) { + if ( exists( $env{"form.$sec"} ) ) { my $secentry; - if ( exists( $ENV{"form.$secnum"} ) ) { - $secentry = $ENV{"form.$secnum"}.':'; + if ( exists( $env{"form.$secnum"} ) ) { + $secentry = $env{"form.$secnum"}.':'; } - if ( exists( $ENV{"form.$gp"} ) ) { - $secentry .= $ENV{"form.$gp"}; + if ( exists( $env{"form.$gp"} ) ) { + $secentry .= $env{"form.$gp"}; } - if ( grep/^$ENV{"form.$secnum"}:/,@currsections) { + if ( grep/^$env{"form.$secnum"}:/,@currsections) { push @sections, $secentry; $seccount ++; } else { - my $newsec = $coursecode.$ENV{"form.$secnum"}; + my $newsec = $coursecode.$env{"form.$secnum"}; my $coursecheck = &Apache::lonnet::auto_validate_courseID($crs,$dom,$newsec); if ($coursecheck eq 'ok') { my $addcheck = &Apache::lonnet::auto_new_course($crs,$dom,$newsec,$owner); if ($addcheck eq 'ok') { - push @sections,$ENV{"form.$secnum"}.":".$ENV{"form.$gp"}; + push @sections,$env{"form.$secnum"}.":".$env{"form.$gp"}; $seccount ++; $addcount ++; } else { - push @badowner,$ENV{"form.$secnum"}.":".$ENV{"form.$gp"}; + push @badowner,$env{"form.$secnum"}.":".$env{"form.$gp"}; } } else { - push @badsections, $ENV{"form.$secnum"}.":".$ENV{"form.$gp"}.":".$coursecheck; + push @badsections, $env{"form.$secnum"}.":".$env{"form.$gp"}.":".$coursecheck; } } } @@ -1867,13 +1817,13 @@ sub print_sections_menu () { for (my $i=0; $i<@currsections; $i++) { my $sec = "sec_".$i; my $gp = "secgp_".$i; - if ( exists($ENV{"form.$sec"}) ) { + if ( exists($env{"form.$sec"}) ) { my $secentry = ''; if ($currsections[$i] =~ m/^(\w+:)/ ) { $secentry = $1; } - if ( exists($ENV{"form.$gp"}) ) { - $secentry .= $ENV{"form.$gp"}; + if ( exists($env{"form.$gp"}) ) { + $secentry .= $env{"form.$gp"}; } push @sections,$secentry; $seccount ++; @@ -1883,11 +1833,8 @@ sub print_sections_menu () { } } - if ($seccount > 1) { - $secstr = join(",",@sections); - } else { - $secstr = $sections[0]; - } + $secstr = join(",",@sections); + my %cenv = ('internal.sectionnums' => $secstr); my $reply = &Apache::lonnet::put('environment',\%cenv,$dom,$crs); if ($reply !~ /^ok$/) { @@ -1936,8 +1883,8 @@ sections which contribute to enrollment } } - if ( exists($ENV{'form.numsec'}) ) { - my $numsec = $ENV{'form.numsec'}; + if ( exists($env{'form.numsec'}) ) { + my $numsec = $env{'form.numsec'}; if ($numsec > 0) { my @bgcolors=("#eeeeee","#cccccc"); $response .= qq( @@ -1997,33 +1944,31 @@ sub print_sections_response () { my $putreply = ''; my $warning = ''; my $warn_prefix = ''; - if ($secstr =~ m/,/) { - @allsections = split/,/,$secstr; - } else { - unless ($secstr eq '') { $allsections[0] = $secstr; } + if ($secstr ne '') { + @allsections = split(/,/,$secstr); } - if ( exists($ENV{'form.numsec'}) ) { - $numsec = $ENV{'form.numsec'}; + if ( exists($env{'form.numsec'}) ) { + $numsec = $env{'form.numsec'}; } if ($numsec > 0) { for (my $i=0; $i<$numsec; $i++) { my $sec = "newsec_".$i; my $gp = "newsecgp_".$i; - if ( exists($ENV{"form.$sec"}) ) { - unless ( (grep/^$ENV{"form.$sec"}:/,@allsections) || (grep/^$ENV{"form.$sec"}:/,@sections) ) { - my $newsec = $coursecode.$ENV{"form.$sec"}; + if ( exists($env{"form.$sec"}) ) { + unless ( (grep/^$env{"form.$sec"}:/,@allsections) || (grep/^$env{"form.$sec"}:/,@sections) ) { + my $newsec = $coursecode.$env{"form.$sec"}; my $coursecheck = &Apache::lonnet::auto_validate_courseID($crs,$dom,$newsec); if ($coursecheck eq 'ok') { my $addcheck = &Apache::lonnet::auto_new_course($crs,$dom,$newsec,$owner); if ($addcheck eq 'ok') { - push @sections,$ENV{"form.$sec"}.":".$ENV{"form.$gp"}; + push @sections,$env{"form.$sec"}.":".$env{"form.$gp"}; } else { - push @badowner,$ENV{"form.$sec"}.":".$ENV{"form.$gp"}; + push @badowner,$env{"form.$sec"}.":".$env{"form.$gp"}; } } else { - push @badsections, $ENV{"form.$sec"}.":".$ENV{"form.$gp"}.":".$coursecheck; + push @badsections, $env{"form.$sec"}.":".$env{"form.$gp"}.":".$coursecheck; } } } @@ -2033,11 +1978,7 @@ sub print_sections_response () { if (@sections > 0 ) { unless ($secstr eq '') { $secstr .= ","; } - if (@sections > 1) { - $secstr .= join(",",@sections); - } else { - $secstr .= $sections[0]; - } + $secstr .= join(",",@sections); my %cenv = ('internal.sectionnums' => $secstr); $putreply = &Apache::lonnet::put('environment',\%cenv,$dom,$crs); if ($putreply !~ /^ok$/) { @@ -2089,8 +2030,8 @@ sub print_photos_response () { my %settings = &Apache::lonnet::get('environment',['internal.showphotos'],$dom,$crs); my $currphotos = $settings{'internal.showphotos'}; my $showphotos = ''; - if ( exists($ENV{'form.showphotos'}) ) { - $showphotos=$ENV{'form.showphotos'}; + if ( exists($env{'form.showphotos'}) ) { + $showphotos=$env{'form.showphotos'}; } my $response = ""; @@ -2135,11 +2076,11 @@ sub print_update_result () { my $authtype = $settings{'internal.authtype'}; my $autharg = $settings{'internal.autharg'}; my ($startaccess,$endaccess) = &get_dates_from_form(); - if ( exists($ENV{'form.updateadds'}) ) { - $updateadds = $ENV{'form.updateadds'}; + if ( exists($env{'form.updateadds'}) ) { + $updateadds = $env{'form.updateadds'}; } - if ( exists($ENV{'form.updatedrops'}) ) { - $updatedrops = $ENV{'form.updatedrops'}; + if ( exists($env{'form.updatedrops'}) ) { + $updatedrops = $env{'form.updatedrops'}; } if (($startaccess eq '') || ($endaccess eq '')) { $response = "There was a problem processing your requested roster update because start and and access dates could not be determined. No changes have been made to the class roster.
    "; @@ -2154,16 +2095,12 @@ sub print_update_result () { my @currsections = (); my @currxlists = (); - if ($settings{'internal.sectionnums'} =~ m/,/) { - @currsections = split/,/,$settings{'internal.sectionnums'}; - } elsif ($settings{'internal.sectionnums'} ne '') { - $currsections[0] = $settings{'internal.sectionnums'}; + if ($settings{'internal.sectionnums'} ne '') { + @currsections = split(/,/,$settings{'internal.sectionnums'}); } - if ($settings{'internal.crosslistings'} =~ m/,/) { - @currxlists = split/,/,$settings{'internal.crosslistings'}; - } elsif ($settings{'internal.crosslistings'} ne '') { - $currxlists[0] = $settings{'internal.crosslistings'}; + if ($settings{'internal.crosslistings'} ne '') { + @currxlists = split(/,/,$settings{'internal.crosslistings'}); } if (@currxlists > 0) { @@ -2197,7 +2134,7 @@ sub print_update_result () { &Apache::lonnet::logthis("lonpopulate:update roster". "failed to retrieve classlist". " data for ".$crs."\@".$dom." by ". - $ENV{'user.name'}." \@ ".$ENV{'user.domain'}. + $env{'user.name'}." \@ ".$env{'user.domain'}. ": ".$outcome); } if ($reply{$crs} > 0) { @@ -2239,44 +2176,19 @@ sub print_viewclass_response { my %otherdom = (); my %lockchg = (); my %nolockchg = (); - my $classlist = &Apache::loncoursedata::get_classlist($cid,$dom,$crs); + my $classlist = &Apache::loncoursedata::get_classlist($dom,$crs); my $endidx = &Apache::loncoursedata::CL_END; my $startidx = &Apache::loncoursedata::CL_START; my $ididx=&Apache::loncoursedata::CL_ID; my $secidx=&Apache::loncoursedata::CL_SECTION; my $typeidx=&Apache::loncoursedata::CL_TYPE; my $lockedidx=&Apache::loncoursedata::CL_LOCKEDTYPE; - my @typechglist = (); - my @lockchglist = (); &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},['chgauto','chgmanual','lockchg','unlockchg']); - if ($ENV{'form.chgauto'}) { - if (ref($ENV{'form.chgauto'}) eq 'ARRAY') { - push @typechglist, @{$ENV{'form.chgauto'}}; - } else { - push @typechglist, $ENV{'form.chgauto'}; - } - } - if ($ENV{'form.chgmanual'}) { - if (ref($ENV{'form.chgmanual'}) eq 'ARRAY') { - push @typechglist, @{$ENV{'form.chgmanual'}}; - } else { - push @typechglist, $ENV{'form.chgmanual'}; - } - } - if ($ENV{'form.lockchg'}) { - if (ref($ENV{'form.lockchg'}) eq 'ARRAY') { - push @lockchglist, @{$ENV{'form.lockchg'}}; - } else { - push @lockchglist, $ENV{'form.lockchg'}; - } - } - if ($ENV{'form.unlockchg'}) { - if (ref($ENV{'form.unlockchg'}) eq 'ARRAY') { - push @lockchglist, @{$ENV{'form.unlockchg'}}; - } else { - push @lockchglist, $ENV{'form.unlockchg'}; - } - } + my @typechglist = (&Apache::loncommon::get_env_multiple('form.chgauto'), + &Apache::loncommon::get_env_multiple('form.chgmanual')); + my @lockchglist = (&Apache::loncommon::get_env_multiple('form.lockchg'), + &Apache::loncommon::get_env_multiple('form.unlockchg')); + foreach my $student (sort @typechglist) { my ($uname,$udom) = split/:/,$student; my $sdata = $classlist->{$student}; @@ -2346,7 +2258,7 @@ sub print_viewclass_response { } if ($chgtotal > 0) { $response = "You requested a change in enrollment type for $chgtotal students.

    \n"; - $classlist = &Apache::loncoursedata::get_classlist($cid,$dom,$crs); + $classlist = &Apache::loncoursedata::get_classlist($dom,$crs); if ($chgok > 0) { $response .= "The following $chgok changes were successful:
    "; $response .= &enrolltype_result(\%chg,$classlist,$endidx,$startidx,$ididx,$secidx,$typeidx); @@ -2363,7 +2275,7 @@ sub print_viewclass_response { } if ($locktotal > 0) { $response .= "You requested locking/unlocking for $locktotal manually enrolled students.

    \n"; - $classlist = &Apache::loncoursedata::get_classlist($cid,$dom,$crs); + $classlist = &Apache::loncoursedata::get_classlist($dom,$crs); if ($lockok > 0) { $response .= "The following $lockok changes were successful:
    "; $response .= &enrolltype_result(\%lockchg,$classlist,$endidx,$startidx,$ididx,$secidx,$typeidx,$lockedidx); @@ -2494,9 +2406,9 @@ sub setup_date_selectors { if (! defined($starttime)) { $starttime = time; if ($action eq 'setdates') { - if (exists($ENV{'course.'.$ENV{'request.course.id'}. + if (exists($env{'course.'.$env{'request.course.id'}. '.default_enrollment_start_date'})) { - $starttime = $ENV{'course.'.$ENV{'request.course.id'}. + $starttime = $env{'course.'.$env{'request.course.id'}. '.default_enrollment_start_date'}; } } @@ -2504,9 +2416,9 @@ sub setup_date_selectors { if (! defined($endtime)) { $endtime = time+(6*30*24*60*60); # 6 months from now, approx if ($action eq 'setdates') { - if (exists($ENV{'course.'.$ENV{'request.course.id'}. + if (exists($env{'course.'.$env{'request.course.id'}. '.default_enrollment_end_date'})) { - $endtime = $ENV{'course.'.$ENV{'request.course.id'}. + $endtime = $env{'course.'.$env{'request.course.id'}. '.default_enrollment_end_date'}; } } @@ -2525,7 +2437,7 @@ sub get_dates_from_form { my $enddate; $startdate = &Apache::lonhtmlcommon::get_date_from_form('startdate'); $enddate = &Apache::lonhtmlcommon::get_date_from_form('enddate'); - if ( exists ($ENV{'form.no_end_date'}) ) { + if ( exists ($env{'form.no_end_date'}) ) { $enddate = 0; } return ($startdate,$enddate); @@ -2558,19 +2470,19 @@ sub date_setting_table { sub handler { my $r = shift; if ($r->header_only) { - $r->content_type('text/html'); + &Apache::loncommon::content_type($r,'text/html'); $r->send_http_header; return OK; } &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},['action','state']); # Needs to be in a course - if (! (($ENV{'request.course.fn'}) && (&Apache::lonnet::allowed('cst',$ENV{'request.course.id'})))) { + if (! (($env{'request.course.fn'}) && (&Apache::lonnet::allowed('cst',$env{'request.course.id'})))) { # Not in a course, or not allowed to modify parms - $ENV{'user.error.msg'}="/adm/populate:cst:0:0:Cannot drop or add students"; + $env{'user.error.msg'}="/adm/populate:cst:0:0:Cannot drop or add students"; return HTTP_NOT_ACCEPTABLE; } # Start page - $r->content_type('text/html'); + &Apache::loncommon::content_type($r,'text/html'); $r->send_http_header; my @tasks = ("information","chgsettings","setdates","setaccess","notify","crosslist","sections","photos","updatenow","viewclass"); @@ -2605,25 +2517,25 @@ sub handler { ); my $realm = ''; - if ( exists($ENV{'request.course.id'}) ) { - $realm= $ENV{'course.'.$ENV{'request.course.id'}.'.description'}; + if ( exists($env{'request.course.id'}) ) { + $realm= $env{'course.'.$env{'request.course.id'}.'.description'}; } unless ($realm) { $realm=' '; } - my $dom = $ENV{'course.'.$ENV{'request.course.id'}.'.domain'}; - my $crs = $ENV{'course.'.$ENV{'request.course.id'}.'.num'}; + my $dom = $env{'course.'.$env{'request.course.id'}.'.domain'}; + my $crs = $env{'course.'.$env{'request.course.id'}.'.num'}; # # Main switch on form.action and form.state, as appropriate # my $action = "information"; - if ( exists($ENV{'form.action'}) ) { - $action = $ENV{'form.action'}; + if ( exists($env{'form.action'}) ) { + $action = $env{'form.action'}; } my $state = "choose"; - if ( exists($ENV{'form.state'}) ) { - $state = $ENV{'form.state'}; + if ( exists($env{'form.state'}) ) { + $state = $env{'form.state'}; } if ($action eq "information") { @@ -2633,8 +2545,8 @@ sub handler { $r->print(&choose_header($action)); } else { if ($action eq "crosslist") { - if ( exists($ENV{'form.numcross'}) ) { - if ( $ENV{'form.numcross'} > 0 ) { + if ( exists($env{'form.numcross'}) ) { + if ( $env{'form.numcross'} > 0 ) { $r->print(&choose_header($action)); } else { $r->print(&header()); @@ -2643,8 +2555,8 @@ sub handler { $r->print(&header()); } } elsif ($action eq "sections") { - if ( exists($ENV{'form.numsec'}) ) { - if ( $ENV{'form.numsec'} > 0 ) { + if ( exists($env{'form.numsec'}) ) { + if ( $env{'form.numsec'} > 0 ) { $r->print(&choose_header($action)); } else { $r->print(&header());