--- loncom/interface/lonpopulate.pm	2006/07/27 23:24:19	1.44
+++ loncom/interface/lonpopulate.pm	2007/05/02 01:33:49	1.50
@@ -1,5 +1,5 @@
 # automated enrollment configuration handler
-# $Id: lonpopulate.pm,v 1.44 2006/07/27 23:24:19 raeburn Exp $
+# $Id: lonpopulate.pm,v 1.50 2007/05/02 01:33:49 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -46,7 +46,7 @@ sub header {
 
 sub choose_header {
     my ($action) = @_;
-
+    my $notify_check = '/^note_[0-9]+$/';
     my $scripttag = qq|
 <script language='javascript' type='text/javascript'>
 <!--
@@ -111,6 +111,32 @@ function process(calling,numauto,nummanu
          checker = 0
      }
  }
+ if (calling == "notify") {
+     var totalnote = 0;
+     for (var i=0; i<formName.elements.length; i++) {
+	 var elementname = formName.elements[i].name;
+	 var check_name = elementname.match($notify_check);
+	 if (check_name != null) {
+	     if (formName.elements[i].checked) {
+		 totalnote ++;
+	     }
+	 } 
+     }
+     if (totalnote > 0) {
+	 if (formName.notify[1].checked == true) {
+	     if (confirm("You have indicated that you do not want notification of roster changes messages to be sent, but "+totalnote+" have been checked as recipients.\\nClick 'OK' to erase all recipients, or 'Cancel'.")) {
+		 checker  = 1;
+	     } else {
+		 checker = 0;
+	     }
+	 }
+     } else {
+	 if (formName.notify[0].checked == true) {
+	     alert("You have indicated that you want notification of roster changes messages to be sent, but you have not selected any recipients.");
+	     checker = 0;
+	 }
+     }
+ }
  if (calling == "viewclass") {
      var totcheck = 0
      var numchk = 0
@@ -494,10 +520,10 @@ ENDTWO
           $noteset = "OFF";
       }
       my %dompersonnel = &Apache::lonnet::get_domain_roles($dom,['dc']);
-      foreach my $server (keys %dompersonnel) {
-          foreach my $user (sort(keys %{$dompersonnel{$server}})) {
+      foreach my $server (keys(%dompersonnel)) {
+          foreach my $user (sort(keys(%{$dompersonnel{$server}}))) {
               my ($trole,$uname,$udom,$runame,$rudom,$rsec) = split(/:/,$user);
-              if (!grep/^$uname:$udom$/,@domcoord) {
+              if (!grep(/^$uname:$udom$/,@domcoord)) {
                   push(@domcoord,$uname.':'.$udom);
               }
           }
@@ -546,7 +572,7 @@ ENDTWO
               next;
           }
           if ($role eq 'cc')  {
-              unless (grep/^$user$/,@ccs) {
+              unless (grep(/^$user$/,@ccs)) {
                   if ($end && $end < $now) {
                       $status{$user} = 'previous';
                   } elsif ($start > $now) {
@@ -558,7 +584,7 @@ ENDTWO
                   my ($uname,$udom) = split(/:/,$user);
                   $pname{$user} = 
                            &Apache::loncommon::plainname($uname,$udom);
-                  if (grep/^$user$/,@notified) {
+                  if (grep(/^$user$/,@notified)) {
                       $notifystate{$user} = 1;
                   } else {
                       $notifystate{$user} = 0;
@@ -566,7 +592,7 @@ ENDTWO
               }
           }
       }
-      my $notifyshow = @ccs;
+      my $notifyshow = 0; 
       my %lt = &Apache::lonlocal::texthash(
                                   name => 'Name',
                                   usnm => 'username:domain',
@@ -639,9 +665,15 @@ ENDTWO
              </td>
           </tr>");
       }
-      if ($notifycount || @showdom > 0) {
-          $r->print("<tr><td>&nbsp;</td></tr><tr><td>".
-                &mt("Uncheck the 'Notification?' checkbox for each person who is to be removed from the list of recipients who are currently informed of roster changes whenever any adds or drops occur during the nightly enrollment check.").' '.&mt("To include individuals who are not currently recipients, simply check the 'Notification?' checkbox. Click 'Go' to store your changes.")."
+      if (@ccs > 0 || @showdom > 0) {
+          $r->print("<tr><td>&nbsp;</td></tr><tr><td>");
+          if ($notifycount) {
+              $r->print(&mt("Uncheck the checkbox(es) to terminate notification for people currently informed of roster changes from the nightly enrollment update.<br />"));
+         }
+         if ((@ccs + @showdom) > $notifycount) {
+             $r->print(&mt("Check the checkbox(es) to initiate notification for people not currently informed of roster changes from the nightly enrollment update.<br />"));
+         }
+         $r->print(&mt("Click 'Go' to save your changes.")."
            <br/>
            <table width=\"100%\" border=\"0\" cellspadding=\"2\" cellspacing=\"2\">
             <tr>
@@ -675,7 +707,7 @@ ENDTWO
       ");
       if ($cross_str > 0) {
           $r->print("
-                Currently, this LON-CAPA course is crosslisted with $cross_str course section(s).  Students enrolling in these course sections will be automatically added to the class roster for the course, if you have chosen to enable a nightly automated enrollment update.  For each crosslisting, leave the checkbox checked if you want registered students in that course to be included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise uncheck it. If you wish to change the section ID assigned in your LON-CAPA course for a crosslisted course, enter the new section ID in the appropriate textbox. The LON-CAPA section ID can be left (or set to) empty, if you do not wish to tie a section ID to this crosslisting. If you wish to add new crosslisted courses, enter the number of new courses to add in the textbox at the bottom of the page. You will provide information about each of the new crosslistings on a subsequent page.  Click 'Go' to store your changes.
+                Currently, this LON-CAPA course is crosslisted with $cross_str course section(s).  Students enrolling in these course sections will be automatically added to the class roster for the course, if you have chosen to enable a nightly automated enrollment update.  For each crosslisting, leave the checkbox checked if you want registered students in that course to be included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise uncheck it. If you wish to change the section ID assigned in your LON-CAPA course for a crosslisted course, enter the new section ID in the appropriate textbox. The LON-CAPA section ID can be left (or set to) empty, if you do not wish to tie a section ID to this crosslisting. If you wish to add new crosslisted courses, enter the number of new courses to add in the textbox at the bottom of the page. You will provide information about each of the new crosslistings on a subsequent page.  Click 'Go' to save your changes.
               </td>
              </tr>
             </table>
@@ -761,8 +793,7 @@ ENDTWO
               </td>
              </tr>
              <tr>
-              <td>For each section, check the checkbox if you want registered students in that section to be included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise uncheck it. If you want to change the section ID designation used for this section in LON-CAPA, delete the current value in the LON-CAPA section ID textbox and enter the new value. The LON-CAPA section ID can be left (or set to) empty, if you do not wish to tie a section ID to this section. To add a new section, check the 'Enrollment in this course?' checkbox, and enter the desired LON-CAPA section ID in the appropriate textbox. Click 'Go' to store
-your changes.</td>
+              <td>For each section, check the checkbox if you want registered students in that section to be included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise uncheck it. If you want to change the section ID designation used for this section in LON-CAPA, delete the current value in the LON-CAPA section ID textbox and enter the new value. The LON-CAPA section ID can be left (or set to) empty, if you do not wish to tie a section ID to this section. To add a new section, check the 'Enrollment in this course?' checkbox, and enter the desired LON-CAPA section ID in the appropriate textbox. Click 'Go' to save your changes.</td>
              </tr>
             </table>
             <br/>
@@ -822,7 +853,7 @@ your changes.</td>
           if (@currsections) {
               my $secshow = @currsections;
               $r->print("
-                Currently, this LON-CAPA course incorporates enrollment from $secshow sections.  Students enrolling in any of these course sections will be automatically added to the class roster for the course, if you have chosen to enable a nightly automated enrollment update. For each section, uncheck the checkbox if you want registered students in that section to cease being included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise leave it checked. If you want to change the section ID designation used for this section in LON-CAPA, delete the current value in the LON-CAPA section ID textbox and enter the new value.  If you wish to add new course section, enter the number of new sections to add in the textbox at the bottom of the page. You will provide information about each of the new sections on a subsequent page. Click 'Go' to store your changes.
+                Currently, this LON-CAPA course incorporates enrollment from $secshow sections.  Students enrolling in any of these course sections will be automatically added to the class roster for the course, if you have chosen to enable a nightly automated enrollment update. For each section, uncheck the checkbox if you want registered students in that section to cease being included in the student roster for LON-CAPA course: <b>$realm ($enrollvar{coursecode})</b>; otherwise leave it checked. If you want to change the section ID designation used for this section in LON-CAPA, delete the current value in the LON-CAPA section ID textbox and enter the new value.  If you wish to add new course section, enter the number of new sections to add in the textbox at the bottom of the page. You will provide information about each of the new sections on a subsequent page. Click 'Go' to save your changes.
               </td>
              </tr>
             </table>
@@ -912,19 +943,13 @@ your changes.</td>
       ');
       my ($result,$perm_reqd)=&Apache::lonnet::auto_photo_permission($crs,$dom);
       my $can_enable = 1;
-      my $institution = $Apache::lonnet::domaindescription{$dom};
-      my $user;
-      if ($enrollvar{'courseowner'} =~ /^[^:]+:[^:]+$/) {
-          $user = $env{'user.name'}.':'.$env{'user.domain'};
-      } else {
-          $user = $env{'user.name'};
-      }
+      my $institution = &Apache::lonnet::domain($dom,'description');
       if ($result eq 'ok') {
           if ($perm_reqd eq 'yes') {
               if (!($enrollvar{'photopermission'} eq 'yes')) {
                   $can_enable = 0;
               } else {
-                  if ($user eq $enrollvar{'courseowner'}) {
+                  if (&user_is_courseowner($enrollvar{'courseowner'})) {
                       $r->print('
                     <tr>
                      <td>'.
@@ -951,13 +976,13 @@ your changes.</td>
                     <tr>
                      <td>
                       <font color="#888888">'.
-&mt('Note: if you enable automatic import of student photos, your course will automatically have access to photos stored by your institution for officially registered students, via a conduit established by your LON-CAPA domain coordinator.').'  
+&mt('Note: if you enable automatic import of student photos, your course will automatically have access to photos saved by your institution for officially registered students, via a conduit established by your LON-CAPA domain coordinator.').'  
                       </font>
                      </td>
                     </tr>
 ');
       } else {
-          if ($user eq $enrollvar{'courseowner'}) {
+          if (&user_is_courseowner($enrollvar{'courseowner'})) {
               $r->print('
                     <tr>
                      <td>'.
@@ -1091,7 +1116,7 @@ onclick="javascript:document.photoupdate
       if (! exists($env{'form.sortby'})) {
           $env{'form.sortby'} = 'username';
       }
-      if ($env{'form.Status'} !~ /^(Any|Expired|Active)$/) {
+      if ($env{'form.Status'} !~ /^(Any|Expired|Active|Future)$/) {
           $env{'form.Status'} = 'Active';
       }
       my $status_select = &Apache::lonhtmlcommon::StatusOptions($env{'form.Status'});
@@ -1761,7 +1786,7 @@ sub print_crosslistings_menu () {
 	if ($numcross > 0) {
 	    my @bgcolors=("#eeeeee","#cccccc");
 	    $response .= qq(You indicated that you wish to add an additional $numcross crosslisting(s).  For each new crosslisting enter the insititutional course section code (e.g., fs03zol101001, for section 001 of zol101 for fs03 semester), and the LON-CAPA section ID you wish to assign to students who will be enrolled in your LON-CAPA class as a result of their registration in the crosslisted course section. The LON-CAPA section ID can be left blank, if you do not wish to tie a section ID to this crosslisting.  The institutional course section code should only contain letters and/or numbers, and must be consistent with the scheme adopted by your Domain Coordinator to map course codes (and section numbers) to your institution's student information system.<br/><br/>
-           <form name="enter" method="post">);
+           <form name="enter" method="post">); #' stupid emacs
            $response .= &Apache::loncommon::start_data_table();
            $response .= &Apache::loncommon::start_data_table_row();
            $response .= qq(
@@ -2251,7 +2276,7 @@ sub photo_permission {
 					$dom,$crs);
     my ($showphotos,$response);
     if (exists($env{'form.cancel_agreement'})) {
-        if ($env{'user.name'} eq $settings{'internal.courseowner'}) {
+        if (&user_is_courseowner($settings{'internal.courseowner'})) {
             my %cenv = (
                 'internal.photopermission' => 'no',
             );
@@ -2320,8 +2345,8 @@ sub photo_permission {
 sub print_photo_agreement {
     my ($r,$realm,$dom,$crs,$action,$tasktitleref,$conditions,$courseowner)=@_;
     my $response;
-    my $institution = $Apache::lonnet::domaindescription{$dom};
-    if ($env{'user.name'} eq $courseowner) {
+    my $institution = &Apache::lonnet::domain($dom,'description');
+    if (&user_is_courseowner($courseowner)) {
         $response = '
 <script type="text/javascript">
 function agreement_result(caller) {
@@ -2952,6 +2977,17 @@ sub validate_lcsec {
     return 'ok';
 }
 
+sub user_is_courseowner {
+    my ($courseowner) = @_;
+    my $user;
+    if ($courseowner =~ /^[^:]+:[^:]+$/) {
+	$user = $env{'user.name'}.':'.$env{'user.domain'};
+    } else {
+	$user = $env{'user.name'};
+    }
+    return ($user eq $courseowner);
+}
+    
 ###################################################################
 sub handler {
     my $r = shift;