--- loncom/interface/lonsearchcat.pm	2007/04/13 23:05:40	1.284
+++ loncom/interface/lonsearchcat.pm	2007/06/15 23:29:17	1.287
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Search Catalog
 #
-# $Id: lonsearchcat.pm,v 1.284 2007/04/13 23:05:40 albertel Exp $
+# $Id: lonsearchcat.pm,v 1.287 2007/06/15 23:29:17 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -379,7 +379,7 @@ END
                                      $errorstring);
 
 	    my $msg = 
-		'Unable to create table in which to store search results. '.
+		'Unable to create table in which to save search results. '.
 		'The search has been aborted.';
 	    &Apache::loncommon::simple_error_page($r,'Search Error',
 						  $msg);
@@ -388,7 +388,7 @@ END
         delete($env{'form.launch'});
         if (! &make_form_data_persistent($r,$persistent_db_file)) {
 	    my $msg=
-		'Unable to properly store search information. '.
+		'Unable to properly save search information. '.
 		'The search has been aborted.';
 	    &Apache::loncommon::simple_error_page($r,'Search Error',
 						  $msg);
@@ -990,7 +990,7 @@ ENDHEADER
                description=>'Network-wide number of accesses (hits)',},
              { name=>'stdno',
                description=>
-               'Total number of students who have worked on this problem',},
+               'Statistics calculated for number of students',},
              { name => 'avetries',
                description=>'Average number of tries till solved',},
              { name => 'difficulty',
@@ -2146,7 +2146,7 @@ sub ensure_db_and_table {
     ##
     if (! defined($table) || $table eq '' || $table =~ /\D/ ) {
         $r->print("Unable to retrieve search results.  ".
-                  "Unable to determine the table results were stored in.  ".
+                  "Unable to determine the table results were saved in.  ".
 		  &Apache::loncommon::end_page());
         return undef;
     }
@@ -2156,7 +2156,7 @@ sub ensure_db_and_table {
     my $connection_result = &Apache::lonmysql::connect_to_db();
     if (!defined($connection_result)) {
         $r->print("Unable to connect to the MySQL database where your results".
-                  " are stored.".
+                  " are saved.".
 		  &Apache::loncommon::end_page());
         &Apache::lonnet::logthis("lonsearchcat: unable to get lonmysql to".
                                  " connect to database.");
@@ -2522,7 +2522,7 @@ END
     # Check on the mysql table we will use to store results.
     my $table =$env{'form.table'};
     if (! defined($table) || $table eq '' || $table =~ /\D/ ) {
-        $r->print("Unable to determine table id to store search results in.".
+        $r->print("Unable to determine table id to save search results in.".
                   "The search has been aborted.".
 		  &Apache::loncommon::end_page());
         return;
@@ -2760,7 +2760,7 @@ sub display_results {
     if ($env{'form.catalogmode'} eq 'import') {
         if (! tie(%groupsearch_db,'GDBM_File',$diropendb,
                   &GDBM_WRCREAT(),0640)) {
-            $r->print('Unable to store import results.</form>'.
+            $r->print('Unable to save import results.</form>'.
 		      &Apache::loncommon::end_page());
             $r->rflush();
             return;
@@ -2997,8 +2997,8 @@ sub catalogmode_output {
         $title=~ s/\'/\\\'/g;
         if ($env{'form.catalogmode'} eq 'interactive') {
             $output.=<<END 
-<font size='-1'><INPUT TYPE="button" NAME="returnvalues" VALUE="SELECT"
-onClick="javascript:select_data('$title','$url')">
+<font size='-1'><input type="button" name="returnvalues" value="select"
+onClick="javascript:select_data('$title','$url')" />
 </font>
 END
         }
@@ -3007,7 +3007,7 @@ END
         $groupsearch_db{"pre_${fnum}_title"}=$title;
         $output.=<<END;
 <font size='-1'>
-<input type="checkbox" name="returnvalues" value="SELECT"
+<input type="checkbox" name="returnvalues" value="select"
 onClick="javascript:queue($checkbox_num,$fnum)" />
 </font>
 END
@@ -3444,11 +3444,8 @@ sub detailed_citation_view {
         if (exists($field->{'type'}) && $field->{'type'} eq 'list') {
             $result .= '<b>'.&mt($field->{'translate'}).'</b>';
             foreach my $item (split(',',$values{$field->{'name'}})){
-                $result .= 
-		  &Apache::lonhtmlcommon::crumbs(&Apache::lonnet::clutter($item),
-		  'preview',
-		  '',
-		  (($env{'form.catalogmode'} eq 'import')?'parent.statusframe.document.forms.statusform':''),2,0,1);
+                $item = &Apache::lonnet::clutter($item);
+                $result .= &display_url($item,[2,0,1]);
             }
         } elsif (exists($field->{'format'}) && $field->{'format'} ne ''){
             $result.= &mt($field->{'translate'},
@@ -3456,15 +3453,7 @@ sub detailed_citation_view {
                                   $values{$field->{'name'}}))."<br />\n";
         } else {
             if ($field->{'special'} eq 'url link') {
-               if ($jumpurl=~/^http\:\/\//) {
-                 $result.='<tt>'.$jumpurl.'</tt>';
-               } else {
-                 $result .=
-		  &Apache::lonhtmlcommon::crumbs($jumpurl,
-		  'preview',
-		  '',
-		  (($env{'form.catalogmode'} eq 'import')?'parent.statusframe.document.forms.statusform':''),3,0,1);
-               }
+                $result .= &display_url($jumpurl,[3,0,1]);
             } else {
                 $result.= &mt($field->{'translate'},
                               $values{$field->{'name'}});
@@ -3520,19 +3509,13 @@ sub summary_view {
         $result .= '&nbsp;'.$tmp.'&nbsp;';
     }
     my $jumpurl=$values{'url'};
-    my $link;
-    if ($jumpurl=~m|^/ext/|) {
-	$jumpurl=~s|^/ext/|http://|;
-	$link='<br /><tt>'.$jumpurl.'</tt>';
-    } else {
-	$link=&Apache::lonhtmlcommon::crumbs($jumpurl,
-		  'preview',
-		  '',
-		  (($env{'form.catalogmode'} eq 'import')?'parent.statusframe.document.forms.statusform':''),2,0,1);
-    }
+    $jumpurl=~s|^/ext/|http://|;
+    my $link = &display_url($jumpurl,[2,0,1]);
+
     $result.=<<END;
 <a href="$jumpurl" 
-   target='preview'>$values{'title'}</a>$link
+   target='preview'>$values{'title'}</a> <br />
+$link <br />
 $values{'author'}, $values{'owner'} -- $values{'lastrevisiondate'}<br />
 $values{'copyrighttag'}<br />
 $values{'extrashow'}
@@ -3565,16 +3548,10 @@ sub summary_preview {
 sub compact_view {
     my ($prefix,%values) = @_;
     my $jumpurl=$values{'url'};
-    my $link;
-    if ($jumpurl=~m|^/ext/|) {
-	$jumpurl=~s|^/ext/|http://|;
-	$link='<tt>'.$jumpurl.'</tt>';
-    } else {
-        $link=&Apache::lonhtmlcommon::crumbs($jumpurl,
-		  'preview',
-		  '',
-		  (($env{'form.catalogmode'} eq 'import')?'parent.statusframe.document.forms.statusform':''),1,1,1).' ';
-    }
+    $jumpurl=~s|^/ext/|http://|;
+
+    my $link = &display_url($jumpurl,[1,1,1]);
+    
     my $result = 
         $prefix.'<img src="'.&Apache::loncommon::icon($values{'url'}).'">';
     if (exists($env{'form.sortfield'}) && 
@@ -3583,12 +3560,30 @@ sub compact_view {
         if (! defined($tmp)) { $tmp = 'undefined'; }
         $result .= '&nbsp;'.$tmp.'&nbsp;';
     }
-    $result.='&nbsp;<a href="'.$jumpurl.'" target="preview">'.
-        $values{'title'}.'</a>'.('&nbsp;'x2).$link.
-        '<b>'.$values{'author'}.'</b> ('.$values{'domain'}.')<br />';
+    $jumpurl = &HTML::Entities::encode($jumpurl,'<>&"');
+    $result.=' <span class="LC_nobreak">'.
+	'<a href="'.$jumpurl.'" target="preview">'.
+        &HTML::Entities::encode($values{'title'},'<>&"').'</a></span> '.
+	$link.' <b>'.$values{'author'}.'</b> ('.$values{'domain'}.')<br />';
     return $result;
 }
 
+sub display_url {
+    my ($url,$crumb_args) = @_;
+    my $link;
+    if ($url=~m|^/ext/|) {
+	$url=~s|^/ext/|http://|;
+	$link='<span class="LC_filename">'.$url.'</span>';
+    } elsif ($url=~m{^(http://|/uploaded/)}) {
+	$link='<span class="LC_filename">'.$url.'</span>';
+    } else {
+        $link=&Apache::lonhtmlcommon::crumbs($url,
+		  'preview',
+		  '',
+		  (($env{'form.catalogmode'} eq 'import')?'parent.statusframe.document.forms.statusform':''),@{$crumb_args}).' ';
+    }
+    return $link;
+}
 
 ######################################################################
 ######################################################################