--- loncom/interface/lonsupportreq.pm	2008/07/08 01:08:57	1.49
+++ loncom/interface/lonsupportreq.pm	2009/10/22 13:41:41	1.55
@@ -1,5 +1,5 @@
 #
-# $Id: lonsupportreq.pm,v 1.49 2008/07/08 01:08:57 raeburn Exp $
+# $Id: lonsupportreq.pm,v 1.55 2009/10/22 13:41:41 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -238,9 +238,12 @@ function initialize_codes() {
     if ($r->uri eq '/adm/helpdesk') {
         &print_header($r,$origurl);
     }
+    my @css = ('LC_evenrow_value','LC_oddrow_value');
+    my $num = 1;
+    my $i = $num%2;
     $r->print('<form method="post" name="logproblem" enctype="multipart/form-data">'."\n");
     my $output = &Apache::lonhtmlcommon::start_pick_box().
-                 &Apache::lonhtmlcommon::row_title($lt{'name'},undef,'LC_oddrow_value')."\n";
+                 &Apache::lonhtmlcommon::row_title($lt{'name'},undef,$css[$num])."\n";
     my $fullname = '';
     if ((defined($lastname) && $lastname ne '') && (defined($firstname) && $firstname ne '')) {
         $fullname = "$firstname $lastname"; 
@@ -254,15 +257,23 @@ function initialize_codes() {
         $output .= '<input type="text" size="20" name="username" value="'.&HTML::Entities::encode($fullname,'"<>&').'" />';
     }
     $output .= '&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<input type="button" value="'.$lt{'subm'}.'" onclick="validate()" />&nbsp;'.
-                &Apache::lonhtmlcommon::row_closure()."\n".
-                &Apache::lonhtmlcommon::row_title($lt{'emad'},undef,'LC_evenrow_value').
-                '<input type="text" size="20" name="email" value="'.
-                &HTML::Entities::encode($email,'"<>&').'" /><br />'."\n".
-                &Apache::lonhtmlcommon::row_closure().
-                &Apache::lonhtmlcommon::row_title($lt{'emac'},undef,'LC_oddrow_value').
-                '<input type="text" size="50" name="cc" value="" /><br />'."\n".
-                &Apache::lonhtmlcommon::row_closure().
-                &Apache::lonhtmlcommon::row_title("$lt{'unme'}/$lt{'doma'}",undef,'LC_evenrow_value');
+                &Apache::lonhtmlcommon::row_closure()."\n";
+    $num ++;
+    $i = $num%2;
+    $output .= &Apache::lonhtmlcommon::row_title($lt{'emad'},undef,$css[$i]).
+               '<input type="text" size="20" name="email" value="'.
+               &HTML::Entities::encode($email,'"<>&').'" /><br />'."\n".
+               &Apache::lonhtmlcommon::row_closure();
+    $num ++;
+    $i = $num%2;
+    if (defined($env{'user.name'})) {
+        $output .= &Apache::lonhtmlcommon::row_title($lt{'emac'},undef,$css[$i]).
+                   '<input type="text" size="50" name="cc" value="" /><br />'."\n".
+                   &Apache::lonhtmlcommon::row_closure();
+        $num ++;
+        $i = $num%2;
+    }
+    $output .= &Apache::lonhtmlcommon::row_title("$lt{'unme'}/$lt{'doma'}",undef,$css[$i]);
     my $udom_input = '<input type="hidden" name="udom" value="'.
                      &HTML::Entities::encode($udom,'"<>&').'" />';
     my $uname_input = '<input type="hidden" name="uname" value="'.
@@ -294,15 +305,19 @@ function initialize_codes() {
         }
         $output .= $unameform.$udomform;
     }
-    $output .= &Apache::lonhtmlcommon::row_closure().
-               &Apache::lonhtmlcommon::row_title("$lt{'urlp'}",undef,'LC_oddrow_value').
+    $output .= &Apache::lonhtmlcommon::row_closure();
+    $num ++;
+    $i = $num%2;
+    $output .= &Apache::lonhtmlcommon::row_title("$lt{'urlp'}",undef,$css[$i]).
                $showserver.'<input type="hidden" name="sourceurl" value="'.
                &HTML::Entities::encode($server,'"<>&').'" />'.
                &Apache::lonhtmlcommon::row_closure().
                &Apache::lonhtmlcommon::row_title("$lt{'phon'}",undef,'LC_evenrow_value').
                '<input type="text" size="15" name="phone" /><br />'.
-               &Apache::lonhtmlcommon::row_closure().
-               &Apache::lonhtmlcommon::row_title("$lt{'crsd'}$details_title",undef,'LC_oddrow_value');
+               &Apache::lonhtmlcommon::row_closure();
+    $num ++;
+    $i = $num%2; 
+    $output .= &Apache::lonhtmlcommon::row_title("$lt{'crsd'}$details_title",undef,$css[$i]);
     if ($cnum) {
         if ($coursecodes{$cnum}) {
             foreach my $item (@codetitles) {
@@ -380,8 +395,10 @@ function initialize_codes() {
         $output .= '<br />'.$lt{'enct'}.':&nbsp;
                  <input type="text" name="title" size="25" value="" />'."\n";
     }
-    $output .= &Apache::lonhtmlcommon::row_closure().
-               &Apache::lonhtmlcommon::row_title($lt{'secn'},undef,'LC_evenrow_value');
+    $output .= &Apache::lonhtmlcommon::row_closure();
+    $num ++;
+    $i = $num%2;
+    $output .= &Apache::lonhtmlcommon::row_title($lt{'secn'},undef,$css[$i]);
     if ($sectionlist) {
         $output .= "<select name=\"section\"\n>".
                    "  <option value=\"\" selected=\"selected\">$lt{'sele'}</option>\n";
@@ -400,21 +417,25 @@ function initialize_codes() {
     } else {
         $output .= '<input type="text" name="section" size="10" />';
     }
-    $output .= &Apache::lonhtmlcommon::row_closure().
-               &Apache::lonhtmlcommon::row_title($lt{'subj'},undef,'LC_oddrow_value').
+    $output .= &Apache::lonhtmlcommon::row_closure();
+    $num ++;
+    $i = $num%2; 
+    $output .= &Apache::lonhtmlcommon::row_title($lt{'subj'},undef,'LC_oddrow_value').
                '  <input type="text" size="40" name="subject" />'."\n".
                &Apache::lonhtmlcommon::row_closure().
                &Apache::lonhtmlcommon::row_title($lt{'detd'},undef,'LC_evenrow_value').
                '  <textarea rows="10" cols="45" name="description" wrap="virtual"></textarea>'.
                &Apache::lonhtmlcommon::row_closure();
-    my $lastrow = 'LC_evenrow_value';
+    $num ++;
+    $i = $num%2; 
     if (defined($env{'user.name'})) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'opfi'},undef,'LC_oddrow_value').
+        $output .= &Apache::lonhtmlcommon::row_title($lt{'opfi'},undef,$css[$i]).
                    ' <input type="file" name="screenshot" size="20" /><br />'.$lt{'uplf'}."\n".
         &Apache::lonhtmlcommon::row_closure();
-        $lastrow = 'LC_oddrow_value';
+        $num ++;
+        $i = $num%2; 
     }
-    $output .= &Apache::lonhtmlcommon::row_title($lt{'fini'},undef,$lastrow);
+    $output .= &Apache::lonhtmlcommon::row_title($lt{'fini'},undef,$css[$i]);
     $output .= <<END;
              <table border="0" cellpadding="8" cellspacing="0">
               <tr>
@@ -474,7 +495,7 @@ sub print_request_receipt {
     }
     my %lt = &Apache::lonlocal::texthash (
                  username    => 'Name',
-                 email       => 'Email',
+                 email       => 'E-mail',
                  cc          => 'Cc',
                  user        => 'Username/domain',
                  phone       => 'Phone',
@@ -493,7 +514,7 @@ sub print_request_receipt {
     );
 
     my (@ok_ccs,@bad_ccs,$badccmsg,$okcclist);
-    if (defined($env{'form.cc'})) {
+    if ((defined($env{'user.name'})) && (defined($env{'form.cc'}))) {
         my @ccs;
         if ($env{'form.cc'} =~ /,/) {
             @ccs = split(/,/,$env{'form.cc'});
@@ -545,13 +566,15 @@ END
         if ($env{'form.'.$item} ne '') {
             if ($item eq 'description') {
                 my $descrip = $env{'form.description'};
-                $descrip =~ s|\n|<br />|g;
+                $descrip =  &cleanup_html($descrip);
+                $descrip =~ s|[\n\r\f]|<br />|g;
                 $displaymsg .= 
                     '<span class="LC_helpform_receipt_cat">'.
                     "$lt{$item}</span>: $descrip<br />\n";
             } elsif ($item eq 'sourceurl') {
                 my $showurl = $env{'form.sourceurl'};
                 $showurl =~ s/\?.*$//;
+                $showurl =  &cleanup_html($showurl);
                 $displaymsg .= 
                     '<span class="LC_helpform_receipt_cat">'.
                     "$lt{$item}</span>: $showurl<br />\n";
@@ -560,9 +583,11 @@ END
                     '<span class="LC_helpform_receipt_cat">'.
                     "$lt{$item}</span>: $okcclist<br />\n";
             } else {
+                my $showitem = $env{'form.'.$item};
+                $showitem = &cleanup_html($showitem);
                 $displaymsg .= 
                     '<span class="LC_helpform_receipt_cat">'.
-                    "$lt{$item}</span>: $env{'form.'.$item}<br />\n";
+                    "$lt{$item}</span>: $showitem<br />\n";
             }
         }
     }
@@ -663,7 +688,12 @@ END
 
     if ($attachmentpath =~ m-/([^/]+)$-) {
         $fname = $1;
-        $displaymsg .= '<br />'.&mt('An uploaded screenshot file \'[_1]\' ([_2] bytes) was included in the request sent by [_3].',$fname,$attachmentsize,$env{'user.name'}.': '.$env{'user.domain'});
+        $displaymsg .= '<br />'
+                      .&mt('An uploaded screenshot file [_1] ([_2] bytes) was included in the request sent by [_3].'
+                          ,'<span class="LC_filename">'.$fname.'<span>'
+                          ,$attachmentsize
+                          ,$env{'user.name'}.':'.$env{'user.domain'}
+                       );
         $supportmsg .= "\n";
         foreach my $var (@cookievars) {
             $supportmsg .= "$var: $cookies{$var}\n";
@@ -720,7 +750,8 @@ END
         unlink($attachmentpath);
     }
     $r->print('<b>'.$lt{'your'}.'</b>:<br /><br />'."\n");
-    $r->print(&Apache::lonhtmlcommon::start_pick_box('LC_helpform_receipt').
+    $r->print('<div style="width:620px;">'.
+              &Apache::lonhtmlcommon::start_pick_box().
               &Apache::lonhtmlcommon::row_title($lt{'info'},undef,'LC_oddrow_value')."\n".$displaymsg."\n".
               &Apache::lonhtmlcommon::row_closure().
               &Apache::lonhtmlcommon::row_title($lt{'adin'},undef,'LC_evenrow_value'));
@@ -746,7 +777,8 @@ END
     $envmsg =~ s/, $//;
     $r->print($envmsg."\n".
               &Apache::lonhtmlcommon::row_closure(1)."\n".
-              &Apache::lonhtmlcommon::end_pick_box()."\n".
+              &Apache::lonhtmlcommon::end_pick_box().
+              "</div>\n".
               &Apache::loncommon::end_page());
 }
 
@@ -775,7 +807,11 @@ sub print_header {
     $r->print(<<END);
 <table width="620" border="0" cellspacing="0" cellpadding="0" height="55">   <tr height="50">    <td width='5'>&nbsp;</td>
    <td>
-    <fieldset><legend><img src="$location/lonIcons/minilogo.gif" height='20' width='29' valign='bottom' />&nbsp;&nbsp;<b><font size="+1">LON-CAPA $lt{'headline'}</font></b></legend>
+    <fieldset>
+      <legend>
+        <img src="$location/lonIcons/minilogo.gif" height="20" width="29" valign="bottom" />
+        LON-CAPA $lt{'headline'}
+      </legend>
  <table id="LC_helpmenu_links">
    <tr>
     <td align="center"><span class="LC_nobreak"><img src="$location/help/help.png" border="0" alt="($lt{'login'})" valign="middle" />&nbsp;<b><a href="/adm/loginproblems.html">$lt{'login'}</a></b>&nbsp;</span></td>
@@ -816,9 +852,27 @@ sub get_domain {
     } elsif ($env{'request.role.domain'}) {
         $codedom = $env{'request.role.domain'};
     } else {
-        $codedom = $Apache::lonnet::perlvar{'lonDefDomain'};
+        $codedom = &Apache::lonnet::default_login_domain();
     }
     return $codedom;
 }
 
+sub cleanup_html {
+    my ($incoming) = @_;
+    my $outgoing;
+    if ($incoming ne '') {
+        $outgoing = $incoming;
+        $outgoing =~ s/\#/&#035;/g;
+        $outgoing =~ s/\&/&#038;/g;
+        $outgoing =~ s/</&#060;/g;
+        $outgoing =~ s/>/&#062;/g;
+        $outgoing =~ s/\(/&#040/g;
+        $outgoing =~ s/\)/&#041;/g;
+        $outgoing =~ s/"/&#034;/g;
+        $outgoing =~ s/'/&#039;/g;
+        $outgoing =~ s/\$/&#036;/g;
+    }
+    return $outgoing;
+}
+
 1;