--- loncom/interface/lonuserutils.pm	2009/03/05 23:58:00	1.83
+++ loncom/interface/lonuserutils.pm	2009/05/06 13:39:16	1.91
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Utility functions for managing LON-CAPA user accounts
 #
-# $Id: lonuserutils.pm,v 1.83 2009/03/05 23:58:00 raeburn Exp $
+# $Id: lonuserutils.pm,v 1.91 2009/05/06 13:39:16 bisitz Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -86,7 +86,7 @@ sub modifystudent {
 sub modifyuserrole {
     my ($context,$setting,$changeauth,$cid,$udom,$uname,$uid,$umode,$upass,
         $first,$middle,$last,$gene,$sec,$forceid,$desiredhome,$email,$role,
-        $end,$start,$checkid) = @_;
+        $end,$start,$checkid,$inststatus) = @_;
     my ($scope,$userresult,$authresult,$roleresult,$idresult);
     if ($setting eq 'course' || $context eq 'course') {
         $scope = '/'.$cid;
@@ -124,7 +124,7 @@ sub modifyuserrole {
     $userresult =
         &Apache::lonnet::modifyuser($udom,$uname,$uid,$umode,$upass,$first,
                                     $middle,$last,$gene,$forceid,$desiredhome,
-                                    $email,$role,$start,$end);
+                                    $email,$inststatus);
     if ($userresult eq 'ok') {
         if ($role ne '') {
             $role =~ s/_/\//g;
@@ -328,7 +328,7 @@ sub print_upload_manager_header {
         &javascript_validations('upload',$krbdefdom,$password_choice,undef,
                                 $env{'request.role.domain'},$context,
                                 $groupslist);
-    my $checked=(($env{'form.noFirstLine'})?' checked="checked" ':'');
+    my $checked=(($env{'form.noFirstLine'})?' checked="checked"':'');
     $r->print(&mt('Total number of records found in file: [_1]','<b>'.$distotal.'</b>').
               "<br />\n");
     $r->print('<div class="LC_left_float"><h3>'.
@@ -341,7 +341,7 @@ sub print_upload_manager_header {
               &hidden_input('fileupload',$env{'form.fileupload'}).
               &hidden_input('upfiletype',$env{'form.upfiletype'}).
               &hidden_input('upfile_associate',$env{'form.upfile_associate'}));
-    $r->print('<br /><label><input type="checkbox" name="noFirstLine"'.$checked.'/>'.
+    $r->print('<br /><label><input type="checkbox" name="noFirstLine"'.$checked.' />'.
               &mt('Ignore First Line').'</label><br />');
     $r->print('<br /><input type="button" value="'.&mt('Reverse Association').'" '.
               'name="Reverse Association" '.
@@ -408,10 +408,13 @@ sub javascript_validations {
          domain   => 'The optional domain field was not specified.',
          continue => 'Continue adding users?',
          );
+    if (($mode eq 'upload') && ($context eq 'domain')) {
+        $alert{'inststatus'} = &mt('The optional affiliation field was not specified'); 
+    }
     my $function_name = <<"END";
 $setsections_js
 
-function verify_message (vf,founduname,foundpwd,foundname,foundid,foundsec,foundemail,foundrole,founddomain) {
+function verify_message (vf,founduname,foundpwd,foundname,foundid,foundsec,foundemail,foundrole,founddomain,foundinststatus) {
 END
     my ($authnum,%can_assign) =  &Apache::loncommon::get_assignable_auth($domain);
     my $auth_checks;
@@ -538,6 +541,20 @@ END
         }
         message+='$alert{'domain'}';
     }
+END
+        if (($mode eq 'upload') && ($context eq 'domain')) {
+            $optional_checks .= (<<END);
+
+    if (foundinststatus==0) {
+        if (message!='') {
+            message+='\\n';
+        }
+        message+='$alert{'inststatus'}';
+    }
+END
+        }
+        $optional_checks .= (<<END);
+
     if (message!='') {
         message+= '\\n$alert{'continue'}';
         if (confirm(message)) {
@@ -568,6 +585,7 @@ function verify(vf,sec_caller) {
     var foundemail=0;
     var foundrole=0;
     var founddomain=0;
+    var foundinststatus=0;
     var tw;
     for (i=0;i<=vf.nfields.value;i++) {
         tw=eval('vf.f'+i+'.selectedIndex');
@@ -579,8 +597,9 @@ function verify(vf,sec_caller) {
         if (tw==10) { foundemail=1; }
         if (tw==11) { foundrole=1; }
         if (tw==12) { founddomain=1; }
+        if (tw==13) { foundinststatus=1; }
     }
-    verify_message(vf,founduname,foundpwd,foundname,foundid,foundsec,foundemail,foundrole,founddomain);
+    verify_message(vf,founduname,foundpwd,foundname,foundid,foundsec,foundemail,foundrole,founddomain,foundinststatus);
 }
 
 //
@@ -602,6 +621,7 @@ function verify(vf,sec_caller) {
 // 10 = email address
 // 11 = role
 // 12 = domain
+// 13 = inststatus
 
 function flip(vf,tf) {
    var nw=eval('vf.f'+tf+'.selectedIndex');
@@ -666,6 +686,7 @@ function verify(vf,sec_caller) {
     var foundsec=0;
     var foundrole=0;
     var founddomain=0;
+    var foundinststatus=0;
     var tw;
     for (i=0;i<=vf.nfields.value;i++) {
         tw=eval('vf.f'+i+'.selectedIndex');
@@ -676,8 +697,9 @@ function verify(vf,sec_caller) {
         if (i==8 && tw!=0) { foundpwd=1; }
         if (i==9 && tw!=0) { foundrole=1; }
         if (i==10 && tw!=0) { founddomain=1; }
+        if (i==13 && tw!=0) { foundinstatus=1; }
     }
-    verify_message(vf,founduname,foundpwd,foundname,foundid,foundsec,foundrole,founddomain);
+    verify_message(vf,founduname,foundpwd,foundname,foundid,foundsec,foundrole,founddomain,foundinststatus);
 }
 
 function flip(vf,tf) {
@@ -791,7 +813,7 @@ sub print_upload_manager_footer {
         my $secbox = &section_picker($cdom,$cnum,'Any',$rowtitle,
                                      $permission,$context,'upload');
         $Str .= $secbox."<h3>".&mt('Full Update')."</h3>\n".
-                '<p><label><input type="checkbox" name="fullup" value="yes">'.
+                '<p><label><input type="checkbox" name="fullup" value="yes" />'.
                 ' '.&mt('Display students with current/future access who are not in the uploaded file.').'</label><br />'.&mt('Students selected from this list can be dropped.').'</p>'."\n";
     }
     if ($context eq 'course' || $context eq 'domain') {
@@ -816,13 +838,13 @@ sub forceid_change {
     my ($context) = @_;
     my $output = 
         "<h3>".&mt('Student/Employee ID')."</h3>\n".
-        "<p>\n".'<label><input type="checkbox" name="forceid" value="yes">'.
+        "<p>\n".'<label><input type="checkbox" name="forceid" value="yes" />'.
         &mt('Disable Student/Employee ID Safeguard and force change of conflicting IDs').
         '</label><br />'."\n".
         &mt('(only do if you know what you are doing.)')."\n";
     if ($context eq 'domain') {
         $output .= '<br /><label><input type="checkbox" name="recurseid"'.
-                   ' value="yes">'. 
+                   ' value="yes" />'. 
   &mt('Update Student/Employee ID in courses in which user is active/future student,[_1](if forcing change).','<br />').
                    '</label>'."\n";
     }
@@ -864,6 +886,7 @@ sub print_upload_manager_form {
                                'email_choice' => 'scalar',
                                'role_choice' => 'scalar',
                                'domain_choice' => 'scalar',
+                               'inststatus_choice' => 'scalar',
                              };
     my $defdom = $env{'request.role.domain'};
     if ($context eq 'course') {
@@ -895,7 +918,8 @@ sub print_upload_manager_form {
              ['ipwd', &mt('Initial Password'),$env{'form.ipwd_choice'}],
              ['email',&mt('E-mail Address'),   $env{'form.email_choice'}],
              ['role',&mt('Role'),             $env{'form.role_choice'}],
-             ['domain',&mt('Domain'),         $env{'form.domain_choice'}]);
+             ['domain',&mt('Domain'),         $env{'form.domain_choice'}],
+             ['inststatus',&mt('Affiliation'), $env{'form.inststatus_choice'}]);
         if ($env{'form.upfile_associate'} eq 'reverse') {
             &Apache::loncommon::csv_print_samples($r,\@records);
             $i=&Apache::loncommon::csv_print_select_table($r,\@records,
@@ -1308,7 +1332,7 @@ sub print_userlist {
              .'</span></label>'.('&nbsp;'x3)."\n");
     my $roleselected = '';
     if ($env{'form.showrole'} eq 'Any') {
-       $roleselected = ' selected="selected" '; 
+       $roleselected = ' selected="selected"'; 
     }
     my ($cnum,$cdom);
     $r->print(&role_filter($context));
@@ -1502,7 +1526,7 @@ sub role_filter {
     my $output;
     my $roleselected = '';
     if ($env{'form.showrole'} eq 'Any') {
-       $roleselected = ' selected="selected" ';
+       $roleselected = ' selected="selected"';
     }
     my ($role_select);
     if ($context eq 'domain') {
@@ -1518,7 +1542,7 @@ sub role_filter {
         foreach my $role (@poss_roles) {
             $roleselected = '';
             if ($role eq $env{'form.showrole'}) {
-                $roleselected = ' selected="selected" ';
+                $roleselected = ' selected="selected"';
             }
             my $plrole;
             if ($role eq 'cr') {
@@ -2188,15 +2212,15 @@ END
             foreach my $item (@linkdests) {
                 my $checkedstr = '';
                 if ($item eq $usernamelink) {
-                    $checkedstr = ' checked="checked" ';
+                    $checkedstr = ' checked="checked"';
                 }
-                $output .= '<span class="LC_nobreak"><label><input type="radio" name="usernamelink" value="'.$item.'"'.$checkedstr.'>&nbsp;'.$lt{$item}.'</label></span><br />';
+                $output .= '<span class="LC_nobreak"><label><input type="radio" name="usernamelink" value="'.$item.'"'.$checkedstr.' />&nbsp;'.$lt{$item}.'</label></span><br />';
             }
             my $checkwin;
             if ($env{'form.userwin'}) {
-                $checkwin = 'checked = "checked"';
+                $checkwin = ' checked="checked"';
             }
-            $output .= '</td><td valign="top"><span class="LC_nobreak"><input type="checkbox" name="userwin" value="1" '.$checkwin.'/>'.$lt{'owin'}.'</span></td></tr></table></fieldset></div>';
+            $output .= '</td><td valign="top"><span class="LC_nobreak"><input type="checkbox" name="userwin" value="1"'.$checkwin.' />'.$lt{'owin'}.'</span></td></tr></table></fieldset></div>';
         }
         $output .= "\n".'<div class="LC_clear_float_footer">&nbsp;</div>'."\n".
                   &Apache::loncommon::start_data_table().
@@ -2513,7 +2537,7 @@ END
                             }
                         }
                         $r->print('<td><input type="checkbox" name="'.
-                                  'actionlist" value="'.$checkval.'"></td>');
+                                  'actionlist" value="'.$checkval.'" /></td>');
                     } else {
                         $r->print('<td>&nbsp;</td>');
                     }
@@ -2548,7 +2572,7 @@ END
                     }
                     if ($env{'course.'.$env{'request.course.id'}.'.internal.showphoto'}) {
                         if ($displayphotos eq 'on' && $role eq 'st' && $in{'photo'} ne '') {
-                            $r->print('    <td align="right"><a href="javascript:photowindow('."'".$in{'photo'}."'".')"><img src="'.$in{'thumbnail'}.'" border="1"></a></td>');
+                            $r->print('    <td align="right"><a href="javascript:photowindow('."'".$in{'photo'}."'".')"><img src="'.$in{'thumbnail'}.'" border="1" alt="" /></a></td>');
                         } else {
                             $r->print('    <td>&nbsp;</td>  ');
                         }
@@ -2835,8 +2859,8 @@ sub select_actions {
             }
         }
         if ($choices{'sections'}) {
-            $output .= '<input type="hidden" name="retainsec" value= "" />'."\n".
-                       '<input type="hidden" name="newsecs" value= "" />'."\n";
+            $output .= '<input type="hidden" name="retainsec" value="" />'."\n".
+                       '<input type="hidden" name="newsecs" value="" />'."\n";
         }
     }
     return $output;
@@ -3235,7 +3259,7 @@ sub show_drop_list {
 $check_uncheck_js
 </script>
 <p>
-<input type="hidden" name="phase" value="four">
+<input type="hidden" name="phase" value="four" />
 END
     my ($indexhash,$keylist) = &make_keylist_array();
     my $studentcount = 0;
@@ -3353,7 +3377,7 @@ END
         #
         $r->print(&Apache::loncommon::start_data_table_row());
         $r->print(<<"END");
-    <td><input type="checkbox" name="droplist" value="$studentkey"></td>
+    <td><input type="checkbox" name="droplist" value="$studentkey" /></td>
     <td>$username</td>
     <td>$domain</td>
     <td>$id</td>
@@ -3372,10 +3396,14 @@ END
                        'ua'   => "uncheck all",
                                        );
     $r->print(<<"END");
-</p><p>
-<input type="button" value="$lt{'ca'}" onclick="javascript:checkAll(document.studentform.droplist)"> &nbsp;
-<input type="button" value="$lt{'ua'}" onclick="javascript:uncheckAll(document.studentform.droplist)">
-<p><input type=submit value="$lt{'dp'}"></p>
+</p>
+<p>
+<input type="button" value="$lt{'ca'}" onclick="javascript:checkAll(document.studentform.droplist)" /> &nbsp;
+<input type="button" value="$lt{'ua'}" onclick="javascript:uncheckAll(document.studentform.droplist)" />
+</p>
+<p>
+<input type="submit" value="$lt{'dp'}" />
+</p>
 END
     return;
 }
@@ -3386,10 +3414,13 @@ END
 sub print_first_users_upload_form {
     my ($r,$context) = @_;
     my $str;
-    $str  = '<input type="hidden" name="phase" value="two">';
+    $str  = '<input type="hidden" name="phase" value="two" />';
     $str .= '<input type="hidden" name="action" value="upload" />';
     $str .= '<input type="hidden"   name="state"  value="got_file" />';
-    $str .= "<h3>".&mt('Upload a file containing information about users')."</h3>\n";
+    $str .= '<h2>'.&mt('Upload a file containing information about users').'</h2>'."\n";
+    $str .= '<p class="LC_info">'
+           .&mt('Please upload an UTF8 encoded file to ensure a correct character encoding in your classlist.')
+           .'</p>'."\n";
     $str .= &Apache::loncommon::upfile_select_html();
     $str .= '<p>';
     $str .= &Apache::loncommon::help_open_topic("Course_Create_Class_List",
@@ -3402,7 +3433,7 @@ sub print_first_users_upload_form {
     $str .= '<label><input type="checkbox" name="noFirstLine" /> '.
         &mt('Ignore First Line')."</label></p>\n";
     $str .= '<input type="submit" name="fileupload" value="'.
-        &mt('Next').'">'."<br />\n";
+        &mt('Next').'" />'."<br />\n";
     $str .= &Apache::loncommon::end_page();
     $r->print($str);
     return;
@@ -3447,7 +3478,8 @@ sub upfile_drop_add {
                                                 'ipwd_choice' => 'scalar',
                                                 'email_choice' => 'scalar',
                                                 'role_choice'  => 'scalar',
-                                                'domain_choice' => 'scalar'});
+                                                'domain_choice' => 'scalar',
+                                                'inststatus_choice' => 'scalar'});
     #
     my ($startdate,$enddate) = &get_dates_from_form();
     if ($env{'form.makedatesdefault'}) {
@@ -3530,6 +3562,7 @@ sub upfile_drop_add {
                     'permanentemail','id');
     my %canmodify;
     if (&Apache::lonnet::allowed('mau',$domain)) {
+        push(@userinfo,'inststatus');
         foreach my $field (@userinfo) {
             $canmodify{$field} = 1;
         }
@@ -3578,6 +3611,8 @@ sub upfile_drop_add {
         } else {
             $r->print('<h3>'.&mt('Adding/Modifying Users')."</h3>\n<p>\n");
         }
+        $r->rflush;
+
         my %counts = (
                        user => 0,
                        auth => 0,
@@ -3717,7 +3752,15 @@ sub upfile_drop_add {
                     if (defined($fields{'email'})) {
                         if (defined($entries{$fields{'email'}})) {
                             $email=$entries{$fields{'email'}};
-                            unless ($email=~/^[^\@]+\@[^\@]+$/) { $email=''; }                        }
+                            unless ($email=~/^[^\@]+\@[^\@]+$/) { $email=''; }
+                        }
+                    }
+                    # determine affiliation
+                    my $inststatus='';
+                    if (defined($fields{'inststatus'})) {
+                        if (defined($entries{$fields{'inststatus'}})) {
+                            $inststatus=$entries{$fields{'inststatus'}};
+                        }
                     }
                     # determine user password
                     my $password = $genpwd;
@@ -3800,7 +3843,7 @@ sub upfile_drop_add {
                                 }
                             }
                             my @newinfo = (\$fname,\$mname,\$lname,\$gen,\$email,\$id);
-                            for (my $i=0; $i<@userinfo; $i++) {
+                            for (my $i=0; $i<@newinfo; $i++) {
                                 if (${$newinfo[$i]} ne '') {
                                     if (!$canmodify{$userinfo[$i]}) {
                                         ${$newinfo[$i]} = '';
@@ -3849,7 +3892,7 @@ sub upfile_drop_add {
                                      $fname,$mname,$lname,$gen,$sec,$enddate,
                                      $startdate,$env{'form.forceid'},
                                      $desiredhost,$email,'manual','',$cid,
-                                     '',$context);
+                                     '',$context,$inststatus);
                             $userresult = $roleresult;
                         } else {
                             if ($role ne '') { 
@@ -3869,7 +3912,7 @@ sub upfile_drop_add {
                                                     $mname,$lname,$gen,$sec,
                                                     $env{'form.forceid'},$desiredhost,
                                                     $email,$role,$enddate,
-                                                    $startdate,$checkid);
+                                                    $startdate,$checkid,$inststatus);
                                             }
                                         } elsif (@secs > 0) {
                                             $singlesec = $secs[0];
@@ -3884,7 +3927,8 @@ sub upfile_drop_add {
                                                     $id,$amode,$password,$fname,
                                                     $mname,$lname,$gen,$singlesec,
                                                     $env{'form.forceid'},$desiredhost,
-                                                    $email,$role,$enddate,$startdate,$checkid);
+                                                    $email,$role,$enddate,$startdate,
+                                                    $checkid,$inststatus);
                             }
                         }
                         if ($multiple) {