--- loncom/interface/lonwhatsnew.pm	2010/08/09 23:39:43	1.98.2.2
+++ loncom/interface/lonwhatsnew.pm	2010/08/10 03:28:53	1.98.2.3
@@ -1,5 +1,5 @@
 #
-# $Id: lonwhatsnew.pm,v 1.98.2.2 2010/08/09 23:39:43 raeburn Exp $
+# $Id: lonwhatsnew.pm,v 1.98.2.3 2010/08/10 03:28:53 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -267,6 +267,7 @@ sub display_header {
             $command eq 'chgnewroleinterval' || $command eq 'chgcrslogininterval') {
        $scripttag = <<"END";
 <script type="text/javascript">
+// <![CDATA[
 function change_display(caller,change) {
     caller.value = change;
     document.visible.submit();
@@ -328,6 +329,7 @@ function togglelogins() {
     }
     return;
 }
+// ]]>
 </script>
 ';
     }
@@ -556,17 +558,21 @@ sub display_actions_box {
         $countunread = 'on';
     }
     if ($$checkallowed{'abovethreshold'}) {
-        &get_curr_thresholds(\%threshold,$uname,$udom,$cid,$cdom,$crs);
+        &get_curr_thresholds(\%threshold,$uname,$udom,$cid,$cdom,$crs,$custommenu);
     }
 
-    $headings{'abovethreshold'} = 
-	&mt('(Problems with av. attempts &ge; [_1] or deg. difficulty &ge; [_2]) [_3] and total number of '.$stulabel{$crstype}.' with submissions &ge; [_4]',
-	    $threshold{'av_attempts'},$threshold{'degdiff'},
-	    '<br />',$threshold{'numstudents'});
+    if ($custommenu) {
+        $headings{'abovethreshold'} = &mt('Questions with submissions');  
+    } else {
+        $headings{'abovethreshold'} = 
+	    &mt('(Problems with av. attempts &ge; [_1] or deg. difficulty &ge; [_2]) [_3] and total number of '.$stulabel{$crstype}.' with submissions &ge; [_4]',
+	        $threshold{'av_attempts'},$threshold{'degdiff'},
+	        '<br />',$threshold{'numstudents'});
+    }
 
     my @actionorder;
     if ($custommenu) {
-        @actionorder = ('coursenormalmail','coursecritmail','newroles','oldroles','crslogin');
+        @actionorder = ('coursenormalmail','coursecritmail','abovethreshold','newroles','oldroles','crslogin');
     } else {
         @actionorder = ('handgrading','haserrors','abovethreshold','versionchanges','coursediscussion','coursenormalmail','coursecritmail','newroles','oldroles');
     }
@@ -593,7 +599,7 @@ sub display_actions_box {
 
     my $itemserror;
     if ($needitems) {
-        $itemserror = &getitems(\%unread,\%ungraded,\%bombed,\%triggered,\%changed,\@newdiscussions,\@tograde,\@bombs,\@warnings,\%threshold,$cdom,$crs,\%res_title,\%show,$starttime,$countunread);
+        $itemserror = &getitems(\%unread,\%ungraded,\%bombed,\%triggered,\%changed,\@newdiscussions,\@tograde,\@bombs,\@warnings,\%threshold,$cdom,$crs,\%res_title,\%show,$starttime,$countunread,$custommenu);
     }
     if ($show{'coursenormalmail'}) {
         $msgcount = &getnormalmail(\@newmsgs);
@@ -621,7 +627,11 @@ sub display_actions_box {
         }
     }
 
-    $r->print('<input type="hidden" name="refpage" value="'.$refpage.'" /><table class="LC_double_column"><tr><td class="LC_left_col">');
+    $r->print('<input type="hidden" name="refpage" value="'.$refpage.'" />');
+    unless($custommenu) {
+        $r->print('</form>');
+    }
+    $r->print('<table class="LC_double_column"><tr><td class="LC_left_col">');
 
     my $displayed = 0;
     my $totalboxes = 0;
@@ -635,22 +645,25 @@ sub display_actions_box {
     my $halfway = 4;
 #    my $halfway = int($totalboxes/2) + $totalboxes%2;
     if ($custommenu) {
-        $halfway = 2;
+        $halfway = 3;
     }
     foreach my $actionitem (@actionorder) {
         if ($$checkallowed{$actionitem}) {
             if ($displayed == $halfway) {
                 $r->print('</td><td>&nbsp;</td><td class="LC_right_col" >');
             }
-            &display_launcher($r,$actionitem,$refpage,$checkallowed,\%show,\%headings,\%res_title,\@tograde,\%ungraded,\@bombs,\%bombed,\%changed,\@warnings,\%triggered,\@newdiscussions,\%unread,$msgcount,\@newmsgs,$critmsgcount,\@critmsgs,\%interval,$countunread,\%expired,$expirecount,\%activated,$activecount,$crstype,$itemserror,\%loggedin,$logincount);
+            &display_launcher($r,$actionitem,$refpage,$checkallowed,\%show,\%headings,\%res_title,\@tograde,\%ungraded,\@bombs,\%bombed,\%changed,\@warnings,\%triggered,\@newdiscussions,\%unread,$msgcount,\@newmsgs,$critmsgcount,\@critmsgs,\%interval,$countunread,\%expired,$expirecount,\%activated,$activecount,$crstype,$itemserror,\%loggedin,$logincount,$custommenu);
             $displayed ++; 
         }
     }
     $r->print('
-      </td></form>
+      </td>
     </tr>
    </table>
 ');
+    if ($custommenu) {
+        $r->print("</form>\n");
+    }
 }
 
 #-------------------------------
@@ -783,12 +796,14 @@ sub display_discussion_config {
                       'off' => 'on',
                     );
     $r->print('<script type="text/javascript">
+// <![CDATA[
 function toggle_countunread(choice) {
     if (choice == "unchanged") {
         document.discussionswitch.command.value = "";
     }
     document.discussionswitch.submit();
 }
+// ]]>
 </script>');
     $r->print('<br />'
              .&mt('Choose whether or not to display a count of the number of new posts for each resource or discussion board which has unread posts.')
@@ -897,10 +912,10 @@ sub display_launcher {
         $tograde,$ungraded,$bombs,$bombed,$changed,$warnings,$triggered,
         $newdiscussions,$unread,$msgcount,$newmsgs,$critmsgcount,$critmsgs,
         $interval,$countunread,$expired,$expirecount,$activated,$activecount,
-        $crstype,$itemserror,$loggedin,$logincount) = @_;
+        $crstype,$itemserror,$loggedin,$logincount,$custommenu) = @_;
 
     if ($$checkallowed{$action}) {
-        &start_box($r,$show,$headings,$action,$refpage,$action);
+        &start_box($r,$show,$headings,$action,$refpage,$action,$custommenu);
         if ($$show{$action}) {
             if ($action eq 'handgrading') {    # UNGRADED ITEMS
                 &display_handgrade($r,$tograde,$ungraded,$itemserror);
@@ -910,7 +925,7 @@ sub display_launcher {
                 &display_versionchanges($r,$changed,$res_title,$interval->{'versions'},$itemserror);
             } elsif ($action eq 'abovethreshold') { # DEGDIFF/AV. TRIES TRIGGERS
                 &display_abovethreshold($r,$refpage,$warnings,$triggered,
-					$res_title,$itemserror);
+					$res_title,$itemserror,$custommenu);
             } elsif ($action eq 'coursediscussion') { # UNREAD COURSE DISCUSSION
                 &display_coursediscussion($r,$newdiscussions,$unread,
                                 $countunread,$res_title,$itemserror);
@@ -938,7 +953,7 @@ sub display_launcher {
 sub getitems {
     my ($unread,$ungraded,$bombed,$triggered,$changed,$newdiscussions,
         $tograde,$bombs,$warnings,$threshold,$cdom,$crs,$res_title,$show,
-        $starttime,$countunread) = @_;
+        $starttime,$countunread,$custommenu) = @_;
     my $navmap = Apache::lonnavmaps::navmap->new();
     if (!defined($navmap)) {
         my $itemserror = '<span class="LC_warning">'.&mt('An error occurred retrieving information about the course.').'<br />'.&mt('It is recommended that you [_1]re-select the course[_2].','<a href="/adm/roles">','</a>').'</span>';
@@ -998,7 +1013,7 @@ sub getitems {
 # Maxtries and degree of difficulty for problem parts, unless handgradeable
         if ($$show{'abovethreshold'}) {  
             &check_thresholds($resource,$symb,\%resourcetracker,
-			      $triggered,$threshold,$warnings);
+			      $triggered,$threshold,$warnings,$custommenu);
         }
 
     }
@@ -1072,7 +1087,7 @@ sub check_bombed {
 }
 
 sub check_thresholds {
-    my ($resource,$symb,$resourcetracker,$triggered,$threshold,$warnings) = @_;
+    my ($resource,$symb,$resourcetracker,$triggered,$threshold,$warnings,$custommenu) = @_;
 # Compile maxtries and degree of difficulty for problem parts, unless handgradeable
     my @parts = @{$resource->parts()};
     my %stats;
@@ -1130,12 +1145,17 @@ sub check_thresholds {
                     $$triggered{$symb}{text}[$partcount] = '
                      <td>'.&mt('single part').'</td>';
                 }
-                $$triggered{$symb}{text}[$partcount] .= '
-                     <td>'.$stats{$part}{users}.'</td>
-                     <td>'.$stats{$part}{attempts}.'</td>
-                     <td>'.$stats{$part}{degdiff}.'</td>
-                     <td>'.$lastreset{$part}.'</td>
-                     <td><input type="checkbox" name="'.$resetname.'" /><input type="hidden" name="'.$resettitle.'" value="'.&escape($$triggered{$symb}{title}).'" /></td>';
+                if ($custommenu) {
+                    $$triggered{$symb}{text}[$partcount] .= '
+                         <td class="LC_right_item">'.$stats{$part}{users}.'</td>';
+                } else {
+                    $$triggered{$symb}{text}[$partcount] .= '
+                         <td>'.$stats{$part}{users}.'</td>
+                         <td>'.$stats{$part}{attempts}.'</td>
+                         <td>'.$stats{$part}{degdiff}.'</td>
+                         <td>'.$lastreset{$part}.'</td>
+                         <td><input type="checkbox" name="'.$resetname.'" /><input type="hidden" name="'.$resettitle.'" value="'.&escape($$triggered{$symb}{title}).'" /></td>';
+                }
                 $partcount ++;
             }
             $$triggered{$symb}{numparts} = $partcount;
@@ -1146,7 +1166,14 @@ sub check_thresholds {
 
 
 sub get_curr_thresholds {
-    my ($threshold,$uname,$udom,$cid,$cdom,$crs) = @_;
+    my ($threshold,$uname,$udom,$cid,$cdom,$crs,$custommenu) = @_;
+    if ($custommenu) {
+        %$threshold = (av_attempts => 0,
+                  degdiff => 0.00000000000000,
+                  numstudents => 1
+                  );
+        return;
+    }
     # set default values
     %$threshold = (av_attempts => 2,
                   degdiff => 0.5,
@@ -1658,7 +1685,7 @@ sub display_haserrors {
 }
 
 sub display_abovethreshold {
-    my ($r,$refpage,$warnings,$triggered,$res_title,$itemserror) = @_;
+    my ($r,$refpage,$warnings,$triggered,$res_title,$itemserror,$custommenu) = @_;
     my %lt = &Apache::lonlocal::texthash(
                  reso => 'Resource',
                  part => 'Part',
@@ -1672,16 +1699,35 @@ sub display_abovethreshold {
     );
     if (@{$warnings} > 0) {
         @{$warnings} = sort { &cmp_title($a,$b,$res_title) } @{$warnings};
-        $r->print('<form name="reset_tracking" method="post" action="/adm/whatsnew">'.
+        if ($custommenu) {
+            my (%bynum,@overthresh);
+            foreach my $item (@{$warnings}) {
+                my ($probnum) = ($res_title->{$item} =~ /^Problem\s+(\d+)$/);
+                if ($probnum ne '') {
+                    $bynum{$probnum} = $item;
+                }
+            }
+            foreach my $num (sort { $a <=> $b } keys(%bynum)) {
+                push(@overthresh,$bynum{$num});
+            }
+            @{$warnings} = @overthresh;
+        }
+        if ($custommenu) {
+            $r->print('<tr class="LC_info_row">'.
+                      '<td class="LC_left_item">'.$lt{'reso'}.'</td>'.
+                      '<td>'.$lt{'part'}.'</td><td class="LC_right_item">'.$lt{'nust'}.'</td></tr>');
+        } else {
+            $r->print('<form name="reset_tracking" method="post" action="/adm/whatsnew">'.
                 ' <input type="hidden" name="command" value="reset" />'."\n".
                 ' <input type="hidden" name="refpage" value="'.$refpage.'" />'.
                 "\n");
-        $r->print('<tr class="LC_info_row">'.
-		  '<td class="LC_left_item">'.$lt{'reso'}.'</td>'.
-		  '<td>'.$lt{'part'}.'</td><td>'.$lt{'nust'}.'</td>'.
-		  '<td>'.$lt{'avat'}.'</td><td>'.$lt{'dedi'}.'</td>'.
-		  '<td>'.$lt{'lare'}.'</td><td  class="LC_right_item">'.
-                  $lt{'reco'}.'</td></tr>');
+            $r->print('<tr class="LC_info_row">'.
+		      '<td class="LC_left_item">'.$lt{'reso'}.'</td>'.
+		      '<td>'.$lt{'part'}.'</td><td>'.$lt{'nust'}.'</td>'.
+		      '<td>'.$lt{'avat'}.'</td><td>'.$lt{'dedi'}.'</td>'.
+		      '<td>'.$lt{'lare'}.'</td><td  class="LC_right_item">'.
+                      $lt{'reco'}.'</td></tr>');
+        }
 	my $row;
         foreach my $res (@{$warnings}) {
 	    $row++;
@@ -1713,7 +1759,9 @@ sub display_abovethreshold {
                 }
             }
         }
-        $r->print('<tr class="LC_info_row"><td colspan="7" class="LC_right_item"><br /><input type="submit" name="counters" value="'.$lt{'rese'}.'" /></td></tr></form>');
+        unless ($custommenu) {
+            $r->print('<tr class="LC_info_row"><td colspan="7" class="LC_right_item"><br /><input type="submit" name="counters" value="'.$lt{'rese'}.'" /></td></tr></form>');
+        }
     } elsif ($itemserror) {
         $r->print('<tr class="LC_empty_row"><td>'.$itemserror.'</td></tr>');
     } else {
@@ -1824,14 +1872,15 @@ sub display_crslogins {
         'number' => 'Total number of logins',
     );
     if ($logincount) {
-        $r->print('<tr class="LC_info_row" style="display:none" id="logintitledet">'.
+      
+        my $hdr = '<tr class="LC_info_row" style="display:none" id="logintitledet">'.
                   '<td class="LC_left_item">'.$lt{'user'}.'</td>'.
                   '<td class="LC_left_item">'.$lt{'role'}.'</td>'.
                   '<td class="LC_left_item">'.$lt{'sec'}.'</td></tr>'.
                   '<tr class="LC_info_row" id="logintitlesum">'.
                   '<td class="LC_left_item">'.$lt{'number'}.'</td>'.
                   '<td class="LC_left_item">'.$lt{'role'}.'</td>'.
-                  '<td class="LC_left_item">'.$lt{'sec'}.'</td></tr>');
+                  '<td class="LC_left_item">'.$lt{'sec'};
         my (%bylastname,%counts);
         if (ref($loggedin) eq 'HASH') {
             my @logins = sort { $b <=> $a } (keys(%{$loggedin}));
@@ -1863,12 +1912,13 @@ sub display_crslogins {
                     }
                 }
             }
+            my $table;
             foreach my $person (sort(keys(%bylastname))) {
                 if (ref($bylastname{$person}) eq 'ARRAY') { 
                     foreach my $item (@{$bylastname{$person}}) { 
                         $numlogin ++;
                         my $css_class = $numlogin%2?' class="LC_odd_row"':'';
-                        $r->print('<tr'.$css_class.' style="display:none;"  id="logindet_'.$numlogin.'">'.$item.'</td></tr>'); 
+                        $table .= '<tr'.$css_class.' style="display:none;"  id="logindet_'.$numlogin.'">'.$item.'</tr>'; 
                     }
                 }
             }
@@ -1879,16 +1929,16 @@ sub display_crslogins {
                     foreach my $sec (sort { $b <=> $a } (keys(%{$counts{$role}}))) {
                         $numrow ++;
                         my $css_class = $numrow%2?' class="LC_odd_row"':'';
-                        $r->print('<tr '.$css_class.' id="loginsum_'.$numrow.'">'.
+                        $table .= '<tr '.$css_class.' id="loginsum_'.$numrow.'">'.
                                   '<td>'.$counts{$role}{$sec}.'</td>'.
                                   '<td>'.$showrole.'</td>'.
-                                  '<td>'.$sec.'</td></tr>');
+                                  '<td>'.$sec.'</td></tr>';
                    }
                 }
             }
-            $r->print('<input type="hidden" name="logincount" value="'.$numlogin.
+            $r->print($hdr.'<input type="hidden" name="logincount" value="'.$numlogin.
                       '" /><input type="hidden" name="loginrow" value="'.$numrow.
-                      '" />');
+                      '" /></td></tr>'.$table);
         }
     } else {
         $r->print('<tr class="LC_empty_row"><td>'.
@@ -2157,7 +2207,7 @@ sub store_courseinit_setting {
 }
 
 sub start_box {
-    my ($r,$show,$heading,$caller,$refpage) = @_;
+    my ($r,$show,$heading,$caller,$refpage,$action,$custommenu) = @_;
     my %lt = &Apache::lonlocal::texthash( 
                        chth => 'Change thresholds?',
                        chin => 'Change interval?',
@@ -2182,7 +2232,7 @@ sub start_box {
            <th class="LC_right_item">'.$showhide.'</th>
           </tr>');
      if (($caller eq 'abovethreshold') && ($$show{$caller})) {
-         if ($$show{$caller}) {
+         if ($$show{$caller} && !$custommenu) {
              $r->print('
               <tr>
                 <td class="LC_subheader" colspan="2"><a href="/adm/whatsnew?command=chgthreshold&amp;refpage='.$refpage.'">'.$lt{'chth'}.'</a></td>