--- loncom/interface/portfolio.pm	2006/06/22 13:27:13	1.108
+++ loncom/interface/portfolio.pm	2006/06/22 19:01:30	1.116
@@ -31,7 +31,7 @@ use Apache::lonfeedback;
 use Apache::lonlocal;
 use Apache::lonnet;
 use Apache::longroup;
-use lib '/home/httpd/lib/perl';
+use HTML::Entities;
 use LONCAPA;
 
 # receives a file name and path stub from username/userfiles/portfolio/
@@ -40,9 +40,9 @@ sub make_anchor {
     my ($url, $filename, $current_path, $current_mode, $field_name,
         $continue_select,$group) = @_;
     if ($continue_select ne 'true') {$continue_select = 'false'};
-    my $anchor = '<a href="'.$url.'?selectfile='.$filename.'&currentpath='.$current_path.'&mode='.$current_mode.'&continue='.$continue_select.'&fieldname='.$field_name;
+    my $anchor = '<a href="'.$url.'?selectfile='.$filename.'&amp;currentpath='.$current_path.'&amp;mode='.$current_mode.'&amp;continue='.$continue_select.'&amp;fieldname='.$field_name;
     if (defined($group)) {
-        $anchor .= '&group='.$group;
+        $anchor .= '&amp;group='.$group;
     }
     $anchor .= '">'.$filename.'</a>';
     return $anchor;
@@ -63,38 +63,39 @@ sub display_common {
 					 'createdir' => 'Create Subdirectory',
 					 'createdir_label' => 
 					 'Create subdirectory in current directory:');
+    my $escuri = &HTML::Entities::encode($r->uri,'&<>"');
     $r->print(<<"TABLE"); 
-<table border="0" cellspacing="2" cellpadding="2">
-  <form method="post" enctype="multipart/form-data">
-    <tr valign="middle">
-      <td bgcolor="#ccddaa" align="right">
-        $text{'upload_label'}
-      </td>
-      <td bgcolor="#ccddaa" align="left">$groupitem
+<table id="LC_portfolio_actions">
+  <tr id="LC_portfolio_upload">
+    <td class="LC_label">
+      $text{'upload_label'}
+    </td>
+    <td class="LC_value">$groupitem
+      <form method="post" enctype="multipart/form-data" action="$escuri">
         <input name="uploaddoc" type="file" />
 	<input type="hidden" name="currentpath" value="$current_path" />
 	<input type="hidden" name="action" value="$env{"form.action"}" />
 	<input type="hidden" name="fieldname" value="$env{"form.fieldname"}" />
 	<input type="hidden" name="mode" value="$env{"form.mode"}" />
 	<input type="submit" name="storeupl" value="$text{'upload'}" />
-      </td>
-    </tr>
-  </form>
-  <form method="post">
-    <tr>
-      <td bgcolor="#ccddaa" align="right">
-        $text{'createdir_label'}
-      </td>
-      <td bgcolor="#ccddaa" align="left">
+      </form>
+    </td>
+  </tr>
+  <tr id="LC_portfolio_createdir">
+    <td class="LC_label">
+      $text{'createdir_label'}
+    </td>
+    <td class="LC_value">
+      <form method="post" action="$escuri">
         <input name="newdir" type="input" />$groupitem
         <input type="hidden" name="currentpath" value="$current_path" />
         <input type="hidden" name="action" value="$env{"form.action"}" />
         <input type="hidden" name="fieldname" value="$env{"form.fieldname"}" />
         <input type="hidden" name="mode" value="$env{"form.mode"}" />
         <input type="submit" name="createdir" value="$text{'createdir'}" />
-      </td>
-    </tr>
-  </form>
+      </form>
+    </td>
+  </tr>
 </table>
 TABLE
     my @tree = split (/\//,$current_path);
@@ -108,9 +109,9 @@ TABLE
     }
     $r->print('</font>');
     &Apache::lonhtmlcommon::store_recent($namespace,$current_path,$current_path);
-    $r->print('<br /><form method=post action="'.$url.'?mode='.$env{"form.mode"}.'&fieldname='.$env{"form.fieldname"});
+    $r->print('<br /><form method="post" action="'.$url.'?mode='.$env{"form.mode"}.'&amp;fieldname='.$env{"form.fieldname"});
     if (defined($group)) {
-        $r->print('&group='.$group);
+        $r->print('&amp;group='.$group);
     }
     $r->print('">'.
 	      &Apache::lonhtmlcommon::select_recent($namespace,'currentpath',
@@ -153,13 +154,13 @@ sub display_directory {
 	return;
     }
     if ($select_mode eq 'true') {
-        $r->print('<table border="0" cellspacing="2" cellpadding="2">'.
-            '<tr><th>Select</th><th>&nbsp;</th><th>Name</th><th>Size</th><th>Last Modified</th></tr>');
         $r->print('<form method="post" name="checkselect" action="'.$url.'">');
+        $r->print('<table class="LC_browser">'.
+            '<tr><th>Select</th><th>&nbsp;</th><th>Name</th><th>Size</th><th>Last Modified</th></tr>');
     } else {
-        $r->print('<table border="0" cellspacing="2" cellpadding="2">'.
-            '<tr><th colspan="2">Actions</th><th>&nbsp;</th><th>Name</th><th>Size</th><th>Last Modified</th><th>Current Access Status</th></tr>');
         $r->print('<form method="post" action="'.$url.'">');
+        $r->print('<table class="LC_browser">'.
+            '<tr><th colspan="2">Actions</th><th>&nbsp;</th><th>Name</th><th>Size</th><th>Last Modified</th><th>Current Access Status</th></tr>');
     }
     if (defined($group)) {
         $r->print("\n".$groupitem."\n");
@@ -189,16 +190,17 @@ sub display_directory {
         my ($fname,$version,$extension) = &Apache::grades::file_name_version_ext($filename);
     	if (($filename ne '.') && ($filename ne '..') && ($filename !~ /\.meta$/ ) && ($filename !~ /(.*)\.(\d+)\.([^\.]*)$/)) {
             if ($dirptr&$testdir) {
+		my $colspan='colspan="2"';
                 if ($select_mode eq 'true'){
-                    $r->print('<tr bgcolor="#FFAA99"><td><img src="'.$iconpath.'folder_closed.gif"></td>');
-                } else {
-                    $r->print('<tr bgcolor="#FFAA99"><td colspan="2"><img src="'.$iconpath.'folder_closed.gif"></td>');
+		    undef($colspan);
                 }
+		$r->print('<tr class="LC_browser_folder"><td '.$colspan.'><img alt="'.&mt('closed folder').'" src="'.$iconpath.'folder_closed.gif" /></td>');
                 $r->print('<td>Go to ...</td>');
                 $r->print('<td>'.&make_anchor($url,$filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'},$group).'</td>'); 
                 $r->print('</tr>'); 
             } else {
-                $r->print('<tr bgcolor="#CCCCFF">');
+		my $css_class = 'LC_browser_file';
+		my $line;
                 my $version_flag;
                 if (exists($versioned{$fname})) {
                    $version_flag = "*";
@@ -208,22 +210,25 @@ sub display_directory {
                my $fullpath = $current_path.$filename;
                 $fullpath = &prepend_group($fullpath,$group);
                 if ($select_mode eq 'true'){
-                    $r->print('<td><input type="checkbox" name="checkfile" value="'.$filename.'"');
-                    if ($$checked_files{$filename} eq 'selected') {
-                        $r->print("CHECKED");
+                    $line='<td><input type="checkbox" name="checkfile" value="'.$filename.'"';
+		    if ($$checked_files{$filename} eq 'selected') {
+                        $line.=" checked ";
                     }
-                    $r->print('></td>');
+		    $line.=' /></td>';
                 } else {
                     if (exists $locked_files{$fullpath}) {
-                        $r->print('<td colspan="2"><a href="'.$url.'?lockinfo='.$current_path.$filename.$groupecho.'">Locked</a></td>');
+                        $line.='<td colspan="2"><a href="'.$url.'?lockinfo='.$current_path.$filename.$groupecho.'">Locked</a></td>';
+			$css_class= 'LC_browser_file_locked';
                     } else {
 			my $cat='<img alt="'.&mt('Catalog Information').
 			    '" src="'.&Apache::loncommon::lonhttpdurl('/res/adm/pages/catalog.gif').'" />';
-                        $r->print('<td><input type="checkbox" name="selectfile" value="'.$filename.'" />
+                        $line.='<td><input type="checkbox" name="selectfile" value="'.$filename.'" />
                             <a href="'.$url.'?rename='.$filename.'&amp;currentpath='.$current_path.$groupecho.'">Rename</a></td>
                             <td><a href="'.$href_edit_location.$filename.'.meta">'.$cat.'</a>
-                            </td>');
+                            </td>';
                     }
+		    $r->print('<tr class="'.$css_class.'">');
+		    $r->print($line);
                 }
                 my $curr_access;
                 my $pub_access = 0;
@@ -256,15 +261,15 @@ sub display_directory {
                     }
                     $curr_access = join('+ ',@allaccesses);
                 }
-                $r->print('<td><img src="'.&Apache::loncommon::icon($filename).'"></td>');
+                $r->print('<td><img alt="" src="'.&Apache::loncommon::icon($filename).'" /></td>');
                 $r->print('<td><a href="'.$href_location.$filename.'">'.
 			    $filename.'</a></td>'); 
                 $r->print('<td>'.$size.'</td>');
                 $r->print('<td>'.&Apache::lonlocal::locallocaltime($mtime).'</td>');
-                $r->print('<td><nobr>'.&mt($curr_access).'&nbsp;&nbsp;&nbsp;'.
+                $r->print('<td><span style="white-space: nowrap">'.&mt($curr_access).'&nbsp;&nbsp;&nbsp;'.
                           '<a href="'.$url.'?access='.$filename.
                           '&amp;currentpath='.$current_path.$groupecho.
-                          '">'.&mt('View/Change').'</a></nobr></td>');
+                          '">'.&mt('View/Change').'</a></span></td>');
                 $r->print('</tr>'); 
             }
         }
@@ -316,7 +321,7 @@ sub close_form {
               $group.'" />');
     }
     $r->print('</p></form>');
-    $r->print('<form action="'.$url.'" method="POST">
+    $r->print('<form action="'.$url.'" method="post">
                <p>
               <input type="hidden" name="currentpath" value="'.
 	      $env{'form.currentpath'}.'" />');
@@ -331,16 +336,20 @@ sub close_form {
 sub display_file {
     my ($path,$filename)=@_;
     my $display_file_text;
+    my $file_start='<span class="LC_filename">';
+    my $file_end='</span>';
     if (!defined($path)) { $path=$env{'form.currentpath'}; }
     if (!defined($filename)) { 
         $filename=$env{'form.selectfile'};
-        $display_file_text = '<tt>'.$path.$filename.'</tt>';
+        $display_file_text = $file_start.$path.$filename.$file_end;
     } elsif (ref($filename) eq "ARRAY") {
-        foreach (@$filename) {
-            $display_file_text .= '<tt>'.$path.$_.'</tt><br />';
+        foreach my $file (@$filename) {
+            $display_file_text .= $file_start.$path.$file.$file_end.'<br />';
         }
     } elsif (ref($filename) eq "SCALAR") {
-        $display_file_text = '<tt>'.$path.$filename.'</tt>';        
+        $display_file_text = $file_start.$path.$$filename.$file_end;
+    } else {
+	$display_file_text = $file_start.$path.$filename.$file_end;
     }
     return $display_file_text;
 }
@@ -394,8 +403,8 @@ sub delete_confirmed {
 					       $env{'form.currentpath'}.
 					       $delete_file);
         if ($result ne 'ok') {
-	$r->print('<font color="red"> An error occured ('.$result.
-		  ') while trying to delete '.&display_file(undef, $delete_file).'</font><br />');
+	$r->print('<span class="LC_error"> An error occured ('.$result.
+		  ') while trying to delete '.&display_file(undef, $delete_file).'</span><br />');
         }
     }
     $r->print(&done(undef,$url,$group));
@@ -419,8 +428,8 @@ sub delete_dir_confirmed {
 					       $directory_name);
 					       
     if ($result ne 'ok') {
-	$r->print('<font color="red"> An error occured (dir) ('.$result.
-		  ') while trying to delete '.$directory_name.'</font><br />');
+	$r->print('<span class="LC_error"> An error occured (dir) ('.$result.
+		  ') while trying to delete '.$directory_name.'</span><br />');
     } else {
         # now remove from recent
 #        $r->print('<br /> removing '.$directory_name.'<br /');
@@ -459,9 +468,9 @@ sub rename_confirmed {
     my ($uname,$udom) = &get_name_dom($group);
     my $port_path = &get_port_path($group);
     if ($filenewname eq '') {
-	$r->print('<font color="red">'.
+	$r->print('<span class="LC_error">'.
 		  &mt("Error: no valid filename was provided to rename to.").
-		  '</font><br />');
+		  '</span><br />');
 	$r->print(&done(undef,$url,$group));
 	return;
     } 
@@ -470,12 +479,15 @@ sub rename_confirmed {
             $port_path.$env{'form.currentpath'}.$env{'form.selectfile'},
             $port_path.$env{'form.currentpath'}.$filenewname);
     if ($result ne 'ok') {
-	$r->print('<font color="red"> An errror occured ('.$result.
-		  ') while trying to rename '.&display_file().' to '.
-		  &display_file(undef,$filenewname).'</font><br />');
+	$r->print('<span class="LC_error">'.
+		  &mt('An errror occured ([_1]) while trying to rename [_2]'
+		      .' to [_3]',$result,&display_file(),
+		      &display_file('',$filenewname)).'</span><br />');
     }
     if ($filenewname ne $env{'form.filenewname'}) {
-        $r->print("The new file name was changed from:<br /><strong>".$env{'form.filenewname'}."</strong> to <strong>$filenewname </strong>");
+        $r->print(&mt("The new file name was changed from:<br />[_1] to [_2]",
+		      '<strong>'.&display_file('',$env{'form.filenewname'}).'</strong>',
+		      '<strong>'.&display_file('',$filenewname).'</strong>'));
     }
     $r->print(&done(undef,$url,$group));
 }
@@ -539,23 +551,26 @@ sub update_access {
     }
     my $current_permissions = &Apache::lonnet::get_portfile_permissions($udom,
                                                                        $uname);
-    my %access_controls = &Apache::lonnet::get_access_controls(
-                                       $current_permissions,$group,$file_name);
+    my %access_controls = 
+	&Apache::lonnet::get_access_controls($current_permissions,
+					     $group,$file_name);
     if ($totalprocessed) {
         if ($outcome eq 'ok') {
             my $updated_controls = $access_controls{$file_name};
             my ($showstart,$showend);
             $r->print(&Apache::loncommon::start_data_table());
-            $r->print(&Apache::loncommon::start_data_table_row());
+            $r->print(&Apache::loncommon::start_data_table_header_row());
             $r->print('<th>'.&mt('Type of change').'</th><th>'.
                       &mt('Access control').'</th><th>'.&mt('Dates available').
                       '</th><th>'.&mt('Additional information').'</th>');
-            $r->print(&Apache::loncommon::end_data_table_row());
+            $r->print(&Apache::loncommon::end_data_table_header_row());
             foreach my $chg (sort(keys(%processing))) {
                 if (@{$processing{$chg}} > 0) {
                     if ($chg eq 'delete') {
                         if (!($deloutcome eq 'ok')) {
-                            $errors .= &mt('A problem occurred deleting access controls: [_1]',$deloutcome);
+                            $errors .='<span class="LC_error">'.
+				&mt('A problem occurred deleting access controls: [_1]',$deloutcome).
+				'</span>';
                             next;
                         }
                     }
@@ -573,8 +588,7 @@ sub update_access {
                         if ($chg eq 'activate') {
                             $newkey =~ s/^(\d+)/$$translation{$1}/;
                         }
-                        my %content = &Apache::lonnet::parse_access_controls(
-                                                     $$updated_controls{$newkey});
+                        my $content = $$updated_controls{$newkey};
                         if ($chg eq 'delete') {
                             $showstart = &mt('Deleted');
                             $showend = $showstart;
@@ -589,7 +603,7 @@ sub update_access {
                         $r->print('<td>'.&mt($scope));
                         if (($scope eq 'course') || ($scope eq 'group')) {
                             if ($chg ne 'delete') {
-                                my $cid = $content{'domain'}.'_'.$content{'number'};
+                                my $cid = $content->{'domain'}.'_'.$content->{'number'};
                                 my %course_description = &Apache::lonnet::coursedescription($cid);
                                 $r->print('<br />('.$course_description{'description'}.')');
                             }
@@ -598,7 +612,7 @@ sub update_access {
                                   '<br />'.&mt('End: ').$showend.'</td><td>');
                         if ($chg ne 'delete') {
                             if ($scope eq 'guest') {
-                                $r->print(&mt('Password').': '.$content{'password'});
+                                $r->print(&mt('Password').': '.$content->{'password'});
                             } elsif ($scope eq 'course' || $scope eq 'group') {
                                 $r->print('<table border="0"><tr bgcol = "'.
                                           $tablecolor.'">');
@@ -611,7 +625,7 @@ sub update_access {
                                     $r->print('<th>'.&mt('Teams').'</th>');
                                 }
                                 $r->print('</tr>');
-                                foreach my $id (sort(keys(%{$content{'roles'}}))) {
+                                foreach my $id (sort(keys(%{$content->{'roles'}}))) {
                                     $r->print('<tr>');
                                     foreach my $item ('role','access','section','group') {
                                         $r->print('<td>');
@@ -619,7 +633,7 @@ sub update_access {
                                             my $ucscope = $scope;
                                             $ucscope =~ s/^(\w)/uc($1)/;
                                             my $role_output;  
-                                            foreach my $role (@{$content{'roles'}{$id}{$item}}) {
+                                            foreach my $role (@{$content->{'roles'}{$id}{$item}}) {
                                                 if ($role eq 'all') {
                                                     $role_output .= $role.',';
                                                 } elsif ($role =~ /^cr/) {
@@ -631,7 +645,7 @@ sub update_access {
                                             $role_output =~ s/,$//;
                                             $r->print($role_output);  
                                         } else {
-                                            $r->print(join(',',@{$content{'roles'}{$id}{$item}}));
+                                            $r->print(join(',',@{$content->{'roles'}{$id}{$item}}));
                                         }
                                         $r->print('</td>');
                                     }
@@ -639,9 +653,9 @@ sub update_access {
                                 $r->print(&Apache::loncommon::end_data_table_row());
                                 $r->print(&Apache::loncommon::end_data_table());
                             } elsif ($scope eq 'domains') {
-                                $r->print(&mt('Domains: ').join(',',@{$content{'dom'}}));
+                                $r->print(&mt('Domains: ').join(',',@{$content->{'dom'}}));
                             } elsif ($scope eq 'users') {
-                                my $curr_user_list = &sort_users($content{'users'});
+                                my $curr_user_list = &sort_users($content->{'users'});
                                 $r->print(&mt('Users: ').$curr_user_list);
                             } else {
                                 $r->print('&nbsp;');
@@ -658,7 +672,9 @@ sub update_access {
             $r->print(&Apache::loncommon::end_data_table());
         } else {
             if ((@{$processing{'activate'}} > 0) || (@{$processing{'update'}} > 0)) {
-                $errors .= &mt('A problem occurred storing access control settings: [_1]',$outcome);
+                $errors .= '<span class="LC_error">'.
+		    &mt('A problem occurred storing access control settings: [_1]',$outcome).
+		    '</span>';
             }
         }
         if ($errors) { 
@@ -693,7 +709,7 @@ sub update_access {
         &close_form($r,$url,$group);
     } else {
         $r->print('<br /><a href="'.$url.'?access='.$env{'form.selectfile'}.
-                  '&currentpath='.$env{'form.currentpath'}.'">'.
+                  '&amp;currentpath='.$env{'form.currentpath'}.'">'.
                    &mt('Display all access settings for this file').'</a>');
     }
     return;
@@ -701,95 +717,73 @@ sub update_access {
 
 sub build_access_record {
     my ($num,$scope,$start,$end,$chg) = @_;
-    my $record = '<scope type="'.$scope.'"><start>'.$start.'</start><end>'.
-                 $end.'</end>';
-    if ($scope eq 'guest') {
-        $record .= '<password>'.$env{'form.password'}.'</password>';
+    my $record = {
+	type => $scope,
+	time => {
+	    start => $start,
+	    end   => $end
+	    },
+	    };
+		
+    if ($scope eq 'guest') {	
+        $record->{'password'} = $env{'form.password'};
     } elsif (($scope eq 'course') || ($scope eq 'group')) {
-        $record .= '<domain>'.$env{'form.crsdom_'.$num}.'</domain><number>'.
-                   $env{'form.crsnum_'.$num}.'</number>';
+        $record->{'domain'} = $env{'form.crsdom_'.$num};
+	$record->{'number'} = $env{'form.crsnum_'.$num};
         my @role_ids;
-        my @delete_role_ids;
-        if (exists($env{'form.delete_role_'.$num})) {
-            @delete_role_ids = &Apache::loncommon::get_env_multiple('form.delete_role_'.$num);
-        }
-        if (exists($env{'form.preserve_role_'.$num})) {
-            my @preserves = &Apache::loncommon::get_env_multiple('form.preserve_role_'.$num);
-            if (@delete_role_ids > 0) {
-                foreach my $id (@preserves) {
-                    if (grep/^\Q$id\E$/,@delete_role_ids) {
-                        next;
-                    }
-                    push(@role_ids,$id); 
-                }
-            } else {
-                push(@role_ids,@preserves);
-            }
-        }
-        my $next_id = '';
-        if (exists($env{'form.add_role_'.$num})) {
-            $next_id = $env{'form.add_role_'.$num};
-            if ($next_id) {
-                push(@role_ids,$next_id);
-            }
-        }
+        my @delete_role_ids =
+            &Apache::loncommon::get_env_multiple('form.delete_role_'.$num);
+	my @preserves =
+	    &Apache::loncommon::get_env_multiple('form.preserve_role_'.$num);
+	if (@delete_role_ids) {
+	    foreach my $id (@preserves) {
+		if (grep {$_ = $id} (@delete_role_ids)) {
+		    next;
+		}
+		push(@role_ids,$id); 
+	    }
+	} else {
+	    push(@role_ids,@preserves);
+	}
+
+	my $next_id = $env{'form.add_role_'.$num};
+	if ($next_id) {
+	    push(@role_ids,$next_id);
+	}
+
         foreach my $id (@role_ids) {
             my (@roles,@accesses,@sections,@groups);
             if (($id == $next_id) && ($chg eq 'update')) {
-                @roles = split(/,/,$env{'form.role_'.$num.'_'.$next_id});
+                @roles    = split(/,/,$env{'form.role_'.$num.'_'.$next_id});
                 @accesses = split(/,/,$env{'form.access_'.$num.'_'.$next_id});
                 @sections = split(/,/,$env{'form.section_'.$num.'_'.$next_id});
-                @groups = split(/,/,$env{'form.group_'.$num.'_'.$next_id});
+                @groups   = split(/,/,$env{'form.group_'.$num.'_'.$next_id});
             } else {
                 @roles = &Apache::loncommon::get_env_multiple('form.role_'.$num.'_'.$id);
                 @accesses = &Apache::loncommon::get_env_multiple('form.access_'.$num.'_'.$id);
                 @sections = &Apache::loncommon::get_env_multiple('form.section_'.$num.'_'.$id);
                 @groups = &Apache::loncommon::get_env_multiple('form.group_'.$num.'_'.$id);
             }
-            $record .= '<roles id="'.$id.'">';
-            foreach my $role (@roles) {
-                $record .= '<role>'.$role.'</role>';
-            }
-            foreach my $access (@accesses) {
-                $record .= '<access>'.$access.'</access>';
-            }
-            foreach my $section (@sections) {
-                $record .= '<section>'.$section.'</section>';
-            }
-            foreach my $group (@groups) {
-                $record .= '<group>'.$group.'</group>';
-            }
-            $record .= '</roles>';
+	    $record->{'roles'}{$id}{'role'}    = \@roles;
+	    $record->{'roles'}{$id}{'access'}  = \@accesses;
+	    $record->{'roles'}{$id}{'section'} = \@sections;
+	    $record->{'roles'}{$id}{'group'}   = \@groups;
         }
     } elsif ($scope eq 'domains') {
         my @doms = &Apache::loncommon::get_env_multiple('form.dom_'.$num);
-        foreach my $dom (@doms) {
-            if ($dom ne '') {
-                $record .= '<dom>'.$dom.'</dom>'; 
-            }
-        }
+	$record->{'dom'} = \@doms;
     } elsif ($scope eq 'users') {
         my $userlist = $env{'form.users_'.$num};
-        $userlist =~ s/[\r\n\f]+//g;
-        $userlist =~ s/\s+//g;
-        my @users = split/,/,$userlist;
-        my %userhash;
-        my @unique_users;
-        foreach my $user (@users) {
-            if (!exists($userhash{$user})) {
-                $userhash{$user} = 1;
-                push(@unique_users,$user);
-            }
-        }
-        $record .= '<users>';
-        foreach my $user (@unique_users) {
+        $userlist =~ s/\s+//sg;
+	my %userhash = map { ($_,1) } (split(/,/,$userlist));
+        foreach my $user (keys(%userhash)) {
             my ($uname,$udom) = split(/:/,$user);
-            $record .= '<user><uname>'.$uname.'</uname><udom>'.$udom.
-                       '</udom></user>';
-        }
-        $record .= '</users>';
+	    push(@{$record->{'users'}}, {
+		'uname' => $uname,
+		'udom'  => $udom
+		});
+	}
     }
-    $record .= '</scope>';
     return $record;
 }
 
@@ -806,12 +800,11 @@ sub get_dates_from_form {
 }
 
 sub sort_users {
-    my ($users_hash) = @_; 
-    my @curr_users;
-    foreach my $user (keys(%{$users_hash})) {
-        $curr_users[$$users_hash{$user}] = $user;
-    }
-    my $curr_user_list = join(",\n",@curr_users);
+    my ($users) = @_; 
+    my @curr_users = map {
+	$_->{'uname'}.':'.$_->{'udom'}
+    } (@{$users});
+    my $curr_user_list = join(",\n",sort(@curr_users));
     return $curr_user_list;
 }
 
@@ -853,9 +846,9 @@ sub access_setting_table {
     $r->print('<table border="0"><tr><td valign="top">');
     $r->print('<h3>'.&mt('Public access:').' '.$publictext.'</h3>');
     $r->print(&Apache::loncommon::start_data_table());
-    $r->print(&Apache::loncommon::start_data_table_row());
+    $r->print(&Apache::loncommon::start_data_table_header_row());
     $r->print('<th>'.&mt('Action').'</th><th>'.&mt('Dates available').'</th>');
-    $r->print(&Apache::loncommon::end_data_table_row());
+    $r->print(&Apache::loncommon::end_data_table_header_row());
     $r->print(&Apache::loncommon::start_data_table_row());
     if ($public) {
         $r->print('<td>'.&actionbox('old',$publicnum,'public').'</td><td>'.
@@ -869,16 +862,14 @@ sub access_setting_table {
     $r->print('</td><td width="40">&nbsp;</td><td valign="top">');
     $r->print('<h3>'.&mt('Password-protected access:').' '.$guesttext.'</h3>');
     $r->print(&Apache::loncommon::start_data_table());
-    $r->print(&Apache::loncommon::start_data_table_row());
+    $r->print(&Apache::loncommon::start_data_table_header_row());
     $r->print('<th>'.&mt('Action').'</th><th>'.&mt('Dates available').
               '</th><th>'. &mt('Password').'</th>');
-    $r->print(&Apache::loncommon::end_data_table_row());
+    $r->print(&Apache::loncommon::end_data_table_header_row());
     $r->print(&Apache::loncommon::start_data_table_row());
     my $passwd;
     if ($guest) {
-        my %content = &Apache::lonnet::parse_access_controls(
-                                         $$access_controls{$guest});
-        $passwd = $content{'password'};
+        $passwd = $$access_controls{$guest}{'password'};
         $r->print('<td>'.&actionbox('old',$guestnum,'guest').'</td><td>'.
                   &dateboxes($guestnum,$start{$guest},$end{$guest}).'</td>');
     } else {
@@ -951,8 +942,8 @@ sub display_access_row {
         my $uctype = $type;
         $uctype =~ s/^(\w)/uc($1)/e;
         $r->print(&Apache::loncommon::start_data_table());
-        $r->print(&Apache::loncommon::start_data_table_row());
-        $r->print('<th>'.&mt('Action?').'</th><th>'.&mt($uctype).'</td><th>'.
+        $r->print(&Apache::loncommon::start_data_table_header_row());
+        $r->print('<th>'.&mt('Action?').'</th><th>'.&mt($uctype).'</th><th>'.
               &mt('Dates available').'</th>');
         if (($type eq 'course') || ($type eq 'group')) {
             $r->print('<th>'.&mt('Allowed [_1] member affiliations',$type).
@@ -963,7 +954,8 @@ sub display_access_row {
         } elsif ($type eq 'domains') {
             @all_doms = &Apache::loncommon::get_domains();
         }
-        $r->print(&Apache::loncommon::end_data_table_row());
+        $r->print(&Apache::loncommon::end_data_table_header_row());
+	$r->print(&Apache::loncommon::start_data_table_row());
         foreach my $key (@{$items}) {
             if (($type eq 'course') || ($type eq 'group')) {
                 &course_row($r,$status,$type,$key,$access_controls,
@@ -976,10 +968,11 @@ sub display_access_row {
             }
         }
         $r->print(&Apache::loncommon::end_data_table_row());
-        $r->print(&Apache::loncommon::start_data_table_row());
         if ($status eq 'old') {
+	    $r->print(&Apache::loncommon::start_data_table_row());
             $r->print('<td colspan="',$colspan.'">'.&additional_item($type).
                       '</td>');
+	    $r->print(&Apache::loncommon::end_data_table_row());
         }
         $r->print(&Apache::loncommon::end_data_table());
     } else {
@@ -989,17 +982,8 @@ sub display_access_row {
     return;
 }
 
-sub course_row {
-    my ($r,$status,$type,$item,$access_controls,$tablecolor,$now,$then) = @_;
-    my %content;
-    my $defdom = $env{'user.domain'};
-    if ($status eq 'old') {
-        %content = &Apache::lonnet::parse_access_controls(
-                                                     $$access_controls{$item});
-        $defdom = $content{'domain'}; 
-    }
-    $r->print(&Apache::loncommon::coursebrowser_javascript($defdom));
-    $r->print(qq|
+sub course_js {
+    return qq|
 <script type="text/javascript">
 function setRoleOptions(caller,num,cdom,cnum,type) {
     addIndexnum = getCallerIndex(caller);
@@ -1038,19 +1022,30 @@ function getIndex(name,value) {
 }
 
 </script>
-|);
-    $r->print(&Apache::loncommon::start_data_table_row());
+|;
+}
+
+sub course_row {
+    my ($r,$status,$type,$item,$access_controls,$tablecolor,$now,$then) = @_;
+    my $content;
+    my $defdom = $env{'user.domain'};
+    if ($status eq 'old') {
+        $content = $$access_controls{$item}; 
+        $defdom =  $content->{'domain'};
+    }
+    my $js = &Apache::loncommon::coursebrowser_javascript($defdom)
+	.&course_js();
     my $crsgrptext = 'Groups';
     if ($type eq 'group') {
         $crsgrptext = 'Teams';
     }
     my ($num,$scope,$end,$start) = &set_identifiers($status,$item,$now,$then,
                                                     $type);
-    $r->print('<td>'.&actionbox($status,$num,$scope).'</td>');
+    $r->print('<td>'.$js.&actionbox($status,$num,$scope).'</td>');
     if ($status eq 'old') {
-        my $cid = $content{'domain'}.'_'.$content{'number'};
+        my $cid = $content->{'domain'}.'_'.$content->{'number'};
         my %course_description = &Apache::lonnet::coursedescription($cid);
-        $r->print('<td><input type="hidden" name="crsdom_'.$num.'" value="'.$content{'domain'}.'" /><input type="hidden" name="crsnum_'.$num.'" value="'.$content{'number'}.'" />'.$course_description{'description'}.'</td>');
+        $r->print('<td><input type="hidden" name="crsdom_'.$num.'" value="'.$content->{'domain'}.'" /><input type="hidden" name="crsnum_'.$num.'" value="'.$content->{'number'}.'" />'.$course_description{'description'}.'</td>');
     } elsif ($status eq 'new') {
         my $uctype = $type;
         $uctype =~ s/^(\w)/uc($1)/e;
@@ -1063,39 +1058,35 @@ function getIndex(name,value) {
               &mt($crsgrptext).'</th></tr>');
     if ($status eq 'old') {
         my $max_id = 0;
-        foreach my $role_id (sort(keys(%{$content{'roles'}}))) {
+        foreach my $role_id (sort(keys(%{$content->{'roles'}}))) {
             if ($role_id > $max_id) {
                 $max_id = $role_id;
             }
             $max_id ++;
-            my $role_selects = &role_selectors($num,$role_id,$status,$type,\%content,'display');
-            $r->print('<tr><td><nobr><label><input type="checkbox" name="delete_role_'.$num.'" value="'.$role_id.'" />'.&mt('Delete').'</label></nobr><br /><input type="hidden" name="preserve_role_'.$num.'" value="'.$role_id.'" /></td>'.$role_selects.'</tr>');
+            my $role_selects = &role_selectors($num,$role_id,$status,$type,$content,'display');
+            $r->print('<tr><td><span style="white-space: nowrap"><label><input type="checkbox" name="delete_role_'.$num.'" value="'.$role_id.'" />'.&mt('Delete').'</label></span><br /><input type="hidden" name="preserve_role_'.$num.'" value="'.$role_id.'" /></td>'.$role_selects.'</tr>');
         }
-        $r->print('</table><br />'.&mt('Add a roles-based condition').'&nbsp;<input type="checkbox" name ="add_role_'.$num.'" onClick="javascript:setRoleOptions(this,'."'$num','$content{domain}','$content{number}','Course'".')" value="'.$max_id.'" /><input type="hidden" name="role_'.$num.'_'.$max_id.'" /><input type="hidden" name="access_'.$num.'_'.$max_id.'" /><input type="hidden" name="section_'.$num.'_'.$max_id.'" /><input type="hidden" name="group_'.$num.'_'.$max_id.'" /></td>');
+        $r->print('</table><br />'.&mt('Add a roles-based condition').'&nbsp;<input type="checkbox" name ="add_role_'.$num.'" onClick="javascript:setRoleOptions(this,'."'$num','$content->{'domain'}','$content->{'number'}','Course'".')" value="'.$max_id.'" /><input type="hidden" name="role_'.$num.'_'.$max_id.'" /><input type="hidden" name="access_'.$num.'_'.$max_id.'" /><input type="hidden" name="section_'.$num.'_'.$max_id.'" /><input type="hidden" name="group_'.$num.'_'.$max_id.'" /></td>');
     } elsif ($status eq 'new') {
         my $role_id = 1;
         my $role_selects = &role_selectors($num,$role_id,$status,$type,undef,'display');
         $r->print('<tr><td><input type="checkbox" name="add_role_'.$num.'" value="'.$role_id.'" checked="checked" />'.&mt('Add').'<input type="hidden" name="grplist_'.$num.'_'.$role_id.'" /></td>'.$role_selects);
         $r->print('</tr></table></td>');
     }
-    $r->print(&Apache::loncommon::end_data_table_row());
     return;
 }
 
 sub domains_row {
     my ($r,$status,$item,$all_doms,$access_controls,$now,$then) = @_;
-    $r->print(&Apache::loncommon::start_data_table_row());
     my ($num,$scope,$end,$start) = &set_identifiers($status,$item,$now,$then,
                                                     'domains');
-    my $dom_select = '<select name="dom_'.$num.'" size="4" multiple="true"/>'.
+    my $dom_select = '<select name="dom_'.$num.'" size="4" multiple="true">'.
                      ' <option value="">'.&mt('Please select').'</option>';
-    $r->print(&Apache::loncommon::start_data_table_row());
     if ($status eq 'old') {
-        my %content = &Apache::lonnet::parse_access_controls(
-                                                      $$access_controls{$item});
-        my @curr_doms = @{$content{'dom'}};
-        foreach my $dom (@{$all_doms}) {
-            if ((@{$content{'dom'}} > 0) && (grep(/^\Q$dom\E$/,@{$content{'dom'}}))) {
+        my $content =  $$access_controls{$item};
+	foreach my $dom (@{$all_doms}) {
+            if ((@{$content->{'dom'}} > 0) 
+		&& (grep(/^\Q$dom\E$/,@{$content->{'dom'}}))) {
                 $dom_select .= '<option value="'.$dom.'" selected>'.
                                $dom.'</option>';
             } else {
@@ -1107,25 +1098,21 @@ sub domains_row {
             $dom_select .= '<option value="'.$dom.'">'.$dom.'</option>';
         }
     }
+    $dom_select .= '</select>';
     $r->print('<td>'.&actionbox($status,$num,$scope).'</td><td>'.$dom_select.
               '</td><td>'.&dateboxes($num,$start,$end).'</td>');
-    $r->print(&Apache::loncommon::end_data_table_row());
-    $r->print(&Apache::loncommon::start_data_table_row());
 }
 
 sub users_row {
     my ($r,$status,$item,$access_controls,$now,$then) = @_;
-    $r->print(&Apache::loncommon::start_data_table_row());
     my ($num,$scope,$end,$start) = &set_identifiers($status,$item,$now,$then,
                                                     'users');
     my $curr_user_list;
     if ($status eq 'old') {
-        my %content = &Apache::lonnet::parse_access_controls(
-                                                     $$access_controls{$item});
-        $curr_user_list = &sort_users($content{'users'});
+        my $content = $$access_controls{$item};
+        $curr_user_list = &sort_users($content->{'users'});
     }
     $r->print('<td>'.&actionbox($status,$num,$scope).'</td><td>'.&mt("Format for users' username:domain information:").'<br /><tt>sparty:msu,illini:uiuc  ... etc.</tt><br /><textarea name="users_'.$num.'" cols="30"  rows="5">'.$curr_user_list.'</textarea></td><td>'.&dateboxes($num,$start,$end).'</td>');
-    $r->print(&Apache::loncommon::end_data_table_row());
 }
 
 sub additional_item {
@@ -1136,17 +1123,17 @@ sub additional_item {
 
 sub actionbox {
     my ($status,$num,$scope) = @_;
-    my $output = '<nobr><label>';
+    my $output = '<span style="white-space: nowrap"><label>';
     if ($status eq 'new') {
         $output .= '<input type="checkbox" name="activate" value="'.$num.'" />'.
         &mt('Activate');
     } else {
         $output .= '<input type="checkbox" name="delete" value="'.$num.
-                   '" />'.&mt('Delete').'</label><br /><nobr>'.
+                   '" />'.&mt('Delete').'</label></span><br /><span style="white-space: nowrap">'.
                    '<label><input type="checkbox" name="update" value="'.
                    $num.'" />'.&mt('Update');
     }
-    $output .= '</label></nobr><input type="hidden" name="scope_'.$num.                '" value="'.$scope.'" />';
+    $output .= '</label></span><input type="hidden" name="scope_'.$num.                '" value="'.$scope.'" />';
     return $output;
 }
                                                                                    
@@ -1161,10 +1148,10 @@ sub dateboxes {
                             undef,undef,1);
     my $enddate = &Apache::lonhtmlcommon::date_setter('portform',
                                'enddate_'.$num,$end,undef,undef,undef,1,undef,
-                                undef,undef,1). '&nbsp;&nbsp;<nobr><label>'.
+                                undef,undef,1). '&nbsp;&nbsp;<span style="white-space: nowrap"><label>'.
                                 '<input type="checkbox" name="noend_'.
                                 $num.'" '.$noend.' />'.&mt('No end date').
-                                '</label></nobr>';
+                                '</label></span>';
                                                                                    
     my $output = &mt('Start: ').$startdate.'<br />'.&mt('End: ').$enddate;
     return $output;
@@ -1307,7 +1294,7 @@ sub select_files {
         $java_files.=',';
     }
     my $javascript =(<<ENDSMP);
-        <script language='javascript'>
+        <script type="text/javascript">
         function finishSelect() {
 ENDSMP
     $javascript .= 'fileList = "'.$java_files.'";';
@@ -1367,17 +1354,17 @@ sub upload {
     }
     my $current_disk_usage = &Apache::lonnet::diskusage($udom,$uname,$portfolio_root);
     if (($current_disk_usage + $filesize) > $disk_quota){
-        $r->print('<font color="red">Unable to upload <strong>'.$fname.' (size = '.$filesize.' kilobytes)</strong>. Disk quota will be exceeded.'.
+        $r->print('<span class="LC_error">Unable to upload <strong>'.$fname.' (size = '.$filesize.' kilobytes)</strong>. Disk quota will be exceeded.</span>'.
                   '<br />Disk quota is '.$disk_quota.' kilobytes. Your current disk usage is '.$current_disk_usage.' kilobytes.');
         $r->print(&done('Back',$url,$group));
     } 
     elsif ($found_file){
         if ($locked_file){
-            $r->print('<font color="red">Unable to upload <strong>'.$fname.'</strong>, a <strong>locked</strong> file by that name was found in <strong>'.$port_path.$env{'form.currentpath'}.'</strong></font>'.
+            $r->print('<span class="LC_error">'.'Unable to upload <strong>'.$fname.'</strong>, a <strong>locked</strong> file by that name was found in <strong>'.$port_path.$env{'form.currentpath'}.'</strong></span>'.
                   '<br />You will be able to rename or delete existing '.$fname.' after a grade has been assigned.');
             $r->print(&done('Back',$url,$group));      
         } else {   
-            $r->print('<font color="red">Unable to upload <strong>'.$fname.'</strong>, a file by that name was found in <strong>'.$port_path.$env{'form.currentpath'}.'</strong></font>'.
+            $r->print('<span class="LC_error">'.'Unable to upload <strong>'.$fname.'</strong>, a file by that name was found in <strong>'.$port_path.$env{'form.currentpath'}.'</strong></span>'.
                   '<br />To upload, rename or delete existing '.$fname.' in '.$port_path.$env{'form.currentpath'});
             $r->print(&done('Back',$url,$group));
         }
@@ -1385,8 +1372,8 @@ sub upload {
         my $result=&Apache::lonnet::userfileupload('uploaddoc','',
 	        	 $port_path.$env{'form.currentpath'});
         if ($result !~ m|^/uploaded/|) {
-            $r->print('<font color="red"> An errror occured ('.$result.
-	              ') while trying to upload '.&display_file().'</font><br />');
+            $r->print('<span class="LC_error">'.'An errror occured ('.$result.
+	              ') while trying to upload '.&display_file().'</span><br />');
 	    $r->print(&done('Back',$url,$group));
         } else {
             $r->print(&done(undef,$url,$group));
@@ -1429,9 +1416,9 @@ sub createdir {
     my ($r,$url,$group)=@_;
     my $newdir=&Apache::lonnet::clean_filename($env{'form.newdir'});
     if ($newdir eq '') {
-    	$r->print('<font color="red">'.
+    	$r->print('<span class="LC_error">'.
 	    	  &mt("Error: no directory name was provided.").
-		      '</font><br />');
+		      '</span><br />');
 	    $r->print(&done(undef,$url,$group));
 	    return;
     }
@@ -1445,16 +1432,16 @@ sub createdir {
         }
     }
     if ($found_file){
-    	    $r->print('<font color="red"> Unable to create a directory named <strong>'.$newdir.
-    	            ' </strong>a file or directory by that name already exists.</font><br />');
+    	    $r->print('<span class="LC_error">'.'Unable to create a directory named <strong>'.$newdir.
+    	            ' </strong>a file or directory by that name already exists.</span><br />');
     } else {
         my ($uname,$udom) = &get_name_dom($group);
         my $port_path = &get_port_path($group);
         my $result=&Apache::lonnet::mkdiruserfile($uname,$udom,
 	         $port_path.$env{'form.currentpath'}.$newdir);
         if ($result ne 'ok') {
-    	    $r->print('<font color="red"> An errror occured ('.$result.
-	    	      ') while trying to create a new directory '.&display_file().'</font><br />');
+    	    $r->print('<span class="LC_error">'.'An errror occured ('.$result.
+	    	      ') while trying to create a new directory '.&display_file().'</span><br />');
         }
     }
     if ($newdir ne $env{'form.newdir'}) {
@@ -1558,7 +1545,7 @@ sub handler {
                                       $env{'request.course.id'}.'/'.$group))) {
                     $portfolio_root = &get_portfolio_root($group);
                 } else {
-                    $r->print('You do not have the privileges required to access the shared files space for this group');
+                    $r->print('You do not have the privileges required to access the shared files space for this group.');
                     $earlyout = 1;
                 }
             } else {
@@ -1592,9 +1579,11 @@ sub handler {
     }
     $r->rflush();
 	if (($env{'form.storeupl'}) & (!$env{'form.uploaddoc.filename'})){
-   	    $r->print('<font color="red"> No file was selected to upload.'.
-   	            'To upload a file, click <strong>Browse...</strong>'.
-   	            ', select a file, then click <strong>Upload</strong>,</font>');
+   	    $r->print('<span class="LC_error">'.
+		      'No file was selected to upload.'.
+		      'To upload a file, click <strong>Browse...</strong>'.
+		      ', select a file, then click <strong>Upload</strong>.'.
+		      '</span>');
 	}
     if ($env{'form.meta'}) {
         &open_form($r,$url);