--- loncom/interface/portfolio.pm	2013/04/12 17:21:09	1.241
+++ loncom/interface/portfolio.pm	2013/04/30 14:27:51	1.244
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # portfolio browser
 #
-# $Id: portfolio.pm,v 1.241 2013/04/12 17:21:09 bisitz Exp $
+# $Id: portfolio.pm,v 1.244 2013/04/30 14:27:51 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -640,7 +640,7 @@ sub display_file {
 
 sub done {
     my ($linktext,$url)=@_;
-    unless (defined $linktext) {
+    unless (defined($linktext)) {
         $linktext='Return to directory';
     }
     my %anchor_fields = (
@@ -1219,7 +1219,7 @@ sub update_access {
                 $totalnew = $lastitem;
                 my @numbers;   
                 for (my $i=$firstitem; $i<$lastitem; $i++) {
-                    push (@numbers,$i);
+                    push(@numbers,$i);
                 }
                 &display_access_row($r,$status,$newitem,\@numbers,
                                     $access_controls{$file_name},$now,$then);
@@ -2708,7 +2708,7 @@ sub handler {
    	$r->print(
             '<p><span class="LC_warning">'
            .&mt('No file was selected to upload.')
-           .'</span><<br />'
+           .'</span><br />'
            .&mt('To upload a file, click [_1]Browse...[_2] and select a file, then click [_1]Upload[_2].'
                 ,'<strong>','</strong>')
            .'</p>'
@@ -2750,8 +2750,8 @@ sub handler {
     } elsif ($env{'form.action'} eq 'modify_orightml') {
         if ($can_upload) {
             my $result = 
-                &Apache::loncommon::modify_html_refs('portfolio',$port_path,$uname,$udom,$group,
-                                                     $portfolio_root,$group);
+                &Apache::loncommon::modify_html_refs('portfolio',$port_path,$uname,
+                                                     $udom,$portfolio_root);
             $r->print($result.
                       &done('Return to directory',$url));
         } else {