--- loncom/interface/portfolio.pm 2006/07/19 15:58:33 1.121.2.7 +++ loncom/interface/portfolio.pm 2006/07/08 01:20:40 1.132 @@ -1,7 +1,7 @@ # The LearningOnline Network # portfolio browser # -# $Id: portfolio.pm,v 1.121.2.7 2006/07/19 15:58:33 albertel Exp $ +# $Id: portfolio.pm,v 1.132 2006/07/08 01:20:40 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -40,48 +40,29 @@ use Apache::lonhtmlcommon; use HTML::Entities; use LONCAPA; -sub group_args { - my $output; - if (defined($env{'form.group'})) { - $output .= '&group='.$env{'form.group'}; - if (defined($env{'form.ref'})) { - $output .= '&ref='.$env{'form.ref'}; - } - } - return $output; -} - -sub group_form_data { - my $output; - if (defined($env{'form.group'})) { - $output = ''; - if (exists($env{'form.ref'})) { - $output .= ''; - } - } -} - # receives a file name and path stub from username/userfiles/portfolio/ # returns an anchor tag consisting encoding filename and currentpath sub make_anchor { my ($url, $filename, $current_path, $current_mode, $field_name, - $continue_select) = @_; + $continue_select,$group) = @_; if ($continue_select ne 'true') {$continue_select = 'false'}; my $anchor = ''.$filename.''; return $anchor; } - my $dirptr=16384; sub display_common { - my ($r,$url,$current_path,$is_empty,$dir_list,$can_upload)=@_; - my $namespace = &get_namespace(); - my $port_path = &get_port_path(); + my ($r,$url,$current_path,$is_empty,$dir_list,$group,$can_upload)=@_; + my $namespace = &get_namespace($group); + my $port_path = &get_port_path($group); if ($can_upload) { - my $groupitem = &group_form_data(); - + my $groupitem; + if (defined($group)) { + $groupitem = ''; + } my $iconpath= $r->dir_config('lonIconsURL') . "/"; my %text=&Apache::lonlocal::texthash( 'upload' => 'Upload', @@ -128,36 +109,43 @@ sub display_common { TABLE } my @tree = split (/\//,$current_path); - $r->print(''.&make_anchor($url,$port_path,'/',$env{"form.mode"},$env{"form.fieldname"},$env{"form.continue"}).'/'); + $r->print(''.&make_anchor($url,$port_path,'/',$env{"form.mode"},$env{"form.fieldname"},$env{"form.continue"},$group).'/'); if (@tree > 1){ my $newCurrentPath = ''; for (my $i = 1; $i< @tree; $i++){ $newCurrentPath .= $tree[$i].'/'; - $r->print(&make_anchor($url,$tree[$i],'/'.$newCurrentPath, $env{"form.mode"},$env{"form.fieldname"}, $env{"form.continue"}).'/'); + $r->print(&make_anchor($url,$tree[$i],'/'.$newCurrentPath, $env{"form.mode"},$env{"form.fieldname"}, $env{"form.continue"},$group).'/'); } } $r->print(''); &Apache::lonhtmlcommon::store_recent($namespace,$current_path,$current_path); - $r->print('
'. &Apache::lonhtmlcommon::select_recent($namespace,'currentpath', 'this.form.submit();')); $r->print("
"); } - sub display_directory { my ($r,$url,$current_path,$is_empty,$dir_list,$group,$can_upload, $can_modify,$can_delete,$can_setacl)=@_; my $iconpath= $r->dir_config('lonIconsURL') . "/"; + my ($groupitem,$groupecho); my $display_out; my $select_mode; my $checked_files; - my $port_path = &get_port_path(); - my ($uname,$udom) = &get_name_dom(); + my $port_path = &get_port_path($group); + my ($uname,$udom) = &get_name_dom($group); my $access_admin_text = &mt('View Status'); if ($can_setacl) { $access_admin_text = &mt('View/Change Status'); } + if ((defined($group)) && (defined($env{'request.course.id'}))) { + $groupitem = ''; + $groupecho = '&group='.$group; + } my $current_permissions = &Apache::lonnet::get_portfile_permissions($udom, $uname); @@ -171,8 +159,7 @@ sub display_directory { $select_mode = 'true'; } if ($is_empty && ($current_path ne '/') && $can_delete) { - $display_out = '
'. - &group_form_data(). + $display_out = ''.$groupitem. ''. ''. ''. @@ -191,11 +178,13 @@ sub display_directory { $r->print(''. ''); } - $r->print("\n".&group_form_data()."\n"); - + if (defined($group)) { + $r->print("\n".$groupitem."\n"); + } my $href_location="/uploaded/$udom/$uname/$port_path".$current_path; my $href_edit_location="/editupload/$udom/$uname/$port_path".$current_path; my @dir_lines; + my @version_lines; my %versioned; foreach my $line (sort { @@ -209,14 +198,26 @@ sub display_directory { $filename =~ s/\s+$//; my ($fname,$version,$extension) = &Apache::grades::file_name_version_ext($filename); if ($version) { - $versioned{$fname} .= $version.","; + push(@version_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); + $versioned{$fname.'.'.$extension} .= $version.","; + } else { + push(@dir_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); } - push(@dir_lines, [$filename,$dom,$testdir,$size,$mtime,$obs]); } foreach my $line (@dir_lines) { my ($filename,$dom,$testdir,$size,$mtime,$obs) = @$line; my ($fname,$version,$extension) = &Apache::grades::file_name_version_ext($filename); if (($filename ne '.') && ($filename ne '..') && ($filename !~ /\.meta$/ ) && ($filename !~ /(.*)\.(\d+)\.([^\.]*)$/)) { + my %version_flag; + my $show_versions; + if ($env{'form.showversions'} eq $filename) { + $show_versions = 'true'; + } + if (exists($versioned{$filename})) { + $version_flag{$filename} = ''.&mt('closed folder').''; + } else { + $version_flag{$filename} = ''; + } if ($dirptr&$testdir) { my $colspan='colspan="2"'; if ($select_mode eq 'true'){ @@ -224,19 +225,13 @@ sub display_directory { } $r->print(''); $r->print(''); - $r->print(''); + $r->print(''); $r->print(''); } else { my $css_class = 'LC_browser_file'; my $line; - my $version_flag; - if (exists($versioned{$fname})) { - $version_flag = "*"; - } else { - $version_flag = ""; - } - my $fullpath = $current_path.$filename; - $fullpath = &prepend_group($fullpath); + my $fullpath = $current_path.$filename; + $fullpath = &prepend_group($fullpath,$group); if ($select_mode eq 'true') { $line=''; + $line.=''; $css_class= 'LC_browser_file_locked'; } else { if (!$can_modify) { @@ -259,8 +254,8 @@ sub display_directory { if ($can_modify) { my $cat=''.&mt('Catalog Information').
                             ''; - $line .= 'Rename'; - $line .= ''; } @@ -301,7 +296,7 @@ sub display_directory { } } $r->print(''); - $r->print(''); $r->print(''); $r->print(''); @@ -309,7 +304,7 @@ sub display_directory { $r->print(''); } $r->print(''.$/); @@ -354,7 +349,7 @@ sub open_form { } sub close_form { - my ($r,$url,$button_text)=@_; + my ($r,$url,$group,$button_text)=@_; if (!defined($button_text)) { $button_text = { 'continue' => &mt('Continue'), @@ -362,12 +357,19 @@ sub close_form { }; } $r->print('

'); - $r->print(&group_form_data().'

'); + if (defined($group)) { + $r->print("\n".''); + } + $r->print('

'); $r->print('

'. - &group_form_data()); + $env{'form.currentpath'}.'" />'); + if (defined($group)) { + $r->print("\n".''); + } $r->print("\n".'

'); } @@ -394,47 +396,49 @@ sub display_file { } sub done { - my ($message,$url)=@_; + my ($message,$url,$group)=@_; unless (defined $message) { $message='Done'; } my $result = '

'.&mt($message).'

'; return $result; } sub delete { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my @check; my $file_name = $env{'form.currentpath'}.$env{'form.selectfile'}; - $file_name = &prepend_group($file_name); + $file_name = &prepend_group($file_name,$group); my @files=&Apache::loncommon::get_env_multiple('form.selectfile'); - my ($uname,$udom) = &get_name_dom(); + my ($uname,$udom) = &get_name_dom($group); if (&Apache::lonnet::is_locked($file_name,$udom,$uname) eq 'true') { $r->print ("The file is locked and cannot be deleted.
"); - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); } else { if (scalar(@files)) { &open_form($r,$url); $r->print('

'.&mt('Delete').' '.&display_file(undef,\@files).'?

'); - &close_form($r,$url); + &close_form($r,$url,$group); } else { $r->print("No file was checked to delete.
"); - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } } } sub delete_confirmed { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my @files=&Apache::loncommon::get_env_multiple('form.selectfile'); my $result; - my ($uname,$udom) = &get_name_dom(); - my $port_path = &get_port_path(); + my ($uname,$udom) = &get_name_dom($group); + my $port_path = &get_port_path($group); foreach my $delete_file (@files) { $result=&Apache::lonnet::removeuserfile($uname,$udom,$port_path. $env{'form.currentpath'}. @@ -444,23 +448,23 @@ sub delete_confirmed { ') while trying to delete '.&display_file(undef, $delete_file).'
'); } } - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } sub delete_dir { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; &open_form($r,$url); $r->print('

'.&mt('Delete').' '.&display_file().'?

'); - &close_form($r,$url); + &close_form($r,$url,$group); } sub delete_dir_confirmed { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my $directory_name = $env{'form.currentpath'}; $directory_name =~ s|/$||; # remove any trailing slash - my ($uname,$udom) = &get_name_dom(); - my $namespace = &get_namespace(); - my $port_path = &get_port_path(); + my ($uname,$udom) = &get_name_dom($group); + my $namespace = &get_namespace($group); + my $port_path = &get_port_path($group); my $result=&Apache::lonnet::removeuserfile($uname,$udom,$port_path. $directory_name); @@ -480,35 +484,35 @@ sub delete_dir_confirmed { } $env{'form.currentpath'} = $directory_name; } - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } sub rename { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my $file_name = $env{'form.currentpath'}.$env{'form.rename'}; - my ($uname,$udom) = &get_name_dom(); - $file_name = &prepend_group($file_name); + my ($uname,$udom) = &get_name_dom($group); + $file_name = &prepend_group($file_name,$group); if (&Apache::lonnet::is_locked($file_name,$udom,$uname) eq 'true') { $r->print ("The file is locked and cannot be renamed.
"); - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } else { &open_form($r,$url); $r->print('

'.&mt('Rename').' '.&display_file().' to ?

'); - &close_form($r,$url); + &close_form($r,$url,$group); } } sub rename_confirmed { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my $filenewname=&Apache::lonnet::clean_filename($env{'form.filenewname'}); - my ($uname,$udom) = &get_name_dom(); - my $port_path = &get_port_path(); + my ($uname,$udom) = &get_name_dom($group); + my $port_path = &get_port_path($group); if ($filenewname eq '') { $r->print(''. &mt("Error: no valid filename was provided to rename to."). '
'); - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); return; } my $result= @@ -526,35 +530,20 @@ sub rename_confirmed { ''.&display_file('',$env{'form.filenewname'}).'', ''.&display_file('',$filenewname).'')); } - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } sub display_access { - my ($r,$url,$group,$can_setacl,$port_path) = @_; - my ($uname,$udom) = &get_name_dom(); + my ($r,$url,$group,$can_setacl) = @_; + my ($uname,$udom) = &get_name_dom($group); my $file_name = $env{'form.currentpath'}.$env{'form.access'}; - $file_name = &prepend_group($file_name); + $file_name = &prepend_group($file_name,$group); my $current_permissions = &Apache::lonnet::get_portfile_permissions($udom, $uname); my %access_controls = &Apache::lonnet::get_access_controls($current_permissions,$group,$file_name); my $aclcount = keys(%access_controls); - my $header = '

'.&mt('Allowing others to retrieve portfolio file: [_1]', - $port_path.$env{'form.currentpath'}. - $env{'form.access'}).'

'; - my $info .= - &mt('Access to this file by others can be set to be one or more of the following types: public, passphrase-protected or conditional.'). - '
'; + my $header = '

'.&mt('Allowing others to retrieve portfolio file: [_1]',$env{'form.currentpath'}.$env{'form.access'}).'

'; + my $info .= &mt('Access to this file by others can be set to be one or more of the following types: public, passphrase-protected or conditional.').'
'; if ($can_setacl) { &open_form($r,$url); $r->print($header.$info); @@ -563,18 +552,19 @@ sub display_access { 'continue' => &mt('Proceed'), 'cancel' => &mt('Back to directory listing'), }; - &close_form($r,$url,$button_text); + &close_form($r,$url,$group,$button_text); } else { $r->print($header); if ($aclcount) { $r->print($info); } - &view_access_settings($r,$url,$access_controls{$file_name},$aclcount); + &view_access_settings($r,$url,$group,$access_controls{$file_name}, + $aclcount); } } sub view_access_settings { - my ($r,$url,$access_controls,$aclcount) = @_; + my ($r,$url,$group,$access_controls,$aclcount) = @_; my ($showstart,$showend); my %todisplay; foreach my $key (sort(keys(%{$access_controls}))) { @@ -595,8 +585,12 @@ sub view_access_settings { } else { $r->print(&mt('No access control settings currently exist for this file.
' )); } + my $group_arg; + if ($group) { + $group_arg = '&group='.$group; + } $r->print('
'.&mt('Return to directory listing').''); + $group_arg.'">'.&mt('Return to directory listing').''); return; } @@ -704,7 +698,7 @@ sub build_access_summary { sub update_access { - my ($r,$url,$group,$port_path) = @_; + my ($r,$url,$group) = @_; my $totalprocessed = 0; my %processing; my %title = ( @@ -730,9 +724,9 @@ sub update_access { } my $file_name = $env{'form.currentpath'}.$env{'form.selectfile'}; $r->print('

'.&mt('Allowing others to retrieve portfolio file: [_1]', - $port_path.$file_name).'

'."\n"); - $file_name = &prepend_group($file_name); - my ($uname,$udom) = &get_name_dom(); + $file_name).''."\n"); + $file_name = &prepend_group($file_name,$group); + my ($uname,$udom) = &get_name_dom($group); my ($errors,$outcome,$deloutcome,$new_values,$translation); if ($totalprocessed) { ($outcome,$deloutcome,$new_values,$translation) = @@ -803,7 +797,7 @@ sub update_access { if ($allnew > 0) { my $now = time; my $then = $now + (60*60*24*180); # six months approx. - &open_form($r,$url); + &open_form($r,$url,$group); foreach my $newitem ('course','group','domains','users') { if ($env{'form.new'.$newitem} > 0) { $r->print('
'.&mt('Add new [_1]-based access control for portfolio file: [_2]',$newitem,$env{'form.currentpath'}.$env{'form.selectfile'}).'

'); @@ -818,14 +812,15 @@ sub update_access { $access_controls{$file_name},$now,$then); } } - &close_form($r,$url); + &close_form($r,$url,$group); } else { + my $group_arg; + if ($group) { + $group_arg = '&group='.$group; + } $r->print('
'. - &mt('Display all access settings for this file').''. - '     '. - ''.&mt('Return to directory listing').''); + '&currentpath='.$env{'form.currentpath'}.$group_arg.'">'. + &mt('Display all access settings for this file').''); } return; } @@ -995,25 +990,24 @@ sub access_setting_table { $passwd.'" />'); $r->print(&Apache::loncommon::end_data_table_row()); $r->print(&Apache::loncommon::end_data_table()); - - #$r->print(''); - #if (@courses > 0 || @groups > 0) { - # $r->print(''); - #if (@courses > 0 || @groups > 0) { - # $r->print(''); + if (@courses > 0 || @groups > 0) { + $r->print(''); + if (@courses > 0 || @groups > 0) { + $r->print('
Actions NameSizeLast ModifiedCurrent Access Status
'.&mt('closed folder').'Go to ...'.&make_anchor($url,$filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'}).''.$version_flag{$filename}.&make_anchor($url,$filename.'/',$current_path.$filename.'/',$env{'form.mode'},$env{"form.fieldname"},$env{'form.continue'},$group).'
LockedLocked'.$cat.''; + $line .= 'Rename'; + $line .= ''.$version_flag{$filename}.''.$cat.''; } $line .= ''. + $r->print(''.$version_flag{$filename}.''. $filename.''.$size.''.&Apache::lonlocal::locallocaltime($mtime).''. &mt($curr_access).'   '); $r->print(''.$access_admin_text.'
 
'); - #&access_element($r,'domains',\%acl_count,\@domains,$access_controls,$now,$then); - #$r->print(' '); - #&access_element($r,'users',\%acl_count,\@users,$access_controls,$now,$then); - #$r->print('
'); - #} else { - # $r->print(''); - #} - #&access_element($r,'course',\%acl_count,\@courses,$access_controls,$now,$then); - #$r->print('
 
'); - #} else { - # $r->print(' '); - #} - #&access_element($r,'group',\%acl_count,\@groups,$access_controls,$now,$then); + $r->print('
 
'); + &access_element($r,'domains',\%acl_count,\@domains,$access_controls,$now,$then); + $r->print(' '); + &access_element($r,'users',\%acl_count,\@users,$access_controls,$now,$then); + $r->print('
'); + } else { + $r->print(''); + } + &access_element($r,'course',\%acl_count,\@courses,$access_controls,$now,$then); + $r->print('
 
'); + } else { + $r->print(' '); + } + &access_element($r,'group',\%acl_count,\@groups,$access_controls,$now,$then); $r->print('
'); } @@ -1394,7 +1388,7 @@ END_SCRIPT } sub select_files { - my ($r) = @_; + my ($r,$group) = @_; if ($env{'form.continue'} eq 'true') { # here we update the selections for the currentpath # eventually, have to handle removing those not checked, but . . . @@ -1438,7 +1432,6 @@ ENDSMP } } } - sub upload { my ($r,$url,$group)=@_; my $fname=$env{'form.uploaddoc.filename'}; @@ -1454,20 +1447,19 @@ sub upload { } $fname=&Apache::lonnet::clean_filename($fname); - my $portfolio_root=&get_portfolio_root(); - my ($uname,$udom) = &get_name_dom(); - my $port_path = &get_port_path(); + my $portfolio_root=&get_portfolio_root($group); + my ($uname,$udom) = &get_name_dom($group); + my $port_path = &get_port_path($group); # Fixme --- Move the checking for existing file to LOND error return - my @dir_list=&get_dir_list($portfolio_root); + my @dir_list=&get_dir_list($portfolio_root,$group); my $found_file = 0; my $locked_file = 0; foreach my $line (@dir_list) { my ($file_name)=split(/\&/,$line,2); if ($file_name eq $fname){ $file_name = $env{'form.currentpath'}.$file_name; - $file_name = &prepend_group($file_name); + $file_name = &prepend_group($file_name,$group); $found_file = 1; - # FIXME I think this is incorrect, prepend_group took care of this? if (defined($group)) { $file_name = $group.'/'.$file_name; } @@ -1480,17 +1472,17 @@ sub upload { if (($current_disk_usage + $filesize) > $disk_quota){ $r->print('Unable to upload '.$fname.' (size = '.$filesize.' kilobytes). Disk quota will be exceeded.'. '
Disk quota is '.$disk_quota.' kilobytes. Your current disk usage is '.$current_disk_usage.' kilobytes.'); - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); } elsif ($found_file){ if ($locked_file){ $r->print(''.'Unable to upload '.$fname.', a locked file by that name was found in '.$port_path.$env{'form.currentpath'}.''. '
You will be able to rename or delete existing '.$fname.' after a grade has been assigned.'); - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); } else { $r->print(''.'Unable to upload '.$fname.', a file by that name was found in '.$port_path.$env{'form.currentpath'}.''. '
To upload, rename or delete existing '.$fname.' in '.$port_path.$env{'form.currentpath'}); - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); } } else { my $result=&Apache::lonnet::userfileupload('uploaddoc','', @@ -1498,20 +1490,20 @@ sub upload { if ($result !~ m|^/uploaded/|) { $r->print(''.'An errror occured ('.$result. ') while trying to upload '.&display_file().'
'); - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); } else { - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } } } sub lock_info { my ($r,$url,$group) = @_; - my ($uname,$udom) = &get_name_dom(); + my ($uname,$udom) = &get_name_dom($group); my $current_permissions = &Apache::lonnet::get_portfile_permissions($udom, $uname); my $file_name = $env{'form.lockinfo'}; - $file_name = &prepend_group($file_name); + $file_name = &prepend_group($file_name,$group); if (defined($file_name) && defined($$current_permissions{$file_name})) { foreach my $array_item (@{$$current_permissions{$file_name}}) { if (ref($array_item) eq 'ARRAY') { @@ -1534,22 +1526,21 @@ sub lock_info { } } } - $r->print(&done('Back',$url)); + $r->print(&done('Back',$url,$group)); return 'ok'; } - sub createdir { - my ($r,$url)=@_; + my ($r,$url,$group)=@_; my $newdir=&Apache::lonnet::clean_filename($env{'form.newdir'}); if ($newdir eq '') { $r->print(''. &mt("Error: no directory name was provided."). '
'); - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); return; } - my $portfolio_root = &get_portfolio_root(); - my @dir_list=&get_dir_list($portfolio_root); + my $portfolio_root = &get_portfolio_root($group); + my @dir_list=&get_dir_list($portfolio_root,$group); my $found_file = 0; foreach my $line (@dir_list) { my ($filename)=split(/\&/,$line,2); @@ -1561,8 +1552,8 @@ sub createdir { $r->print(''.'Unable to create a directory named '.$newdir. ' a file or directory by that name already exists.
'); } else { - my ($uname,$udom) = &get_name_dom(); - my $port_path = &get_port_path(); + my ($uname,$udom) = &get_name_dom($group); + my $port_path = &get_port_path($group); my $result=&Apache::lonnet::mkdiruserfile($uname,$udom, $port_path.$env{'form.currentpath'}.$newdir); if ($result ne 'ok') { @@ -1573,14 +1564,15 @@ sub createdir { if ($newdir ne $env{'form.newdir'}) { $r->print("The new directory name was changed from:
".$env{'form.newdir'}." to $newdir "); } - $r->print(&done(undef,$url)); + $r->print(&done(undef,$url,$group)); } sub get_portfolio_root { - my ($uname,$udom) = &get_name_dom(); - my $path; - if (defined($env{'form.group'})) { - $path = '/userfiles/groups/'.$env{'form.group'}.'/portfolio'; + my ($group) = @_; + my ($portfolio_root,$udom,$uname,$path); + ($uname,$udom) = &get_name_dom($group); + if (defined($group)) { + $path = '/userfiles/groups/'.$group.'/portfolio'; } else { $path = '/userfiles/portfolio'; } @@ -1605,15 +1597,16 @@ sub get_group_quota { } sub get_dir_list { - my ($portfolio_root) = @_; - my ($uname,$udom) = &get_name_dom(); + my ($portfolio_root,$group) = @_; + my ($uname,$udom) = &get_name_dom($group); return &Apache::lonnet::dirlist($env{'form.currentpath'}, $udom,$uname,$portfolio_root); } sub get_name_dom { + my ($group) = @_; my ($uname,$udom); - if (defined($env{'form.group'})) { + if (defined($group)) { $udom = $env{'course.'.$env{'request.course.id'}.'.domain'}; $uname = $env{'course.'.$env{'request.course.id'}.'.num'}; } else { @@ -1624,26 +1617,28 @@ sub get_name_dom { } sub prepend_group { - my ($filename) = @_; - if (defined($env{'form.group'})) { - $filename = $env{'form.group'}.$filename; + my ($filename,$group) = @_; + if (defined($group)) { + $filename = $group.$filename; } return $filename; } sub get_namespace { + my ($group) = @_; my $namespace = 'portfolio'; - if (defined($env{'form.group'})) { - my ($uname,$udom) = &get_name_dom(); - $namespace .= '_'.$udom.'_'.$uname.'_'.$env{'form.group'}; + if (defined($group)) { + my ($uname,$udom) = &get_name_dom($group); + $namespace .= '_'.$udom.'_'.$uname.'_'.$group; } return $namespace; } sub get_port_path { + my ($group) = @_; my $port_path; - if (defined($env{'form.group'})) { - $port_path = "groups/$env{'form.group'}/portfolio"; + if (defined($group)) { + $port_path = "groups/$group/portfolio"; } else { $port_path = 'portfolio'; } @@ -1651,7 +1646,7 @@ sub get_port_path { } sub missing_priv { - my ($r,$url,$priv) = @_; + my ($r,$url,$priv,$group) = @_; my $longtext = { upload => 'upload files', delete => 'delete files', @@ -1669,9 +1664,9 @@ sub missing_priv { $r->print(&mt('

Action disallowed

')); $r->print(&mt('You do not have sufficient privileges to [_1] ', $longtext->{$priv})); - if (defined($env{'form.group'})) { + if ($group) { $r->print(&mt("in the group's file repository.")); - $rtnlink .= &group_args() + $rtnlink .= '&group='.$group; } else { $r->print(&mt('in this portfolio.')); } @@ -1682,23 +1677,17 @@ sub missing_priv { } sub coursegrp_portfolio_header { - my ($cdom,$cnum,$grp_desc)=@_; + my ($cdom,$cnum,$group,$grp_desc)=@_; my $gpterm = &Apache::loncommon::group_term(); my $ucgpterm = $gpterm; $ucgpterm =~ s/^(\w)/uc($1)/e; - if ($env{'form.ref'}) { - &Apache::lonhtmlcommon::add_breadcrumb - ({href=>"/adm/coursegroups", - text=>"Groups", - title=>"Course Groups"}); - } &Apache::lonhtmlcommon::add_breadcrumb - ({href=>"/adm/$cdom/$cnum/$env{'form.group'}/smppg?ref=$env{'form.ref'}", + ({href=>"/adm/$cdom/$cnum/$group/smppg", text=>"$ucgpterm: $grp_desc", title=>"Go to group's home page"}, - {href=>"/adm/coursegrp_portfolio?".&group_args(), + {href=>"//?group=$group", text=>"Group Portfolio", - title=>"Display group portfolio"}); + title=>"Display group portfolio"},); my $output = &Apache::lonhtmlcommon::breadcrumbs( &mt('[_1] portfolio files - [_2]',$gpterm,$grp_desc)); return $output; @@ -1711,7 +1700,7 @@ sub handler { &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'}, ['selectfile','currentpath','meta','lockinfo','currentfile','action', 'fieldname','mode','rename','continue','group','access','setnum', - 'cnum','cdom','type','setroles']); + 'cnum','cdom','type','setroles','showversions']); my ($uname,$udom,$portfolio_root,$url,$group,$caller,$title,$grp_desc); if ($r->uri =~ m|^(/adm/)([^/]+)|) { $url = $1.$2; @@ -1727,12 +1716,12 @@ sub handler { return HTTP_NOT_ACCEPTABLE; } my $earlyout = 0; - my $view_permission = - &Apache::lonnet::allowed('vcg',$env{'request.course.id'}.($env{'request.course.sec'}?'/'.$env{'request.course.sec'}:'')); - $env{'form.group'} =~ s/\W//g; - $group = $env{'form.group'}; + my $view_permission = &Apache::lonnet::allowed('vcg', + $env{'request.course.id'}); + $group = $env{'form.group'}; + $group =~ s/\W//g; if ($group) { - ($uname,$udom) = &get_name_dom(); + ($uname,$udom) = &get_name_dom($group); my %curr_groups = &Apache::longroup::coursegroups($udom,$uname, $group); if (%curr_groups) { @@ -1741,7 +1730,7 @@ sub handler { $grp_desc = &unescape($grp_content{'description'}); if (($view_permission) || (&Apache::lonnet::allowed('rgf', $env{'request.course.id'}.'/'.$group))) { - $portfolio_root = &get_portfolio_root(); + $portfolio_root = &get_portfolio_root($group); } else { $r->print('You do not have the privileges required to access the shared files space for this group.'); $earlyout = 1; @@ -1785,7 +1774,6 @@ sub handler { $can_setacl = 1; } - my $port_path = &get_port_path(); &Apache::loncommon::no_cache($r); &Apache::loncommon::content_type($r,'text/html'); $r->send_http_header; @@ -1811,7 +1799,7 @@ sub handler { &open_form($r,$url); # $r->print(&edit_meta_data($r, $env{'form.currentpath'}.$env{'form.selectfile'})); $r->print('Edit the meta data
'); - &close_form($r,$url); + &close_form($r,$url,$group); } if ($env{'form.store'}) { } @@ -1820,67 +1808,67 @@ sub handler { if ($can_upload) { &upload($r,$url,$group); } else { - &missing_priv($r,$url,'upload'); + &missing_priv($r,$url,'upload',$group), } } elsif ($env{'form.action'} eq 'delete' && $env{'form.confirmed'}) { if ($can_delete) { - &delete_confirmed($r,$url); + &delete_confirmed($r,$url,$group); } else { - &missing_priv($r,$url,'delete'); + &missing_priv($r,$url,'delete',$group); } } elsif ($env{'form.action'} eq 'delete') { if ($can_delete) { - &delete($r,$url); + &delete($r,$url,$group); } else { - &missing_priv($r,$url,'delete'); + &missing_priv($r,$url,'delete',$group); } } elsif ($env{'form.action'} eq 'deletedir' && $env{'form.confirmed'}) { if ($can_delete) { - &delete_dir_confirmed($r,$url); + &delete_dir_confirmed($r,$url,$group); } else { - &missing_priv($r,$url,'delete'); + &missing_priv($r,$url,'delete',$group); } } elsif ($env{'form.action'} eq 'deletedir') { if ($can_delete) { - &delete_dir($r,$url); + &delete_dir($r,$url,$group); } else { - &missing_priv($r,$url,'delete'); + &missing_priv($r,$url,'delete',$group); } } elsif ($env{'form.action'} eq 'rename' && $env{'form.confirmed'}) { if ($can_modify) { - &rename_confirmed($r,$url); + &rename_confirmed($r,$url,$group); } else { - &missing_priv($r,$url,'rename'); + &missing_priv($r,$url,'rename',$group); } } elsif ($env{'form.rename'}) { $env{'form.selectfile'} = $env{'form.rename'}; $env{'form.action'} = 'rename'; if ($can_modify) { - &rename($r,$url); + &rename($r,$url,$group); } else { - &missing_priv($r,$url,'rename'); + &missing_priv($r,$url,'rename',$group); } } elsif ($env{'form.access'}) { $env{'form.selectfile'} = $env{'form.access'}; $env{'form.action'} = 'chgaccess'; - &display_access($r,$url,$group,$can_setacl,$port_path); + &display_access($r,$url,$group,$can_setacl); } elsif ($env{'form.action'} eq 'chgaccess') { if ($can_setacl) { - &update_access($r,$url,$group,$port_path); + &update_access($r,$url,$group); } else { - &missing_priv($r,$url,'setacl'); + &missing_priv($r,$url,'setacl',$group); } } elsif ($env{'form.action'} eq 'rolepicker') { if ($can_setacl) { &role_options_window($r); } else { - &missing_priv($r,$url,'setacl'); + &missing_priv($r,$url,'setacl',$group); } } elsif ($env{'form.createdir'}) { if ($can_upload) { - &createdir($r,$url); + &createdir($r,$url,$group); } else { - &missing_priv($r,$url,'upload'); + &missing_priv($r,$url,'upload',$group); } } elsif ($env{'form.lockinfo'}) { &lock_info($r,$url,$group); @@ -1891,16 +1879,16 @@ sub handler { } if ($caller eq 'coursegrp_portfolio') { &Apache::lonhtmlcommon::clear_breadcrumbs(); - $r->print(&coursegrp_portfolio_header($udom,$uname,$grp_desc)); + $r->print(&coursegrp_portfolio_header($udom,$uname,$group,$grp_desc)); } - my @dir_list=&get_dir_list($portfolio_root); + my @dir_list=&get_dir_list($portfolio_root,$group); if ($dir_list[0] eq 'no_such_dir'){ # two main reasons for this: # 1) never been here, so directory structure not created # 2) back-button navigation after deleting a directory if ($current_path eq '/'){ &Apache::lonnet::mkdiruserfile($uname,$udom, - &get_port_path()); + &get_port_path($group)); } else { # some directory that snuck in get rid of the directory # from the recent pulldown, just in case @@ -1914,8 +1902,8 @@ sub handler { } # need to know if directory is empty so it can be removed if desired my $is_empty=(@dir_list == 2); - &display_common($r,$url,$current_path,$is_empty,\@dir_list, - $can_upload); + &display_common($r,$url,$current_path,$is_empty,\@dir_list,$group, + $can_upload); &display_directory($r,$url,$current_path,$is_empty,\@dir_list,$group, $can_upload,$can_modify,$can_delete,$can_setacl); $r->print(&Apache::loncommon::end_page());