--- loncom/interface/slotrequest.pm	2005/11/02 22:46:12	1.28
+++ loncom/interface/slotrequest.pm	2005/11/21 19:50:36	1.34
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler for requesting to have slots added to a students record
 #
-# $Id: slotrequest.pm,v 1.28 2005/11/02 22:46:12 albertel Exp $
+# $Id: slotrequest.pm,v 1.34 2005/11/21 19:50:36 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -231,17 +231,55 @@ sub make_reservation {
     return undef;
 }
 
+sub remove_registration {
+    my ($r) = @_;
+    my $name = &Apache::loncommon::plainname($env{'form.uname'},
+					     $env{'form.udom'});
+
+    my $title = &Apache::lonnet::gettitle($env{'form.symb'});
+
+    my $hidden_input;
+    foreach my $parm ('uname','udom','slotname','entry','symb') {
+	$hidden_input .=
+	    '<input type="hidden" name="'.$parm.'" value="'
+	    .&HTML::Entities::encode($env{'form.'.$parm},'"<>&\'').'" />'."\n";
+    }
+    $r->print(<<"END_CONFIRM");
+<p> Remove $name from slot $env{'form.slotname'} for $title</p>
+<form action="/adm/slotrequest" method="POST">
+    <input type="hidden" name="command" value="release" />
+    $hidden_input
+    <input type="submit" name="Yes" value="yes" />
+</form>
+<form action="/adm/slotrequest" method="POST">
+    <input type="hidden" name="command" value="showslots" />
+    <input type="submit" name="No" value="no" />
+</form>
+END_CONFIRM
+
+}
+
 sub release_slot {
-    my ($r,$symb,$slot_name,$inhibit_return_link)=@_;
+    my ($r,$symb,$slot_name,$inhibit_return_link,$mgr)=@_;
 
     if ($slot_name eq '') { $slot_name=$env{'form.slotname'}; }
     my ($cnum,$cdom)=&get_course();
 
+    my ($uname,$udom) = ($env{'user.name'}, $env{'user.domain'});
+    if ($mgr eq 'F' 
+	&& defined($env{'form.uname'}) && defined($env{'form.udom'})) {
+	($uname,$udom) = ($env{'form.uname'}, $env{'form.udom'});
+    }
+
+    if ($mgr eq 'F' 
+	&& defined($env{'form.symb'})) {
+	$symb = $env{'form.symb'};
+    }
+
     # get parameter string, check for existance, rebuild string with the slot
-				       
     my @slots = split(/:/,&Apache::lonnet::EXT("resource.0.availablestudent",
-					       $symb,$env{'user.domain'},
-					       $env{'user.name'}));
+					       $symb,$udom,$uname));
+
     my @new_slots;
     foreach my $exist_slot (@slots) {
 	if ($exist_slot eq $slot_name) { next; }
@@ -253,21 +291,24 @@ sub release_slot {
     my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
 				       "^$slot_name\0");
     foreach my $entry (keys(%consumed)) {
-	if ( $consumed{$entry}->{'name'} eq 
-	     ($env{'user.name'}.'@'.$env{'user.domain'}) ) {
+	if ( $consumed{$entry}->{'name'} eq ($uname.'@'.$udom) ) {
 	    &Apache::lonnet::del('slot_reservations',[$entry],
 				 $cdom,$cnum);
 	}
     }
+
     # store new parameter string
     my $result=&Apache::lonparmset::storeparm_by_symb($symb,
 						      '0_availablestudent',
 						      1, $new_param, 'string',
-						      $env{'user.name'},
-						      $env{'user.domain'});
+						      $uname,$udom);
     my %slot=&Apache::lonnet::get_slot($slot_name);
     my $description=&get_description($env{'form.slotname'},\%slot);
     $r->print("<p>Released Reservation: $description</p>");
+    if ($mgr eq 'F') {
+	$r->print('<p><a href="/adm/slotrequest?command=showslots">'.
+		  &mt('Return to slot list').'</a></p>');
+    }
     if (!$inhibit_return_link) {
 	$r->print('<p><a href="/adm/flip?postdata=return:">'.
 		  &mt('Return to last resource').'</a></p>');
@@ -275,6 +316,38 @@ sub release_slot {
     return 1;
 }
 
+sub delete_slot {
+    my ($r)=@_;
+
+    my $slot_name = $env{'form.slotname'};
+    my %slot=&Apache::lonnet::get_slot($slot_name);
+
+    my ($cnum,$cdom)=&get_course();
+    my %consumed=&Apache::lonnet::dump('slot_reservations',$cdom,$cnum,
+				       "^$slot_name\0");
+
+    if (%slot && !%consumed) {
+	$slot{'type'} = 'deleted';
+	my $ret = &Apache::lonnet::cput('slots', {$slot_name => \%slot},
+					$cdom, $cnum);
+	if ($ret eq 'ok') {
+	    $r->print("<p>Slot <tt>$slot_name</tt> marked as deleted.</p>");
+	} else {
+	    $r->print("<p> An error ($ret) occurse when attempting to delete Slot <tt>$slot_name</tt>.</p>");
+	}
+    } else {
+	if (%consumed) {
+	    $r->print("<p>Slot <tt>$slot_name</tt> has active reservations.</p>");
+	} else {
+	    $r->print("<p>Slot <tt>$slot_name</tt> does not exist.</p>");
+	}
+    }
+    $r->print('<p><a href="/adm/slotrequest?command=showslots">'.
+	      &mt('Return to slot list').'</a></p>');
+    $r->print('<p><a href="/adm/flip?postdata=return:">'.
+	      &mt('Return to last resource').'</a></p>');
+}
+
 sub get_slot {
     my ($r,$symb)=@_;
 
@@ -450,6 +523,67 @@ STUFF
     $r->print('</table>');
 }
 
+sub to_show {
+    my ($when,$slot) = @_;
+    my $time=time;
+    my $week=60*60*24*7;
+    if ($when eq 'now') {
+	if ($time > $slot->{'starttime'} &&
+	    $time < $slot->{'endtime'}) {
+	    return 1;
+	}
+	return 0;
+    } elsif ($when eq 'nextweek') {
+	if ( ($time        < $slot->{'starttime'} &&
+	      ($time+$week) > $slot->{'starttime'})
+	     ||
+	     ($time        < $slot->{'endtime'} &&
+	      ($time+$week) > $slot->{'endtime'}) ) {
+	    return 1;
+	}
+	return 0;
+    } elsif ($when eq 'lastweek') {
+	if ( ($time        > $slot->{'starttime'} &&
+	      ($time-$week) < $slot->{'starttime'})
+	     ||
+	     ($time        > $slot->{'endtime'} &&
+	      ($time-$week) < $slot->{'endtime'}) ) {
+	    return 1;
+	}
+	return 0;
+    } elsif ($when eq 'willopen') {
+	if ($time < $slot->{'starttime'}) {
+	    return 1;
+	}
+	return 0;
+    } elsif ($when eq 'wereopen') {
+	if ($time > $slot->{'endtime'}) {
+	    return 1;
+	}
+	return 0;
+    }
+    
+    return 1;
+}
+
+sub remove_link {
+    my ($slotname,$entry,$uname,$udom,$symb) = @_;
+
+    $slotname  = &Apache::lonnet::escape($slotname);
+    $entry     = &Apache::lonnet::escape($entry);
+    $uname     = &Apache::lonnet::escape($uname);
+    $udom      = &Apache::lonnet::escape($udom);
+    $symb      = &Apache::lonnet::escape($symb);
+
+    my $remove= &mt('Remove');
+
+    return <<"END_LINK";
+ <a href="/adm/slotrequest?command=remove_registration&slotname=$slotname&entry=$entry&uname=$uname&udom=$udom&symb=$symb"
+   >($remove)</a>
+END_LINK
+
+}
+
 sub show_table {
     my ($r,$mgr)=@_;
 
@@ -460,6 +594,7 @@ sub show_table {
     } 
     my $available;
     if ($mgr eq 'F') {
+	$r->print('<div>');
 	$r->print('<form method="POST" action="/adm/slotrequest">
 <input type="hidden" name="command" value="uploadstart" />
 <input type="submit" name="start" value="'.&mt('Upload Slot List').'" />
@@ -467,25 +602,70 @@ sub show_table {
 	$r->print('<form method="POST" action="/adm/helper/newslot.helper">
 <input type="submit" name="newslot" value="'.&mt('Create a New Slot').'" />
 </form>');
+	$r->print('</div>');
     }
+    
+    my %Saveable_Parameters = ('show'  => 'array',
+			       'when'  => 'scalar',
+			       'order' => 'scalar');
+
+    &Apache::loncommon::store_course_settings('slotrequest',\%Saveable_Parameters);
+    &Apache::loncommon::restore_course_settings('slotrequest',\%Saveable_Parameters);
+
+    my %show_fields=&Apache::lonlocal::texthash(
+	     'name'         => 'Slot Name',
+	     'description'  => 'Description',
+	     'type'         => 'Type',
+	     'starttime'    => 'Start time',
+	     'endtime'      => 'End Time',
+             'startreserve' => 'Time students can start reserving',
+	     'secret'       => 'Secret Word',
+	     'maxspace'     => 'Maxium # of students',
+	     'ip'           => 'IP or DNS restrictions',
+	     'symb'         => 'Resource slot is restricted to.',
+	     'uniqueperiod' => 'Period of time slot is unique',
+	     'proctor'      => 'List of proctors');
+    my @show_order=('name','description','type','starttime','endtime',
+	       'startreserve','secret','maxspace','ip','symb',
+	       'uniqueperiod','proctor');
+    my @show = 
+	(exists($env{'form.show'})) ? &Apache::loncommon::get_env_multiple('form.show')
+	                            : keys(%show_fields);
+    my %show =  map { $_ => 1 } (@show);
+
+    my %when_fields=&Apache::lonlocal::texthash(
+	     'now' => 'Open now',
+	     'nextweek' => 'Open within the next week',
+	     'lastweek' => 'Were open last week',
+	     'willopen' => 'Will open later',
+	     'wereopen' => 'Were open');
+    my @when_order=('now','nextweek','lastweek','willopen','wereopen');
+    $when_fields{'select_form_order'} = \@when_order;
+    my $when = 	(exists($env{'form.when'})) ? $env{'form.when'}
+                                            : 'now';
+
+    $r->print('<form method="POST" action="/adm/slotrequest">
+<input type="hidden" name="command" value="showslots" />');
+    $r->print('<div>');
+    $r->print('<table class="inline"><tr><th>'.&mt('Show').'</th><th>'.&mt('Open').'</th></tr><tr><td>'.&Apache::loncommon::multiple_select_form('show',\@show,6,\%show_fields,\@show_order).
+	      '</td><td>'.&Apache::loncommon::select_form($when,'when',%when_fields).
+	      '</td></tr></table>');
+    $r->print('</div>');
+    $r->print('<p><input type="submit" name="start" value="'.&mt('Update Display').'" /></p>');
     my $linkstart='<a href="/adm/slotrequest?command=showslots&amp;order=';
-    $r->print('<table border="1">
+    $r->print('<table class="thinborder">
 <tr>
-  <th></th>
-  <th>'.$linkstart.'name"        >Slot name</a></th>
-  <th>'.$linkstart.'type"        >Type</a></th>
-  <th>'.$linkstart.'description" >Description</a></th>
-  <th>'.$linkstart.'starttime"   >Start Time</a></th>
-  <th>'.$linkstart.'endtime"     >End Time</a></th>
-  <th>'.$linkstart.'startreserve">Time Students Can Start Reserving</a></th>
-  <th>'.$linkstart.'secret"      >Secret</a></th>
-  <th>'.$linkstart.'maxspace"    >Max space</a></th>
-  <th>                            Scheduled Students</th>
-  <th>'.$linkstart.'unique"      >Unique Period</a></th>
-</tr>');
+  <th></th>');
+    foreach my $which (@show_order) {
+	if ($which ne 'proctor' && exists($show{$which})) {
+	    $r->print('<th>'.$linkstart.$which.'">'.$show_fields{$which}.'</a></th>');
+	}
+    }
+    $r->print('<th>Scheduled Students</th></tr>');
+
     my %name_cache;
     my $slotsort = sub {
-	if ($env{'form.order'}=~/^(type|description|endtime|maxspace)$/) {
+	if ($env{'form.order'}=~/^(type|description|endtime|startreserve|maxspace|ip|symb)$/) {
 	    if (lc($slots{$a}->{$env{'form.order'}})
 		ne lc($slots{$b}->{$env{'form.order'}})) {
 		return (lc($slots{$a}->{$env{'form.order'}}) 
@@ -495,7 +675,7 @@ sub show_table {
 	    if (lc($a) cmp lc($b)) {
 		return lc($a) cmp lc($b);
 	    }
-	} elsif ($env{'form.order'} eq 'unique') {
+	} elsif ($env{'form.order'} eq 'uniqueperiod') {
 	    
 	    if ($slots{$a}->{'uniqueperiod'}[0] 
 		ne $slots{$b}->{'uniqueperiod'}[0]) {
@@ -511,6 +691,7 @@ sub show_table {
 	return $slots{$a}->{'starttime'} <=> $slots{$b}->{'starttime'};
     };
     foreach my $slot (sort $slotsort (keys(%slots)))  {
+	if (!&to_show($when,$slots{$slot})) { next; }
 	if (defined($slots{$slot}->{'type'})
 	    && $slots{$slot}->{'type'} ne 'schedulable_student') {
 	    #next;
@@ -521,8 +702,13 @@ sub show_table {
 	my $ids;
 	foreach my $entry (sort(keys(%consumed))) {
 	    my (undef,$id)=split("\0",$entry);
-	    $ids.= $id.'-> '.$consumed{$entry}->{'name'}.'<br />';
+	    my ($uname,$udom) = split('@',$consumed{$entry}{'name'});
+	    my $name = &Apache::loncommon::plainname($uname,$udom);
+	    $ids.= '<nobr>'.$name.&remove_link($slot,$entry,$uname,$udom,
+					       $consumed{$entry}{'symb'})
+		.'</nobr><br />';
 	}
+
 	my $start=($slots{$slot}->{'starttime'}?
 		   &Apache::lonlocal::locallocaltime($slots{$slot}->{'starttime'}):'');
 	my $end=($slots{$slot}->{'endtime'}?
@@ -535,44 +721,86 @@ sub show_table {
 	    $unique=localtime($slots{$slot}{'uniqueperiod'}[0]).','.
 		localtime($slots{$slot}{'uniqueperiod'}[1]);
 	}
-	my @proctors = map {
-	    my ($uname,$udom)=split(/@/,$_);
-	    my $fullname=$name_cache{$_};
-	    if (!defined($fullname)) {
-		&Apache::lonnet::logthis("Gettign $uname $udom");
-		$fullname = &Apache::loncommon::plainname($uname,$udom);
-		$fullname =~s/\s/&nbsp;/g;
-		$name_cache{$_} = $fullname;
-	    }
-	    &Apache::loncommon::aboutmewrapper($fullname,$uname,$udom);
-	} (sort(split(/\s*,\s*/,$slots{$slot}->{'proctor'})));
-	
+
+	my $title;
+	if (exists($slots{$slot}{'symb'})) {
+	    my (undef,undef,$res)=
+		&Apache::lonnet::decode_symb($slots{$slot}{'symb'});
+	    $res =   &Apache::lonnet::clutter($res);
+	    $title = &Apache::lonnet::gettitle($slots{$slot}{'symb'});
+	    $title='<a href="'.$res.'?symb='.$slots{$slot}{'symb'}.'">'.$title.'</a>';
+	}
+
+	my @proctors;
+	my $rowspan=1;
+	my $colspan=1;
+	if (exists($show{'proctor'})) {
+	    $rowspan=2;
+	    @proctors= map {
+		my ($uname,$udom)=split(/@/,$_);
+		my $fullname=$name_cache{$_};
+		if (!defined($fullname)) {
+		    &Apache::lonnet::logthis("Gettign $uname $udom");
+		    $fullname = &Apache::loncommon::plainname($uname,$udom);
+		    $fullname =~s/\s/&nbsp;/g;
+		    $name_cache{$_} = $fullname;
+		}
+		&Apache::loncommon::aboutmewrapper($fullname,$uname,$udom);
+	    } (sort(split(/\s*,\s*/,$slots{$slot}->{'proctor'})));
+	}
 	my $proctors=join(', ',@proctors);
 
-	my $edit=(<<EDITFORM);
-<form method="POST" action="/adm/helper/newslot.helper">
-  <input type="hidden" name="name" value="$slot" />
-  <input type="submit" name="Edit" value="Edit" />
-</form>
-EDITFORM
-	$r->print(<<STUFF);
-<tr>
- <td rowspan="2">$edit</td>
- <td>$slot</td>
- <td>$slots{$slot}->{'type'}</td>
- <td>$description</td>
- <td>$start</td>
- <td>$end</td>
- <td>$start_reserve</td>
- <td>$slots{$slot}->{'secret'}</td>
- <td>$slots{$slot}->{'maxspace'}</td>
- <td>$ids</td>
- <td>$unique</td>
-</tr>
+	my $edit=(<<"EDITLINK");
+<a href="/adm/helper/newslot.helper?name=$slot">Edit</a>
+EDITLINK
+
+	my $delete=(<<"DELETELINK");
+<a href="/adm/slotrequest?command=delete&slotname=$slot">Delete</a>
+DELETELINK
+        if ($ids ne '') { undef($delete); }
+
+        $r->print("<tr>\n<td rowspan=\"$rowspan\">$edit $delete</td>\n");
+	if (exists($show{'name'})) {
+	    $colspan++;$r->print("<td>$slot</td>");
+	}
+	if (exists($show{'description'})) {
+	    $colspan++;$r->print("<td>$description</td>\n");
+	}
+	if (exists($show{'type'})) {
+	    $colspan++;$r->print("<td>$slots{$slot}->{'type'}</td>\n");
+	}
+	if (exists($show{'starttime'})) {
+	    $colspan++;$r->print("<td>$start</td>\n");
+	}
+	if (exists($show{'endtime'})) {
+	    $colspan++;$r->print("<td>$end</td>\n");
+	}
+	if (exists($show{'startreserve'})) {
+	    $colspan++;$r->print("<td>$start_reserve</td>\n");
+	}
+	if (exists($show{'secret'})) {
+	    $colspan++;$r->print("<td>$slots{$slot}{'secret'}</td>\n");
+	}
+	if (exists($show{'maxspace'})) {
+	    $colspan++;$r->print("<td>$slots{$slot}{'maxspace'}</td>\n");
+	}
+	if (exists($show{'ip'})) {
+	    $colspan++;$r->print("<td>$slots{$slot}{'ip'}</td>\n");
+	}
+	if (exists($show{'symb'})) {
+	    $colspan++;$r->print("<td>$title</td>\n");
+	}
+	if (exists($show{'uniqueperiod'})) {
+	    $colspan++;$r->print("<td>$unique</td>\n");
+	}
+	$colspan++;$r->print("<td>$ids</td>\n</tr>\n");
+	if (exists($show{'proctor'})) {
+	    $r->print(<<STUFF);
 <tr>
- <td colspan="10">$proctors</td>
+ <td colspan="$colspan">$proctors</td>
 </tr>
 STUFF
+        }
     }
     $r->print('</table>');
 }
@@ -759,16 +987,34 @@ sub csv_upload_assign {
     my $cname=$env{'course.'.$env{'request.course.id'}.'.num'};
     my $cdom=$env{'course.'.$env{'request.course.id'}.'.domain'};
     my $countdone=0;
+    my @errors;
     foreach my $slot (@slotdata) {
 	my %slot;
 	my %entries=&Apache::loncommon::record_sep($slot);
 	my $domain;
 	my $name=$entries{$fields{'name'}};
+	if ($name=~/^\s*$/) {
+	    push(@errors,"Did not create slot with no name");
+	    next;
+	}
+	if ($name=~/\s/) { 
+	    push(@errors,"$name not created -- Name must not contain spaces");
+	    next;
+	}
+	if ($name=~/\W/) { 
+	    push(@errors,"$name not created -- Name must contain only letters, numbers and _");
+	    next;
+	}
 	if ($entries{$fields{'type'}}) {
 	    $slot{'type'}=$entries{$fields{'type'}};
 	} else {
 	    $slot{'type'}='preassigned';
 	}
+	if ($slot{'type'} ne 'preassigned' &&
+	    $slot{'type'} ne 'schedulable_student') {
+	    push(@errors,"$name not created -- invalid type ($slot{'type'}) must be either preassigned or schedulable_student");
+	    next;
+	}
 	if ($entries{$fields{'starttime'}}) {
 	    $slot{'starttime'}=&UnixDate($entries{$fields{'starttime'}},"%s");
 	}
@@ -797,8 +1043,10 @@ sub csv_upload_assign {
 	$r->rflush();
 	$countdone++;
     }
-    $r->print("<br />Created $countdone slots\n");
-    $r->print("<br />\n");
+    $r->print("<p>Created $countdone slots\n</p>");
+    foreach my $error (@errors) {
+	$r->print("<p>$error\n</p>");
+    }
     &show_table($r,$mgr);
     return '';
 }
@@ -806,6 +1054,13 @@ sub csv_upload_assign {
 sub handler {
     my $r=shift;
 
+    &Apache::loncommon::content_type($r,'text/html');
+    &Apache::loncommon::no_cache($r);
+    if ($r->header_only()) {
+	$r->send_http_header();
+	return OK;
+    }
+
     &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'});
     
     my $vgr=&Apache::lonnet::allowed('vgr',$env{'request.course.id'});
@@ -818,6 +1073,12 @@ sub handler {
 
     if ($env{'form.command'} eq 'showslots' && $vgr eq 'F') {
 	&show_table($r,$mgr);
+    } elsif ($env{'form.command'} eq 'remove_registration' && $mgr eq 'F') {
+	&remove_registration($r);
+    } elsif ($env{'form.command'} eq 'release' && $mgr eq 'F') {
+	&release_slot($r,undef,undef,undef,$mgr);
+    } elsif ($env{'form.command'} eq 'delete' && $mgr eq 'F') {
+	&delete_slot($r);
     } elsif ($env{'form.command'} eq 'uploadstart' && $mgr eq 'F') {
 	&upload_start($r);
     } elsif ($env{'form.command'} eq 'csvuploadmap' && $mgr eq 'F') {