CVS log for loncom/interface/statistics/lonpercentage.pm

Up to [LON-CAPA] / loncom / interface / statistics

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Improved and consistent layout:
    - Error style for error messages
    - data_table (implies simplified code), table header
- Internationalization: Added missing &mt() calls
- XHTML: action attribute required in <form>

XHTML conform <br />

Added missing ";" to all " "

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

lonstatistics.pm:
   POD cleanups
   @SelectedSections is set when we read the classlist.
   Added variables $top_map, @Sequences, and @Assessments.  These are
      initialized by &PrepareCourseData($r).
   Added &PrepareCourseData($r) which is essentially a wrapper for
      &Apache::loncoursedata::get_sequence_assessment_data().
   Added &MapSelect() to output a <select> box for sequences.  Not tested.
   Added &SectionSelect(..) to output a <select> box for sections.  Tested.
   Added &DisplayClasslist($r) which displays a table of the current classlist
      that is sortable by each column.  Does not bother with 'update time' as
      this should not be an issue for the user.  Tested.
   Added call to &PrepareCourseData by the handler.
lonpercentage.pm, lonproblemanalysis.pm, lonproblemstatistics.pm,
lonstudentassessment.pm: modified to call &Apache::lonstatistics::SectionSelect
   instead of the method in lonhtmlcommon.pm.

To fix the reopened bug #1152 a minor change has been done.
If a student has 125 correct out of 125 possible, that is 100%,
he was not included on the plot but NOW it is included.

To fix bug #1152 this is changed in lonpercentage.pm
When cousre has more than or equal 100 then the range will be 100.
otherwise it would be the range of x's would be the number of broblems.

I had these Suggestions to fix bug #1052:

1)a) If the number of problems involved is less than 100
    it would be better to change the plotting to
    display "number of problems correct" on the x-axis
    and the range would be from 0 to 99
  b) If the number of problems is > or = 100
    Plot the % leave as it is currently.

So I chnged the lonpercentage module:

        if ( $totalProblems >= 100 ) {
            $percent = sprintf("%d", ($totalProblems) ?
                              (($totalCorrect/$totalProblems)*100) : 0);
        } else {
            $percent = sprintf("%d", ($totalProblems) ? $totalCorrect : 0);
        }

...

    my $xlabel = ($totalProblems >= 100 ) ?
                  'Percentage_of_Problems_Correct' :
                  'Number_of_Problems_Correct';

I hope will work well.
Let me know any feedback

Fixed bug #1052.
The graph of percentage of correct problems shows zeroz, so the distribution of corrected problems are shown better.
If get more feedback I will complete it.

Fixed bug #1020.
lonperntage.pm fixed to show the percentages of correct answers of students correctly.
A field (frequency) added to percentage table.
I don't know why data are not cached and every time are computed.
Maybe it will be repoted in bugzilla so it would be considered to fix.

- using png now

First, was getting a strange warning for doing scalar(split(...)) in
lonpercentage.  Second I think I fixed the updating of symbols in
chart after they have been changed.  I tried it out and it work for
my test case.  We will see if it works for everyone.  The problem
is as I suspected, and because I didn't remove the keys when the
students data was updated it was still using old data.  This
would occur if the data didn't overwrite, but changed supporting
information.

Fixed an error for map selection in problem statistics.  Added a new
module that will display a graph of percentage correctness for
a problem or series of problems based on input.  It doesn't quite
look correct yet, because of graph.gif.  I will have to edit graph.gif
in order to get ranges for the x axis etc.  This was also an
experiment to see multiple dependent selections.  Will probably do
that with student assessment next, but with students.