[BACK]Return to lond CVS log [TXT] [DIR] Up to [LON-CAPA] / loncom

Diff for /loncom/lond between versions 1.522 and 1.528

version 1.522, 2016/05/30 03:16:38 version 1.528, 2016/09/21 05:39:53
Line 15 Line 15
 #  #
 # LON-CAPA is distributed in the hope that it will be useful,  # LON-CAPA is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of  # but WITHOUT ANY WARRANTY; without even the implied warranty of
   
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the  # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.  # GNU General Public License for more details.
 #  #
Line 41  use IO::File; Line 40  use IO::File;
 #use Apache::File;  #use Apache::File;
 use POSIX;  use POSIX;
 use Crypt::IDEA;  use Crypt::IDEA;
 use LWP::UserAgent();  use HTTP::Request;
 use Digest::MD5 qw(md5_hex);  use Digest::MD5 qw(md5_hex);
 use GDBM_File;  use GDBM_File;
 use Authen::Krb5;  use Authen::Krb5;
Line 58  use Mail::Send; Line 57  use Mail::Send;
 use Crypt::Eksblowfish::Bcrypt;  use Crypt::Eksblowfish::Bcrypt;
 use Digest::SHA;  use Digest::SHA;
 use Encode;  use Encode;
   use LONCAPA::LWPReq;
   
 my $DEBUG = 0;       # Non zero to enable debug log entries.  my $DEBUG = 0;       # Non zero to enable debug log entries.
   
Line 74  my $clientip;   # IP address of client. Line 74  my $clientip;   # IP address of client.
 my $clientname; # LonCAPA name of client.  my $clientname; # LonCAPA name of client.
 my $clientversion;              # LonCAPA version running on client.  my $clientversion;              # LonCAPA version running on client.
 my $clienthomedom;              # LonCAPA domain of homeID for client.   my $clienthomedom;              # LonCAPA domain of homeID for client. 
                                 # primary library server.   my $clientintdom;               # LonCAPA "internet domain" for client.
   my $clientsameinst;             # LonCAPA "internet domain" same for 
                                   # this host and client.
   my $clientremoteok;             # Client allowed to host domain's users.
                                   # (version constraints ignored), not set
                                   # if this host and client share "internet domain". 
   my %clientprohibited;           # Actions prohibited on client;
    
 my $server;  my $server;
   
 my $keymode;  my $keymode;
Line 145  my @installerrors = ("ok", Line 151  my @installerrors = ("ok",
      );       );
   
 #  #
   # The %trust hash classifies commands according to type of trust 
   # required for execution of the command.
   #
   # When clients from a different institution request execution of a
   # particular command, the trust settings for that institution set
   # for this domain (or default domain for a multi-domain server) will
   # be checked to see if running the command is allowed.
   #
   # Trust types which depend on the "Trust" domain configuration
   # for the machine's default domain are:
   #
   # content   ("Access to this domain's content by others")
   # shared    ("Access to other domain's content by this domain")
   # enroll    ("Enrollment in this domain's courses by others")
   # coaurem   ("Co-author roles for this domain's users elsewhere")
   # domroles  ("Domain roles in this domain assignable to others")
   # catalog   ("Course Catalog for this domain displayed elsewhere")
   # reqcrs    ("Requests for creation of courses in this domain by others")
   # msg       ("Users in other domains can send messages to this domain")
   # 
   # Trust type which depends on the User Session Hosting (remote) 
   # domain configuration for machine's default domain is: "remote".
   #
   # Trust types which depend on contents of manager.tab in 
   # /home/httpd/lonTabs is: "manageronly".
   # 
   # Trust type which requires client to share the same LON-CAPA
   # "internet domain" (i.e., same institution as this server) is:
   # "institutiononly".
   #
   
   my %trust = (
                  auth => {remote => 1},
                  autocreatepassword => {remote => 1},
                  autocrsreqchecks => {remote => 1, reqcrs => 1},
                  autocrsrequpdate => {remote => 1},
                  autocrsreqvalidation => {remote => 1},
                  autogetsections => {remote => 1},
                  autoinstcodedefaults => {remote => 1, catalog => 1},
                  autoinstcodeformat => {remote => 1, catalog => 1},
                  autonewcourse => {remote => 1, reqcrs => 1},
                  autophotocheck => {remote => 1, enroll => 1},
                  autophotochoice => {remote => 1},
                  autophotopermission => {remote => 1, enroll => 1},
                  autopossibleinstcodes => {remote => 1, reqcrs => 1},
                  autoretrieve => {remote => 1, enroll => 1, catalog => 1},
                  autorun => {remote => 1, enroll => 1, reqcrs => 1},
                  autovalidateclass_sec => {catalog => 1},
                  autovalidatecourse => {remote => 1, enroll => 1},
                  autovalidateinstcode => {domroles => 1, remote => 1, enroll => 1},
                  changeuserauth => {remote => 1, domroles => 1},
                  chatretr => {remote => 1, enroll => 1},
                  chatsend => {remote => 1, enroll => 1},
                  courseiddump => {remote => 1, domroles => 1, enroll => 1},
                  courseidput => {remote => 1, domroles => 1, enroll => 1},
                  courseidputhash => {remote => 1, domroles => 1, enroll => 1},
                  courselastaccess => {remote => 1, domroles => 1, enroll => 1},
                  currentauth => {remote => 1, domroles => 1, enroll => 1},
                  currentdump => {remote => 1, enroll => 1},
                  currentversion => {remote=> 1, content => 1},
                  dcmaildump => {remote => 1, domroles => 1},
                  dcmailput => {remote => 1, domroles => 1},
                  del => {remote => 1, domroles => 1, enroll => 1, content => 1},
                  deldom => {remote => 1, domroles => 1}, # not currently used
                  devalidatecache => {institutiononly => 1},
                  domroleput => {remote => 1, enroll => 1},
                  domrolesdump => {remote => 1, catalog => 1},
                  du => {remote => 1, enroll => 1},
                  du2 => {remote => 1, enroll => 1},
                  dump => {remote => 1, enroll => 1, domroles => 1},
                  edit => {institutiononly => 1},  #not used currently
                  eget => {remote => 1, domroles => 1, enroll => 1}, #not used currently
                  ekey => {}, #not used currently
                  exit => {anywhere => 1},
                  fetchuserfile => {remote => 1, enroll => 1},
                  get => {remote => 1, domroles => 1, enroll => 1},
                  getdom => {anywhere => 1},
                  home => {anywhere => 1},
                  iddel => {remote => 1, enroll => 1},
                  idget => {remote => 1, enroll => 1},
                  idput => {remote => 1, domroles => 1, enroll => 1},
                  inc => {remote => 1, enroll => 1},
                  init => {anywhere => 1},
                  inst_usertypes => {remote => 1, domroles => 1, enroll => 1},
                  instemailrules => {remote => 1, domroles => 1},
                  instidrulecheck => {remote => 1, domroles => 1,},
                  instidrules => {remote => 1, domroles => 1,},
                  instrulecheck => {remote => 1, enroll => 1, reqcrs => 1, domroles => 1},
                  instselfcreatecheck => {institutiononly => 1},
                  instuserrules => {remote => 1, enroll => 1, reqcrs => 1, domroles => 1},
                  keys => {remote => 1,},
                  load => {anywhere => 1},
                  log => {anywhere => 1},
                  ls => {remote => 1, enroll => 1, content => 1,},
                  ls2 => {remote => 1, enroll => 1, content => 1,},
                  ls3 => {remote => 1, enroll => 1, content => 1,},
                  makeuser => {remote => 1, enroll => 1, domroles => 1,},
                  mkdiruserfile => {remote => 1, enroll => 1,},
                  newput => {remote => 1, enroll => 1, reqcrs => 1, domroles => 1,},
                  passwd => {remote => 1},
                  ping => {anywhere => 1},
                  pong => {anywhere => 1},
                  pushfile => {manageronly => 1},
                  put => {remote => 1, enroll => 1, domroles => 1, msg => 1, content => 1, shared => 1},
                  putdom => {remote => 1, domroles => 1,},
                  putstore => {remote => 1, enroll => 1},
                  queryreply => {anywhere => 1},
                  querysend => {anywhere => 1},
                  quit => {anywhere => 1},
                  readlonnetglobal => {institutiononly => 1},
                  reinit => {manageronly => 1}, #not used currently
                  removeuserfile => {remote => 1, enroll => 1},
                  renameuserfile => {remote => 1,},
                  restore => {remote => 1, enroll => 1, reqcrs => 1,},
                  rolesdel => {remote => 1, enroll => 1, domroles => 1, coaurem => 1},
                  rolesput => {remote => 1, enroll => 1, domroles => 1, coaurem => 1},
                  servercerts => {institutiononly => 1},
                  serverdistarch => {anywhere => 1},
                  serverhomeID => {anywhere => 1},
                  serverloncaparev => {anywhere => 1},
                  servertimezone => {remote => 1, enroll => 1},
                  setannounce => {remote => 1, domroles => 1},
                  sethost => {anywhere => 1},
                  store => {remote => 1, enroll => 1, reqcrs => 1,},
                  studentphoto => {remote => 1, enroll => 1},
                  sub => {content => 1,},
                  tmpdel => {anywhere => 1},
                  tmpget => {anywhere => 1},
                  tmpput => {anywhere => 1},
                  tokenauthuserfile => {anywhere => 1},
                  unsub => {content => 1,},
                  update => {shared => 1},
                  updateclickers => {remote => 1},
                  userhassession => {anywhere => 1},
                  userload => {anywhere => 1},
                  version => {anywhere => 1}, #not used
               );
   
   #
 #   Statistics that are maintained and dislayed in the status line.  #   Statistics that are maintained and dislayed in the status line.
 #  #
 my $Transactions = 0; # Number of attempted transactions.  my $Transactions = 0; # Number of attempted transactions.
Line 667  sub PushFile { Line 812  sub PushFile {
                 $clientprotocol = 'http' if ($clientprotocol ne 'https');                  $clientprotocol = 'http' if ($clientprotocol ne 'https');
                 my $url = '/adm/'.$filename;                  my $url = '/adm/'.$filename;
                 $url =~ s{_}{/};                  $url =~ s{_}{/};
                 my $ua=new LWP::UserAgent;  
                 $ua->timeout(60);  
                 my $request=new HTTP::Request('GET',"$clientprotocol://$clienthost$url");                  my $request=new HTTP::Request('GET',"$clientprotocol://$clienthost$url");
                 my $response=$ua->request($request);                  my $response = LONCAPA::LWPReq::makerequest($clientname,$request,'',\%perlvar,60,0);
                 if ($response->is_error()) {                  if ($response->is_error()) {
                     &logthis('<font color="red"> Pushfile: unable to install '                      &logthis('<font color="red"> Pushfile: unable to install '
                             .$tablefile." - error attempting to pull data. </font>");                              .$tablefile." - error attempting to pull data. </font>");
Line 1797  sub server_distarch_handler { Line 1940  sub server_distarch_handler {
 }  }
 &register_handler("serverdistarch", \&server_distarch_handler, 0, 1, 0);  &register_handler("serverdistarch", \&server_distarch_handler, 0, 1, 0);
   
   sub server_certs_handler {
       my ($cmd,$tail,$client) = @_;
       my $userinput = "$cmd:$tail";
       my $result;
       my $result = &LONCAPA::Lond::server_certs(\%perlvar);
       &Reply($client,\$result,$userinput);
       return;
   }
   &register_handler("servercerts", \&server_certs_handler, 0, 1, 0);
   
 #   Process a reinit request.  Reinit requests that either  #   Process a reinit request.  Reinit requests that either
 #   lonc or lond be reinitialized so that an updated   #   lonc or lond be reinitialized so that an updated 
 #   host.tab or domain.tab can be processed.  #   host.tab or domain.tab can be processed.
Line 1929  sub authenticate_handler { Line 2082  sub authenticate_handler {
                 my ($remote,$hosted);                  my ($remote,$hosted);
                 my $remotesession = &get_usersession_config($udom,'remotesession');                  my $remotesession = &get_usersession_config($udom,'remotesession');
                 if (ref($remotesession) eq 'HASH') {                  if (ref($remotesession) eq 'HASH') {
                     $remote = $remotesession->{'remote'}                      $remote = $remotesession->{'remote'};
                 }                  }
                 my $hostedsession = &get_usersession_config($clienthomedom,'hostedsession');                  my $hostedsession = &get_usersession_config($clienthomedom,'hostedsession');
                 if (ref($hostedsession) eq 'HASH') {                  if (ref($hostedsession) eq 'HASH') {
Line 2331  sub update_resource_handler { Line 2484  sub update_resource_handler {
 # FIXME: this should use the LWP mechanism, not internal alarms.  # FIXME: this should use the LWP mechanism, not internal alarms.
                 alarm(1200);                  alarm(1200);
  {   {
     my $ua=new LWP::UserAgent;  
     my $request=new HTTP::Request('GET',"$remoteurl");      my $request=new HTTP::Request('GET',"$remoteurl");
     $response=$ua->request($request,$transname);                      $response=&LONCAPA::LWPReq::makerequest($clientname,$request,$transname,\%perlvar,1200,0,1);
  }   }
  alarm(0);   alarm(0);
  if ($response->is_error()) {   if ($response->is_error()) {
Line 2346  sub update_resource_handler { Line 2498  sub update_resource_handler {
 # FIXME: isn't there an internal LWP mechanism for this?  # FIXME: isn't there an internal LWP mechanism for this?
  alarm(120);   alarm(120);
  {   {
     my $ua=new LWP::UserAgent;  
     my $mrequest=new HTTP::Request('GET',$remoteurl.'.meta');      my $mrequest=new HTTP::Request('GET',$remoteurl.'.meta');
     my $mresponse=$ua->request($mrequest,$fname.'.meta');                              my $mresponse = &LONCAPA::LWPReq::makerequest($clientname,$mrequest,$fname.'.meta',\%perlvar,120,0,1);
     if ($mresponse->is_error()) {      if ($mresponse->is_error()) {
  unlink($fname.'.meta');   unlink($fname.'.meta');
     }      }
Line 2423  sub fetch_user_file_handler { Line 2574  sub fetch_user_file_handler {
  my $remoteurl=$clientprotocol.'://'.$clienthost.'/userfiles/'.$fname;   my $remoteurl=$clientprotocol.'://'.$clienthost.'/userfiles/'.$fname;
  my $response;   my $response;
  Debug("Remote URL : $remoteurl Transfername $transname Destname: $destname");   Debug("Remote URL : $remoteurl Transfername $transname Destname: $destname");
  alarm(120);   alarm(1200);
  {   {
     my $ua=new LWP::UserAgent;  
     my $request=new HTTP::Request('GET',"$remoteurl");      my $request=new HTTP::Request('GET',"$remoteurl");
     $response=$ua->request($request,$transname);              my $verifycert = 1;
               my @machine_ids = &Apache::lonnet::current_machine_ids();
               if (grep(/^\Q$clientname\E$/,@machine_ids)) {
                   $verifycert = 0;
               }
               $response = &LONCAPA::LWPReq::makerequest($clientname,$request,$transname,\%perlvar,1200,$verifycert);
  }   }
  alarm(0);   alarm(0);
  if ($response->is_error()) {   if ($response->is_error()) {
Line 5513  sub auto_export_grades_handler { Line 5668  sub auto_export_grades_handler {
 #    $cmd      - The command that got us dispatched.  #    $cmd      - The command that got us dispatched.
 #    $tail     - The tail of the command.  In our case this is a colon   #    $tail     - The tail of the command.  In our case this is a colon 
 #                separated list that will be split into:  #                separated list that will be split into:
 #                $filename - The name of the file to remove.  #                $filename - The name of the file to retrieve.
 #                            The filename is given as a path relative to  #                            The filename is given as a path relative to
 #                            the LonCAPA temp file directory.  #                            the LonCAPA temp file directory.
 #    $client   - Socket open on the client.  #    $client   - Socket open on the client.
Line 5530  sub retrieve_auto_file_handler { Line 5685  sub retrieve_auto_file_handler {
   
     if ($filename =~m{/\.\./}) {      if ($filename =~m{/\.\./}) {
         &Failure($client, "refused\n", $userinput);          &Failure($client, "refused\n", $userinput);
       } elsif ($filename !~ /^$LONCAPA::match_domain\_$LONCAPA::match_courseid\_.+_classlist\.xml$/) {
           &Failure($client, "refused\n", $userinput);
     } elsif ( (-e $source) && ($filename ne '') ) {      } elsif ( (-e $source) && ($filename ne '') ) {
  my $reply = '';   my $reply = '';
  if (open(my $fh,$source)) {   if (open(my $fh,$source)) {
Line 6167  sub get_request { Line 6324  sub get_request {
 #  #
 # Parameters:  # Parameters:
 #    user_input   - The request received from the client (lonc).  #    user_input   - The request received from the client (lonc).
   #
 # Returns:  # Returns:
 #    true to keep processing, false if caller should exit.  #    true to keep processing, false if caller should exit.
 #  #
 sub process_request {  sub process_request {
     my ($userinput) = @_;      # Easier for now to break style than to      my ($userinput) = @_; # Easier for now to break style than to
                                 # fix all the userinput -> user_input.                            # fix all the userinput -> user_input.
     my $wasenc    = 0; # True if request was encrypted.      my $wasenc    = 0; # True if request was encrypted.
 # ------------------------------------------------------------ See if encrypted  # ------------------------------------------------------------ See if encrypted
     # for command      # for command
Line 6252  sub process_request { Line 6410  sub process_request {
     Debug("Client not privileged to do this operation");      Debug("Client not privileged to do this operation");
     $ok = 0;      $ok = 0;
  }   }
           if ($ok) {
               if (ref($trust{$command}) eq 'HASH') {
                   my $donechecks;
                   if ($trust{$command}{'anywhere'}) {
                      $donechecks = 1;
                   } elsif ($trust{$command}{'manageronly'}) {
                       unless (&isManager()) {
                           $ok = 0;
                       }
                       $donechecks = 1;
                   } elsif ($trust{$command}{'institutiononly'}) {
                       unless ($clientsameinst) {
                           $ok = 0;
                       }
                       $donechecks = 1;
                   } elsif ($clientsameinst) {
                       $donechecks = 1;
                   }
                   unless ($donechecks) {
                       foreach my $rule (keys(%{$trust{$command}})) {
                           next if ($rule eq 'remote');
                           if ($trust{$command}{$rule}) {
                               if ($clientprohibited{$rule}) {
                                   $ok = 0;
                               } else {
                                   $ok = 1;
                                   $donechecks = 1;
                                   last;
                               }
                           }
                       }
                   }
                   unless ($donechecks) {
                       if ($trust{$command}{'remote'}) {
                           if ($clientremoteok) {
                               $ok = 1;
                           } else {
                               $ok = 0;
                           } 
                       }
                   }
               }
           }
   
  if($ok) {   if($ok) {
     Debug("Dispatching to handler $command $tail");      Debug("Dispatching to handler $command $tail");
Line 6262  sub process_request { Line 6463  sub process_request {
     Failure($client, "refused\n", $userinput);      Failure($client, "refused\n", $userinput);
     return 1;      return 1;
  }   }
       }
     }      
   
     print $client "unknown_cmd\n";      print $client "unknown_cmd\n";
 # -------------------------------------------------------------------- complete  # -------------------------------------------------------------------- complete
Line 7020  sub make_new_child { Line 7220  sub make_new_child {
             my $clienthost = &Apache::lonnet::hostname($clientname);              my $clienthost = &Apache::lonnet::hostname($clientname);
             my $clientserverhomeID = &Apache::lonnet::get_server_homeID($clienthost);              my $clientserverhomeID = &Apache::lonnet::get_server_homeID($clienthost);
             $clienthomedom = &Apache::lonnet::host_domain($clientserverhomeID);              $clienthomedom = &Apache::lonnet::host_domain($clientserverhomeID);
               $clientintdom = &Apache::lonnet::internet_dom($clientserverhomeID);
               $clientsameinst = 0;
               if ($clientintdom ne '') {
                   my $internet_names = &Apache::lonnet::get_internet_names($currenthostid);
                   if (ref($internet_names) eq 'ARRAY') {
                       if (grep(/^\Q$clientintdom\E$/,@{$internet_names})) {
                           $clientsameinst = 1;
                       }
                   }
               }
               $clientremoteok = 0;
               unless ($clientsameinst) {
                   $clientremoteok = 1;
                   my $defdom = &Apache::lonnet::host_domain($perlvar{'lonHostID'});
                   %clientprohibited = &get_prohibited($defdom);
                   if ($clientintdom) {
                       my $remsessconf = &get_usersession_config($defdom,'remotesession');
                       if (ref($remsessconf) eq 'HASH') {
                           if (ref($remsessconf->{'remote'}) eq 'HASH') {
                               if (ref($remsessconf->{'remote'}->{'excludedomain'}) eq 'ARRAY') {
                                   if (grep(/^\Q$clientintdom\E$/,@{$remsessconf->{'remote'}->{'excludedomain'}})) {
                                       $clientremoteok = 0;
                                   }
                               }
                               if (ref($remsessconf->{'remote'}->{'includedomain'}) eq 'ARRAY') {
                                   if (grep(/^\Q$clientintdom\E$/,@{$remsessconf->{'remote'}->{'includedomain'}})) {
                                       $clientremoteok = 1;
                                   } else {
                                       $clientremoteok = 0;
                                   }
                               }
                           }
                       }
                   }
               }
     while(($user_input = get_request) && $keep_going) {      while(($user_input = get_request) && $keep_going) {
  alarm(120);   alarm(120);
  Debug("Main: Got $user_input\n");   Debug("Main: Got $user_input\n");
Line 7035  sub make_new_child { Line 7270  sub make_new_child {
     &logthis("<font color='blue'>WARNING: "      &logthis("<font color='blue'>WARNING: "
      ."Rejected client $clientip, closing connection</font>");       ."Rejected client $clientip, closing connection</font>");
  }   }
     }                  }
           
 # =============================================================================  # =============================================================================
           
Line 7715  sub make_passwd_file { Line 7950  sub make_passwd_file {
     my $pf = IO::File->new(">$passfilename");      my $pf = IO::File->new(">$passfilename");
     if($pf) {      if($pf) {
  print $pf "localauth:$npass\n";   print $pf "localauth:$npass\n";
                   &update_passwd_history($uname,$udom,$umode,$action);
     } else {      } else {
  $result = "pass_file_failed_error";   $result = "pass_file_failed_error";
     }      }
Line 7777  sub get_usersession_config { Line 8013  sub get_usersession_config {
         return $usersessionconf;          return $usersessionconf;
     } else {      } else {
         my %domconfig = &Apache::lonnet::get_dom('configuration',['usersessions'],$dom);          my %domconfig = &Apache::lonnet::get_dom('configuration',['usersessions'],$dom);
         if (ref($domconfig{'usersessions'}) eq 'HASH') {          &Apache::lonnet::do_cache_new($name,$dom,$domconfig{'usersessions'},3600);
             &Apache::lonnet::do_cache_new($name,$dom,$domconfig{'usersessions'},3600);          return $domconfig{'usersessions'};
             return $domconfig{'usersessions'};  
         }  
     }      }
     return;      return;
 }  }
   
   sub get_prohibited {
       my ($dom) = @_;
       my $name = 'trust';
       my ($trustconfig,$cached)=&Apache::lonnet::is_cached_new($name,$dom);
       unless (defined($cached)) {
           my %domconfig = &Apache::lonnet::get_dom('configuration',['trust'],$dom);
           &Apache::lonnet::do_cache_new($name,$dom,$domconfig{'trust'},3600);
           $trustconfig = $domconfig{'trust'};
       }
       my %prohibited;
       if (ref($trustconfig)) {
           foreach my $prefix (keys(%{$trustconfig})) {
               if (ref($trustconfig->{$prefix}) eq 'HASH') {
                   my $reject;
                   if (ref($trustconfig->{$prefix}->{'exc'}) eq 'ARRAY') {
                       if (grep(/^\Q$clientintdom\E$/,@{$trustconfig->{$prefix}->{'exc'}})) {
                           $reject = 1;
                       }
                   }
                   if (ref($trustconfig->{$prefix}->{'inc'}) eq 'ARRAY') {
                       if (grep(/^\Q$clientintdom\E$/,@{$trustconfig->{$prefix}->{'inc'}})) {
                           $reject = 0;
                       } else {
                           $reject = 1;
                       }
                   }
                   if ($reject) {
                       $prohibited{$prefix} = 1;
                   }
               }
           }
       }
       return %prohibited;
   }
   
 sub distro_and_arch {  sub distro_and_arch {
     return $dist.':'.$arch;      return $dist.':'.$arch;
Removed from v.1.522  
changed lines
  Added in v.1.528

FreeBSD-CVSweb <freebsd-cvsweb@FreeBSD.org>