--- loncom/lonmaxima 2007/04/19 17:29:11 1.26 +++ loncom/lonmaxima 2007/11/09 18:47:01 1.34 @@ -3,7 +3,7 @@ # The LearningOnline Network with CAPA # Connect to MAXIMA CAS # -# $Id: lonmaxima,v 1.26 2007/04/19 17:29:11 raeburn Exp $ +# $Id: lonmaxima,v 1.34 2007/11/09 18:47:01 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -237,7 +237,7 @@ sub make_new_child { return; } else { # Child can *not* return from this subroutine. - $SIG{INT} = 'DEFAULT'; # make SIGINT kill us as it did before + # unblock signals sigprocmask(SIG_UNBLOCK, $sigset) @@ -246,15 +246,23 @@ sub make_new_child { &logthis('New process started'); my $command=Expect->spawn('maxima'); - $command->log_stdout(0); - - &getmaximaoutput($command); + # soft/hard_close can take awhile and we really + # don't care we just want it gone + $SIG{INT} = sub { + my $pid = $command->pid(); + kill('KILL'=>$pid); + exit; + }; + + $command->log_stdout(0); + #$command->log_file("$execdir/logs/lonmaxima.session.log"); + &sync($command); for (my $i=0; $i < $MAX_CLIENTS_PER_CHILD; $i++) { &status('Accepting connections'); my $client = $server->accept() or last; - print $command "kill(all);\n"; - &getmaximaoutput($command); + print $command ("display2d:false;kill(all);\n"); + &getmaximaoutput($command,2); &sync($command); my $syntaxerr = 0; while (my $cmd=<$client>) { @@ -275,6 +283,7 @@ sub make_new_child { } } + print $command ("quit();\n"); # tidy up gracefully and finish $command->soft_close(); @@ -307,43 +316,48 @@ sub getmaximaoutput { my $regexp = '\(\%i\d+\)'; my $syntaxerr=0; if ($numcheck) { - if ($command->match() =~ /\(\%i(\d+)\)/) { + if ($numcheck eq 2) { + # command was the killall so should get a full reset on + # command numbers + $regexp = '(\(\%i(1)\)|Incorrect syntax\:)'; + } elsif ($command->match() =~ /\(\%i(\d+)\)/) { my $nextmatch = $1+1; $regexp = '(\(\%i'.$nextmatch.'\)|Incorrect syntax\:)'; } } my $timeout = 20; - my (undef,$error,$matched,$output)=$command->expect($timeout, -re => $regexp); - if ($numcheck) { - if ($matched eq 'Incorrect syntax:') { - $syntaxerr = 1; - if (wantarray) { - return ($matched,$syntaxerr); - } else { - return $matched; - } - } + my (undef,$error,$matched,$output) = + $command->expect($timeout, -re => $regexp); + + if ($numcheck && $matched eq 'Incorrect syntax:') { + $syntaxerr = 1; + if (wantarray) { + return ($matched,$syntaxerr); + } else { + return $matched; + } } if ($error) { - if (wantarray) { - return ('Error: '.$error); - } else { - return 'Error: '.$error; - } + return 'Error: '.$error; } $output =~ s/\r+//g; # Remove Windows-style linebreaks my $foundoutput=0; + my $found_label=0; my $realoutput=''; foreach my $line (split(/\n/,$output)) { if ($line=~/\;/) { $foundoutput=1; next; } if (!$foundoutput) { next; } if ($line=~/^Incorrect syntax:/) { $syntaxerr = 1; next; } - (my $label, $line) = ($line=~ /^(\(\%o\d+\))(.+)$/); - if ($label) { - $label=~s/\S/ /g; + if ($line=~ /^(\(\%o\d+\))(.+)$/){ + my $label = $1; + $line = $2; + $label =~s/\S/ /g; $line=$label.$line; + $found_label=1; + } + if ($found_label) { + $realoutput.=$line."\n"; } - $realoutput.=$line."\n"; } if (wantarray) { return ($realoutput,$syntaxerr);