--- loncom/lti/ltiroster.pm 2017/12/07 15:36:25 1.1 +++ loncom/lti/ltiroster.pm 2017/12/09 16:24:03 1.2 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # LTI Consumer Module to respond to a course roster request. # -# $Id: ltiroster.pm,v 1.1 2017/12/07 15:36:25 raeburn Exp $ +# $Id: ltiroster.pm,v 1.2 2017/12/09 16:24:03 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -85,7 +85,6 @@ sub handler { ($cdom,$cnum) = &LONCAPA::ltiutils::get_loncapa_course($r->dir_config('lonHostID'), $cid,\%errors); unless ($cdom && $cnum) { - $errors{4} = 1; &invalid_request($r,\%errors); return OK; } @@ -98,7 +97,7 @@ sub handler { &LONCAPA::ltiutils::get_tool_instance($cdom,$cnum,$digsymb,undef,\%errors); unless ($marker) { - $errors{5} = 1; + $errors{4} = 1; &invalid_request($r,\%errors); return OK; } @@ -126,7 +125,6 @@ sub handler { unless (LONCAPA::ltiutils::verify_request($params,$protocol,$r->hostname,$r->uri, $env{'request.method'},$consumer_secret, \%errors)) { - $errors{6} = 1; &invalid_request($r,\%errors); return OK; } @@ -137,7 +135,7 @@ sub handler { unless (&LONCAPA::ltiutils::check_nonce($params->{'oauth_nonce'},$params->{'oauth_timestamp'}, $nonce_lifetime,$cdom,$r->dir_config('lonLTIDir'))) { - $errors{7} = 1; + $errors{16} = 1; &invalid_request($r,\%errors); return OK; } @@ -149,7 +147,6 @@ sub handler { unless (&LONCAPA::ltiutils::verify_lis_item($rostersig,'roster',$digsymb,undef,$cdom,$cnum, \%toolsettings,\%ltitools,\%errors)) { - $errors{8} = 1; &invalid_request($r,\%errors); return OK; } @@ -165,7 +162,7 @@ sub handler { } unless (keys(%maproles)) { - $errors{9} = 1; + $errors{21} = 1; &invalid_request($r,\%errors); return OK; } @@ -392,7 +389,7 @@ sub invalid_request { my ($r,$errors) = @_; my $errormsg; if (ref($errors) eq 'HASH') { - $errormsg = join('&&',keys(%{$errors})); + $errormsg = join(',',keys(%{$errors})); } &Apache::loncommon::content_type($r,'text/xml'); $r->send_http_header;