CVS log for loncom/publisher/loncfile.pm

Up to [LON-CAPA] / loncom / publisher

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Remove trailing whitespace.  No code changes.

- Breadcrumbs text when creating new file in Course Authoring Space.
- Creation of new files with extensions: .page, .sequence, .rights and
  .library is disabled in Course Authoring Space.

- Include intermediate confirmation screen when changes were made automatically
  to path, directory and/or filename proposed by user.
- Escape instead of encode entities in URLs being assigned to location.href in
  javascript calls.

- Eliminate some <span> tags and include LC_error class in <p> tag instead.

authoring space overhaul
this update tries to improve the user experience of the authoring space.

added codemirror for xml editor and script tags in colorful editor
added possibility to deactivate codemirror in author settings
added dropdown menu to insert problem templates into xml editor (thanks to tobias reinhardt)
added feature of saving current scrollposition on save when editing problems
added possibility to fold blocks in colorful editor, this state will be saved and restored
added shortcuts to create empty problems, html files and directories

and other smaller features and bugfixes

- Pass correct third arg to loncommon::excess_filesize_warning().
- Eliminate unused scalar: $authorspace.

Corrected typo in loncfile.pm 1.120 - wrong sub routine name (bug #6168)

- Bug 6168 (a part).
  - Display warning if copying file would exceed quota in authoring space
  - Testing if quota would be exceeded by file upload moved from lonupload.pm
    to &excess_filesize_authorspace() routine in loncommon.pm to facilitate reuse.

- Replace term: "Construction Space" with "Authoring Space" for
  consistency with type of role used to access it, and action taken there.

Consistent wording: "file name" vs. "filename"
Use "filename" since this is more commonly used.

- Consistent and improved page layout:
    - confirm_success
    - actionbox
    - removed impropriate headline usage
- form.action: Improved code readability
- Typos

- &constructaccess() moved from loncacc.pm to lonnet.pm
  - to facilitate re-use, and separate from handler,
  - for use in lonnet.pm (use Apache::Constants() not supported there.

- Ignore .DS_Store file when determining if a directory in Authoring is
  empty and so can be deleted via web interface.

- &authorspace() routine now takes an argument: $uri
  so "Construction Space" breadcrumb points at appropriate author space
  for resource/directory being viewed or acted om.
  - current role could be different or ("no role" - i.e., cm), so is only
    used to determine authorspace when $uri is unavailable.

- Fix Construction breadcrumb trails for /adm/cfile, /adm/publish,
  /adm/retrieve, /adm/upload.

- Fix Construction breadcrumb trails for /adm/loncfile
- use lonDocRoot perlvar in place of static string: '/home/httpd/html'
- coding style
   - eliminate leaning toothpicks

- use lonDocRoot perlvar in place of static string: '/home/httpd/html'
- coding style: eliminate leaning toothpicks.

Bug #1320

Bug #1320

... bug 1320 ...

Bug #1320

Read the metafiles

- access checking.

That we are a co-author is additional information, not a warning

- Inhibit menu in directory selector page in pop-up for testbank and IMS import
  to Construction Space.

- Fix typo in backport in 1.100.2.3.

- Backport 1.103.

Don't apply "LC_filename" twice.  Sub routine "display" already wraps filename in "LC_filename".

- Backport 1.102.

- Bug 5983.

- Reversing changes from 1.99 )not included in 2.9.X).

Changes related to modification of LON-CAPA screen header.
Added dynamic link to Construction Space to breadcrumbs

Optimized warning/error styles and Localization:
- Added warning/error style to some messages
- Replaced some error styles by warning styles for messages which are more warnings than errors
- Added filename style to paths/filenames
- Optimized &mt calls for Copy/Move/Rename/Decompress operations
- Added full stops to full sentences
- Adjusted and added corresponding phrases in de.pm

Changes related to modification of LON-CAPA screen header.
start_page call:
- Added breadcrumbs
- Added head_subbox and included CSTR standard header
  (crumbs in header doesn't work here - will be checked and changed later)

Don't translate separator character between and domain.
Advantages: No need to change the translation files, if...
  - different separator character should be used
  - different output is wanted, e.g. just username, plainname, both, etc.
  - different style should be used for output
(work in progress to make this even more flexible by introducing a global function usernamewrapper)

XHTML: Attributes in lower-case only (<form method="post" ...)

- Additional extensions allowed for new files created in Construction Space:
js css txt

XHTML conform tags (input, br, hr)

Optimized Co-Author warnings:
- Replaced error style by warning style which fits much better here
- Don't use headline tag anymore as style to highlight message
- Optimized &mt usage
- Consistent/standard output of username:domain

Localization: Optimized "bad filename" warning message

Localization:
- Get rid of \' inside mt arguments (avoid delimiter rebuild issues in synch.pl)
- Other related mt call optimizations
- de.pm: some other wording improvments

- Regular Expression for both http and https.

Name of form in opener (IMS import or Testbank import) was changed from dataForm to info.

Bug #2075: Get rid of "done" (or at least forward immediately)

Change arguments accepted by lonnet::appenv() to:
1. reference to hash
2. (optional) reference to array.

Change all instances where lonnet::appenv() is called to replace first argument passed (originally a hash) to a reference to the hash.

- Modify lonnet.pm rev 1.35 code intended to prevent "dangerous" modifications of the environment, so it will actually do this.
- Allow these modifications to be made in certain instances:
   DC switching to adhoc role
   CC switching to a different course role in the current course.
   user self-enrolling as a student

- BUG#5488,
   - strip leading trailing blanks from filenames,
   - switch to displaying file names with pre to preserve the multiple
     blank spaces in a row if they exists

- add task to creation menu

- bug#1860, allow case where trying to recreate a directory of the same name of a previously created directory that has had items published out of it before.
- prevent user form creating a file that is the same name as a directory that has been created and published out of before

- BUG#4548 was able still to copy/rename a file to (name).(number).(extension)

- switch <font color="red". to css
- bug#5245 allow creation of files with the same name as previously deleted obsolte files, but warn about it

- don't complain about mime types if the lc of the extension is the same

- filenames can have perios in the directory names, need to only strip the filename

- bunch of \w replacements

	Bug 5079. Address Comment 1. Offer link to directory and to
		newly named file.

	Bug 5079. Construction space rename file returns to directory
		  listing.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- BUG#4732

- start_page

.bak files also need ignoring when deleting empty directories.

- eliminating the inclusion of Apache::Log (it annoys Apache 2 and aache 1 doesn't need it)

- : in a file name causes some suprising results BUG#4293, lets turn it off

Fix bug 4257.

Bug 1860.  Allow deletion of a directory which only contains .save, .meta and .log files associated with published, obsoleted, then deleted resource(s).

Bug 3392 - don't allow ':::', etc
Bug 4113 - require extensions

- need to grab the $1 value before it gets beaen up

- ENV -> env

- according to the perl docs the use of $` or $' slows down all regexps in a program so elimnating them

* Be able to make new library files
* Check for existing filename on new file generation was defunct
* Bug #3443: Copyright/Distribution Help was misplaced on screen and outdated

- copying was not allowing copyng between dirs, also fixed the english on the error statement. BUG#3768

- BUG#3065, / in gfilename were troublesome

- move didn't actually work. Sigh (BUG#3368)

- bug#3375 copy metadata when copying a file

Bug #2450: deleting un-openable files from Construction Space

- sigh

- BUG#3151, directories with . in their names cause all kinds of havoc.

- " causes alot of things to go breaky. (BUG#3067 at least)

- trying to protect more funky filenames from breaingthings

- style police woke up on the wrong side of the vbed and noticed this mess

- style police aren't happy, thinking of instituting a 'indent must not need to do anything' law

Bug #2870: do not allow directory to be renamed with MIME-type extension.

- BUG#2545, move and rename are not exactly the same

Modified to permit processing of testbank uploads and IMS package uploads.

Bug #2361: find out if file is unpublished or obsolete before deleting,
renaming or moving.

Correct language headers in loncfile
Improved filename crumbs
Better prettyprint

Just some cleanup work, nothing really important, however, made easier by the great christmas cd

Localization is finished. All entries are in ru.pm.

Deleting of directoies is now included, also fixed a regular expression mistake that allows for more graceful handling of files that do not have extensions, let me know if it breaks anything

Whoops, forgot to remove some debugging information, it pollutes the log less now

loncfile includes the new decompression system integrated, a lot better than the old way lonconstruct and lonpubdir just support

- BUG#1904

- fixes BUG#2133
   - adds a 'Move file' that is an alias for Rename
   -for copy and rename if the sourec is a file and the dest is a directory the file is copied/renamed to the new directory with the same previous name
   - copy preserves previous file extension if none was specified

no comment

Bug #2004: when renaming a file, also rename hidden files.
Jay Ihry

Bug #2018: fix &exists() and use it.

Bug #2018: looks like it works.

Working on bug #2018: could not handle absolute vs. relative URLs

Just saving my work. This is hard.

Really, there are always only two relevant filenames:

$fn: where we are right now
$newfilename: any second fileparameter (copy, rename, etc)

Make sure that these are now *always* full *file*-paths, e.g.

/home/author/public_html/bar/foo.html

Looking better for bug #2018, needs testing.

Create style and rights files.

Put in uniform headers.

- better solution to BUG#1242, cleans onall actions now

- remove bad characters from file names(BUG#1242)

- defaults to creating a resource if 'Select Action' is left (BUG#1705)
- change to use method POST rather than GET, (BUG#1520)

- fixes BUG#195, renames that involve moves across directories wern't adding the default extension back on

New .sequence and .page menu options

- can rename a directory (but can't move it)

- adding in BUGS#1246 suggestion on new file extensions

- I think new file works as one migth expect now Fixes BUG#1246

- part of BUG#1246, renames dont need fileextension

- xhtmlize

- added code for new file creation

- Fixes condition where one could copy a file to a directory. BUG#1142
- Must suply filename in all cases

- Done link after delete is now correct
- Fixes BUG#1010

- Fixes BUG#910, when copying files using ../ it simplifies the message

Correct ad hoc mapping of urls to use HTTP::Entities::encode.

various spelling fixes

fix a spelling error

Bug 442: Two issues with special chars. solved here:
1. spaces in names - escape works fine on this issue.
2. apostrophe's in uploaded file names:

Apostrophe solution not so easy as spaces:  The problem was in the
Frame src tag for the lower frame of construction space.. it's of the form:
<frame> src='$lowerframe' ...Thanks to matt for finding this.
The embedded ' closes the src from the point of view of the html.  Amazingly the
 extra characters don't cause browsers to complain.  The problem: demonstrably,
escaping via lonnet::escape does nothing worth while.  Using my handy dandy
html pocket guide, I determined that lonnet::escape is too simple minded
and may in fact be not quite right.  did a:
1. made the quotations " rather than '
2. Substituted for " in $lowerframe by:
   $lowerframe=~s/\"/&quot\;/g;

Turning " -> &quot; as per the entity chart on pg 82 of HTML Pocket ref.
This works fine.

Ensure that files manipulated in construction space will have permissions:
rw-rw---  and directories:  rwxrwxs---
This fix is inspired by, but not actually all of bug 59... Also need to catch
this for uploads.

Get cancel actions to work.

Still need to :
  validate bugzilla issues.
  ensure this stuff works for non filesystem auth.
  Clean up final copy to remove detritus I've introduced in debug.

Complete rewrite:
- Break out functionality.
- Integrate pod as per proposed commenting standard to see how that works.

NOTE: Work still to be done:
  - Test cancel code paths.
  - Ensure that bugs: 52, 115, 158, 195, 259, 443, 457, 540 get addressed.
  - Figure out how to address bugs 442, 516 543

- $fn seems to be set to the full path (/home/$uname/public_html) but was treated as if to was relative to the public_html directory.

- tested for filesystem authenticated, but not internal users

Add a sub for URL -> Path conversion, use it in handler...
  still must look for applications eleswhere in the module.

(Bug 259).
Correct directory mapping in construction space:
- Generation of names for creational operations was wrong for internally
  authenticated users.
- Stage 2 Create directory: Done left us in a bad directory.

- better chcking of existance and suffixes
- Cancel button

 - GPL headers added

Bug fix for link back

Actually does stuff now

Some more functionality - still not there.

More functionality

Copy action

More actions in construction space