--- loncom/publisher/loncfile.pm 2003/02/10 23:13:17 1.24 +++ loncom/publisher/loncfile.pm 2003/06/19 20:23:39 1.30 @@ -9,7 +9,7 @@ # and displays a page showing the results of the action. # # -# $Id: loncfile.pm,v 1.24 2003/02/10 23:13:17 albertel Exp $ +# $Id: loncfile.pm,v 1.30 2003/06/19 20:23:39 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -412,7 +412,7 @@ sub CloseForm1 { &Debug($request, "Cancel url is: ".$cancelurl); $request->print('

'); $request->print('

'); + '" method="POST">

'); } @@ -494,13 +494,19 @@ sub Rename1 { if(-e $conspace) { if($ENV{'form.newfilename'}) { my $newfilename = $ENV{'form.newfilename'}; - if ($newfilename =~ m|^[^\.]+$|) { + if ($newfilename =~ m|/[^\.]+$|) { #no extension add on orignal extension if ($filename =~ m|/[^\.]*\.([^\.]+)$|) { $newfilename.='.'.$1; } } $request->print(&checksuffix($filename, $newfilename)); + #renaming a dir, delete the trailing / + #remove last element for current dir + if ($filename =~ m|/$|) { + $filename =~ s|/$||; + $dir =~ s|/[^/]*$||; + } my $return=&exists($user, $domain, $dir, $newfilename); $request->print($return); if ($return =~/^Error:/) { @@ -764,6 +770,10 @@ sub NewFile1 { if ($ENV{'form.action'} =~ /new(.+)file/) { my $extension=$1; if ($newfilename !~ /\Q.$extension\E$/) { + if ($newfilename =~ m|^[^\.]*\.([^\.]+)$|) { + #already has an extension strip it and add in expected one + $newfilename =~ s|.([^\.]+)$||; + } $newfilename.=".$extension"; } } @@ -776,15 +786,15 @@ sub NewFile1 { $request->print('

File exists.

'); } else { - $request->print('

Make new file '.$newfilename.'?

'); + $request->print('

Make new file '.$dir.'/'.$newfilename.'?

'); my $dest=&MakeFinalUrl($request,$fullpath); &Debug($request, "Cancel url is: ".$cancelurl); &Debug($request, "Dest url is: ".$dest); $request->print(''); $request->print('

'); + '" method="POST">

'); $request->print('

'); + '" method="POST">

'); } } @@ -833,9 +843,11 @@ sub phaseone { ''); if ($ENV{'form.action'} eq 'rename') { - - &Rename1($r, $fn, $uname, $udom, $dir); - + if (!defined($dir)) { + $fn=~m:(.*)/:; + $dir=$1; + } + &Rename1($r, $fn, $uname, $udom, $dir); } elsif ($ENV{'form.action'} eq 'delete') { &Delete1($r, $uname, $fn); @@ -851,17 +863,20 @@ sub phaseone { &NewDir1($r, $uname, $dir, $ENV{'form.newfilename'}); } elsif ($ENV{'form.action'} eq 'newfile' || $ENV{'form.action'} eq 'newhtmlfile' || - $ENV{'form.action'} eq 'newproblemfile') { - if($ENV{'form.newfilename'}) { - my $newfilename = $ENV{'form.newfilename'}; - if (!defined($dir)) { - $fn=~m:(.*)/:; - $dir=$1; + $ENV{'form.action'} eq 'newproblemfile' || + $ENV{'form.action'} eq 'newpagefile' || + $ENV{'form.action'} eq 'newsequencefile' || + $ENV{'form.action'} eq 'Select Action') { + if($ENV{'form.newfilename'}) { + my $newfilename = $ENV{'form.newfilename'}; + if (!defined($dir)) { + $fn=~m:(.*)/:; + $dir=$1; + } + &NewFile1($r, $uname, $udom, $dir, $newfilename); + } else { + $r->print('

No new filename specified.

'); } - &NewFile1($r, $uname, $udom, $dir, $fn, $newfilename); - }else { - $r->print('

No new filename specified.

'); - } } } @@ -909,8 +924,19 @@ sub Rename2 { $newfile); if(-e $oldfile) { - unless(rename($oldfile, - $directory.'/'.$newfile)) { + my $dest; + + if ($oldfile =~ m|/$|) { + #renaming a dir + $oldfile =~ s|/$||; + $dest=$directory; + $dest=~s|(/)([^/]*)$|$1|; + $dest.='/'.$newfile; + } else { + $dest=$directory.'/'.$newfile; + } + + unless(rename($oldfile,$dest)) { $request->print('Error: '.$!.''); return 0; } else {} @@ -1088,11 +1114,16 @@ sub phasetwo { # Break down the file into it's component pieces. - $fn=~/(.*)\/([^\/]+)\.(\w+)$/; - my $dir=$1; # Directory path - my $main=$2; # Filename. - my $suffix=$3; # Extension. - + my $dir; # Directory path + my $main; # Filename. + my $suffix; # Extension. + + if ($fn=~m:(.*)/([^/]+)\.(\w+)$:) { + $dir=$1; # Directory path + $main=$2; # Filename. + $suffix=$3; # Extension. + } + my $dest; # On success this is where we'll go. &Debug($r, @@ -1112,12 +1143,19 @@ sub phasetwo { if ($ENV{'form.action'} eq 'rename') { # Rename. if($ENV{'form.newfilename'}) { + if (!defined($dir)) { + $fn=~m:^(.*)/:; + $dir=$1; + } if(!&Rename2($r, $uname, $dir, $fn, $ENV{'form.newfilename'})) { return; } # Prepend the directory to the new name to form the basis of the # url of the new resource. # + #renaming a dir + #remove last element for current dir + if ($fn =~ m|/$|) { $dir =~ s|/[^/]*$||; } $dest = $dir."/".$ENV{'form.newfilename'}; } } elsif ($ENV{'form.action'} eq 'delete') { @@ -1256,10 +1294,13 @@ sub handler { $r->print('

Copy

'); } elsif ($ENV{'form.action'} eq 'newfile' || $ENV{'form.action'} eq 'newhtmlfile' || - $ENV{'form.action'} eq 'newproblemfile') { + $ENV{'form.action'} eq 'newproblemfile' || + $ENV{'form.action'} eq 'newpagefile' || + $ENV{'form.action'} eq 'newsequencefile' || + $ENV{'form.action'} eq 'Select Action' ) { $r->print('

New Resource

'); } else { - $r->print('

Unknown Action

'); + $r->print('

Unknown Action '.$ENV{'form.action'}.'

'); return OK; } if ($ENV{'form.phase'} eq 'two') {