--- loncom/publisher/loncfile.pm	2004/05/26 22:25:38	1.55
+++ loncom/publisher/loncfile.pm	2011/10/30 19:27:27	1.112
@@ -9,7 +9,7 @@
 #  and displays a page showing the results of the action.
 #
 #
-# $Id: loncfile.pm,v 1.55 2004/05/26 22:25:38 albertel Exp $
+# $Id: loncfile.pm,v 1.112 2011/10/30 19:27:27 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -69,10 +69,11 @@ use File::Copy;
 use HTML::Entities();
 use Apache::Constants qw(:common :http :methods);
 use Apache::loncacc;
-use Apache::Log ();
 use Apache::lonnet;
 use Apache::loncommon();
 use Apache::lonlocal;
+use LONCAPA qw(:DEFAULT :match);
+
 
 my $DEBUG=0;
 my $r;				# Needs to be global for some stuff RF.
@@ -101,20 +102,24 @@ my $r;				# Needs to be global for some
 =cut
 
 sub Debug {
-  
-    # Marshall the parameters.
-  
-    my $r       = shift;
-    my $log     = $r->log;
-    my $message = shift;
-  
     # Put out the indicated message butonly if DEBUG is true.
-  
     if ($DEBUG) {
+	my ($r,$message) = @_;
 	$r->log_reason($message);
     }
 }
 
+sub done {
+   my ($url)=@_;
+   my $done=&mt("Done");
+   return(<<ENDDONE);
+<a href="$url">$done</a>
+<script type="text/javascript">
+location.href="$url";
+</script>
+ENDDONE
+}
+
 =pod
 
 =item URLToPath($url)
@@ -154,23 +159,26 @@ sub URLToPath {
     my $Url = shift;
     &Debug($r, "UrlToPath got: $Url");
     $Url=~ s/\/+/\//g;
-    $Url=~ s/^http\:\/\/[^\/]+//;
+    $Url=~ s/^https?\:\/\/[^\/]+//;
     $Url=~ s/^\///;
-    $Url=~ s/(\~|priv\/)(\w+)\//\/home\/$2\/public_html\//;
+    $Url='/home/httpd/html/'.$Url;
     &Debug($r, "Returning $Url \n");
     return $Url;
 }
 
 sub url {
     my $fn=shift;
-    $fn=~s/^\/home\/(\w+)\/public\_html/\/priv\/$1/;
+    $fn=~s/^\/home\/httpd\/html//;
+    $fn=~s/\/\.\//\//g;
+    $fn=&HTML::Entities::encode($fn,'<>"&');
     return $fn;
 }
 
 sub display {
     my $fn=shift;
-    $fn=~s-^/home/(\w+)/public_html-/priv/$1-;
-    return '<tt>'.$fn.'</tt>';
+    $fn=~s/^\/home\/httpd\/html//;
+    $fn=~s/\/\.\//\//g;
+    return '<span class="LC_filename">'.$fn.'</span>';
 }
 
 
@@ -180,9 +188,9 @@ sub display {
 
 sub obsolete_unpub {
     my ($user,$domain,$construct)=@_;
+    my $londocroot = $Apache::lonnet::perlvar{'lonDocRoot'};
     my $published=$construct;
-    $published=~
-	s/^\/home\/$user\/public\_html\//\/home\/httpd\/html\/res\/$domain\/$user\//;
+    $published=~s{^\Q$londocroot/priv/\E}{$londocroot/res/};
     if (-e $published) {
 	if (&Apache::lonnet::metadata($published,'obsolete')) {
 	    return 1;
@@ -193,7 +201,32 @@ sub obsolete_unpub {
     }
 }
 
-
+# see if directory is empty
+# ignores any .meta, .save, .bak, and .log files created for a previously
+# published file, which has since been marked obsolete and deleted.
+sub empty_directory {
+    my ($dirname,$phase) = @_;
+    if (opendir DIR, $dirname) {
+        my @files = grep(!/^\.\.?$/, readdir(DIR)); # ignore . and ..
+        if (@files) { 
+            my @orphans = grep(/\.(meta|save|log|bak)$/,@files);
+            if (scalar(@files) - scalar(@orphans) > 0) { 
+                return 0;
+            } else {
+                if (($phase eq 'Delete2') && (@orphans > 0)) {
+                    foreach my $file (@orphans) {
+                        if ($file =~ /\.(meta|save|log|bak)$/) {
+                            unlink($dirname.$file);
+                        }
+                    }
+                }
+            }
+        }
+        closedir(DIR);
+        return 1;
+    }
+    return 0;
+}
 
 =pod
 
@@ -206,12 +239,16 @@ sub obsolete_unpub {
 
 =over 4
 
-=item  $user   - string [in] - Name of the user for which to check.
+=item  $user     - string [in] - Name of the user for which to check.
 
-=item  $domain - string [in] - Name of the domain in which the resource
+=item  $domain   - string [in] - Name of the domain in which the resource
                           might have been published.
 
-=item  $file   - string [in] - Name of the file.
+=item  $file     - string [in] - Name of the file.
+
+=item  $creating - string [in] - optional, type of object being created,
+                               either 'directory' or 'file'. Defaults to
+                               'file' if unspecified.
 
 =back
 
@@ -219,6 +256,9 @@ Returns:
 
 =over 4
 
+=item  string - Either undef, 'warning' or 'error' depending on the
+                type of problem
+
 =item  string - Either where the resource exists as an html string that can
            be embedded in a dialog or an empty string if the resource
            does not exist.
@@ -228,20 +268,39 @@ Returns:
 =cut
 
 sub exists {
-    my ($user, $domain, $construct) = @_;
+    my ($user, $domain, $construct, $creating) = @_;
+    $creating ||= 'file';
+
+    my $londocroot = $Apache::lonnet::perlvar{'lonDocRoot'};
     my $published=$construct;
-    $published=~
-	s/^\/home\/$user\/public\_html\//\/home\/httpd\/html\/res\/$domain\/$user\//;
-    my $result='';    
+    $published=~s{^\Q$londocroot/priv/\E}{$londocroot/res/};
+    my ($type,$result);
     if ( -d $construct ) {
-	return &mt('Error: destination for operation is an existing directory.');
+	return ('error','<p><span class="LC_error">'.&mt('Error: destination for operation is an existing directory.').'</span></p>');
+	
     }
+
     if ( -e $published) {
-	$result.='<p><font color="red">'.&mt('Warning: target file exists, and has been published!').'</font></p>';
+	if ( -e $construct ) {
+	    $type = 'warning';
+	    $result.='<p><span class="LC_warning">'.&mt('Warning: target file exists, and has been published!').'</span></p>';
+	} else {
+	    my $published_type = (-d $published) ? 'directory' : 'file';
+
+	    if ($published_type eq $creating) {
+		$type = 'warning';
+		$result.='<p><span class="LC_warning">'.&mt("Warning: a published $published_type of this name exists.").'</span></p>';
+	    } else {
+		$type = 'error';
+		$result.='<p><span class="LC_error">'.&mt("Error: a published $published_type of this name exists.").'</span></p>';
+	    }
+	}
     } elsif ( -e $construct) {
-	$result.='<p><font color="red">'.&mt('Warning: target file exists!').'</font></p>';
+	$type = 'warning';
+	$result.='<p><span class="LC_warning">'.&mt('Warning: target file exists!').'</span></p>';
     }
-    return $result;
+
+    return ($type,$result);
 }
 
 =pod
@@ -280,28 +339,63 @@ sub checksuffix {
     my $newsuffix;
     if ($new=~m:(.*/*)([^/]+)\.(\w+)$:) { $newsuffix=$3; }
     if ($old=~m:(.*)/+([^/]+)\.(\w+)$:) { $oldsuffix=$3; }
-    if ($oldsuffix ne $newsuffix) {
+    if (lc($oldsuffix) ne lc($newsuffix)) {
 	$result.=
-            '<p><font color="red">'.&mt('Warning: change of MIME type!').'</font></p>';
+            '<p><span class="LC_warning">'.&mt('Warning: change of MIME type!').'</span></p>';
     }
     return $result;
 }
 
 sub cleanDest {
-    my ($request,$dest)=@_;
+    my ($request,$dest,$subdir,$fn,$uname,$udom)=@_;
     #remove bad characters
-    if  ($dest=~/[\#\?&]/) {
-	$request->print("<p><font color=\"red\">".&mt('Invalid characters in requested name have been removed.')."</font></p>");
-	$dest=~s/[\#\?&]//g;
+    my $foundbad=0;
+    my $error='';
+    if ($subdir && $dest =~/\./) {
+	$foundbad=1;
+	$dest=~s/\.//g;
+    }
+    $dest =~ s/(\s+$|^\s+)//g;
+    if  ($dest=~/[\#\?&%\":]/) {
+	$foundbad=1;
+	$dest=~s/[\#\?&%\":]//g;
+    }
+    if ($dest=~m|/|) {
+	my ($newpath)=($dest=~m|(.*)/|);
+	($newpath,$error)=&relativeDest($fn,$newpath,$uname,$udom);
+	if (! -d "$newpath") {
+	    $request->print('<p><span class="LC_warning">'
+                           .&mt("You have requested to create file in directory [_1] which doesn't exist. The requested directory path has been removed from the requested file name."
+                               ,&display($newpath))
+                           .'</span></p>');
+	    $dest=~s|.*/||;
+	}
+    }
+    if ($dest =~ /\.(\d+)\.(\w+)$/){
+	$request->print('<p><span class="LC_warning">'
+			.&mt('Bad filename [_1]',&display($dest))
+                        .'<br />'
+                        .&mt('[_1](name).(number).(extension)[_2] not allowed.','<tt>','</tt>')
+                        .'<br />'
+                        .&mt('Removing the [_1].number.[_2] from requested filename.','<tt>','</tt>')
+			.'</span></p>');
+	$dest =~ s/\.(\d+)(\.\w+)$/$2/;
+    }
+    if ($foundbad) {
+        $request->print('<p><span class="LC_warning">'
+                       .&mt('Invalid characters in requested name have been removed.')
+                        .'</span></p>'
+        );
     }
-    return $dest;
+    return ($dest,$error);
 }
 
 sub relativeDest {
-    my ($fn,$newfilename,$uname)=@_;
+    my ($fn,$newfilename,$uname,$udom)=@_;
+    my $error = '';
     if ($newfilename=~/^\//) {
 # absolute, simply add path
-	$newfilename='/home/'.$uname.'/public_html/';
+	$newfilename='/home/httpd/html/res/'.$udom.'/'.$uname.'/';
     } else {
 	my $dir=$fn;
 	$dir=~s/\/[^\/]+$//;
@@ -311,7 +405,12 @@ sub relativeDest {
     while ($newfilename=~m:/\.\./:) {
 	$newfilename=~ s:/[^/]+/\.\./:/:g; #remove dir/..
     }
-    return $newfilename;
+    my ($authorname,$authordom)=&Apache::loncacc::constructaccess($newfilename);
+    unless (($authorname) && ($authordom)) {
+       my $otherdir = &display($newfilename);
+       $error = &mt('Access denied to [_1]',$otherdir);
+    }
+    return ($newfilename,$error);
 }
 
 =pod
@@ -336,7 +435,7 @@ sub CloseForm1 {
     my ($request,  $fn) = @_;
     $request->print('<p><input type="submit" value="'.&mt('Continue').'" /></p></form>');
     $request->print('<form action="'.&url($fn).
-		    '" method="POST"><p><input type="submit" value="'.&mt('Cancel').'" /></p></form>');
+		    '" method="post"><p><input type="submit" value="'.&mt('Cancel').'" /></p></form>');
 }
 
 
@@ -366,7 +465,7 @@ Parameters:
 
 sub CloseForm2 {
     my ($request, $user, $fn) = @_;
-    $request->print('<h3><a href="'.&url($fn).'/">'.&mt('Done').'</a></h3>');
+    $request->print(&done(&url($fn)));
 }
 
 =pod
@@ -427,10 +526,10 @@ sub Rename1 {
 	    if (-d $fn) {
 		$newfilename=~/\.(\w+)$/;
 		if (&Apache::loncommon::fileembstyle($1) eq 'ssi') {
-		    $request->print('<br /><font color="red">'.
-				    &mt('Cannot change MIME type of a directory').
-				    '</font>'.
-				    '<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a>');
+		    $request->print('<p><span class="LC_error">'.
+				    &mt('Cannot change MIME type of a directory.').
+				    '</span>'.
+				    '<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a></p>');
 		    return;
 		}
 		$newfilename=~s/\/[^\/]+\/([^\/]+)$/\/$1/;
@@ -439,34 +538,45 @@ sub Rename1 {
 	    while ($newfilename=~m:/\.\./:) {
 		$newfilename=~ s:/[^/]+/\.\./:/:g; #remove dir/..
 	    }
-	    my $return=&exists($user, $domain, $newfilename);
+	    my ($type, $return)=&exists($user, $domain, $newfilename);
 	    $request->print($return);
-	    if ($return =~/^Error:/) {
+	    if ($type eq 'error') {
 		$request->print('<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a>');
 		return;
 	    }
 	    unless (&obsolete_unpub($user,$domain,$fn)) {
-		$request->print('<h3>'.&mt('Cannot rename or move non-obsolete published file').'</h3>'.
-				'<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a>');
+                $request->print('<p><span class="LC_error">'
+                               .&mt('Cannot rename or move non-obsolete published file.')
+                               .'</span><br />'
+                               .'<a href="'.&url($fn).'">'.&mt('Cancel').'</a></p>'
+                );
 		return;
 	    }
 	    my $action;
 	    if ($style eq 'rename') {
-		$action=&mt('Rename');
+		$action='Rename';
 	    } else {
-		$action=&mt('Move');
+		$action='Move';
 	    }
-	    $request->print('<input type="hidden" name="newfilename" value="'.
-			    $newfilename.
-			    '" /><p>'.$action.' '.&display($fn).
-			    '</tt><br />to '.&display($newfilename).'?</p>');
+            $request->print('<input type="hidden" name="newfilename" value="'
+                           .$newfilename.'" />'
+                           .'<p>'
+                           .&mt($action.' [_1] to [_2]?',
+                                &display($fn),
+                                &display($newfilename))
+                           .'</p>'
+        );
 	    &CloseForm1($request, $fn);
 	} else {
-	    $request->print('<p>'.&mt('No new filename specified.').'</p></form>');
+	    $request->print('<p class="LC_error">'.&mt('No new filename specified.').'</p></form>');
 	    return;
 	}
     } else {
-	$request->print('<p> '.&mt('No such file').': '.&display($fn).'</p></form>');
+        $request->print('<p class="LC_error">'
+                       .&mt('No such file: [_1]',
+                            &display($fn))
+                       .'</p></form>'
+        );
 	return;
     }
     
@@ -501,16 +611,41 @@ sub Delete1 {
 
     if( -e $fn) {
 	$request->print('<input type="hidden" name="newfilename" value="'.
-			$fn.'"/>');
-	unless (&obsolete_unpub($user,$domain,$fn)) {
-	    $request->print('<h3>'.&mt('Cannot delete non-obsolete published file').'</h3>'.
-			    '<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a>');
-	    return;
-	}
-	$request->print('<p>'.&mt('Delete').' '.&display($fn).'?</p>');
+			$fn.'" />');
+        if (-d $fn) {
+            unless (&empty_directory($fn,'Delete1')) {
+                $request->print('<p>'
+                               .'<span class="LC_error">'
+                               .&mt('Only empty directories may be deleted.')
+                               .'</span><br />'
+                               .&mt('You must delete the contents of the directory first.')
+                               .'</p>'
+                               .'<p><a href="'.&url($fn).'">'.&mt('Cancel').'</a></p>'
+                );
+                return;
+            }
+        } else { 
+	    unless (&obsolete_unpub($user,$domain,$fn)) {
+                $request->print('<p><span class="LC_error">'
+                               .&mt('Cannot delete non-obsolete published file.')
+                               .'</span><br />'
+                               .'<a href="'.&url($fn).'">'.&mt('Cancel').'</a></p>'
+                );
+	        return;
+	    }
+        }
+        $request->print('<p>'
+                       .&mt('Delete [_1]?',
+                            &display($fn))
+                       .'</p>'
+        );
 	&CloseForm1($request, $fn);
     } else {
-	$request->print('<p>'.&mt('No such file').': '.&display($fn).'</p></form>');
+        $request->print('<p class="LC_error">'
+                       .&mt('No such file: [_1]',
+                            &display($fn))
+                       .'</p></form>'
+        );
     }
 }
 
@@ -558,19 +693,28 @@ sub Copy1 {
 	    $newfilename=~ s:/[^/]+/\.\./:/:g; #remove dir/..
 	}
 	$request->print(&checksuffix($fn,$newfilename));
-	my $return=&exists($user, $domain, $newfilename);
+	my ($type,$return)=&exists($user, $domain, $newfilename);
 	$request->print($return);
-	if ($return =~/^Error:/) {
+	if ($type eq 'error') {
 	    $request->print('<br /><a href="'.&url($fn).'">'.&mt('Cancel').'</a>');
 	    return;
 	}
-	$request->print('<input type="hidden" name="newfilename" value="'.
-			$newfilename.
-			'" /><p>'.&mt('Copy').' '.&display($fn).'<br />to '.
-			&display($newfilename).'?</p>');
+    $request->print(
+        '<input type="hidden" name="newfilename"'
+       .' value="'.$newfilename.'" />'
+       .'<p>'
+       .&mt('Copy [_1] to [_2]?',
+            &display($fn),
+            &display($newfilename))
+       .'</p>'
+        );
 	&CloseForm1($request, $fn);
     } else {
-	$request->print('<p>'.&mt('No such file').': '.&display($fn).'</p></form>');
+        $request->print('<p class="LC_error">'
+                       .&mt('No such file: [_1]',
+                            &display($fn))
+                       .'</p></form>'
+        );
     }
 }
 
@@ -616,18 +760,22 @@ causes the newdir operation to transitio
 sub NewDir1 {
     my ($request, $username, $domain, $fn, $newfilename, $mode) = @_;
 
-    my $result=&exists($username,$domain,$newfilename);
-    if ($result) {
-	$request->print('<font color="red">'.$result.'</font></form>');
+    my ($type, $result)=&exists($username,$domain,$newfilename,'directory');
+    $request->print($result);
+    if ($type eq 'error') {
+	$request->print('</form>');
     } else {
-	if ($mode eq 'testbank') {
-	    $request->print('<input type="hidden" name="callingmode" value="testbank">');
-	} elsif ($mode eq 'imsimport') {
-	    $request->print('<input type="hidden" name="callingmode" value="imsimport">');
-	}
-	$request->print('<input type="hidden" name="newfilename" value="'.
-			$newfilename.'" /><p>'.&mt('Make new directory').' '.
-			&display($newfilename).'?</p>');
+	if (($mode eq 'testbank') || ($mode eq 'imsimport')) {
+	    $request->print('<input type="hidden" name="callingmode" value="'.$mode.'" />'."\n".
+                            '<input type="hidden" name="inhibitmenu" value="yes" />');
+	}
+        $request->print('<input type="hidden" name="newfilename" value="'
+                       .$newfilename.'" />'
+                       .'<p>'
+                       .&mt('Make new directory [_1]?',
+                            &display($newfilename))
+                       .'</p>'
+        );
 	&CloseForm1($request, $fn);
     }
 }
@@ -636,11 +784,19 @@ sub NewDir1 {
 sub Decompress1 {
     my ($request, $user, $domain, $fn) = @_;
     if( -e $fn) {
-   	$request->print('<input type="hidden" name="newfilename" value="'.$fn.'"/>');
-   	$request->print('<p>'.&mt('Decompress').' '.&display($fn).'?</p>');
+   	$request->print('<input type="hidden" name="newfilename" value="'.$fn.'" />');
+   	$request->print('<p>'
+                   .&mt('Decompress [_1]?',
+                        &display($fn))
+                   .'</p>'
+    );
    	&CloseForm1($request, $fn);
     } else {
-	$request->print('<p>'.&mt('No such file').': '.&display($fn).'</p></form>');
+        $request->print('<p class="LC_error">'
+                       .&mt('No such file: [_1]',
+                            &display($fn))
+                       .'</p></form>'
+        );
     }
 }
 
@@ -686,36 +842,74 @@ button which returns you to the driector
 
 sub NewFile1 {
     my ($request, $user, $domain, $fn, $newfilename) = @_;
+    return if (&filename_check($newfilename) ne 'ok');
 
-    if ($ENV{'form.action'} =~ /new(.+)file/) {
+    if ($env{'form.action'} =~ /new(.+)file/) {
 	my $extension=$1;
-
-        ##Informs User (name).(number).(extension) not allowed 
-	if($newfilename =~ /\.(\d+)\.(\w+)$/){
-	    $r->print('<font color="red">'.$newfilename.
-		      ' - '.&mt('Bad Filename').'<br />('.&mt('name').').('.&mt('number').').('.&mt('extension').')'.
-		      ' '.&mt('Not Allowed').'</font>');
-	    return;
-	}
 	if ($newfilename !~ /\Q.$extension\E$/) {
-	    if ($newfilename =~ m|^[^\.]*\.([^\.]+)$|) {
+	    if ($newfilename =~ m|/[^/.]*\.(?:[^/.]+)$|) {
 		#already has an extension strip it and add in expected one
-		$newfilename =~ s|.([^\.]+)$||;
+		$newfilename =~ s|(/[^./])\.(?:[^.]+)$|$1|;
 	    }
 	    $newfilename.=".$extension";
 	}
     }
-    my $result=&exists($user,$domain,$newfilename);
-    if($result) {
-	$request->print('<font color="red">'.$result.'</font></form>');
+    my ($type, $result)=&exists($user,$domain,$newfilename);
+    $request->print($result);
+    if ($type eq 'error') {
+	$request->print('</form>');
     } else {
+        my $extension;
+
+        if ($newfilename =~ m{[^/.]+\.([^/.]+)$}) {
+            $extension = $1;
+        }
+
+        my @okexts = qw(xml html xhtml htm xhtm problem page sequence rights sty task library js css txt);
+        if (($extension eq '') || (!grep(/^\Q$extension\E/,@okexts))) {
+            my $validexts = '.'.join(', .',@okexts);
+            $request->print('<p class="LC_warning">'.
+                &mt('Invalid filename: ').&display($newfilename).'</p><p>'.
+                &mt('The name of the new file needs to end with an appropriate file extension to indicate the type of file to create.').'<br />'.
+                &mt('The following are valid extensions: [_1].',$validexts).
+                '</p></form><p>'.
+		'<form name="fileaction" action="/adm/cfile" method="post">'.
+                '<input type="hidden" name="qualifiedfilename" value="'.$fn.'" />'.
+		'<input type="hidden" name="action" value="newfile" />'.
+	        '<span class ="LC_nobreak">'.&mt('Enter a file name: ').'<input type="text" name="newfilename" value="Type Name Here" onfocus="if (this.value == '."'Type Name Here') this.value=''".'" />&nbsp;<input type="submit" value="Go" />'.
+                '</span></form></p>'.
+                '<p><form action="'.&url($fn).
+                '" method="post"><p><input type="submit" value="'.&mt('Cancel').'" /></form></p>');
+            return;
+        }
+
 	$request->print('<p>'.&mt('Make new file').' '.&display($newfilename).'?</p>');
 	$request->print('</form>');
+
 	$request->print('<form action="'.&url($newfilename).
-			'" method="POST"><p><input type="submit" value="'.&mt('Continue').'" /></p></form>');
+			'" method="post"><p><input type="submit" value="'.&mt('Continue').'" /></p></form>');
 	$request->print('<form action="'.&url($fn).
-			'" method="POST"><p><input type="submit" value="'.&mt('Cancel').'" /></p></form>');
+			'" method="post"><p><input type="submit" value="'.&mt('Cancel').'" /></p></form>');
+    }
+    return;
+}
+
+sub filename_check {
+    my ($newfilename) = @_;
+    ##Informs User (name).(number).(extension) not allowed
+    if($newfilename =~ /\.(\d+)\.(\w+)$/){
+        $r->print('<span class="LC_error">'.$newfilename.
+                  ' - '.&mt('Bad Filename').'<br />('.&mt('name').').('.&mt('number').').('.&mt('extension').') '.
+                  ' '.&mt('Not Allowed').'</span>');
+        return;
+    }
+    if($newfilename =~ /(\:\:\:|\&\&\&|\_\_\_)/){
+        $r->print('<span class="LC_error">'.$newfilename.
+                  ' - '.&mt('Bad Filename').'<br />('.&mt('Must not include').' '.$1.') '.
+                  ' '.&mt('Not Allowed').'</span>');
+        return;
     }
+    return 'ok'; 
 }
 
 =pod
@@ -749,45 +943,71 @@ performed and reported to the user.
 sub phaseone {
     my ($r,$fn,$uname,$udom)=@_;
   
-    my $newfilename=&cleanDest($r,$ENV{'form.newfilename'});
-    $newfilename=&relativeDest($fn,$newfilename,$uname);
+    my $doingdir=0;
+    if ($env{'form.action'} eq 'newdir') { $doingdir=1; }
+    my ($newfilename,$error) = 
+        &cleanDest($r,$env{'form.newfilename'},$doingdir,$fn,$uname,$udom);
+    unless ($error) {
+        ($newfilename,$error)=&relativeDest($fn,$newfilename,$uname,$udom);
+    }
+    if ($error) {
+        my $dirlist;
+        if ($fn=~m{^(.*/)[^/]+$}) {
+            $dirlist=$1;
+        } else {
+            $dirlist=$fn; 
+        }
+        $r->print('<div class="LC_error">'.$error.'</div>'.
+                  '<h3><a href="'.&url($dirlist).'">'.&mt('Return to Directory').
+                  '</a></h3>');
+        return;
+    }
     $r->print('<form action="/adm/cfile" method="post">'.
 	      '<input type="hidden" name="qualifiedfilename" value="'.$fn.'" />'.
 	      '<input type="hidden" name="phase" value="two" />'.
-	      '<input type="hidden" name="action" value="'.$ENV{'form.action'}.'" />');
+	      '<input type="hidden" name="action" value="'.$env{'form.action'}.'" />');
   
-    if ($ENV{'form.action'} eq 'rename') {
+    if ($env{'form.action'} eq 'rename') {
 	&Rename1($r, $uname, $udom, $fn, $newfilename, 'rename');
-    } elsif ($ENV{'form.action'} eq 'move') {
+    } elsif ($env{'form.action'} eq 'move') {
 	&Rename1($r, $uname, $udom, $fn, $newfilename, 'move');
-    } elsif ($ENV{'form.action'} eq 'delete') { 
+    } elsif ($env{'form.action'} eq 'delete') { 
 	&Delete1($r, $uname, $udom, $fn);
-    } elsif ($ENV{'form.action'} eq 'decompress') {
+    } elsif ($env{'form.action'} eq 'decompress') {
 	&Decompress1($r, $uname, $udom, $fn);
-    } elsif ($ENV{'form.action'} eq 'copy') { 
+    } elsif ($env{'form.action'} eq 'copy') { 
 	if($newfilename) {
 	    &Copy1($r, $uname, $udom, $fn, $newfilename);
 	} else {
-	    $r->print('<p>'.&mt('No new filename specified.').'</p></form>');
+            $r->print('<p class="LC_error">'
+                     .&mt('No new filename specified.')
+                     .'</p></form>'
+            );
 	}
-    } elsif ($ENV{'form.action'} eq 'newdir') {
+    } elsif ($env{'form.action'} eq 'newdir') {
 	my $mode = '';
-	if (exists($ENV{'form.callingmode'}) ) {
-	    $mode = $ENV{'form.callingmode'};
+	if (exists($env{'form.callingmode'}) ) {
+	    $mode = $env{'form.callingmode'};
 	}   
 	&NewDir1($r, $uname, $udom, $fn, $newfilename, $mode);
-    }  elsif ($ENV{'form.action'} eq 'newfile' ||
-	      $ENV{'form.action'} eq 'newhtmlfile' ||
-	      $ENV{'form.action'} eq 'newproblemfile' ||
-	      $ENV{'form.action'} eq 'newpagefile' ||
-	      $ENV{'form.action'} eq 'newsequencefile' ||
-	      $ENV{'form.action'} eq 'newrightsfile' ||
-	      $ENV{'form.action'} eq 'newstyfile' ||
-	      $ENV{'form.action'} eq 'Select Action') {
-	if ($newfilename) {
+    }  elsif ($env{'form.action'} eq 'newfile' ||
+	      $env{'form.action'} eq 'newhtmlfile' ||
+	      $env{'form.action'} eq 'newproblemfile' ||
+	      $env{'form.action'} eq 'newpagefile' ||
+	      $env{'form.action'} eq 'newsequencefile' ||
+	      $env{'form.action'} eq 'newrightsfile' ||
+	      $env{'form.action'} eq 'newstyfile' ||
+	      $env{'form.action'} eq 'newtaskfile' ||
+              $env{'form.action'} eq 'newlibraryfile' ||
+	      $env{'form.action'} eq 'Select Action') {
+        my $empty=&mt('Type Name Here');
+	if (($newfilename!~/\/$/) && ($newfilename!~/$empty$/)) {
 	    &NewFile1($r, $uname, $udom, $fn, $newfilename);
 	} else {
-	    $r->print('<p>'.&mt('No new filename specified.').'</p></form>');
+            $r->print('<p class="LC_error">'
+                     .&mt('No new filename specified.')
+                     .'</p></form>'
+            );
 	}
     }
 }
@@ -839,7 +1059,7 @@ sub Rename2 {
 	my $oRN=$oldfile;
 	my $nRN=$newfile;
 	unless (rename($oldfile,$newfile)) {
-	    $request->print('<font color="red">'.&mt('Error').': '.$!.'</font>');
+	    $request->print('<span class="LC_error">'.&mt('Error').': '.$!.'</span>');
 	    return 0;
 	}
 	## If old name.(extension) exits, move under new name.
@@ -874,7 +1094,12 @@ sub Rename2 {
 	    unlink $tmp2;
 	}
     } else {
-	$request->print("<p> ".&mt('No such file').": ".&display($oldfile).'</p></form>');
+        $request->print(
+            '<p>'
+           .&mt('No such file: [_1]',
+                &display($oldfile))
+           .'</p></form>'
+        );
 	return 0;
     }
     return 1;
@@ -911,31 +1136,29 @@ Returns:
 
 sub Delete2 {
     my ($request, $user, $filename) = @_;
-    if(opendir DIR, $filename) { 
-	my @files=readdir(DIR);
-	shift @files; shift @files; # takes off . and ..
-	if(@files) { 
-	    $request->print('<font color="red"> '.&mt('Error: Directory Non Empty').'</font>'); 
+    if (-d $filename) { 
+	unless (&empty_directory($filename,'Delete2')) { 
+	    $request->print('<span class="LC_error">'.&mt('Error: Directory Non Empty').'</span>'); 
 	    return 0;
 	} else {   
 	    if(-e $filename) {
 		unless(rmdir($filename)) {
-		    $request->print('<font color="red">'.&mt('Error').': '.$!.'</font>');
+		    $request->print('<span class="LC_error">'.&mt('Error').': '.$!.'</span>');
 		    return 0;
 		}
 	    } else {
-		$request->print('<p> '.&mt('No such file').'. </p></form>');
+        	$request->print('<p class="LC_error">'.&mt('No such file').'</p></form>');
 		return 0;
 	    }
 	}
     } else {
 	if(-e $filename) {
 	    unless(unlink($filename)) {
-		$request->print('<font color="red">'.&mt('Error').': '.$!.'</font>');
+		$request->print('<span class="LC_error">'.&mt('Error').': '.$!.'</span>');
 		return 0;
 	    }
 	} else {
-	    $request->print('<p> '.&mt('No such file').'. </p></form>');
+            $request->print('<p class="LC_error">'.&mt('No such file').'</p></form>');
 	    return 0;
 	}
     }
@@ -966,7 +1189,7 @@ sub Delete2 {
 
 =back
 
-Returns 0 failure, and 0 successs.
+Returns 0 failure, and 1 successs.
 
 =cut
 
@@ -974,18 +1197,27 @@ sub Copy2 {
     my ($request, $username, $dir, $oldfile, $newfile) = @_;
     &Debug($request ,"Will try to copy $oldfile to $newfile");
     if(-e $oldfile) {
+        if ($oldfile eq $newfile) {
+            $request->print('<span class="LC_error">'.&mt('Warning').': '.&mt('Name of new file is the same as name of old file').' - '.&mt('no action taken').'.</span>');
+            return 1;
+        }
 	unless (copy($oldfile, $newfile)) {
-	    $request->print('<font color="red"> '.&mt('copy Error').': '.$!.'</font>');
+	    $request->print('<span class="LC_error">'.&mt('copy Error').': '.$!.'</span>');
+	    return 0;
+	} elsif (!chmod(0660, $newfile)) {
+	    $request->print('<span class="LC_error">'.&mt('chmod error').': '.$!.'</span>');
+	    return 0;
+	} elsif (-e $oldfile.'.meta' && 
+		 !copy($oldfile.'.meta', $newfile.'.meta') &&
+		 !chmod(0660, $newfile.'.meta')) {
+	    $request->print('<span class="LC_error">'.&mt('copy metadata error').
+			    ': '.$!.'</span>');
 	    return 0;
 	} else {
-	    unless (chmod(0660, $newfile)) {
-		$request->print('<font color="red"> '.&mt('chmod error').': '.$!.'</font>');
-		return 0;
-	    }
 	    return 1;
 	}
     } else {
-	$request->print('<p> '.&mt('No such file').' </p>');
+        $request->print('<p class="LC_error">'.&mt('No such file').'</p>');
 	return 0;
     }
     return 1;
@@ -1017,11 +1249,11 @@ sub NewDir2 {
     my ($request, $user, $newdirectory) = @_;
   
     unless(mkdir($newdirectory, 02770)) {
-	$request->print('<font color="red">'.&mt('Error').': '.$!.'</font>');
+	$request->print('<span class="LC_error">'.&mt('Error').': '.$!.'</span>');
 	return 0;
     }
     unless(chmod(02770, ($newdirectory))) {
-	$request->print('<font color="red"> '.&mt('Error').': '.$!.'</font>');
+	$request->print('<span class="LC_error">'.&mt('Error').': '.$!.'</span>');
 	return 0;
     }
     return 1;
@@ -1029,8 +1261,8 @@ sub NewDir2 {
 
 sub decompress2 {
     my ($r, $user, $dir, $file) = @_;
-    &Apache::lonnet::appenv('cgi.file' => $file);
-    &Apache::lonnet::appenv('cgi.dir' => $dir);
+    &Apache::lonnet::appenv({'cgi.file' => $file});
+    &Apache::lonnet::appenv({'cgi.dir' => $dir});
     my $result=&Apache::lonnet::ssi_body('/cgi-bin/decompress.pl');
     $r->print($result);
     &Apache::lonnet::delenv('cgi.file');
@@ -1075,7 +1307,7 @@ sub phasetwo {
     
     &Debug($r, "loncfile - Entering phase 2 for $fn");
     
-    # Break down the file into it's component pieces.
+    # Break down the file into its component pieces.
     
     my $dir;		# Directory path
     my $main;		# Filename.
@@ -1085,69 +1317,80 @@ sub phasetwo {
 	$main=$2;		# Filename.
     }
     if($main=~m:\.(\w+)$:){ # Fixes problems with filenames with no extensions
-	$main=$`; #This is what is before the match (.) so it's just the main filename, yea it's nasty
 	$suffix=$1; #This is the actually filename extension if it exists
+	$main=~s/\.\w+$//; #strip the extension
     }
-    my $dest;                   # On success this is where we'll go.
-    
+    my $dest;                       #
+    my $dest_dir;                   # On success this is where we'll go.
+    my $disp_newname;               #
+    my $dest_newname;               #
     &Debug($r,"loncfile::phase2 dir = $dir main = $main suffix = $suffix");
-    &Debug($r,"    newfilename = ".$ENV{'form.newfilename'});
+    &Debug($r,"    newfilename = ".$env{'form.newfilename'});
 
     my $conspace=$fn;
     
     &Debug($r,"loncfile::phase2 Full construction space name: $conspace");
     
-    &Debug($r,"loncfie::phase2 action is $ENV{'form.action'}");
+    &Debug($r,"loncfie::phase2 action is $env{'form.action'}");
     
     # Select the appropriate processing sub.
-    if ($ENV{'form.action'} eq 'decompress') { 
-	$main .= '.';
-	$main .= $suffix;
+    if ($env{'form.action'} eq 'decompress') { 
+	$main .= '.'.$suffix;
 	if(!&decompress2($r, $uname, $dir, $main)) {
 	    return ;
 	}
 	$dest = $dir."/.";
-    } elsif ($ENV{'form.action'} eq 'rename') { # Rename.
-	if($ENV{'form.newfilename'}) {
+    } elsif ($env{'form.action'} eq 'rename' ||
+	     $env{'form.action'} eq 'move') {
+	if($env{'form.newfilename'}) {
 	    if (!defined($dir)) {
 		$fn=~m:^(.*)/:;
 		$dir=$1; 
 	    }
-	    if(!&Rename2($r, $uname, $dir, $fn, $ENV{'form.newfilename'})) {
+	    if(!&Rename2($r, $uname, $dir, $fn, $env{'form.newfilename'})) {
 		return;
 	    }
-	    $dest = &url($ENV{'form.newfilename'});
+	    $dest = $dir."/";
+	    $dest_newname = $env{'form.newfilename'};
+	    $env{'form.newfilename'} =~ /.+(\/.+$)/;
+	    $disp_newname = $1;
+	    $disp_newname =~ s/\///;
 	}
-    } elsif ($ENV{'form.action'} eq 'delete') { 
-	if(!&Delete2($r, $uname, $ENV{'form.newfilename'})) {
+    } elsif ($env{'form.action'} eq 'delete') { 
+	if(!&Delete2($r, $uname, $env{'form.newfilename'})) {
 	    return ;
 	}
 	# Once a resource is deleted, we just list the directory that
 	# previously held it.
 	#
 	$dest = $dir."/.";		# Parent dir.
-    } elsif ($ENV{'form.action'} eq 'copy') { 
-	if($ENV{'form.newfilename'}) {
-	    if(!&Copy2($r, $uname, $dir, $fn, $ENV{'form.newfilename'})) {
+    } elsif ($env{'form.action'} eq 'copy') { 
+	if($env{'form.newfilename'}) {
+	    if(!&Copy2($r, $uname, $dir, $fn, $env{'form.newfilename'})) {
 		return ;
 	    }
-	    $dest = $ENV{'form.newfilename'};
+	    $dest = $env{'form.newfilename'};
      	} else {
-	    $r->print('<p>'.&mt('No New filename specified').'</p></form>');
+            $r->print('<p class="LC_error">'.&mt('No New filename specified').'</p></form>');
 	    return;
 	}
 	
-    } elsif ($ENV{'form.action'} eq 'newdir') {
-        my $newdir= $ENV{'form.newfilename'};
+    } elsif ($env{'form.action'} eq 'newdir') {
+        my $newdir= $env{'form.newfilename'};
 	if(!&NewDir2($r, $uname, $newdir)) {
 	    return;
 	}
 	$dest = $newdir."/";
     }
-    if ( ($ENV{'form.action'} eq 'newdir') && ($ENV{'form.phase'} eq 'two') && ( ($ENV{'form.callingmode'} eq 'testbank') || ($ENV{'form.callingmode'} eq 'imsimport') ) ) {
+    if ( ($env{'form.action'} eq 'newdir') && ($env{'form.phase'} eq 'two') && ( ($env{'form.callingmode'} eq 'testbank') || ($env{'form.callingmode'} eq 'imsimport') ) ) {
 	$r->print('<h3><a href="javascript:self.close()">'.&mt('Done').'</a></h3>');
     } else {
-	$r->print('<h3><a href="'.&url($dest).'">'.&mt('Done').'</a></h3>');
+        if ($env{'form.action'} eq 'rename') {
+            $r->print('<h3><a href="'.&url($dest).'">'.&mt('Return to Directory').'</a></h3>');
+            $r->print('<h3><a href="'.&url($dest_newname).'">'.$disp_newname.'</a></h3>');
+        } else {
+	    $r->print(&done(&url($dest)));
+	}
     }
 }
 
@@ -1155,10 +1398,11 @@ sub handler {
 
     $r=shift;
 
+    &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},['decompress','action','filename','newfilename']);
 
     &Debug($r, "loncfile.pm - handler entered");
-    &Debug($r, " filename: ".$ENV{'form.filename'});
-    &Debug($r, " newfilename: ".$ENV{'form.newfilename'});
+    &Debug($r, " filename: ".$env{'form.filename'});
+    &Debug($r, " newfilename: ".$env{'form.newfilename'});
 #
 # Determine the root filename
 # This could come in as "filename", which actually is a URL, or
@@ -1166,29 +1410,28 @@ sub handler {
 #
     my $fn;
 
-    if ($ENV{'form.filename'}) {
-	&Debug($r, "test: $ENV{'form.filename'}");
-	$fn=&Apache::lonnet::unescape($ENV{'form.filename'});
+    if ($env{'form.filename'}) {
+	&Debug($r, "test: $env{'form.filename'}");
+	$fn=&unescape($env{'form.filename'});
 	$fn=&URLToPath($fn);
-    }  elsif($ENV{'QUERY_STRING'} && $ENV{'form.phase'} ne 'two') {  
+    }  elsif($ENV{'QUERY_STRING'} && $env{'form.phase'} ne 'two') {  
 	#Just hijack the script only the first time around to inject the
 	#correct information for further processing
-	&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},['decompress']);
-	$fn=&Apache::lonnet::unescape($ENV{'form.decompress'});
+	$fn=&unescape($env{'form.decompress'});
 	$fn=&URLToPath($fn);
-	$ENV{'form.action'}="decompress";
-    } elsif ($ENV{'form.qualifiedfilename'}) {
-	$fn=$ENV{'form.qualifiedfilename'};
+	$env{'form.action'}="decompress";
+    } elsif ($env{'form.qualifiedfilename'}) {
+	$fn=$env{'form.qualifiedfilename'};
     } else {
 	&Debug($r, "loncfile::handler - no form.filename");
-	$r->log_reason($ENV{'user.name'}.' at '.$ENV{'user.domain'}.
+	$r->log_reason($env{'user.name'}.' at '.$env{'user.domain'}.
 		       ' unspecified filename for cfile', $r->filename); 
 	return HTTP_NOT_FOUND;
     }
 
     unless ($fn) { 
 	&Debug($r, "loncfile::handler - doctored url is empty");
-	$r->log_reason($ENV{'user.name'}.' at '.$ENV{'user.domain'}.
+	$r->log_reason($env{'user.name'}.' at '.$env{'user.domain'}.
 		       ' trying to cfile non-existing file', $r->filename); 
 	return HTTP_NOT_FOUND;
     } 
@@ -1197,13 +1440,12 @@ sub handler {
     my $uname;
     my $udom;
 
-    ($uname,$udom)=
-	&Apache::loncacc::constructaccess($fn,$r->dir_config('lonDefDomain'));
+    ($uname,$udom)=&Apache::loncacc::constructaccess($fn);
     &Debug($r, 
 	   "loncfile::handler constructaccess uname = $uname domain = $udom");
     unless (($uname) && ($udom)) {
 	$r->log_reason($uname.' at '.$udom.
-		       ' trying to manipulate file '.$ENV{'form.filename'}.
+		       ' trying to manipulate file '.$env{'form.filename'}.
 		       ' ('.$fn.') - not authorized', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
@@ -1213,61 +1455,85 @@ sub handler {
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
 
-    if ( ($ENV{'form.action'} eq 'newdir') && ($ENV{'form.phase'} eq 'two') && ( ($ENV{'form.callingmode'} eq 'testbank') || ($ENV{'form.callingmode'} eq 'imsimport') ) ) {
-	my $newdirname = $ENV{'form.newfilename'};
-	$r->print('<html><head><title>LON-CAPA Construction Space</title><script language="Javascript">');
-	$r->print(qq|
+    my (%loaditem,$js);
+
+    if ( ($env{'form.action'} eq 'newdir') && ($env{'form.phase'} eq 'two') && ( ($env{'form.callingmode'} eq 'testbank') || ($env{'form.callingmode'} eq 'imsimport') ) ) {
+	my $newdirname = $env{'form.newfilename'};
+	$js = qq|
+<script type="text/javascript">
 function writeDone() {
-    var winName = window.opener
     window.focus();
-    winName.document.dataForm.newdir.value = "$newdirname"
-    setTimeout("self.close()",10000)
+    opener.document.info.newdir.value = "$newdirname";
+    setTimeout("self.close()",10000);
 }
   </script>
-  </head>|);
-	my $loaditem = 'onLoad="writeDone()"';
-	$r->print(&Apache::loncommon::bodytag('Construction Space File Operation','',$loaditem));
-    } else {
-	$r->print('<html><head><title>LON-CAPA Construction Space</title></head>');
-	$r->print(&Apache::loncommon::bodytag('Construction Space File Operation'));
+|;
+	$loaditem{'onload'} = "writeDone()";
     }
-
+    
+    # Breadcrumbs
+    &Apache::lonhtmlcommon::clear_breadcrumbs();
+    &Apache::lonhtmlcommon::add_breadcrumb({
+        'text'  => 'Construction Space',
+        'href'  => &Apache::loncommon::authorspace(),
+    });
+    &Apache::lonhtmlcommon::add_breadcrumb({
+        'text'  => 'File Operation',
+        'title' => 'Construction Space File Operation',
+        'href'  => '',
+    });
+
+    $r->print(&Apache::loncommon::start_page('Construction Space File Operation',
+					     $js,
+					     {'add_entries' => \%loaditem,})
+             .&Apache::lonhtmlcommon::breadcrumbs()
+             .&Apache::loncommon::head_subbox(
+                  &Apache::loncommon::CSTR_pageheader())
+    );
   
     $r->print('<h3>'.&mt('Location').': '.&display($fn).'</h3>');
   
-    if (($uname ne $ENV{'user.name'}) || ($udom ne $ENV{'user.domain'})) {
-	$r->print('<h3><font color="red">'.&mt('Co-Author').': '.$uname.' at '.$udom.
-		  '</font></h3>');
+    if (($uname ne $env{'user.name'}) || ($udom ne $env{'user.domain'})) {
+        $r->print('<p class="LC_info">'
+                 .&mt('Co-Author [_1]',$uname.':'.$udom)
+                 .'</p>'
+        );
     }
 
 
-    &Debug($r, "loncfile::handler Form action is $ENV{'form.action'} ");
-    if ($ENV{'form.action'} eq 'delete') {
+    &Debug($r, "loncfile::handler Form action is $env{'form.action'} ");
+    if ($env{'form.action'} eq 'delete') {
       	$r->print('<h3>'.&mt('Delete').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'rename') {
+    } elsif ($env{'form.action'} eq 'rename') {
 	$r->print('<h3>'.&mt('Rename').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'move') {
+    } elsif ($env{'form.action'} eq 'move') {
 	$r->print('<h3>'.&mt('Move').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'newdir') {
+    } elsif ($env{'form.action'} eq 'newdir') {
 	$r->print('<h3>'.&mt('New Directory').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'decompress') {
+    } elsif ($env{'form.action'} eq 'decompress') {
 	$r->print('<h3>'.&mt('Decompress').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'copy') {
+    } elsif ($env{'form.action'} eq 'copy') {
 	$r->print('<h3>'.&mt('Copy').'</h3>');
-    } elsif ($ENV{'form.action'} eq 'newfile' ||
-	     $ENV{'form.action'} eq 'newhtmlfile' ||
-	     $ENV{'form.action'} eq 'newproblemfile' ||
-	     $ENV{'form.action'} eq 'newpagefile' ||
-	     $ENV{'form.action'} eq 'newsequencefile' ||
-	     $ENV{'form.action'} eq 'newrightsfile' ||
-	     $ENV{'form.action'} eq 'newstyfile' ||
-	     $ENV{'form.action'} eq 'Select Action' ) {
+    } elsif ($env{'form.action'} eq 'newfile' ||
+	     $env{'form.action'} eq 'newhtmlfile' ||
+	     $env{'form.action'} eq 'newproblemfile' ||
+	     $env{'form.action'} eq 'newpagefile' ||
+	     $env{'form.action'} eq 'newsequencefile' ||
+	     $env{'form.action'} eq 'newrightsfile' ||
+	     $env{'form.action'} eq 'newstyfile' ||
+	     $env{'form.action'} eq 'newtaskfile' ||
+             $env{'form.action'} eq 'newlibraryfile' ||
+	     $env{'form.action'} eq 'Select Action' ) {
 	$r->print('<h3>'.&mt('New Resource').'</h3>');
     } else {
-	$r->print('<p>'.&mt('Unknown Action').' '.$ENV{'form.action'}.' </p></body></html>');
+        $r->print('<p class="LC_error">'
+                 .&mt('Unknown Action').' '.$env{'form.action'}
+                 .'</p>'
+                 .&Apache::loncommon::end_page()
+        );
 	return OK;  
     }
-    if ($ENV{'form.phase'} eq 'two') {
+    if ($env{'form.phase'} eq 'two') {
 	&Debug($r, "loncfile::handler  entering phase2");
 	&phasetwo($r,$fn,$uname,$udom);
     } else {
@@ -1275,7 +1541,7 @@ function writeDone() {
 	&phaseone($r,$fn,$uname,$udom);
     }
 
-    $r->print('</body></html>');
+    $r->print(&Apache::loncommon::end_page());
     return OK;  
 }