--- loncom/publisher/loncfile.pm 2003/02/10 23:26:15 1.26 +++ loncom/publisher/loncfile.pm 2003/08/04 17:45:06 1.37 @@ -9,7 +9,7 @@ # and displays a page showing the results of the action. # # -# $Id: loncfile.pm,v 1.26 2003/02/10 23:26:15 albertel Exp $ +# $Id: loncfile.pm,v 1.37 2003/08/04 17:45:06 www Exp $ # # Copyright Michigan State University Board of Trustees # @@ -33,27 +33,6 @@ # # http://www.lon-capa.org/ # -# -# (Handler to retrieve an old version of a file -# -# (Publication Handler -# -# (TeX Content Handler -# -# 05/29/00,05/30,10/11 Gerd Kortemeyer) -# -# 11/28,11/29,11/30,12/01,12/02,12/04,12/23 Gerd Kortemeyer -# 03/23 Guy Albertelli -# 03/24,03/29 Gerd Kortemeyer) -# -# 03/31,04/03,05/02,05/09,06/23,06/24 Gerd Kortemeyer) -# -# 06/23 Gerd Kortemeyer -# 05/07/02 Ron Fox: -# - Added Debug log output so that I can trace what the heck this -# undocumented thingy does. -# 05/28/02 Ron Fox: -# - Started putting in pod in standard format. =pod =head1 NAME @@ -92,6 +71,7 @@ use Apache::Constants qw(:common :http : use Apache::loncacc; use Apache::Log (); use Apache::lonnet; +use Apache::loncommon(); my $DEBUG=0; my $r; # Needs to be global for some stuff RF. @@ -172,12 +152,26 @@ Global References sub URLToPath { my $Url = shift; &Debug($r, "UrlToPath got: $Url"); - $Url=~ s/^http\:\/\/[^\/]+\/\~(\w+)/\/home\/$1\/public_html/; + $Url=~ s/\/+/\//g; $Url=~ s/^http\:\/\/[^\/]+//; + $Url=~ s/^\///; + $Url=~ s/(\~|priv\/)(\w+)\//\/home\/$2\/public_html\//; &Debug($r, "Returning $Url \n"); return $Url; } +sub url { + my $fn=shift; + $fn=~s/^\/home\/(\w+)\/public\_html/\/priv\/$1/; + return $fn; +} + +sub display { + my $fn=shift; + $fn=~s/^\/home\/(\w+)\/public\_html//; + return ''.$fn.''; +} + =pod =item PublicationPath($domain, $user, $dir, $file) @@ -247,41 +241,6 @@ sub ConstructionPath { return '/home/'.$user.'/public_html/'.$dir.'/'.$file; } -=pod - -=item ConstructionPathFromRelative($user, $relname) - - Determines the path to a construction space file given -the username and the path relative to the root of construction space. - -Parameters: - -=over 4 - -=item $user - string [in] Name of the user in whose construction space the - file [will] live. - -=item $relname - string[in] Path to the file relative to the root of the - construction space. - -=back - -Returns: - -=over 4 - -=item string - Full path to the file. - -=back - -=cut - -sub ConstructionPathFromRelative { - - my ($user, $relname) = @_; - return '/home/'.$user.'/public_html'.$relname; - -} =pod @@ -336,8 +295,7 @@ sub exists { } if ( -e $published) { $result.='

Warning: target file exists, and has been published!

'; - } - elsif ( -e $construct) { + } elsif ( -e $construct) { $result.='

Warning: target file exists!

'; } @@ -387,6 +345,34 @@ sub checksuffix { } return $result; } + +sub cleanDest { + my ($request,$dest)=@_; + #remove bad characters + if ($dest=~/[\#\?&]/) { + $request->print("

Invalid characters in requested name have been removed.

"); + $dest=~s/[\#\?&]//g; + } + return $dest; +} + +sub relativeDest { + my ($fn,$newfilename,$uname)=@_; + if ($newfilename=~/^\//) { +# absolute, simply add path + $newfilename='/home/'.$uname.'/public_html/'; + } else { + my $dir=$fn; + $dir=~s/\/[^\/]+$//; + $newfilename=$dir.'/'.$newfilename; + } + $newfilename=~s://+:/:g; # remove duplicate / + while ($newfilename=~m:/\.\./:) { + $newfilename=~ s:/[^/]+/\.\./:/:g; #remove dir/.. + } + return $newfilename; +} + =pod =item CloseForm1($request, $user, $file) @@ -406,14 +392,10 @@ Parameters: =cut sub CloseForm1 { - my ($request, $cancelurl) = @_; - - - &Debug($request, "Cancel url is: ".$cancelurl); + my ($request, $fn) = @_; $request->print('

'); - $request->print('

'); - + $request->print('

'); } @@ -442,9 +424,8 @@ Parameters: =cut sub CloseForm2 { - my ($request, $user, $directory) = @_; - - $request->print('

Done

'); + my ($request, $user, $fn) = @_; + $request->print('

Done

'); } =pod @@ -483,43 +464,41 @@ new filename relative to the current dir =cut sub Rename1 { - my ($request, $filename, $user, $domain, $dir) = @_; - &Debug($request, "Username - ".$user." filename: ".$filename."\n"); - my $conspace = $filename; - - my $cancelurl = "/priv/".$filename; - $cancelurl =~ s/\/home\///; - $cancelurl =~ s/\/public_html//; - - if(-e $conspace) { - if($ENV{'form.newfilename'}) { - my $newfilename = $ENV{'form.newfilename'}; - if ($newfilename =~ m|^[^\.]+$|) { - #no extension add on orignal extension - if ($filename =~ m|/[^\.]*\.([^\.]+)$|) { + my ($request, $user, $domain, $fn, $newfilename) = @_; + + if(-e $fn) { + if($newfilename) { + if ($newfilename =~ m|/[^\.]+$|) { + #no extension add on original extension + if ($fn =~ m|/[^\.]*\.([^\.]+)$|) { $newfilename.='.'.$1; } } - $request->print(&checksuffix($filename, $newfilename)); + $request->print(&checksuffix($fn, $newfilename)); + #renaming a dir, delete the trailing / + #remove last element for current dir + my $dir=$fn; + if ($fn =~ m|/$|) { + $fn =~ s|/$||; + $dir =~ s|/[^/]*$||; + } my $return=&exists($user, $domain, $dir, $newfilename); $request->print($return); if ($return =~/^Error:/) { - $request->print('
Cancel'); + $request->print('
Cancel'); return; } - my $dest=&SimplifyDir($dir,$newfilename); $request->print('

Rename '.$filename. - '
to '. - $dest.'?

'); - &CloseForm1($request, $cancelurl); + '" />

Rename '.&display($fn). + '
to '.&display($newfilename).'?

'); + &CloseForm1($request, $fn); } else { - $request->print('

No new filename specified

'); + $request->print('

No new filename specified.

'); return; } } else { - $request->print('

No such File

'); + $request->print('

No such file: '.&display($fn).'

'); return; } @@ -535,34 +514,29 @@ Parameters: =over 4 -=item $request - Apache Request Object [in] request object for the current +=item $request - Apache Request Object [in] request object for the current request. -=item $user - string [in] Name of session user. +=item $user - string [in] Name of the user initiating the request. +=item $domain - string [in] Domain the initiating user is logged in as -=item $filename - string [in] Name fo the file to be deleted: - Filename is the full filesystem path to the file. +=item $filename - string [in] Source filename. =back =cut sub Delete1 { - my ($request, $user, $filename) = @_; + my ($request, $user, $domain, $fn) = @_; - my $cancelurl = '/priv/'.$filename; - $cancelurl =~ s/\/home\///; - $cancelurl =~ s/\/public_html//; - - - if( -e $filename) { + if( -e $fn) { $request->print(''); - $request->print('

Delete '.$filename.'?

'); - &CloseForm1($request, $cancelurl); + $fn.'"/>'); + $request->print('

Delete '.&display($fn).'?

'); + &CloseForm1($request, $fn); } else { - $request->print('

No Such file: '.$filename.'

'); + $request->print('

No such file: '.&display($fn).'

'); } } @@ -585,9 +559,7 @@ Parameters: =item $domain - string [in] Domain the initiating user is logged in as -=item $dir - string [in] Directory path. - -=item $filename - string [in] Source filename. +=item $fn - string [in] Source filename. =item $newfilename-string [in] Destination filename. @@ -596,62 +568,28 @@ Parameters: =cut sub Copy1 { - my ($request, $user, $domain, $dir, $filename, $newfilename) = @_; + my ($request, $user, $domain, $fn, $newfilename) = @_; - my $cancelurl = "/priv/".$filename; - $cancelurl =~ s/\/home\///; - $cancelurl =~ s/\/public_html//; - - - if(-e $filename) { - $request->print(&checksuffix($filename,$newfilename)); - my $return=&exists($user, $domain, $dir, $newfilename); + if(-e $fn) { + $request->print(&checksuffix($fn,$newfilename)); + my $return=&exists($user, $domain, $fn, $newfilename); $request->print($return); if ($return =~/^Error:/) { - $request->print('
Cancel'); + $request->print('
Cancel'); return; } - my $dest=&SimplifyDir($dir,$newfilename); $request->print('

Copy '.$filename.'
to '. - ''.$dest.'?

'); - &CloseForm1($request, $cancelurl); + $newfilename. + '" />

Copy '.&display($fn).'
to '. + &display($newfilename).'?

'); + &CloseForm1($request, $fn); } else { - $request->print('

No such file '.$filename.'

'); + $request->print('

No such file: '.&display($fn).'

'); } } =pod -=item SimplifyDir - - Removes all extra / and all .. references - -Parameters: - -=over 4 - -=item $dir - string [in] a directory name - -=item $file - string [in] a file reference relative to $dir - -=back - -Results: the concatenated path. - -=cut - -sub SimplifyDir { - my ($dir,$file) = @_; - my $location = $dir. '/'.$file; - $location=~s://+:/:g; # remove duplicate / - while ($location=~m:/\.\./:) {$location=~s:/[^/]+/\.\./:/:g;}#remove dir/.. - return $location; -} - -=pod - =item NewDir1 Does all phase 1 processing of directory creation: @@ -667,7 +605,9 @@ Parameters: =item $username - Name of the user that is requesting the directory creation. -=item $path - current directory relative to construction space. +=item $domain - Domain user is in + +=item $fn - source file. =item $newdir - Name of the directory to be created; path relative to the top level of construction space. @@ -689,24 +629,16 @@ causes the newdir operation to transitio sub NewDir1 { - my ($request, $username, $path, $newdir) = @_; - - my $fullpath = '/home/'.$username.'/public_html/'. - $path.'/'.$newdir; + my ($request, $username, $domain, $fn, $newfilename) = @_; - my $cancelurl = '/priv/'.$username.'/'.$path; - - &Debug($request, "Full path is : ".$fullpath); - - if(-e $fullpath) { + if(-e $newfilename) { $request->print('

Directory exists.

'); } else { $request->print('

Make new directory '. - $path."/".$newdir.'?

'); - &CloseForm1($request, $cancelurl); - + $newfilename.'" />

Make new directory '. + &display($newfilename).'?

'); + &CloseForm1($request, $fn); } } @@ -731,7 +663,7 @@ Parameters: =item $domain - Name of the domain of the user -=item $dir - current absolute diretory +=item $fn - Source file name =item $newfilename - Name of the file to be created; no path information @@ -743,7 +675,7 @@ Side Effects: =item 2 new forms are displayed. Clicking on the confirmation button causes the browser to attempt to load the specfied URL, allowing the -proper handler to take care of file creation. There is also a Cancle +proper handler to take care of file creation. There is also a Cancel button which returns you to the driectory listing you came from =back @@ -752,14 +684,7 @@ button which returns you to the driector sub NewFile1 { - my ($request, $user, $domain, $dir, $newfilename) = @_; - - &Debug($request, "Dir is : ".$dir); - &Debug($request, "Newfile is : ".$newfilename); - - my $cancelurl = "/priv/".$dir; - $cancelurl =~ s/\/home\///; - $cancelurl =~ s/\/public_html//; + my ($request, $user, $domain, $fn, $newfilename) = @_; if ($ENV{'form.action'} =~ /new(.+)file/) { my $extension=$1; @@ -772,23 +697,16 @@ sub NewFile1 { } } - my $fullpath = $dir.'/'.$newfilename; - - &Debug($request, "Full path is : ".$fullpath); - - if(-e $fullpath) { + if(-e $newfilename) { $request->print('

File exists.

'); } else { - $request->print('

Make new file '.$dir.'/'.$newfilename.'?

'); - my $dest=&MakeFinalUrl($request,$fullpath); - &Debug($request, "Cancel url is: ".$cancelurl); - &Debug($request, "Dest url is: ".$dest); + $request->print('

Make new file '.&display($newfilename).'?

'); $request->print(''); - $request->print('

'); - $request->print('

'); + $request->print('

'); + $request->print('

'); } } @@ -823,46 +741,36 @@ performed and reported to the user. sub phaseone { my ($r,$fn,$uname,$udom)=@_; - $fn=~m:(.*)/([^/]+)\.(\w+)$:; - my $dir=$1; - my $main=$2; - my $suffix=$3; - - # my $conspace=ConstructionPathFromRelative($uname, $fn); - - + my $newfilename=&cleanDest($r,$ENV{'form.newfilename'}); + $newfilename=&relativeDest($fn,$newfilename,$uname); + $r->print('
'. - ''. - ''. - ''); + ''. + ''. + ''); if ($ENV{'form.action'} eq 'rename') { - - &Rename1($r, $fn, $uname, $udom, $dir); - + &Rename1($r, $uname, $udom, $fn, $newfilename); } elsif ($ENV{'form.action'} eq 'delete') { - - &Delete1($r, $uname, $fn); - + &Delete1($r, $uname, $udom, $fn); } elsif ($ENV{'form.action'} eq 'copy') { - if($ENV{'form.newfilename'}) { - my $newfilename = $ENV{'form.newfilename'}; - &Copy1($r, $uname, $udom, $dir, $fn, $newfilename); - }else { - $r->print('

No new filename specified.

'); - } + if($newfilename) { + &Copy1($r, $uname, $udom, $fn, $newfilename); + } else { + $r->print('

No new filename specified.

'); + } } elsif ($ENV{'form.action'} eq 'newdir') { - &NewDir1($r, $uname, $dir, $ENV{'form.newfilename'}); + &NewDir1($r, $uname, $udom, $fn, $newfilename); } elsif ($ENV{'form.action'} eq 'newfile' || $ENV{'form.action'} eq 'newhtmlfile' || - $ENV{'form.action'} eq 'newproblemfile') { - if($ENV{'form.newfilename'}) { - my $newfilename = $ENV{'form.newfilename'}; - if (!defined($dir)) { - $fn=~m:(.*)/:; - $dir=$1; - } - &NewFile1($r, $uname, $udom, $dir, $newfilename); + $ENV{'form.action'} eq 'newproblemfile' || + $ENV{'form.action'} eq 'newpagefile' || + $ENV{'form.action'} eq 'newsequencefile' || + $ENV{'form.action'} eq 'newrightsfile' || + $ENV{'form.action'} eq 'newstyfile' || + $ENV{'form.action'} eq 'Select Action') { + if ($newfilename) { + &NewFile1($r, $uname, $udom, $fn, $newfilename); } else { $r->print('

No new filename specified.

'); } @@ -913,8 +821,19 @@ sub Rename2 { $newfile); if(-e $oldfile) { - unless(rename($oldfile, - $directory.'/'.$newfile)) { + my $dest; + + if ($oldfile =~ m|/$|) { + #renaming a dir + $oldfile =~ s|/$||; + $dest=$directory; + $dest=~s|(/)([^/]*)$|$1|; + $dest.='/'.$newfile; + } else { + $dest=$directory.'/'.$newfile; + } + + unless(rename($oldfile,$dest)) { $request->print('Error: '.$!.''); return 0; } else {} @@ -1092,11 +1011,16 @@ sub phasetwo { # Break down the file into it's component pieces. - $fn=~/(.*)\/([^\/]+)\.(\w+)$/; - my $dir=$1; # Directory path - my $main=$2; # Filename. - my $suffix=$3; # Extension. - + my $dir; # Directory path + my $main; # Filename. + my $suffix; # Extension. + + if ($fn=~m:(.*)/([^/]+)\.(\w+)$:) { + $dir=$1; # Directory path + $main=$2; # Filename. + $suffix=$3; # Extension. + } + my $dest; # On success this is where we'll go. &Debug($r, @@ -1116,12 +1040,19 @@ sub phasetwo { if ($ENV{'form.action'} eq 'rename') { # Rename. if($ENV{'form.newfilename'}) { + if (!defined($dir)) { + $fn=~m:^(.*)/:; + $dir=$1; + } if(!&Rename2($r, $uname, $dir, $fn, $ENV{'form.newfilename'})) { return; } # Prepend the directory to the new name to form the basis of the # url of the new resource. # + #renaming a dir + #remove last element for current dir + if ($fn =~ m|/$|) { $dir =~ s|/[^/]*$||; } $dest = $dir."/".$ENV{'form.newfilename'}; } } elsif ($ENV{'form.action'} eq 'delete') { @@ -1187,17 +1118,18 @@ sub handler { &Debug($r, "loncfile.pm - handler entered"); &Debug($r, " filename: ".$ENV{'form.filename'}); &Debug($r, " newfilename: ".$ENV{'form.newfilename'}); - +# +# Determine the root filename +# This could come in as "filename", which actually is a URL, or +# as "qualifiedfilename", which is indeed a real filename in filesystem +# my $fn; if ($ENV{'form.filename'}) { $fn=&Apache::lonnet::unescape($ENV{'form.filename'}); - &Debug($r, "loncfile::handler - raw url: $fn"); -# $fn=~s/^http\:\/\/[^\/]+\/\~(\w+)/\/home\/$1\/public_html/; -# $fn=~s/^http\:\/\/[^\/]+//; - $fn=URLToPath($fn); - &Debug($r, "loncfile::handler - doctored url: $fn"); - + $fn=&URLToPath($fn); + } elsif ($ENV{'form.qualifiedfilename'}) { + $fn=$ENV{'form.qualifiedfilename'}; } else { &Debug($r, "loncfile::handler - no form.filename"); $r->log_reason($ENV{'user.name'}.' at '.$ENV{'user.domain'}. @@ -1228,19 +1160,16 @@ sub handler { return HTTP_NOT_ACCEPTABLE; } - $fn=~s/\/\~(\w+)//; - &Debug($r, "loncfile::handler ~ removed filename: $fn"); $r->content_type('text/html'); $r->send_http_header; $r->print('LON-CAPA Construction Space'); - $r->print( - ''); + $r->print(&Apache::loncommon::bodytag('Construction Space File Operation')); - $r->print('

Construction Space '.$fn.'

'); + $r->print('

Location: '.&display($fn).'

'); if (($uname ne $ENV{'user.name'}) || ($udom ne $ENV{'user.domain'})) { $r->print('

Co-Author: '.$uname.' at '.$udom. @@ -1260,10 +1189,15 @@ sub handler { $r->print('

Copy

'); } elsif ($ENV{'form.action'} eq 'newfile' || $ENV{'form.action'} eq 'newhtmlfile' || - $ENV{'form.action'} eq 'newproblemfile') { + $ENV{'form.action'} eq 'newproblemfile' || + $ENV{'form.action'} eq 'newpagefile' || + $ENV{'form.action'} eq 'newsequencefile' || + $ENV{'form.action'} eq 'newrightsfile' || + $ENV{'form.action'} eq 'newstyfile' || + $ENV{'form.action'} eq 'Select Action' ) { $r->print('

New Resource

'); } else { - $r->print('

Unknown Action

'); + $r->print('

Unknown Action '.$ENV{'form.action'}.'

'); return OK; } if ($ENV{'form.phase'} eq 'two') {