--- loncom/publisher/loncleanup.pm	2008/12/24 07:58:34	1.10
+++ loncom/publisher/loncleanup.pm	2013/06/04 22:20:16	1.20
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to cleanup XML files
 #
-# $Id: loncleanup.pm,v 1.10 2008/12/24 07:58:34 raeburn Exp $
+# $Id: loncleanup.pm,v 1.20 2013/06/04 22:20:16 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -34,12 +34,13 @@ use strict;
 use Apache::File;
 use File::Copy;
 use Apache::Constants qw(:common :http :methods);
-use Apache::loncacc;
 use Apache::loncommon();
+use Apache::lonhtmlcommon();
 use Apache::lonlocal;
 use Apache::lonnet;
 use lib '/home/httpd/lib/perl/';
 use LONCAPA;
+use HTML::Entities();
  
 
 sub latextrans {
@@ -248,35 +249,81 @@ sub htmlclean {
 
 sub phaseone {
     my ($r,$fn,$uname,$udom)=@_;
-    $r->print(&mt('Select actions to attempt:').
-	      '<br /><input type="checkbox" name="linefeed" checked="checked" /> '.
-	      &mt('Linefeeds, formfeeds, and carriage returns').
-	      '<br /><input type="checkbox" name="empty" checked="checked" /> '.
-	      &mt('Empty tags').
-	      '<br /><input type="checkbox" name="lower" checked="checked" /> '.
-	      &mt('Lower casing').
-	      '<br /><input type="checkbox" name="symbol"checked="checked" /> '.
-	      &mt('Symbol font').
-	      '<input type="hidden" name="phase" value="two" />'.
-	      '<p><input type="submit" value="'.&mt('Cleanup').'" /></p>');
+    $r->print(
+        &Apache::lonhtmlcommon::start_pick_box()
+       .&Apache::lonhtmlcommon::row_title(&mt('Select actions to attempt'))
+       .'<label>'
+       .'<input type="checkbox" name="linefeed" checked="checked" /> '
+       .&mt('Linefeeds, formfeeds, and carriage returns')
+       .'</label><br />'
+       .'<label>'
+       .'<input type="checkbox" name="empty" checked="checked" /> '
+       .&mt('Empty tags')
+       .'</label><br />'
+       .'<label>'
+       .'<input type="checkbox" name="lower" checked="checked" /> '
+       .&mt('Lower casing')
+       .'</label><br />'
+       .'<label>'
+       .'<input type="checkbox" name="symbol" checked="checked" /> '
+       .&mt('Symbol font')
+       .'</label>'
+       .&Apache::lonhtmlcommon::row_closure(1)
+       .&Apache::lonhtmlcommon::end_pick_box()
+    );
+
+    $r->print(
+        '<input type="hidden" name="phase" value="two" />'
+       .'<p>'
+       .'<input type="submit" value="'.&mt('Next').'" />'
+       .'</p>'
+    );
 }
 
 sub phasetwo {
+    # Check original file
     my ($r,$fn,$uname,$udom)=@_;
-    open(IN,'/home/'.$uname.'/public_html/'.$fn);
     my $text='';
-    while (my $line=<IN>) {
-	$text.=$line;
+    my $londocroot = $r->dir_config('lonDocRoot');
+    if (open(IN,"<$londocroot/priv/$udom/$uname".$fn)) {
+        while (my $line=<IN>) {
+	    $text.=$line;
+        }
+        close(IN);
+    }
+    # Check if any selection was made
+    if ($env{'form.linefeed'} ne 'on' &&
+        $env{'form.empty'} ne 'on' &&
+        $env{'form.lower'} ne 'on' &&
+        $env{'form.symbol'} ne 'on') {
+        $r->print(
+            '<p class="LC_warning">'
+           .&mt('Please select at least one option.')
+           .'</p>'
+           .'<p><a href="javascript:history.back();">'.&mt('Back').'</p>'
+        );
+        return;
     }
-    close(IN);
-    my $uri='/~'.$uname.$fn;
+
+    my $uri="/priv/$udom/$uname".$fn;
     my $result=&Apache::lonnet::ssi_body($uri,
 					 ('grade_target'=>'web',
 					  'return_only_error_and_warning_counts' => 1));
     my ($errorcount,$warningcount)=split(':',$result);
-    $r->print(&mt('Original file').': '.
-	      $errorcount.' '.&mt('error(s)').', '.
-	      $warningcount.' '.&mt('warning(s)'));
+
+    # Display results for original file
+    $r->print(
+        &Apache::lonhtmlcommon::start_pick_box()
+       .&Apache::lonhtmlcommon::row_title(&mt('Original file'))
+       .&Apache::lonhtmlcommon::confirm_success(
+           &mt('[quant,_1,error]',$errorcount), $errorcount)
+       .'<br />'
+       .&Apache::lonhtmlcommon::confirm_success(
+           &mt('[quant,_1,warning]',$warningcount), $warningcount)
+       .&Apache::lonhtmlcommon::row_closure()
+    );
+
+    # Clean up file
     $text=&htmlclean($text,1,
                ($env{'form.linefeed'} ne 'on'),
                ($env{'form.empty'} ne 'on'),
@@ -284,42 +331,79 @@ sub phasetwo {
                ($env{'form.symbol'} ne 'on'));
     my ($main,$ext)=($fn=~/^(.*)\.(\w+)/);
     my $newfn=$main.'_Auto_Cleaned_Up.'.$ext;
-    open(OUT,'>/home/'.$uname.'/public_html'.$newfn);
-    print OUT $text;
-    close(OUT);
-    my $newuri='/~'.$uname.$newfn;
+    if (open(OUT,">$londocroot/priv/$udom/$uname".$newfn)) {
+        print OUT $text;
+        close(OUT);
+    }
+    my $newuri="/priv/$udom/$uname".$newfn;
     $result=&Apache::lonnet::ssi_body($newuri,
-					 ('grade_target'=>'web',
-					  'return_only_error_and_warning_counts' => 1));
+                                         ('grade_target'=>'web',
+                                          'return_only_error_and_warning_counts' => 1));
     ($errorcount,$warningcount)=split(':',$result);
-    $r->print('<br />'.&mt('Cleaned up file').': '.
-	      $errorcount.' '.&mt('error(s)').', '.
-	      $warningcount.' '.&mt('warning(s)').
-              '<br /><a href="'.$newuri.'" target="prev">'.
-	      &mt('Open (and edit) cleaned up file in new window').'</a>'.
-              '<br /><a href="/adm/diff?filename='.&escape($uri).
-	      '&versionone=priv&filetwo='.
-	      &escape($newuri).'" target="prev">'.
-	      &mt('Show diffs in new window').'</a><br />'.
-	      '<input type="hidden" name="phase" value="three" />'.
-	      '<input type="submit" name="accept" value="'.&mt('Accept Result').'" />'.
-	      '<input type="submit" name="reject" value="'.&mt('Reject Result').'" />'
-	      );
+
+    # Display results for cleaned up file
+    $r->print(
+        &Apache::lonhtmlcommon::row_title(&mt('Cleaned up file'))
+       .&Apache::lonhtmlcommon::confirm_success(
+           &mt('[quant,_1,error]',$errorcount), $errorcount)
+       .'<br />'
+       .&Apache::lonhtmlcommon::confirm_success(
+           &mt('[quant,_1,warning]',$warningcount), $warningcount)
+       .&Apache::lonhtmlcommon::row_closure()
+    );
+
+    # Display actions
+    $r->print(
+        &Apache::lonhtmlcommon::row_title(&mt('Actions'))
+       .'<ul>'
+       .'<li><a href="'.$newuri.'" target="prev">'
+       .&mt('Open (and edit) cleaned up file in new window')
+       .'</a></li>'
+       .'<li><a href="'
+       .&HTML::Entities::encode(
+            '/adm/diff?filename='.&escape($uri)
+           .'&versionone=priv&filetwo='.&escape($newuri))
+       .'" target="prev">'
+       .&mt('Show diffs in new window')
+       .'</a></li>'
+       .'</ul>'
+       .&Apache::lonhtmlcommon::row_closure(1)
+       .&Apache::lonhtmlcommon::end_pick_box()
+       .'<p>'
+       .'<input type="hidden" name="phase" value="three" />'
+       .'<input type="submit" name="accept" value="'
+       .&mt('Clean Up').'" />'
+       .' <input type="submit" name="reject" value="'
+       .&mt('Cancel').'" />'
+       .'</p>'
+    );
 }
 
 sub phasethree {
     my ($r,$fn,$uname,$udom)=@_;
-    my $old='/home/'.$uname.'/public_html/'.$fn;
+    my $old=$r->dir_config('lonDocRoot')."/priv/$udom/$uname".$fn;
     my ($main,$ext)=($fn=~/^(.*)\.(\w+)/);
     my $newfn=$main.'_Auto_Cleaned_Up.'.$ext;
-    my $new='/home/'.$uname.'/public_html'.$newfn;
+    my $new=$r->dir_config('lonDocRoot')."/priv/$udom/$uname".$newfn;
     if ($env{'form.accept'}) {
-	$r->print(&mt('Accepting changes'));
+        $r->print(
+        '<p class="LC_info">'
+       .&mt('Accepting changes...')
+       .'</p>'
+    );
         move($new,$old);
     } else {
-	$r->print(&mt('Rejeting changes'));
+        $r->print(
+        '<p class="LC_info">'
+       .&mt('Rejecting changes...')
+       .'</p>'
+        );
         unlink($new);
     }
+    $r->print(
+        '<p>'
+       .&Apache::lonhtmlcommon::confirm_success(&mt('Done')));
+        '</p>'
 }
 
 # ---------------------------------------------------------------- Main Handler
@@ -335,7 +419,7 @@ sub handler {
 
     if ($env{'form.filename'}) {
 	$fn=$env{'form.filename'};
-	$fn=~s/^https?\:\/\/[^\/]+//;
+	$fn=~s{^https?\://[^/]+}{};
     } else {
 	$r->log_reason($env{'user.name'}.' at '.$env{'user.domain'}.
 		       ' unspecified filename for cleanup', $r->filename); 
@@ -352,8 +436,7 @@ sub handler {
     my $uname;
     my $udom;
 
-    ($uname,$udom)=
-	&Apache::loncacc::constructaccess($fn,$r->dir_config('lonDefDomain'));
+    ($uname,$udom)=&Apache::lonnet::constructaccess($fn);
     unless (($uname) && ($udom)) {
 	$r->log_reason($uname.' at '.$udom.
 		       ' trying to cleanup file '.$env{'form.filename'}.
@@ -362,17 +445,25 @@ sub handler {
 	return HTTP_NOT_ACCEPTABLE;
     }
 
-    $fn=~s{/~($LONCAPA::username_re)}{};
-
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
 
-    $r->print(&Apache::loncommon::start_page('Cleanup XML Document'));
+    # Breadcrumbs
+    my $brcrum = [{'href' => &Apache::loncommon::authorspace($fn),
+                   'text' => 'Authoring Space'},
+                  {'href' => '',
+                   'text' => 'Cleanup XML Document'}];
+
+    $fn=~s{^/priv/$LONCAPA::domain_re/$LONCAPA::username_re}{};
+
+    $r->print(&Apache::loncommon::start_page('Cleanup XML Document',
+                                             undef,
+                                             {'bread_crumbs' => $brcrum,}));
     $r->print('<h2>'.$fn.'</h2>'.
               '<form action="/adm/cleanup" method="post">'.
               '<input type="hidden" name="filename" value="'.$env{'form.filename'}.'" />');
     unless ($fn=~/\.(problem|exam|quiz|assess|survey|form|library|xml|html|htm|xhtml|xhtm|sty)$/) {
-	$r->print(&mt('Cannot cleanup this filetype'));
+	$r->print('<p class="LC_warning">'.&mt('Cannot cleanup this filetype').'</p>');
     } else {
 	if ($env{'form.phase'} eq 'three') {
 	    &phasethree($r,$fn,$uname,$udom);
@@ -383,11 +474,17 @@ sub handler {
 	}
     }
     my $dir=$fn;
-    $dir=~s/\/[^\/]+$/\//;
-    $r->print('</form>'.
-	      '<br /><a href="/priv/'.$uname.'/'.$fn.'">'.&mt('Back to Source File').'</a>'.
-              '<br /><a href="/priv/'.$uname.'/'.$dir.'">'.&mt('Back to Source Directory').'</a>'.
-	      &Apache::loncommon::end_page());
+    $dir=~s{[^/]+$}{};
+    $r->print(
+        '</form>'
+       .&Apache::lonhtmlcommon::actionbox(
+            ['<a href="/priv/'.$udom.'/'.$uname.$fn.'">'.
+                 &mt('Back to Source File').'</a>',
+            '<a href="/priv/'.$udom.'/'.$uname.$dir.'">'.
+                &mt('Back to Source Directory').'</a>'])
+       .&Apache::loncommon::end_page()
+    );
+
     return OK;  
 }