--- loncom/publisher/lonpublisher.pm	2004/01/20 22:52:17	1.162
+++ loncom/publisher/lonpublisher.pm	2005/03/10 03:50:49	1.188
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Publication Handler
 #
-# $Id: lonpublisher.pm,v 1.162 2004/01/20 22:52:17 albertel Exp $
+# $Id: lonpublisher.pm,v 1.188 2005/03/10 03:50:49 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -126,7 +126,7 @@ use Apache::loncommon();
 use Apache::lonmysql;
 use Apache::lonlocal;
 use Apache::loncfile;
-use Apache::lonmeta;
+use LONCAPA::lonmetadata;
 use Apache::lonmsg;
 use vars qw(%metadatafields %metadatakeys);
 
@@ -138,6 +138,9 @@ my $docroot;
 my $cuname;
 my $cudom;
 
+my $registered_cleanup;
+my $modified_urls;
+
 =pod
 
 =item B<metaeval>
@@ -199,7 +202,8 @@ sub metaeval {
 		}
 	    }
 	    my $newentry=$parser->get_text('/'.$entry);
-	    if ($entry eq 'customdistributionfile') {
+	    if (($entry eq 'customdistributionfile') ||
+		($entry eq 'sourcerights')) {
 		$newentry=~s/^\s*//;
 		if ($newentry !~m|^/res|) { $newentry=$prefix.$newentry; }
 	    }
@@ -322,13 +326,30 @@ sub textfield {
     $value=~s/\s+$//gs;
     $value=~s/\s+/ /gs;
     $title=&mt($title);
+    $ENV{'form.'.$name}=$value;
     return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
            "</b></font></p><br />".
            '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />';
 }
 
+sub text_with_browse_field {
+    my ($title,$name,$value,$restriction)=@_;
+    $value=~s/^\s+//gs;
+    $value=~s/\s+$//gs;
+    $value=~s/\s+/ /gs;
+    $title=&mt($title);
+    $ENV{'form.'.$name}=$value;
+    return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
+           "</b></font></p><br />".
+           '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />'.
+	   '<a href="javascript:openbrowser(\'pubform\',\''.$name.'\',\''.$restriction.'\');">Select</a>&nbsp;'.
+	   '<a href="javascript:opensearcher(\'pubform\',\''.$name.'\');">Search</a>';
+	   
+}
+
 sub hiddenfield {
     my ($name,$value)=@_;
+    $ENV{'form.'.$name}=$value;
     return "\n".'<input type="hidden" name="'.$name.'" value="'.$value.'" />';
 }
 
@@ -336,6 +357,11 @@ sub selectbox {
     my ($title,$name,$value,$functionref,@idlist)=@_;
     $title=&mt($title);
     $value=(split(/\s*,\s*/,$value))[-1];
+    if (defined($value)) {
+	$ENV{'form.'.$name}=$value;
+    } else {
+	$ENV{'form.'.$name}=$idlist[0];
+    }
     my $selout="\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
 	'</b></font></p><br /><select name="'.$name.'">';
     foreach (@idlist) {
@@ -348,6 +374,12 @@ sub selectbox {
     return $selout.'</select>';
 }
 
+sub select_level_form {
+    my ($value,$name)=@_;
+    $ENV{'form.'.$name}=$value;
+    if (!defined($value)) { $ENV{'form.'.$name}=0; }
+    return  &Apache::loncommon::select_level_form($value,$name);
+}
 #########################################
 #########################################
 
@@ -458,7 +490,8 @@ sub get_subscribed_hosts {
     while ($filename=readdir(DIR)) {
 	if ($filename=~/\Q$srcf\E\.(\w+)$/) {
 	    my $subhost=$1;
-	    if (($subhost ne 'meta' && $subhost ne 'subscription') &&
+	    if (($subhost ne 'meta' && $subhost ne 'subscription' &&
+		 $subhost ne 'tmp') &&
                 ($subhost ne $Apache::lonnet::perlvar{'lonHostID'})) {
 		push(@subscribed,$subhost);
 	    }
@@ -515,7 +548,8 @@ sub get_max_ids_indices {
 	    my $counter;
 	    if ($counter=$addid{$token->[1]}) {
 		if ($counter eq 'id') {
-		    if (defined($token->[2]->{'id'})) {
+		    if (defined($token->[2]->{'id'}) &&
+			$token->[2]->{'id'} !~ /^\s*$/) {
 			$maxid=($token->[2]->{'id'}>$maxid)?$token->[2]->{'id'}:$maxid;
 			if (exists($allids{$token->[2]->{'id'}})) {
 			    $duplicateids=1;
@@ -527,7 +561,8 @@ sub get_max_ids_indices {
 			$needsfixup=1;
 		    }
 		} else {
-		    if (defined($token->[2]->{'index'})) {
+		    if (defined($token->[2]->{'index'}) &&
+			$token->[2]->{'index'} !~ /^\s*$/) {
 			$maxindex=($token->[2]->{'index'}>$maxindex)?$token->[2]->{'index'}:$maxindex;
 		    } else {
 			$needsfixup=1;
@@ -569,11 +604,11 @@ sub get_all_text_unbalanced {
 	} elsif ($token->[0] eq 'E')  {
 	    $result.=$token->[2];
 	}
-	if ($result =~ /(.*)\Q$tag\E(.*)/s) {
+	if ($result =~ /\Q$tag\E/s) {
+	    ($result,my $redo)=$result =~ /(.*)\Q$tag\E(.*)/is;
 	    #&Apache::lonnet::logthis('Got a winner with leftovers ::'.$2);
 	    #&Apache::lonnet::logthis('Result is :'.$1);
-	    $result=$1;
-	    my $redo=$tag.$2;
+	    $redo=$tag.$redo;
 	    push (@$pars,HTML::LCParser->new(\$redo));
 	    $$pars[-1]->xml_mode('1');
 	    last;
@@ -641,13 +676,15 @@ sub fix_ids_and_indices {
 		if (!$counter) { $counter=$addid{$lctag}; }
 		if ($counter) {
 		    if ($counter eq 'id') {
-			unless (defined($parms{'id'})) {
+			unless (defined($parms{'id'}) &&
+				$parms{'id'}!~/^\s*$/) {
 			    $maxid++;
 			    $parms{'id'}=$maxid;
 			    print $logfile 'ID: '.$tag.':'.$maxid."\n";
 			}
 		    } elsif ($counter eq 'index') {
-			unless (defined($parms{'index'})) {
+			unless (defined($parms{'index'}) &&
+				$parms{'index'}!~/^\s*$/) {
 			    $maxindex++;
 			    $parms{'index'}=$maxindex;
 			    print $logfile 'Index: '.$tag.':'.$maxindex."\n";
@@ -788,55 +825,55 @@ sub store_metadata {
         &Apache::lonnet::logthis($error);
         return ($error,undef);
     }
+    my $dbh = &Apache::lonmysql::get_dbh();
     if (($metadata{'obsolete'}) || ($metadata{'copyright'} eq 'priv') ||
 	($metadata{'copyright'} eq 'custom')) {
-# remove this entry
-	$status=&Apache::lonmysql::remove_from_table
-	    ('metadata','url',$metadata{'url'});
+        # remove this entry
+	$status=&LONCAPA::lonmetadata::delete_metadata($dbh,undef,
+                                                       $metadata{'url'});
     } else {
-# store new data
-# adjust some values to metadatadatabase (e.g., "usage" is a reserved word)
-	$metadata{'creationdate'}=
-	    &Apache::lonmysql::sqltime($metadata{'creationdate'}); 
-	$metadata{'lastrevisiondate'}=
-	    &Apache::lonmysql::sqltime($metadata{'lastrevisiondate'});
-	$metadata{'sequsage'}=$metadata{'usage'};
-	$metadata{'sequsage_list'}=$metadata{'usage_list'};
-	my %newmetadata=();
-# see if we have old entries
-	my @oldmeta=&Apache::lonmysql::get_rows('metadata',
-						"url LIKE BINARY '".
-						$metadata{'url'}."'");
-	if ($#oldmeta==0) {
-# yes, there is one old entry, transfer to newmetadata
-	    %newmetadata=&Apache::lonmeta::metadata_col_to_hash(@{$oldmeta[0]});
-# remove old entry
-	    $status=&Apache::lonmysql::remove_from_table
-		('metadata','url',$metadata{'url'});
-	} elsif ($#oldmeta>0) {
-# more than one entry fit - how did that happen?
-	    $error='<font color="red">Error occured retrieving old values in '.
-	      'metadata table in LON-CAPA database: '.$#oldmeta.
-	      ' matches</font>';
-	    &Apache::lonnet::logthis($error);
-	    return ($error,undef);
-	}
-# store new data on top of it
-	foreach (keys %metadata) {
-	    $newmetadata{$_}=$metadata{$_};
-	}
-	$status = &Apache::lonmysql::store_row('metadata',\%newmetadata);
+        $status = &LONCAPA::lonmetadata::update_metadata($dbh,undef,
+                                                         \%metadata);
     }
-    if (! defined($status)) {
+    if (defined($status) && $status ne '') {
         $error='<font color="red">Error occured storing new values in '.
             'metadata table in LON-CAPA database</font>';
         &Apache::lonnet::logthis($error);
+        &Apache::lonnet::logthis($status);
         return ($error,undef);
     }
     return (undef,$status);
 }
 
 
+# ========================================== Parse file for errors and warnings
+
+sub checkonthis {
+    my ($r,$source)=@_;
+    my $uri=&Apache::lonnet::hreflocation($source);
+    $uri=~s/\/$//;
+    my ($errorcount,$warningcount)=split(/:/,
+	       &Apache::lonnet::ssi_body($uri,
+				('return_only_error_and_warning_counts' => 1)));
+    if (($errorcount) || ($warningcount)) {
+        $r->print('<br /><tt>'.$uri.'</tt>: ');
+	if ($errorcount) {
+	    $r->print('<img src="/adm/lonMisc/bomb.gif" /><font color="red"><b>'.
+		      $errorcount.' '.
+		      &mt('error(s)').'</b></font> ');
+	}
+	if ($warningcount) {
+	    $r->print('<font color="blue">'.
+		      $warningcount.' '.
+		      &mt('warning(s)').'</font>');
+	}
+    } else {
+	$r->print('<font color="green">'.&mt('ok').'</font>');
+    }
+    $r->rflush();
+    return ($warningcount,$errorcount);
+}
+
 # ============================================== Parse file itself for metadata
 #
 # parses a file with target meta, sets global %metadatafields %metadatakeys 
@@ -920,11 +957,11 @@ sub publish {
               $allowstr.="\n".'<allow src="'.$thisdep.'" />';
 	   }
            $scrout.='<br />';
-           unless ($thisdep=~/\*/) {
+           if ($thisdep!~/\*/ && $thisdep!~m|^/adm/|) {
 	       $scrout.='<a href="'.$thisdep.'">';
            }
            $scrout.='<tt>'.$thisdep.'</tt>';
-           unless ($thisdep=~/\*/) {
+           if ($thisdep!~/\*/ && $thisdep!~m|^/adm/|) {
 	       $scrout.='</a>';
                if (
        &Apache::lonnet::getfile($Apache::lonnet::perlvar{'lonDocRoot'}.'/'.
@@ -943,13 +980,8 @@ sub publish {
 	       }
            }
         }
-        $outstring=~s/\n*(\<\/[^\>]+\>)\s*$/$allowstr\n$1\n/s;
+        $outstring=~s/\n*(\<\/[^\>]+\>[^<]*)$/$allowstr\n$1\n/s;
 
-### FIXME: is this really what we want?
-# I dont' think so, to will corrupt any UTF-8 resources at least, 
-# and any encoding other than ISO-8859-1 will probably break
-	#Encode any High ASCII characters
-	#$outstring=&HTML::Entities::encode($outstring,"\200-\377");
 # ------------------------------------------------------------- Write modified.
 
         {
@@ -1007,6 +1039,7 @@ sub publish {
             $scrout.=&metaread($logfile,$currentpath.'default.meta',$prefix);
 	    $prefix=~s|^\.\./||;
         }
+
 # ----------------------------------------------------------- Parse file itself
 # read %metadatafields from file itself
  
@@ -1094,32 +1127,40 @@ sub publish {
     }
 
             
-    foreach (split(/\W+/,$metadatafields{'keywords'})) {
-	$keywords{$_}=1;
+    foreach my $addkey (split(/[\"\'\,\;]/,$metadatafields{'keywords'})) {
+	$addkey=~s/\s+/ /g;
+	$addkey=~s/^\s//;
+	$addkey=~s/\s$//;
+	if ($addkey=~/\w/) {
+	    $keywords{$addkey}=1;
+	}
     }
 # --------------------------------------------------- Now we also have keywords
 # =============================================================================
-# INTERACTIVE MODE
-#
-    unless ($batch) {
-        $scrout.=
-	    '<form name="pubform" action="/adm/publish" method="post">'.
-            '<p><input type="submit" value="'.&mt('Finalize Publication').'" /></p>'.
-            &hiddenfield('phase','two').
-            &hiddenfield('filename',$ENV{'form.filename'}).
-	    &hiddenfield('allmeta',&Apache::lonnet::escape($allmeta)).
-            &hiddenfield('dependencies',join(',',keys %allow)).
-            &textfield('Title','title',$metadatafields{'title'}).
-            &textfield('Author(s)','author',$metadatafields{'author'}).
-	    &textfield('Subject','subject',$metadatafields{'subject'});
+# interactive mode html goes into $intr_scrout
+# batch mode throws away this HTML
+# additionally all of the field functions have a by product of setting
+#   $ENV{'from.'..} so that it can be used by the phase two handler in
+#    batch mode
+
+    my $intr_scrout.=
+	'<form name="pubform" action="/adm/publish" method="post">'.
+	'<p><input type="submit" value="'.&mt('Finalize Publication').'" /></p>'.
+	&hiddenfield('phase','two').
+	&hiddenfield('filename',$ENV{'form.filename'}).
+	&hiddenfield('allmeta',&Apache::lonnet::escape($allmeta)).
+	&hiddenfield('dependencies',join(',',keys %allow)).
+	&textfield('Title','title',$metadatafields{'title'}).
+	&textfield('Author(s)','author',$metadatafields{'author'}).
+	&textfield('Subject','subject',$metadatafields{'subject'});
 
 # --------------------------------------------------- Scan content for keywords
 
-        my $keywords_help = Apache::loncommon::help_open_topic("Publishing_Keywords");
-        my $KEYWORDS=&mt('Keywords');
-	my $CheckAll=&mt('check all');
-	my $UncheckAll=&mt('uncheck all');
-	my $keywordout=<<"END";
+    my $keywords_help = Apache::loncommon::help_open_topic("Publishing_Keywords");
+    my $KEYWORDS=&mt('Keywords');
+    my $CheckAll=&mt('check all');
+    my $UncheckAll=&mt('uncheck all');
+    my $keywordout=<<"END";
 <script>
 function checkAll(field) {
     for (i = 0; i < field.length; i++)
@@ -1138,153 +1179,141 @@ function uncheckAll(field) {
 </p>
 <br />
 END
-	$keywordout.='<table border="2"><tr>';
-	my $colcount=0;
+    $keywordout.='<table border="2"><tr>';
+    my $colcount=0;
 
-	foreach (sort keys %keywords) {
-	    $keywordout.='<td><input type="checkbox" name="keywords" value="'.$_.'"';
-	    if ($metadatafields{'keywords'}) {
-		if ($metadatafields{'keywords'}=~/\Q$_\E/) {
-		    $keywordout.=' checked="on"';
-		}
-	    } elsif (&Apache::loncommon::keyword($_)) {
+    foreach (sort keys %keywords) {
+	$keywordout.='<td><label><input type="checkbox" name="keywords" value="'.$_.'"';
+	if ($metadatafields{'keywords'}) {
+	    if ($metadatafields{'keywords'}=~/\Q$_\E/) {
 		$keywordout.=' checked="on"';
+		$ENV{'form.keywords'}.=$_.',';
 	    }
-	    $keywordout.=' />'.$_.'</td>';
-	    if ($colcount>10) {
-		$keywordout.="</tr><tr>\n";
-		$colcount=0;
-	    }
-	    $colcount++;
+	} elsif (&Apache::loncommon::keyword($_)) {
+	    $keywordout.=' checked="on"';
+	    $ENV{'form.keywords'}.=$_.',';
+	}
+	$keywordout.=' />'.$_.'</label></td>';
+	if ($colcount>10) {
+	    $keywordout.="</tr><tr>\n";
+	    $colcount=0;
 	}
+	$colcount++;
+    }
+    $ENV{'form.keywords'}=~s/\,$//;
 
-	$keywordout.='</tr></table>';
+    $keywordout.='</tr></table>';
 
-	$scrout.=$keywordout;
+    $intr_scrout.=$keywordout;
 
-	$scrout.=&textfield('Additional Keywords','addkey','');
+    $intr_scrout.=&textfield('Additional Keywords','addkey','');
 
-	$scrout.=&textfield('Notes','notes',$metadatafields{'notes'});
+    $intr_scrout.=&textfield('Notes','notes',$metadatafields{'notes'});
 
-	$scrout.=
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".&mt('Abstract').":".
-	    "</b></font></p><br />".
-	    '<textarea cols="80" rows="5" name="abstract">'.
-	    $metadatafields{'abstract'}.'</textarea></p>';
+    $intr_scrout.=
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".&mt('Abstract').":".
+	"</b></font></p><br />".
+	'<textarea cols="80" rows="5" name="abstract">'.
+	$metadatafields{'abstract'}.'</textarea></p>';
 
-	$source=~/\.(\w+)$/;
+    $source=~/\.(\w+)$/;
 
 
-	$scrout.=
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
-	    &mt('Lowest Grade Level').':'.
-           "</b></font></p><br />".
-	   &Apache::loncommon::select_level_form($metadatafields{'lowestgradelevel'},'lowestgradelevel').
-	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
-	    &mt('Highest Grade Level').':'.
-           "</b></font></p><br />".
-	   &Apache::loncommon::select_level_form($metadatafields{'highestgradelevel'},'highestgradelevel').
-           &textfield('Standards','standards',$metadatafields{'standards'});
+    $intr_scrout.=
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
+	&mt('Lowest Grade Level').':'.
+	"</b></font></p><br />".
+	&select_level_form($metadatafields{'lowestgradelevel'},'lowestgradelevel').
+	"\n<p><font color=\"#800000\" face=\"helvetica\"><b>".
+	&mt('Highest Grade Level').':'.
+	"</b></font></p><br />".
+	&select_level_form($metadatafields{'highestgradelevel'},'highestgradelevel').
+	&textfield('Standards','standards',$metadatafields{'standards'});
 
 
 
 
-	$scrout.=&hiddenfield('mime',$1);
+    $intr_scrout.=&hiddenfield('mime',$1);
 
-	my $defaultlanguage=$metadatafields{'language'};
-	$defaultlanguage =~ s/\s*notset\s*//g;
-	$defaultlanguage =~ s/^,\s*//g;
-	$defaultlanguage =~ s/,\s*$//g;
+    my $defaultlanguage=$metadatafields{'language'};
+    $defaultlanguage =~ s/\s*notset\s*//g;
+    $defaultlanguage =~ s/^,\s*//g;
+    $defaultlanguage =~ s/,\s*$//g;
 
-	$scrout.=&selectbox('Language','language',
-			    $defaultlanguage,
-			    \&Apache::loncommon::languagedescription,
-			    (&Apache::loncommon::languageids),
-			   );
+    $intr_scrout.=&selectbox('Language','language',
+			     $defaultlanguage,
+			     \&Apache::loncommon::languagedescription,
+			     (&Apache::loncommon::languageids),
+			     );
 
-	unless ($metadatafields{'creationdate'}) {
-	    $metadatafields{'creationdate'}=time;
-	}
-	$scrout.=&hiddenfield('creationdate',
-			      &Apache::lonmysql::unsqltime($metadatafields{'creationdate'}));
+    unless ($metadatafields{'creationdate'}) {
+	$metadatafields{'creationdate'}=time;
+    }
+    $intr_scrout.=&hiddenfield('creationdate',
+			       &Apache::lonmysql::unsqltime($metadatafields{'creationdate'}));
 
-	$scrout.=&hiddenfield('lastrevisiondate',time);
+    $intr_scrout.=&hiddenfield('lastrevisiondate',time);
 
 
-	$scrout.=&textfield('Publisher/Owner','owner',
-			    $metadatafields{'owner'});
+    $intr_scrout.=&textfield('Publisher/Owner','owner',
+			     $metadatafields{'owner'});
 
+# ---------------------------------------------- Retrofix for unused copyright
+    if ($metadatafields{'copyright'} eq 'free') {
+	$metadatafields{'copyright'}='default';
+	$metadatafields{'sourceavail'}='open';
+    }
+# ------------------------------------------------ Dial in reasonable defaults
+    my $defaultoption=$metadatafields{'copyright'};
+    unless ($defaultoption) { $defaultoption='default'; }
+    my $defaultsourceoption=$metadatafields{'sourceavail'};
+    unless ($defaultsourceoption) { $defaultsourceoption='closed'; }
+    unless ($style eq 'prv') {
 # -------------------------------------------------- Correct copyright for rat.
-        my $defaultoption=$metadatafields{'copyright'};
-        unless ($defaultoption) { $defaultoption='default'; }
-	unless ($style eq 'prv') {
-	    if ($style eq 'rat') {
-		if ($metadatafields{'copyright'} eq 'public') { 
-		    delete $metadatafields{'copyright'};
-                    $defaultoption='default';
-		}
-		$scrout.=&selectbox('Copyright/Distribution','copyright',
-				    $defaultoption,
-				    \&Apache::loncommon::copyrightdescription,
+	if ($style eq 'rat') {
+# -------------------------------------- Retrofix for non-applicable copyright
+	    if ($metadatafields{'copyright'} eq 'public') { 
+		delete $metadatafields{'copyright'};
+		$defaultoption='default';
+	    }
+	    $intr_scrout.=&selectbox('Copyright/Distribution','copyright',
+				     $defaultoption,
+				     \&Apache::loncommon::copyrightdescription,
 				    (grep !/^public$/,(&Apache::loncommon::copyrightids)));
-	    } else {
-		$scrout.=&selectbox('Copyright/Distribution','copyright',
-				    $defaultoption,
-				    \&Apache::loncommon::copyrightdescription,
-				    (&Apache::loncommon::copyrightids));
-	    }
-    
-	    my $copyright_help =
-		Apache::loncommon::help_open_topic('Publishing_Copyright');
-	    $scrout =~ s/DISTRIBUTION:/'DISTRIBUTION: ' . $copyright_help/ge;
-	    $scrout.=&textfield('Custom Distribution File','customdistributionfile',
-				$metadatafields{'customdistributionfile'}).
-				    $copyright_help;
-	    my $uctitle=&mt('Obsolete');
-            $scrout.=
-		"\n<p><font color=\"#800000\" face=\"helvetica\"><b>$uctitle:".
-		'</b></font> <input type="checkbox" name="obsolete" ';
-	    if ($metadatafields{'obsolete'}) {
-		$scrout.=' checked="1" ';
-	    }
-	    $scrout.='/ ></p>'.
-		&textfield('Suggested Replacement for Obsolete File',
-				    'obsoletereplacement',
-				    $metadatafields{'obsoletereplacement'});
 	} else {
-	    $scrout.=&hiddenfield('copyright','private');
+	    $intr_scrout.=&selectbox('Copyright/Distribution','copyright',
+				     $defaultoption,
+				     \&Apache::loncommon::copyrightdescription,
+				     (&Apache::loncommon::copyrightids));
+	}
+	my $copyright_help =
+	    Apache::loncommon::help_open_topic('Publishing_Copyright');
+	$intr_scrout =~ s/Distribution:/'Distribution: ' . $copyright_help/ge;
+	$intr_scrout.=&text_with_browse_field('Custom Distribution File','customdistributionfile',$metadatafields{'customdistributionfile'},'rights').$copyright_help;
+	$intr_scrout.=&selectbox('Source Distribution','sourceavail',
+				 $defaultsourceoption,
+				 \&Apache::loncommon::source_copyrightdescription,
+				 (&Apache::loncommon::source_copyrightids));
+	$intr_scrout.=&text_with_browse_field('Source Custom Distribution File','sourcerights',$metadatafields{'sourcerights'},'rights');
+	my $uctitle=&mt('Obsolete');
+	$intr_scrout.=
+	    "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$uctitle:".
+	    '</b></font> <input type="checkbox" name="obsolete" ';
+	if ($metadatafields{'obsolete'}) {
+	    $intr_scrout.=' checked="1" ';
 	}
-	return ($scrout.'<p><input type="submit" value="'.
-		&mt('Finalize Publication').'" /></p></form>',0);
-# =============================================================================
-# BATCH MODE
-#
+	$intr_scrout.='/ ></p>'.
+	    &text_with_browse_field('Suggested Replacement for Obsolete File',
+				    'obsoletereplacement',
+				    $metadatafields{'obsoletereplacement'});
     } else {
-# Transfer metadata directly to environment for stage 2
-	foreach (keys %metadatafields) {
-	    $ENV{'form.'.$_}=$metadatafields{$_};
-	}
-	$ENV{'form.addkey'}='';
-	$ENV{'form.keywords'}='';
-	foreach (keys %keywords) {
-	    if ($metadatafields{'keywords'}) {
-		if ($metadatafields{'keywords'}=~/\Q$_\E/) { 
-		    $ENV{'form.keywords'}.=$_.','; 
-		}
-	    } elsif (&Apache::loncommon::keyword($_)) {
-		$ENV{'form.keywords'}.=$_.',';
-	    }
-	}
-	$ENV{'form.keywords'}=~s/\,$//;
-	unless ($ENV{'form.creationdate'}) { $ENV{'form.creationdate'}=time; }
-	$ENV{'form.lastrevisiondate'}=time;
-	if ((($style eq 'rat') && ($ENV{'form.copyright'} eq 'public')) ||
-	    (!$ENV{'form.copyright'})) { 
-	    $ENV{'form.copyright'}='default';
-	}
-	$ENV{'form.allmeta'}=&Apache::lonnet::escape($allmeta);
-	return ($scrout,0);
+	$intr_scrout.=&hiddenfield('copyright','private');
     }
+    if (!$batch) {
+	$scrout.=$intr_scrout.'<p><input type="submit" value="'.
+	    &mt('Finalize Publication').'" /></p></form>';
+    }
+    return($scrout,0);
 }
 
 #########################################
@@ -1350,7 +1379,7 @@ sub phasetwo {
     
     %metadatafields=();
     %metadatakeys=();
-    
+
     &metaeval(&Apache::lonnet::unescape($ENV{'form.allmeta'}));
     
     $metadatafields{'title'}=$ENV{'form.title'};
@@ -1369,6 +1398,7 @@ sub phasetwo {
     $metadatafields{'highestgradelevel'}=$ENV{'form.highestgradelevel'};
     $metadatafields{'customdistributionfile'}=
                                  $ENV{'form.customdistributionfile'};
+    $metadatafields{'sourceavail'}=$ENV{'form.sourceavail'};
     $metadatafields{'obsolete'}=$ENV{'form.obsolete'};
     $metadatafields{'obsoletereplacement'}=
 	                        $ENV{'form.obsoletereplacement'};
@@ -1385,8 +1415,11 @@ sub phasetwo {
             $allkeywords .= ','.$ENV{'form.keywords'};
         }
     }
-    $allkeywords=~s/\W+/\,/;
-    $allkeywords=~s/^\,//;
+    $allkeywords=~s/[\"\']//g;
+    $allkeywords=~s/\s*[\;\,]\s*/\,/g;
+    $allkeywords=~s/\s+/ /g;
+    $allkeywords=~s/^[ \,]//;
+    $allkeywords=~s/[ \,]$//;
     $metadatafields{'keywords'}=$allkeywords;
     
 # check if custom distribution file is specified
@@ -1419,7 +1452,7 @@ sub phasetwo {
                     print $mfh ' '.$_.'="'.$value.'"';
                 }
                 print $mfh '>'.
-                    &HTML::Entities::encode($metadatafields{$unikey})
+                    &HTML::Entities::encode($metadatafields{$unikey},'<>&"')
                         .'</'.$tag.'>';
             }
         }
@@ -1544,41 +1577,12 @@ sub phasetwo {
             "<font color=\"red\">".&mt('Failed to write metadata copy').", $!, ".&mt('FAIL')."</font>";
     }
     $r->rflush;
-# --------------------------------------------------- Send update notifications
 
-    my @subscribed=&get_subscribed_hosts($target);
-    foreach my $subhost (@subscribed) {
-	$r->print('<p>'.&mt('Notifying host').' '.$subhost.':');$r->rflush;
-	print $logfile "\nNotifying host ".$subhost.':';
-	my $reply=&Apache::lonnet::critical('update:'.$target,$subhost);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
-    }
-    
-# ---------------------------------------- Send update notifications, meta only
-
-    my @subscribedmeta=&get_subscribed_hosts("$target.meta");
-    foreach my $subhost (@subscribedmeta) {
-	$r->print('<p>'.
-&mt('Notifying host for metadata only').' '.$subhost.':');$r->rflush;
-	print $logfile "\nNotifying host for metadata only ".$subhost.':';
-	my $reply=&Apache::lonnet::critical('update:'.$target.'.meta',
-					    $subhost);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
-    }
-    
-# --------------------------------------------------- Notify subscribed courses
-    my %courses=&coursedependencies($target);
-    my $now=time;
-    foreach (keys %courses) {
-	$r->print('<p>'.&mt('Notifying course').' '.$_.':');$r->rflush;
-	print $logfile "\nNotifying host ".$_.':';
-        my ($cdom,$cname)=split(/\_/,$_);
-	my $reply=&Apache::lonnet::cput
-                  ('versionupdate',{$target => $now},$cdom,$cname);
-	$r->print($reply.'</p><br />');$r->rflush;
-	print $logfile $reply;
+# ------------------------------------------------------------- Trigger updates
+    push(@{$modified_urls},[$target,$source]);
+    unless ($registered_cleanup) {
+	$r->register_cleanup(\&notify);
+	$registered_cleanup=1;
     }
 # ------------------------------------------------ Provide link to new resource
     unless ($batch) {
@@ -1601,9 +1605,47 @@ sub phasetwo {
                    '"><font size="+2">'.
 		  &mt('Back to Source Directory').'</font></a></p>');
     }
+    $logfile->close();
     return '<p><font color="green">'.&mt('Done').'</font></p>';
 }
 
+# =============================================================== Notifications
+sub notify {  
+# --------------------------------------------------- Send update notifications
+    foreach my $targetsource (@{$modified_urls}){
+	my ($target,$source)=@{$targetsource};
+	my $logfile=Apache::File->new('>>'.$source.'.log');
+	print $logfile "\nCleanup phase: Notifications\n";
+	my @subscribed=&get_subscribed_hosts($target);
+	foreach my $subhost (@subscribed) {
+	    print $logfile "\nNotifying host ".$subhost.':';
+	    my $reply=&Apache::lonnet::critical('update:'.$target,$subhost);
+	    print $logfile $reply;
+	}
+# ---------------------------------------- Send update notifications, meta only
+	my @subscribedmeta=&get_subscribed_hosts("$target.meta");
+	foreach my $subhost (@subscribedmeta) {
+	    print $logfile "\nNotifying host for metadata only ".$subhost.':';
+	    my $reply=&Apache::lonnet::critical('update:'.$target.'.meta',
+						$subhost);
+	    print $logfile $reply;
+	} 
+# --------------------------------------------------- Notify subscribed courses
+	my %courses=&coursedependencies($target);
+	my $now=time;
+	foreach (keys %courses) {
+	    print $logfile "\nNotifying course ".$_.':';
+	    my ($cdom,$cname)=split(/\_/,$_);
+	    my $reply=&Apache::lonnet::cput
+		('versionupdate',{$target => $now},$cdom,$cname);
+	    print $logfile $reply;
+	}
+	print $logfile "\n============ Done ============\n";
+	$logfile->close();
+    }
+    return OK;
+}
+
 #########################################
 
 sub batchpublish {
@@ -1684,7 +1726,7 @@ sub publishdirectory {
 		    $ruid,$rgid,$rrdev,$rsize,
 		    $ratime,$rmtime,$rctime,
 		    $rblksize,$rblocks)=stat($resdir.'/'.$filename);
-	        if (($rmtime<$cmtime) || ($ENV{'form.forcerepub'})) {
+	        if (($rmtime<$cmtime) || ($ENV{'form.forcerepub'} eq 'ON')) {
 # previously published, modified now
 		    $publishthis=1;
                 }
@@ -1813,6 +1855,9 @@ sub handler {
     &Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
                                             ['filename']);
 
+# -------------------------------------- Flag and buffer for registered cleanup
+    $registered_cleanup=0;
+    @{$modified_urls}=();
 # -------------------------------------------------------------- Check filename
 
     my $fn=&Apache::lonnet::unescape($ENV{'form.filename'});
@@ -1840,12 +1885,14 @@ sub handler {
 	return HTTP_NOT_ACCEPTABLE;
     }
 
-    unless (&Apache::lonnet::homeserver($cuname,$cudom) 
-	    eq $r->dir_config('lonHostID')) {
+    my $home=&Apache::lonnet::homeserver($cuname,$cudom);
+    my $allowed=0;
+    my @ids=&Apache::lonnet::current_machine_ids();
+    foreach my $id (@ids) { if ($id eq $home) { $allowed = 1; }  }
+    unless ($allowed) {
 	$r->log_reason($cuname.' at '.$cudom.
 		       ' trying to publish file '.$ENV{'form.filename'}.
-		       ' ('.$fn.') - not homeserver ('.
-		       &Apache::lonnet::homeserver($cuname,$cudom).')', 
+		       ' ('.$fn.') - not homeserver ('.$home.')', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
     }
@@ -1904,8 +1951,11 @@ sub handler {
 
     &Apache::loncommon::content_type($r,'text/html');
     $r->send_http_header;
-
-    $r->print('<html><head><title>LON-CAPA Publishing</title></head>');
+    
+    my $js=&Apache::loncommon::browser_and_searcher_javascript();
+    $r->print('<html><head><title>LON-CAPA Publishing</title>
+              <script type="text/javascript">'.$js.'
+              </script></head>');
     $r->print(&Apache::loncommon::bodytag('Resource Publication'));
 
 
@@ -1961,8 +2011,17 @@ ENDDIFF
 # ------------------ Publishing from $thisfn to $thistarget with $thisembstyle.
 
 	unless ($ENV{'form.phase'} eq 'two') {
-	    my ($outstring,$error)=&publish($thisfn,$thistarget,$thisembstyle);
-	    $r->print('<hr />'.$outstring);
+# ---------------------------------------------------------- Parse for problems
+	    my ($warningcount,$errorcount)=&checkonthis($r,$thisfn);
+            unless ($errorcount) {
+		my ($outstring,$error)=
+		    &publish($thisfn,$thistarget,$thisembstyle);
+		$r->print('<hr />'.$outstring);
+	    } else {
+                $r->print('<h3>'.
+		&mt('The document contains errors and cannot be published.').
+			  '</h3>');
+	    }
 	} else {
 	    $r->print('<hr />'.
 	    &phasetwo($r,$thisfn,$thistarget,$thisembstyle,$thisdistarget));