--- loncom/publisher/lonpublisher.pm	2005/02/28 21:28:18	1.185
+++ loncom/publisher/lonpublisher.pm	2005/04/07 06:56:27	1.192
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Publication Handler
 #
-# $Id: lonpublisher.pm,v 1.185 2005/02/28 21:28:18 www Exp $
+# $Id: lonpublisher.pm,v 1.192 2005/04/07 06:56:27 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -121,7 +121,7 @@ use HTML::LCParser;
 use Apache::lonxml;
 use Apache::loncacc;
 use DBI;
-use Apache::lonnet();
+use Apache::lonnet;
 use Apache::loncommon();
 use Apache::lonmysql;
 use Apache::lonlocal;
@@ -326,7 +326,7 @@ sub textfield {
     $value=~s/\s+$//gs;
     $value=~s/\s+/ /gs;
     $title=&mt($title);
-    $ENV{'form.'.$name}=$value;
+    $env{'form.'.$name}=$value;
     return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
            "</b></font></p><br />".
            '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />';
@@ -338,7 +338,7 @@ sub text_with_browse_field {
     $value=~s/\s+$//gs;
     $value=~s/\s+/ /gs;
     $title=&mt($title);
-    $ENV{'form.'.$name}=$value;
+    $env{'form.'.$name}=$value;
     return "\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
            "</b></font></p><br />".
            '<input type="text" name="'.$name.'" size=80 value="'.$value.'" />'.
@@ -349,7 +349,7 @@ sub text_with_browse_field {
 
 sub hiddenfield {
     my ($name,$value)=@_;
-    $ENV{'form.'.$name}=$value;
+    $env{'form.'.$name}=$value;
     return "\n".'<input type="hidden" name="'.$name.'" value="'.$value.'" />';
 }
 
@@ -358,9 +358,9 @@ sub selectbox {
     $title=&mt($title);
     $value=(split(/\s*,\s*/,$value))[-1];
     if (defined($value)) {
-	$ENV{'form.'.$name}=$value;
+	$env{'form.'.$name}=$value;
     } else {
-	$ENV{'form.'.$name}=$idlist[0];
+	$env{'form.'.$name}=$idlist[0];
     }
     my $selout="\n<p><font color=\"#800000\" face=\"helvetica\"><b>$title:".
 	'</b></font></p><br /><select name="'.$name.'">';
@@ -376,8 +376,8 @@ sub selectbox {
 
 sub select_level_form {
     my ($value,$name)=@_;
-    $ENV{'form.'.$name}=$value;
-    if (!defined($value)) { $ENV{'form.'.$name}=0; }
+    $env{'form.'.$name}=$value;
+    if (!defined($value)) { $env{'form.'.$name}=0; }
     return  &Apache::loncommon::select_level_form($value,$name);
 }
 #########################################
@@ -548,7 +548,8 @@ sub get_max_ids_indices {
 	    my $counter;
 	    if ($counter=$addid{$token->[1]}) {
 		if ($counter eq 'id') {
-		    if (defined($token->[2]->{'id'})) {
+		    if (defined($token->[2]->{'id'}) &&
+			$token->[2]->{'id'} !~ /^\s*$/) {
 			$maxid=($token->[2]->{'id'}>$maxid)?$token->[2]->{'id'}:$maxid;
 			if (exists($allids{$token->[2]->{'id'}})) {
 			    $duplicateids=1;
@@ -560,7 +561,8 @@ sub get_max_ids_indices {
 			$needsfixup=1;
 		    }
 		} else {
-		    if (defined($token->[2]->{'index'})) {
+		    if (defined($token->[2]->{'index'}) &&
+			$token->[2]->{'index'} !~ /^\s*$/) {
 			$maxindex=($token->[2]->{'index'}>$maxindex)?$token->[2]->{'index'}:$maxindex;
 		    } else {
 			$needsfixup=1;
@@ -674,13 +676,15 @@ sub fix_ids_and_indices {
 		if (!$counter) { $counter=$addid{$lctag}; }
 		if ($counter) {
 		    if ($counter eq 'id') {
-			unless (defined($parms{'id'})) {
+			unless (defined($parms{'id'}) &&
+				$parms{'id'}!~/^\s*$/) {
 			    $maxid++;
 			    $parms{'id'}=$maxid;
 			    print $logfile 'ID: '.$tag.':'.$maxid."\n";
 			}
 		    } elsif ($counter eq 'index') {
-			unless (defined($parms{'index'})) {
+			unless (defined($parms{'index'}) &&
+				$parms{'index'}!~/^\s*$/) {
 			    $maxindex++;
 			    $parms{'index'}=$maxindex;
 			    print $logfile 'Index: '.$tag.':'.$maxindex."\n";
@@ -846,29 +850,29 @@ sub store_metadata {
 
 sub checkonthis {
     my ($r,$source)=@_;
-    my $oldpath=$ENV{'request.filename'};
-    $ENV{'request.filename'}=$source;
-    &Apache::lonxml::xmlparse($r,'web',
-			      &Apache::lonnet::getfile($source));
-    undef($Apache::lonhomework::parsing_a_problem);
-    $ENV{'request.filename'}=$oldpath;
-    if (($Apache::lonxml::errorcount) ||
-	($Apache::lonxml::warningcount)) {
-	if ($Apache::lonxml::errorcount) {
+    my $uri=&Apache::lonnet::hreflocation($source);
+    $uri=~s/\/$//;
+    my $result=&Apache::lonnet::ssi_body($uri,
+					 ('grade_target'=>'web',
+					  'return_only_error_and_warning_counts' => 1));
+    my ($errorcount,$warningcount)=split(':',$result);
+    if (($errorcount) || ($warningcount)) {
+        $r->print('<br /><tt>'.$uri.'</tt>: ');
+	if ($errorcount) {
 	    $r->print('<img src="/adm/lonMisc/bomb.gif" /><font color="red"><b>'.
-		      $Apache::lonxml::errorcount.' '.
+		      $errorcount.' '.
 		      &mt('error(s)').'</b></font> ');
 	}
-	if ($Apache::lonxml::warningcount) {
+	if ($warningcount) {
 	    $r->print('<font color="blue">'.
-		      $Apache::lonxml::warningcount.' '.
+		      $warningcount.' '.
 		      &mt('warning(s)').'</font>');
 	}
     } else {
-	$r->print('<font color="green">'.&mt('ok').'</font>');
+	#$r->print('<font color="green">'.&mt('ok').'</font>');
     }
     $r->rflush();
-    return ($Apache::lonxml::warningcount,$Apache::lonxml::errorcount);
+    return ($warningcount,$errorcount);
 }
 
 # ============================================== Parse file itself for metadata
@@ -924,7 +928,7 @@ sub publish {
 	return ('<font color="red">'.&mt('No write permission to user directory, FAIL').'</font>',1);
     }
     print $logfile 
-"\n\n================= Publish ".localtime()." Phase One  ================\n".$ENV{'user.name'}.'@'.$ENV{'user.domain'}."\n";
+"\n\n================= Publish ".localtime()." Phase One  ================\n".$env{'user.name'}.'@'.$env{'user.domain'}."\n";
 
     if (($style eq 'ssi') || ($style eq 'rat') || ($style eq 'prv')) {
 # ------------------------------------------------------- This needs processing
@@ -1012,10 +1016,10 @@ sub publish {
 
 # ------------------------------------------------ First, check out environment
      unless (-e $source.'.meta') {
-        $metadatafields{'author'}=$ENV{'environment.firstname'}.' '.
-	                          $ENV{'environment.middlename'}.' '.
-		                  $ENV{'environment.lastname'}.' '.
-		                  $ENV{'environment.generation'};
+        $metadatafields{'author'}=$env{'environment.firstname'}.' '.
+	                          $env{'environment.middlename'}.' '.
+		                  $env{'environment.lastname'}.' '.
+		                  $env{'environment.generation'};
         $metadatafields{'author'}=~s/\s+/ /g;
         $metadatafields{'author'}=~s/\s+$//;
         $metadatafields{'owner'}=$cuname.'@'.$cudom;
@@ -1137,14 +1141,14 @@ sub publish {
 # interactive mode html goes into $intr_scrout
 # batch mode throws away this HTML
 # additionally all of the field functions have a by product of setting
-#   $ENV{'from.'..} so that it can be used by the phase two handler in
+#   $env{'from.'..} so that it can be used by the phase two handler in
 #    batch mode
 
     my $intr_scrout.=
 	'<form name="pubform" action="/adm/publish" method="post">'.
 	'<p><input type="submit" value="'.&mt('Finalize Publication').'" /></p>'.
 	&hiddenfield('phase','two').
-	&hiddenfield('filename',$ENV{'form.filename'}).
+	&hiddenfield('filename',$env{'form.filename'}).
 	&hiddenfield('allmeta',&Apache::lonnet::escape($allmeta)).
 	&hiddenfield('dependencies',join(',',keys %allow)).
 	&textfield('Title','title',$metadatafields{'title'}).
@@ -1184,11 +1188,11 @@ END
 	if ($metadatafields{'keywords'}) {
 	    if ($metadatafields{'keywords'}=~/\Q$_\E/) {
 		$keywordout.=' checked="on"';
-		$ENV{'form.keywords'}.=$_.',';
+		$env{'form.keywords'}.=$_.',';
 	    }
 	} elsif (&Apache::loncommon::keyword($_)) {
 	    $keywordout.=' checked="on"';
-	    $ENV{'form.keywords'}.=$_.',';
+	    $env{'form.keywords'}.=$_.',';
 	}
 	$keywordout.=' />'.$_.'</label></td>';
 	if ($colcount>10) {
@@ -1197,7 +1201,7 @@ END
 	}
 	$colcount++;
     }
-    $ENV{'form.keywords'}=~s/\,$//;
+    $env{'form.keywords'}=~s/\,$//;
 
     $keywordout.='</tr></table>';
 
@@ -1285,7 +1289,7 @@ END
 	}
 	my $copyright_help =
 	    Apache::loncommon::help_open_topic('Publishing_Copyright');
-	$intr_scrout =~ s/DISTRIBUTION:/'DISTRIBUTION: ' . $copyright_help/ge;
+	$intr_scrout =~ s/Distribution:/'Distribution: ' . $copyright_help/ge;
 	$intr_scrout.=&text_with_browse_field('Custom Distribution File','customdistributionfile',$metadatafields{'customdistributionfile'},'rights').$copyright_help;
 	$intr_scrout.=&selectbox('Source Distribution','sourceavail',
 				 $defaultsourceoption,
@@ -1372,44 +1376,44 @@ sub phasetwo {
         return 0;
     }
     print $logfile 
-        "\n================= Publish ".localtime()." Phase Two  ================\n".$ENV{'user.name'}.'@'.$ENV{'user.domain'}."\n";
+        "\n================= Publish ".localtime()." Phase Two  ================\n".$env{'user.name'}.'@'.$env{'user.domain'}."\n";
     
     %metadatafields=();
     %metadatakeys=();
 
-    &metaeval(&Apache::lonnet::unescape($ENV{'form.allmeta'}));
+    &metaeval(&Apache::lonnet::unescape($env{'form.allmeta'}));
     
-    $metadatafields{'title'}=$ENV{'form.title'};
-    $metadatafields{'author'}=$ENV{'form.author'};
-    $metadatafields{'subject'}=$ENV{'form.subject'};
-    $metadatafields{'notes'}=$ENV{'form.notes'};
-    $metadatafields{'abstract'}=$ENV{'form.abstract'};
-    $metadatafields{'mime'}=$ENV{'form.mime'};
-    $metadatafields{'language'}=$ENV{'form.language'};
-    $metadatafields{'creationdate'}=$ENV{'form.creationdate'};
-    $metadatafields{'lastrevisiondate'}=$ENV{'form.lastrevisiondate'};
-    $metadatafields{'owner'}=$ENV{'form.owner'};
-    $metadatafields{'copyright'}=$ENV{'form.copyright'};
-    $metadatafields{'standards'}=$ENV{'form.standards'};
-    $metadatafields{'lowestgradelevel'}=$ENV{'form.lowestgradelevel'};
-    $metadatafields{'highestgradelevel'}=$ENV{'form.highestgradelevel'};
+    $metadatafields{'title'}=$env{'form.title'};
+    $metadatafields{'author'}=$env{'form.author'};
+    $metadatafields{'subject'}=$env{'form.subject'};
+    $metadatafields{'notes'}=$env{'form.notes'};
+    $metadatafields{'abstract'}=$env{'form.abstract'};
+    $metadatafields{'mime'}=$env{'form.mime'};
+    $metadatafields{'language'}=$env{'form.language'};
+    $metadatafields{'creationdate'}=$env{'form.creationdate'};
+    $metadatafields{'lastrevisiondate'}=$env{'form.lastrevisiondate'};
+    $metadatafields{'owner'}=$env{'form.owner'};
+    $metadatafields{'copyright'}=$env{'form.copyright'};
+    $metadatafields{'standards'}=$env{'form.standards'};
+    $metadatafields{'lowestgradelevel'}=$env{'form.lowestgradelevel'};
+    $metadatafields{'highestgradelevel'}=$env{'form.highestgradelevel'};
     $metadatafields{'customdistributionfile'}=
-                                 $ENV{'form.customdistributionfile'};
-    $metadatafields{'sourceavail'}=$ENV{'form.sourceavail'};
-    $metadatafields{'obsolete'}=$ENV{'form.obsolete'};
+                                 $env{'form.customdistributionfile'};
+    $metadatafields{'sourceavail'}=$env{'form.sourceavail'};
+    $metadatafields{'obsolete'}=$env{'form.obsolete'};
     $metadatafields{'obsoletereplacement'}=
-	                        $ENV{'form.obsoletereplacement'};
-    $metadatafields{'dependencies'}=$ENV{'form.dependencies'};
-    $metadatafields{'modifyinguser'}=$ENV{'user.name'}.'@'.
-	                                 $ENV{'user.domain'};
+	                        $env{'form.obsoletereplacement'};
+    $metadatafields{'dependencies'}=$env{'form.dependencies'};
+    $metadatafields{'modifyinguser'}=$env{'user.name'}.'@'.
+	                                 $env{'user.domain'};
     $metadatafields{'authorspace'}=$cuname.'@'.$cudom;
     
-    my $allkeywords=$ENV{'form.addkey'};
-    if (exists($ENV{'form.keywords'})) {
-        if (ref($ENV{'form.keywords'})) {
-            $allkeywords .= ','.join(',',@{$ENV{'form.keywords'}});
+    my $allkeywords=$env{'form.addkey'};
+    if (exists($env{'form.keywords'})) {
+        if (ref($env{'form.keywords'})) {
+            $allkeywords .= ','.join(',',@{$env{'form.keywords'}});
         } else {
-            $allkeywords .= ','.$ENV{'form.keywords'};
+            $allkeywords .= ','.$env{'form.keywords'};
         }
     }
     $allkeywords=~s/[\"\']//g;
@@ -1647,8 +1651,8 @@ sub notify {
 
 sub batchpublish {
     my ($r,$srcfile,$targetfile)=@_;
-    #publication pollutes %ENV with form.* values
-    my %oldENV=%ENV;
+    #publication pollutes %env with form.* values
+    my %oldenv=%env;
     $srcfile=~s/\/+/\//g;
     $targetfile=~s/\/+/\//g;
     my $thisdisfn=$srcfile;
@@ -1676,13 +1680,13 @@ sub batchpublish {
     $r->print('<p>'.$outstring.'</p>');
 # phase two takes
 # my ($source,$target,$style,$distarget,batch)=@_;
-# $ENV{'form.allmeta'},$ENV{'form.title'},$ENV{'form.author'},...
+# $env{'form.allmeta'},$env{'form.title'},$env{'form.author'},...
     if (!$error) {
 	$r->print('<p>');
 	&phasetwo($r,$srcfile,$targetfile,$thisembstyle,$thisdistarget,1);
 	$r->print('</p>');
     }
-    %ENV=%oldENV;
+    %env=%oldenv;
     return '';
 }
 
@@ -1711,7 +1715,7 @@ sub publishdirectory {
 	my $extension='';
 	if ($filename=~/\.(\w+)$/) { $extension=$1; }
 	if ($cmode&$dirptr) {
-	    if (($filename!~/^\./) && ($ENV{'form.pubrec'})) {
+	    if (($filename!~/^\./) && ($env{'form.pubrec'})) {
 		&publishdirectory($r,$fn.'/'.$filename,$thisdisfn.'/'.$filename);
 	    }
 	} elsif ((&Apache::loncommon::fileembstyle($extension) ne 'hdn') &&
@@ -1723,7 +1727,7 @@ sub publishdirectory {
 		    $ruid,$rgid,$rrdev,$rsize,
 		    $ratime,$rmtime,$rctime,
 		    $rblksize,$rblocks)=stat($resdir.'/'.$filename);
-	        if (($rmtime<$cmtime) || ($ENV{'form.forcerepub'} eq 'ON')) {
+	        if (($rmtime<$cmtime) || ($env{'form.forcerepub'} eq 'ON')) {
 # previously published, modified now
 		    $publishthis=1;
                 }
@@ -1857,7 +1861,7 @@ sub handler {
     @{$modified_urls}=();
 # -------------------------------------------------------------- Check filename
 
-    my $fn=&Apache::lonnet::unescape($ENV{'form.filename'});
+    my $fn=&Apache::lonnet::unescape($env{'form.filename'});
 
     ($cuname,$cudom)=
 	&Apache::loncacc::constructaccess($fn,$r->dir_config('lonDefDomain'));
@@ -1876,7 +1880,7 @@ sub handler {
 
     unless (($cuname) && ($cudom)) {
 	$r->log_reason($cuname.' at '.$cudom.
-		       ' trying to publish file '.$ENV{'form.filename'}.
+		       ' trying to publish file '.$env{'form.filename'}.
 		       ' ('.$fn.') - not authorized', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
@@ -1888,7 +1892,7 @@ sub handler {
     foreach my $id (@ids) { if ($id eq $home) { $allowed = 1; }  }
     unless ($allowed) {
 	$r->log_reason($cuname.' at '.$cudom.
-		       ' trying to publish file '.$ENV{'form.filename'}.
+		       ' trying to publish file '.$env{'form.filename'}.
 		       ' ('.$fn.') - not homeserver ('.$home.')', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
@@ -1902,7 +1906,7 @@ sub handler {
     if ($1 ne $cuname) {
 	$r->log_reason($cuname.' at '.$cudom.
 		       ' trying to publish unowned file '.
-		       $ENV{'form.filename'}.' ('.$fn.')', 
+		       $env{'form.filename'}.' ('.$fn.')', 
 		       $r->filename); 
 	return HTTP_NOT_ACCEPTABLE;
     } else {
@@ -1913,12 +1917,12 @@ sub handler {
     unless (-e $fn) { 
 	$r->log_reason($cuname.' at '.$cudom.
 		       ' trying to publish non-existing file '.
-		       $ENV{'form.filename'}.' ('.$fn.')', 
+		       $env{'form.filename'}.' ('.$fn.')', 
 		       $r->filename); 
 	return HTTP_NOT_FOUND;
     } 
 
-    unless ($ENV{'form.phase'} eq 'two') {
+    unless ($env{'form.phase'} eq 'two') {
 
 # -------------------------------- File is there and owned, init lookup tables.
 
@@ -1992,7 +1996,7 @@ ENDCAPTION
         $r->print('</tt></h2><b>'.&mt('Target').':</b> <tt>'.
 		  $thisdistarget.'</tt><br />');
    
-	if (($cuname ne $ENV{'user.name'})||($cudom ne $ENV{'user.domain'})) {
+	if (($cuname ne $env{'user.name'})||($cudom ne $env{'user.domain'})) {
 	    $r->print('<h3><font color="red">'.&mt('Co-Author').': '.
 		      $cuname.&mt(' at ').$cudom.'</font></h3>');
 	}
@@ -2007,11 +2011,21 @@ ENDDIFF
   
 # ------------------ Publishing from $thisfn to $thistarget with $thisembstyle.
 
-	unless ($ENV{'form.phase'} eq 'two') {
+	unless ($env{'form.phase'} eq 'two') {
 # ---------------------------------------------------------- Parse for problems
-	    &checkonthis($r,$thisfn);
-	    my ($outstring,$error)=&publish($thisfn,$thistarget,$thisembstyle);
-	    $r->print('<hr />'.$outstring);
+	    my ($warningcount,$errorcount);
+	    if ($thisembstyle eq 'ssi') {
+		($warningcount,$errorcount)=&checkonthis($r,$thisfn);
+	    }
+	    unless ($errorcount) {
+		my ($outstring,$error)=
+		    &publish($thisfn,$thistarget,$thisembstyle);
+		$r->print('<hr />'.$outstring);
+	    } else {
+		$r->print('<h3>'.
+			  &mt('The document contains errors and cannot be published.').
+			  '</h3>');
+	    }
 	} else {
 	    $r->print('<hr />'.
 	    &phasetwo($r,$thisfn,$thistarget,$thisembstyle,$thisdistarget));