--- loncom/xml/run.pm 2001/11/29 19:03:58 1.21 +++ loncom/xml/run.pm 2001/12/11 15:48:51 1.22 @@ -1,6 +1,6 @@ package Apache::run; # -# $Id: run.pm,v 1.21 2001/11/29 19:03:58 www Exp $ +# $Id: run.pm,v 1.22 2001/12/11 15:48:51 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -30,7 +30,7 @@ sub evaluateold { # print "inside2 evaluate $decls with $expression
\n"; # gerd's old method interpolates unset vars # $safeeval->reval('return qq('.$expression.');'); - unless (defined $expression) { return ''; } + unless (defined($expression)) { return ''; } my $result = ''; $@=''; $safeeval->reval('$_=q|'.$expression.'|;'); @@ -58,7 +58,7 @@ ENDEVALUATE sub evaluate { my ($expression,$safeeval,$decls) = @_; - unless (defined $expression) { return ''; } + unless (defined($expression)) { return ''; } if (!$Apache::lonxml::evaluate) { return $expression; } my $result = ''; $@=''; @@ -99,11 +99,11 @@ sub dump { if ($safeeval->reval('defined($'.$symname.')')) { $dump.='$'.$symname.'='.$safeeval->reval('$'.$symname)."\n"; } - if ($safeeval->reval('defined @'.$symname)) { + if ($safeeval->reval('defined(@'.$symname.')')) { $dump.='@'.$symname.'=('. $safeeval->reval('join(",",@'.$symname.')').")\n"; } - if ($safeeval->reval('defined %'.$symname)) { + if ($safeeval->reval('defined(%'.$symname.')')) { $dump.='%'.$symname.'=('; $dump.=$safeeval->reval('join(",",map { $_."=>".$'. $symname.'{$_} } sort keys %'.