--- rat/lonuserstate.pm	2021/12/14 22:52:33	1.149.2.5
+++ rat/lonuserstate.pm	2017/09/03 18:52:23	1.153
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Construct and maintain state and binary representation of course for user
 #
-# $Id: lonuserstate.pm,v 1.149.2.5 2021/12/14 22:52:33 raeburn Exp $
+# $Id: lonuserstate.pm,v 1.153 2017/09/03 18:52:23 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -42,7 +42,7 @@ use Safe::Hole;
 use Opcode;
 use Apache::lonenc;
 use Fcntl qw(:flock);
-use LONCAPA;
+use LONCAPA qw(:DEFAULT :match);
 use File::Basename;
 
  
@@ -255,9 +255,9 @@ sub loadmap {
 		push(@map_ids, $resource_id);
                 if ($hash{'src_'.$lpc.'.'.$resource_id}) {
                     $rescount{$lpc} ++;
-                    if (($hash{'src_'.$lpc.'.'.$resource_id}=~/\.sequence$/) ||
+                    if (($hash{'src_'.$lpc.'.'.$resource_id}=~/\.sequence$/) || 
                         ($hash{'src_'.$lpc.'.'.$resource_id}=~/\.page$/)) {
-                        $mapcount{$lpc} ++;
+                        $mapcount{$lpc} ++; 
                     }
                 }
                 unless ($codechecked) {
@@ -292,7 +292,15 @@ sub loadmap {
     # Handle randomization and random selection
 
     if ($randomize) {
-        unless (&is_advanced($courseid)) {
+        my $advanced;
+        if ($env{'request.course.id'}) {
+            $advanced = (&Apache::lonnet::allowed('adv') eq 'F');
+        } else {
+            $env{'request.course.id'} = $courseid;
+            $advanced = (&Apache::lonnet::allowed('adv') eq 'F');
+            $env{'request.course.id'} = '';
+        }
+        unless ($advanced) {
             # Order of resources is not randomized if user has and advanced role in the course.
 	    my $seed;
 
@@ -375,18 +383,6 @@ sub loadmap {
     }
 }
 
-sub is_advanced {
-    my ($courseid) = @_;
-    my $advanced;
-    if ($env{'request.course.id'}) {
-        $advanced = (&Apache::lonnet::allowed('adv') eq 'F');
-    } else {
-        $env{'request.course.id'} = $courseid;
-        $advanced = (&Apache::lonnet::allowed('adv') eq 'F');
-        $env{'request.course.id'} = '';
-    }
-    return $advanced;
-}
 
 # -------------------------------------------------------------------- Resource
 #
@@ -473,11 +469,7 @@ sub parse_resource {
     # is not a page.  If the resource is a page then it must be
     # assembled (at fetch time?).
 
-    if ($ispage) {
-        if ($token->[2]->{'external'} eq 'true') { # external
-            $turi=~s{^http\://}{/ext/};
-        }
-    } else {
+    unless ($ispage) {
 	$turi=~/\.(\w+)$/;
 	my $embstyle=&Apache::loncommon::fileembstyle($1);
 	if ($token->[2]->{'external'} eq 'true') { # external
@@ -492,6 +484,8 @@ sub parse_resource {
 	    } elsif ($turi!~/\.(sequence|page)$/) {
 		$turi='/adm/coursedocs/showdoc'.$turi;
 	    }
+        } elsif ($turi=~ m{^/adm/$match_domain/$match_courseid/\d+/ext\.tool$}) {
+            $turi='/adm/wrapper'.$turi;
 	} elsif ($turi=~/\S/) { # normal non-empty internal resource
 	    my $mapdir=$uri;
 	    $mapdir=~s/[^\/]+$//;
@@ -567,9 +561,7 @@ sub parse_resource {
     if (($turi=~/\.sequence$/) ||
 	($turi=~/\.page$/)) {
 	$hash{'is_map_'.$rid}=1;
-	if ((!$hiddenurl{$rid}) || (&is_advanced($courseid))) {
-	    &loadmap($turi,$rid,$courseid);
-	}
+	&loadmap($turi,$rid,$courseid);
     } 
     return $token->[2]->{'id'};
 }
@@ -1200,7 +1192,7 @@ sub mapcrumbs {
 # ---------------------------------------------------- Read map and all submaps
 
 sub readmap {
-    my ($short,$critmsg_check) = @_;
+    my $short=shift;
     $short=~s/^\///;
 
     # TODO:  Hidden dependency on current user:
@@ -1217,7 +1209,7 @@ sub readmap {
     }
     @cond=('true:normal');
 
-    unless (open(LOCKFILE,">","$fn.db.lock")) {
+    unless (open(LOCKFILE,">$fn.db.lock")) {
 	# 
 	# Most likely a permissions problem on the lockfile or its directory.
 	#
@@ -1235,13 +1227,8 @@ sub readmap {
         &unlink_tmpfiles($fn);
     }
     undef %randompick;
-    undef %randompickseed;
-    undef %randomorder;
-    undef %randomizationcode;
     undef %hiddenurl;
     undef %encurl;
-    undef %rescount;
-    undef %mapcount;
     $retfrid='';
     $errtext='';
     my ($untiedhash,$untiedparmhash,$tiedhash,$tiedparmhash); # More state flags.
@@ -1383,13 +1370,8 @@ sub readmap {
             $lock=1;
         }
         undef %randompick;
-        undef %randompickseed;
-        undef %randomorder;
-        undef %randomizationcode;
         undef %hiddenurl;
         undef %encurl;
-        undef %rescount;
-        undef %mapcount;
         $errtext='';
         $retfrid='';
 	#
@@ -1437,18 +1419,14 @@ sub readmap {
 
 #  Depends on user must parameterize this as well..or separate as this is:
 #  more part of determining what someone sees on entering a course?
-#  When lonuserstate::readmap() is called from lonroles.pm, i.e.,
-#  after selecting a role in a course, critical_redirect will be called,
-#  unless the course has a blocking event in effect, which suppresses
-#  critical message checking (users without evb priv).
-#
 
-    if ($critmsg_check) {
-        my ($redirect,$url) = &Apache::loncommon::critical_redirect();
-        if ($redirect) {
-            $retfurl = $url;
+    my @what=&Apache::lonnet::dump('critical',$env{'user.domain'},
+				   $env{'user.name'});
+    if ($what[0]) {
+	if (($what[0] ne 'con_lost') && ($what[0]!~/^error\:/)) {
+	    $retfurl='/adm/email?critical=display';
         }
-    } 
+    }
     return ($retfurl,$errtext);
 }
 
@@ -1544,7 +1522,7 @@ sub build_tmp_hashes {
 # ---------------------------------------------------- Store away initial state
     {
         my $cfh;
-        if (open($cfh,">","$fn.state")) {
+        if (open($cfh,">$fn.state")) {
             print $cfh join("\n",@cond);
             $gotstate = 1;
         } else {
@@ -1581,7 +1559,7 @@ sub evalstate {
     if (-e $fn) {
 	my @conditions=();
 	{
-	    open(my $fh,"<",$fn);
+	    open(my $fh,"<$fn");
 	    @conditions=<$fh>;
             close($fh);
 	}