--- rat/lonuserstate.pm	2002/06/27 14:08:26	1.32
+++ rat/lonuserstate.pm	2002/07/30 20:01:40	1.36
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Construct and maintain state and binary representation of course for user
 #
-# $Id: lonuserstate.pm,v 1.32 2002/06/27 14:08:26 www Exp $
+# $Id: lonuserstate.pm,v 1.36 2002/07/30 20:01:40 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -277,9 +277,10 @@ sub traceroute {
     $sofar=simplify($sofar);
     unless ($beenhere=~/\&$rid\&/) {
        $beenhere.=$rid.'&';  
-       if ($retfurl eq '') {
+       if (($retfurl eq '') && ($hash{'src_'.$rid})) {
            my ($mapid,$resid)=split(/\./,$rid);
-           $retfurl=$hash{'src_'.$rid}.'?symb='.
+           $retfurl=$hash{'src_'.$rid}.
+           (($hash{'src_'.$rid}=~/\?/)?'&':'?').'symb='.
            &Apache::lonnet::symbclean(
                            &Apache::lonnet::declutter($hash{'map_id_'.$mapid}).
                            '___'.$resid.'___'.
@@ -423,7 +424,7 @@ sub pickrandom {
         next if ($#currentrids<$rndpick);
 # -------------------------------- randomly eliminate the ones that should stay
 	srand(&Apache::lonnet::rndseed($rid)); # use rid instead of symb
-        for (my $i=1;$i<=$#currentrids+1-$rndpick;$i++) {
+        for (my $i=1;$i<=$rndpick;$i++) {
             while (1) {
 		my $randomidx=int(rand($#currentrids+1));
                 if ($currentrids[$randomidx]) {
@@ -472,8 +473,8 @@ sub readmap {
    unlink($fn.'parms.db');
    undef %randompick;
    $retfurl='';
-   if ((tie(%hash,'GDBM_File',"$fn.db",&GDBM_WRCREAT,0640)) &&
-       (tie(%parmhash,'GDBM_File',$fn.'_parms.db',&GDBM_WRCREAT,0640))) {
+   if ((tie(%hash,'GDBM_File',"$fn.db",&GDBM_WRCREAT(),0640)) &&
+       (tie(%parmhash,'GDBM_File',$fn.'_parms.db',&GDBM_WRCREAT(),0640))) {
     %hash=();
     %parmhash=();
     $errtext='';