--- loncom/interface/lonannounce.pm 2006/01/12 23:00:08 1.41 +++ loncom/interface/lonannounce.pm 2006/01/12 23:03:41 1.42 @@ -1,7 +1,7 @@ # The LearningOnline Network # Announce # -# $Id: lonannounce.pm,v 1.41 2006/01/12 23:00:08 albertel Exp $ +# $Id: lonannounce.pm,v 1.42 2006/01/12 23:03:41 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -74,9 +74,9 @@ sub readcalendar { my $coursedom=$env{'course.'.$courseid.'.domain'}; my %thiscal=&Apache::lonnet::dump('calendar',$coursedom,$coursenum); my %returnhash=(); - foreach (keys %thiscal) { - unless (($_=~/^error\:/) || ($thiscal{$_}=~/^error\:/)) { - $returnhash{$courseid.'@'.$_}=$thiscal{$_}; + foreach my $item (keys(%thiscal)) { + unless (($item=~/^error\:/) || ($thiscal{$item}=~/^error\:/)) { + $returnhash{$courseid.'@'.$item}=$thiscal{$item}; } } if ($courseid eq $env{'request.course.id'}) { @@ -395,8 +395,8 @@ ENDDOCUMENT # ------------------------------------------------------------ Process commands if ($serverpost) { if ($env{'form.serveraction'}) { - foreach (keys %env) { - if ($_=~/^form\.postto\_(\w+)/) { + foreach my $key (keys(%env)) { + if ($key=~/^form\.postto\_(\w+)/) { $r->print( '
Posting '.$1.': '.&Apache::lonnet::postannounce ($1,$env{'form.serverannnounce'})); @@ -412,11 +412,11 @@ Post announcements to the system login a Check machines:
SERVERANNOUNCE # list servers - foreach (sort keys %Apache::lonnet::hostname) { - if (&Apache::lonnet::allowed('psa',$Apache::lonnet::hostdom{$_})) { - $r->print ('
'. - $_.' '.$Apache::lonnet::hostname{$_}.' '. - ' '. + $host.' '.$Apache::lonnet::hostname{$host}.' '. + 'current'); } } @@ -453,8 +453,8 @@ SERVERANNOUNCE # ---------------------------------------------------------------- Remove items if ($env{'form.action'} eq 'del') { my @delwhich=(); - foreach (keys %env) { - if ($_=~/^form\.remove\_(.+)$/) { + foreach my $key (keys(%env)) { + if ($key=~/^form\.remove\_(.+)$/) { push(@delwhich,$1); } } @@ -469,8 +469,8 @@ SERVERANNOUNCE } # ----------------------------------------------------- Summarize all calendars my %allcal=(); - foreach (&Apache::loncommon::findallcourses()) { - %allcal=(%allcal,&readcalendar($_)); + foreach my $course (&Apache::loncommon::findallcourses()) { + %allcal=(%allcal,&readcalendar($course)); } # ------------------------------- Initialize table and forward backward buttons