CVS log for loncom/interface/lonmsgdisplay.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11.4 (modified)
  Include changes in 1.200

- Stop access denied message for "Refers: to" link in course context where:
  (i) request.role.adv is not 1
  (ii) resource instance had URL hidden set to yes when message was created
  (iii) instance in same course currently has URL hidden not set to yes.

- For 2.11.4 (modified)
  Include changes in 1.199

- For 2.11
  Backport 1.199

- Bug 6929

- For 2.11.4 (modified)
  Include changes in 1.198

- Support access to specific LON-CAPA message after login in cases where a
  LON-CAPA loadbalancer node is used as the portal for a domain.

- For 2.11
  Backport 1.196, 1.197

- Remove unwanted closing tag (originally added in rev. 1.53)

Bug 6955
 -  If IP-based blocking set in domain config is in effect for user's
    current IP address, and 'Messaging 'is among blocked functions:
   (a) 'Send Feedback' (in course context), for resource(s) which allow it
       is only messaging mechanism available to users with out 'evb' priv.
   (b) Subject and Content for messages sent to instructor(s) via 'Send Feedback'
       are replaced in user's Sent Folder with: "Not shown due to IP block".

- For 2.11
  Backport 1.194, 1.195

- Bug 6955 IP-based blocking.
  - Change in args passed to &blocked_in_folder().
  - Remove trailing whitespace.

- Bug 6955 IP-based blocking. Pass user'sIP address as third arg to
  loncommon::blockcheck() and second to loncommon::blocking_status().

- For 2.11
  Backport 1.193

- If display of a message in course context by a privileged user includes
  "student's view of problem" in Resource Details section, load CSS file(s)
  for the resource.

- For 2.11
  Backport 1.192

- Prevent localization of group description in breadcrumbs for group tools.

- For 2.11
  Backport 1.191

- Bug 6921.
  CSS to provide word wrap in display of message body in a LON-CAPA message.

- For 2.11
  Typos in rev. 1.181.2.3 backport of 1.182 changes.

- For 2.11
  Backport 1.182 (part), 1.187, 1.188, 1.189, 1.190

- Coding style.

- Use same size limit (1 MB) for both client-side and server-side checking
  of message attachment size.

- Prepend LC_ to id of hidden form element used in client-side checking for
  uploaded file size, for purposes of namespacing.

- Prepend LC_ to class name in client-side checking for uploaded file size,
  for purposes of namespacing.

- For 2.11
  Backport 1.183

- Bug 6754 LON-CAPA as LTI Consumer
  - Inline menu can include "Communicate" icon for External Tools
  - Functions menu for course personnel can include "Content Grades"
    item if External Tool instance is set to "gradable".

- Trust Settings
  Check if action is permissible based on trust settings for:
  catalog, domroles, enroll, reqcrs, msg, othcoau, or coaurem for current context.

- For 2.11
  - Backport 1.184

- Only show "View recent activity" as an available action if current user is
  in course context, and the sender is a student who was in the same course
  context when sending the message.

- Bug 6780. No "Groups" item in inline menu for users with unprivileged
  course roles if all group home pages are hidden, and no group tools
  enabled.

  Move &display_group_links() from lonsimplepage.pm to longroup.pm to
  facilitate re-use.

File size checking for uploaded files

A new javascript file, file_upload.js, handles client side file size checking.
The function, checkUploadSize(), accepts an html file input element and a maximum
file size (in bytes) as input.  If the size of the file to be uploaded exceeds the
size allowed, a message is displayed the the element is cleared.  Server side
checking is still used if it passes this test.

Loading file_upload.js adds event handlers to file input elements with
class="flUpload".
    <input type="file" class="flUpload" />

It also looks for a hidden element with id="free_space" that contains the maximum
upload size.
    <input type="hidden" id="free_space" value="$free_space" />

The free space is usually calculated by subtracting a user's disk usage from their
quota allowance.  In some cases it is a fixed value.

I have implemented this for every upload instance I could find.  These include:
* Message attachments
* Authoring space
* Portfolio
* Course editor
* Essay response problems
* Helpdesk request forms
* RSS feed uploads

fixed bug 6782, and escaped most localized messages used in Javascript blocks to make sure bugs like that do not happen again

- Report if e-mail was created, in case where privileged user checked:
  "Send copy to permanent e-mail address (if known)". Also log this.

- If an attachment is included in a critical message, the URL needs to be
  passed as the final arg in the call to &lonmsg::user_crit_msg().

- Coding style: keys()

- disfacetoface output enclosed in <div></div> for web target, not tex target.

- Remove debug line.

Addresses bug #5676
Critical messages are now displayed in reverse chronological order.  Also,
only the CRITICAL message folder will be accessible until all critical
messages have been dealt with instead of defaulting to the INBOX.

Improved internationalization:
- Properly compile translation phrases
- Updated related translation file entries

Consistent display of message folders: All internal folders in upper case

In case of trying to delete an internal folder ensure to display folder name INBOX in error message

Do not translate twice

XHTML:
- Fixed typo, rev. 1.53 (text quotation closed at wrong position)
- Fixed typo, rev. 1.70 (incomplete <br />)
- Fixed tag order, rev. 1.53 (start was <b><a> and closure was </a></b>)

Improve display changes made in rev. 1.168 by using CSS instead of dummy table cells.

- Changes to messages in javascript alert pop-ups to facilitate translation.

- More efficient use of screen space, while at the same time retaining
  visual separation of "New Folder" function from other mail folder functions.

- Fix typo in rev. 1.165

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

XHTML: action attribute in <form> tag required (dummy attribute added)

Improved messages/communication page design and usability:
- Avoid wrong click by separating "New Folder" and other functions
- Better clarification of actions at top and bottom of message list
- Improved layout of action list at bottom ("Message Actions")
- Navigation links in menu at top of page now separated from other functions
- Actions for "No critical messages": actionbox
- Corrected unbalanced tags ("Destination folder")

Corrected tag closure

bug #6593 broadcast messages
if there is only one course member for an access status (active/expired/future), a condition check was missing whether that entry was selected

- Customization for MITrelate.
  - Backport 1.158.
  - No domain selector for users from relate domain who do not have .adv priv.

- Move routines for configuration of blocking communication during an exam
  from lonmsgdisplay.pm to separate handler -- lonblockingmenu.pm
- Access to corresponding URL: /adm/setblock from both Messages menu (as before)
  and also from Content and Problem Settings menu.

- Fix comments.

- Sanity checking when retrieving course description for inclusion
  in message display.

Course context was missing from critical messages.
Students need to know to which course the message is related to.
(Thanks to Leo Christianto)

- Typo in 1.124.4.1
- Backport 1.155.

- Sanity checking for ref to array.

- Backport 1.51, 1.52.

- Eliminate routines no longer needed following switch from FCKEditor 2 to CKEdi
tor 3
- Eliminate checking for environment.wysiwygeditor (no longer used).
- Access to "Richtext" editor available via link on each textarea for which it is
  to be made available.
- When editing an HTML document provide "Edit Math" button to allow
  insertion of TeX within the textarea. Button is hidden if Richtext editor in use.
- Additional tags permitted by clear_out_html() - <pre> and <chem>.

- Bug 6251.
  - Third arg is now a ref to a hash, instead of a hash.
  - New (optional) fourth arg, is an additional attribute for the
    select tag, e.g., an onchange action.
- Update calls to loncommon::select_form() accordingly.

Bug #5614: lost headers when cancelling reply

- More of bug6233.
  - Excerpt of message in an e-mail will (by default) omit the break between
    the group part  of the message and the individual student's part
    (<hr /> is eliminated), so warp the <hr /> in a couple of line feeds.

- Backport 1.150.

- Bug 6256.
  - Restoring </form> tag eliminated in rev 1.123.

- Backport 1.139.

- Standard alternating background color for internal message box rows; hover color not needed anymore(?)
- Use standard data_table (call appropriate sub routines and removed now unnecessary styles)
- Moved color indicator to status column
- Localization: added missing &mt() call to status

Optimized screen ergonomics for actions and functions on internal message main page:
- Same alignment for headline and content
- Increased spacing between different items and removed now unnecessary dummy spacing cells
- "Action": Go button right next to corresponding item instead of extra cell
- Same type of usage and design for "New Folder" as for "Action" (headline > input element > Go)
- Better separation of "(un)check all" buttons
- Wrapped "showing ... messages" in separate paragraph
- Added filename style to filename
- Typo; Interpunctation

- &build_block_table was moved to loncommon.pm, and called from there starting with lonmsgdisplay rev 1.44.

Error-messages in a confirm-success-box now have the same font-size as the success-messages. Partly there are both kinds of messages in one box, so it looks better if they have the same font-size.

- Backport 1.141.

- Remove two instances of extra trailing concatenators (added in 1.124.4.5).
- Backport 1.142, 1.146.

- Communication blocking tables: keep checkboxes on the same line as their labels.

- Backport 1.125 (part), 1.138.

- scope
- xhtml

- Backport 1.135, 1.143, 1.144.

- In &mt the argument expected by [quant,_N,text] needs to be a number.

Added confirm-success style and boxes where missing.

Consistent screen ergonomics:
- First checkbox, then option text
- Removed special styles

- Optimized &mt() usage to allow proper translation of "There are no ... messages in this folder."
- Info style for messages about empty folders
- Adjusted translation files es.pm and zh.pm (partly; prepared new phrases), de.pm
  (including changes started in lonmsgdisplay.pm 1.140)

Optimized "Scrollbuttons" on "Send and display messages" page:
- Optimized &mt() usages: Separate style and content
  (Localization still not optimal; work in progress)
- Optimized display: Don't offer (in this case useless) buttons if only one page is shown

- Customization for GCI_3
   - No student submission data appended to feedback messages sent to CCs in gcitest courses.

Adds check before calling lonfeedback::newline_to_br to see if
the text contains block-level HTML elements (such as <table> or <p> or <br />).
If HTML is detected, newlines will no longer be automatically converted
to <br /> tags -- this resolves bugs such as 5550, where for
example, inserting a table using the WYSIWYG editor causes
erroneous break tags to be created.

- Bug 6078 - wording change
- Accommodate Communities

lonaboutme: Changes because I invoke disfacetoface function with argument 'tex' on the wrong position
lonmsgdisplay: delete a log message statement.

-lonaboutme, lontemplate, loncommon, lonmsgdisplay: HTML Validation
-lonaboutme: new delimiter fro quoting the image tag, because from this line I lost the correct
   syntax highlighting for my favorite vim-editor.
-lonmsgdisplay: put target in the argument list of disfacetoface function, to force that I'm interested in a
 tex target. When printing lonaboutme page with facetoface discussion env{form.grade_target} has an empty value.

Localization - Communication and Messages action feedback:
- Added paragraphs and appropriate styles to success, warning and error messages
- Use "quant" to optimize phrases and translations
- Corresponding updates in de.pm

- Backport 1.132, 1.133, 1.134.

- Bug 6028.
 Clicking on column headers in message table on initial load of /adm/communicate bewould not sort because &handler in loncommunicate.pm does not retrieve QUERY_STRING (&handler in lonmsgdisplay.pm does).

- Backport 1.132, 1.133.

- Bug 6004.
- Use correct formname for: "Bcc: course members with future access".

- Bug 6005.
 - Message number in left column of mail folder listing matches number range given in table preamble.

- Reverse part of rev 1.119.  lontemplate::*_functionslist routines not in 2.9.X.

- Backport 1.127, 1.128.

Moved build_blocking_table from loncommon.pm to lonblockingstatus.pm
Added blocking table popup to blogs in lonrss.pm

Moved blocking_status_print from loncommon.pm to lonblockingstatus.pm

Replaced blocking table in lonmsgdisplay.pm to new popup link.

- Term used for type of course used to facilitate collaborative activities,
  e.g., in a campus organization will be "Community".

- Replaced texts for message page button by commonly used icon-like texts
- Corrected unbalanced tags (added missing </a>)
- XHTML:
    - Properly exclude javascript code from being interpreted as HTML code
    - Properly escape parameters in <a href="URL" ...>
    - lower case "onclick", "onchange"

Functionslist:
- Moved sub routines from lontemplate.pm to lonhtmlcommon.pm to allow wider access
- Renamed sub routine names:
    - start_functionslist -> start_funclist
    - item_functionslist -> add_item_funclist
    - end_functionslist -> end_funclist
- Added line breaks for HTML source code
- Added pod documentation to sub routines
- Adjusted sub routine calls

Changes related to modification of LON-CAPA screen header:
- Moved functionslists into new standard screen header "head_subbox"

Other changes:
- Got rid of special style for fieldset legend; adjusted texts
  (lonmsgdisplay.pm, loncommon.pm, de.pm, zh.pm)
- Added warning/info style to warning/info message for weboutput
  and corrected tex output for "No page information provided" message
  (lonsimplepage.pm)
- Optimized floating for functions/actions
  (lonmsgdisplay.pm)

Replaced hardcoded styles for fieldset legends by CSS:
- legends are nearly always wanted to be in bold:
  Added style and removed now unnecessary <b> tags
- Padding wanted for legend texts:
  Added style and removed now unnecessary &nbsp;

XHTML: Attributes in lower-case only (<form method="post" ...)

Optimized screen layout for "Message Log for Selected Users":
- Replaced hardcoded table by standard pick_box
- Added <hr> for better separation of selection options and output
- Extended headline for output:
    - Added message about what kind of content is displayed
    - Added username:domain
    - Added aboutmewrapper to username

Recycle "success" style

XHTML conform tags (input, br, hr)

Update the display for new Messages in the toplevelmenu, if you go on the message site the display in the toplevelmenu now is cleard

Replaced hardcoded and handmade functionlist and actionslist
by standard functionslists provided by lontemplate.pm

- XHTML conform checked attributes in input tags
- Optimized white spaces usage

help_open_topic:
- Repaired unbalanced tags
  (only close help span, if opened before due to existing help link text)
- Localized alt content for help icon
- Added title to help icon
- Optimized CSS usage
- Optimized screen layout:
    - text and help icon now with same background again
    - less agressive background color
    - Added padding

Cheatsheet:
- Replaced <table> structure by <span>s
- Added missing &mt() call to additional help icons text

Adjusted screen layout creation in related scripts to keep old functionality:
lonfeedback.pm, lonmsgdisplay.pm

Table styles in construction space need to be revisited.

Box title is now the main title of the next page and the link text or the former page title will be set to the subtitle in the near future.
Group: consistent wording

edited all chat / Chat => chat room, one entry in mydesk.tab for chatroom and added some missing translations in de.pm

Bug 5865.

consistent wording

weissno: changed "Display all Messages" to "Display All Messages" in the header - failure correction for my last change

weissno: changed "Display All Messages" to "Display all Messages" in the Header for an consistent wording

- Bug 5881.
  - Do not use <div></div> to generate two column display if WYSIWYG is activated.
- Remove extra </div>s.
- Add </td></tr> to balance opening tags.

- "Output Tags" help button only is included in row of help items in authhoring context.
- Third argument to loncommon::helpLatexCheatsheet():  not_author (if true) suppresses display of "Output Tags" item.

- Eliminate duplicate declarations.

- Don't duplicate contents of "Broadcast to:" in "To: " row if $tolist is empty.
- Don't show "To: " row if $tolist is empty.

added one call to &mt

- Use LC_error and LC_warning to wrap messages generated in &disgroup().
- Pass $r (request object) as first arg to &disgroup().
- Return from &disgroup is $hasfloat ('' or 1)
    - 1 if <div>s to be used for 2 column display.
- Removed surplus </a> from inside <th></th> in &disgroup.

- Use a single row for Functions and Actions fieldselects if window allows.
- Additional e-mail -> message changes.
- Remove line feed from within &mt() to aid localization.
- Bold Actions title in fieldset.

- Bold "Functions" title for fieldset containing message actions.

Replaced
  <nobr>...</nobr>
by
  <span class="LC_nobreak">...</span>

- lonsearchcat.pm: Added missing start tag for nobreak area
- lonsurveyreports.pm: Added missing end tag for nobreak area

Display optimizations for functions and actions on message display screen:
- Replaced hardcoded styles and table  by fieldsets
- No special background color and no output in bold anymore
- Optimized float/nobreak behavior for each element
- Prepare functions in an optimized way: separate data collection from screen output (already done for actions)
- Added some comments

consistent notation of e-mail in sentences and E-mail in titles.
button and label renamed, making all button concise.

its a message, not e-mail

Send button correction.

consistent and short button values like "Send", the longer description "Send reply to message" is set as title.

Error: you must have a course role selected to be able to send a broadcast message to a group in the course
renamed to: Error: you must have a course role selected to be able to send a broadcast e-mail to a group in the course

Compose Group E-mail Message
renamed to Compose Group E-mail

Messages being sent
renamed to E-mails being sent

Messages sent
renamed to E-mails sent

$r->print(&submit_button_row($folder,$dismode,$func.' '.$lt{'ma'},
changed to $r->print(&submit_button_row($folder,$dismode,$func,

my $func=&mt('Send New');
changed to my $func=&mt('Send');

Bug 5276.
-  Recipient type - To: or Cc: is preserved when displaying a message you received.
-  When replying can choose which of the To: and Cc: to include in the reply.
-  Additional recipients box includes separate To:, Cc: and Bcc: textboxes.

Message composition screen
- Made more compact
  - "Preview and Check Spelling" on same line as "Send" and "Cancel" buttons
  - "Attachment" row moved above main composition textarea
  - Now one "Critical message" checkbox with radio buttons for return receipt option

Message display
- Link to launch pop-up window to show broadcast recipients when displaying
  a sent message.

Broadcast Messages
- <div> used to create two column-format.
   - Selectors for broadcast recipients in left column.
   - Standard composition elements in right column.
- <fieldset> used to bound each status-based list of potential recipients

Group broadcast
- Group members with sgb priv (or mdg or vgr priv) can elect broadcast message to be Cc or Bcc when sending to active group members.
- If message recipient views message received from a group broadcast when ourse role is selected (in corresponding course), broadcast reply is possible, if group broadcast was originally Cc type, and viewer has sgb, mdg or vgr priv.

- Checking of group broadcast privs moved to new routine: &check_group_priv()

New keys in reciphash stored in nohist_emailrecip.db for sender:
  'course_broadcast','group_cc_broadcast','group_bcc_broadcast'
- allow retrieval of information about broadcast recipients/type.

Optimized Send button texts for internal messages
- Made translation of button text possible/practical: first concatenate, then translate. Added comments.
- Replaced "Mail" with "Message": A LON-CAPA internal message is a "Message", not a "Mail". Usage of "Mail" only in external e-mail context recommended.
- Use only "Send Message", not "Send New Message" - this has more confused than it has helped

Added missing &mt() call

- Eliminate unneeded <pre></pre> which occurs before the first legimate tag (i.e., <html>).
- Missing &end_pick_box().

Wrapped output of internal messages in LON-CAPA standard tables (pick_box)
Separated rows for message text and resource details
Added some comments to source code

Display "Currently available actions" only, if there are actions available
A bit code clean up

Added additional information text at top of page to make even clearer that critical messages need to be moved to the inbox.

- Wrapped critical messages output in standard LON-CAPA tables
- Separated "From" and "Date"
- Changed style for confirm message from critical to warning (fits better)

When creating a broadcast message the recipient lists now have headlines (current, expired, future)

Bugs: 3706 5677 5678.
- Single attachment allowed in messages (whether sent via COM or FDBK).
- Warning displayed if uploaded file exceeded maximum size allowed for attachments (and was therefors discarded).
- Attachments included in forwarded messages (from both single message display, or from forward of multiple messages from folder display).
- Max size definition moved to a single location in lonmsgdisplay.pm and lonfeedback.pm
- Some appearance changes in modify_attachments display (for attachements associated with discussion posts).
- Subdirectory for storage of attachment file in sender's userfiles directory changed from feedback to feedback/$now (i.e., current UNIX time) to lessen likelihood of file being overwritten by a sequent message with an attachment of the same name.

Localization:
Optimized some &mt() calls

Message which informs about how to handle critcal messages was too small. Many students don't recognize this important information. -> Added CSS class

Bug 5178.
- The alert box to pick a destination folder when moving messages annoyed users.
- Now the alert is only shown if a user clicks "Go" but omitted to select a destination folder.

- some more BUG#5350

- BUG#3710, remebering the last mail folder isn't that useful (likely annoying?)

bug 5267.

- correctling css class

bug 5168.
- users with srm priv can designate a reply-to address (which may not be the same as the sender's) for messages
- users with srm priv can specify that a specific message should be eligible fo replies.
- some modification of button display for critical messages for consistency with this.
- Reply link elininated in essage display functions if message is not allowed relies
- Critical message receipts go to reply to address (if different from original sender).

Match of (rep)? was being ignored because of reset of $1.

- xhtml police

Bug 5030.
- Wording of buttons changed depending on whether $content{sendback} is set.
- On button click, message is automatically marked as read after transfer to Inbox.

- style police
- html police

Bug 4614
- Messages composed using COM screen can now specify either Cc or Bcc for the additional recipients textbox.
- recipients written as key = frozenhash to nohist_emailrecip db file in sender's space
- key stored in packaged message
- display of message includes Cc list
- when replying to message can use checkboxes for Ccs and/or "check all", "uncheck all" buttons to include Ccs in reply.
- Does not currently apply to users added via checkboxes in broadcast mode or specified in file in upload mode.

- switch Store to Save

- Bug 3946. Messages sent with multiple recipients now included only once in "Sent Mail" folder, except when mode is "upload".

lonmsgdisplay.pm
- List of recipients included in message in "Sent Mail" folder for additional cases besides Critical and Broadcast.
- If a recipient has forwarding enabled, sender's record of recipients shows original recipient instead of the user account(s) to which it was forwarded.

lonmsg.pm
- Determination of course context of message moved to subroutine.
- User/domain of sent mail folder can be specified when storing sent mail.

- Bug 4551.  Users with dff privilege in a course can add a copy of a message to a User's Record (category Archive).
- Wording change for forwarding screen

- Making perldoc work in lonmsg.pm
- Moving some documentation from lonmsgdisplay.pm to lonmsg.pm
- Fix for critical messages sent to users with multiple forwards (lonmsgdisplay.pm rev 1.12) also needed to be applied for broadcast messages.
- Check for $specialmsg_status{$recipient} modified so sent mail will be stored in case of multiple forwards for critical or broadcast mail.
- Include sanity checking for ARRAY refs.

Style police needs to replace all instances

Bug #4996: student photos in feedback and discussions

- name:domain , name2:domain wasn't working

If there are blocked messages display information about them when there are no other messages in the folder which pass the display filter.

When a folder is deleted, set the $env value for the "folder" form element to '', otherwise "Empty Folder" will be reported for the INBOX, even if that is not true.

Fix bug 5130.

Remove debug line.

If currently viewing a message in the context of a role in the course, check if rsource referred to by message should be encrypted using lonnet::EXT().

Both symb and url are encrypted in display of links, unless viewer has $env{'request.role.adv'}.

Only do check of browse access to the unencrypted baseurl, if not in course context, to determine whether to display "Refers to" link.  (Addresses case where a resource encrypted in one course, is used unencrypted in another).

$fsqs not needed here because $sqs already contains the folder parameter (if defined).

Bug 5116.  Also check for return status of 'ok' or 'con_delayed' to store sent mail or send a message to user's User Notes.

Include symb in msgid when sending feedback about a resource.

Include an error bit in msgid (1 if message is a "bomb" caused by an error when rendering a problem.

Include symb and resource title in messsage (<symb> and <resource_title> tags) when feedback is about a resource.

Navigate Contents page now checks for unread feedback or errors using symb instead of just resource url.

Navigate Contents page checks for resource context based on symb in msgid instead of in [url] included in message subject.  Backwards compatibility with old-style messages retained.

Subject for feedback messages about resources appends message title instead of url inside [].

Title on feedback page now avoids leaking unencrypted file name in cases where no title was assigned to a resource with hidden url.

When displaying feedback messages about a resource in a course, "Refers to" link displayed when viewer has corresponding course role selected includes symb in the link. Link text is now resource title.

"Refers to" link points to unencrypted resource url if feedback message is viewed under role other than original course, only if user has bre privilege for the resource, otherwise "Refers to" link is not displayed.

lonfeedback -- Some replacement of decode_symb() and &clutter() and &dewrapper() with &get_feedurl_and_clean_symb() for replies and edits of discussion posts.

lonfeedback -- More work on in ensuring hidden urls are encrypted or unencrypted as required.

Link needs to include folder name to be able to display messages in folders other than INBOX.  Required for 2.3.0

- save and rember settings between visists
   - sorting (bug#2437)
   - msgstatus
   - folder
   - number to show (bug#4093)

- some test ideas about tranlating

- a few messages missing the "" around the folder name
- one &mt was missing the $folder argument

- better for translating

- eliminating some extra code
- comment to fix emacs syntx highlighting

bugs 4205, 4511
"New messages" display did not include checkboxes and was not honoring limit to number of messages displayed.

"New messages" screen now eliminated.

Can use checkboxes to select multiple messages, and mark read, unread, delete, move to a new folder or forward, for all selected.

Unread messages now appear in bold text.

"Open" and "Delete" links removed.  Message date, sender, and subject for each message are now links which will display the message, if clicked.  Delete occurs by checking checkbox, and clicking "Go" (default action for checked items in folder is delete).

Number of pages required for display of folder contents now correct when the total number of messages is an exact multiple of the number to display per page.

Some sanity cheecking that destination folder for messages being moved is a user-defined folder.

Escape quotes in mail folder names when creating strings for javascript arrays to avoid javascript errors.

transposed quant,_1 in an &mt() call.

bug 3841 - Save => Store

Internationalization

More use of &mt([quant,_1,....])

- BUG#5070, split 'Display Face to face' abilities away from broadcast message send priviledge.

- xhtml

- style

Bug 4636.  Mail folders can now be deleted (if empty) or renamed.

email_status_X.db and nohist_email_X.db files used to store e-mail in different folders now have X set to a unique number (instead of the folder name) for newly created or renamed folders. Legacy data still supported.

Can set blocking of posting to discussion boards in a course, and to a user's course blog via FDBK.

More concise use of &mt() for internationalization.

Ignore the duplication of message in disnew() and disfolder(), for now, because disnew()'s days are numbered.

evb privilege - with this privilege users evade blocking of communication functionality defined by blocks placed by users with dcm privilege.

dcm privilege - this is now used to determine if link to block setting is displayed.

loncommon::findallcourses() now return a hash, where the keys are courseIDs instead of an array of courseIDs.  Places where findallcourses() was called - lonannounce, lonpickcourse changed accordingly.

loncommon::findallcourses() now reports courses for a user where the user's only role was a custom role.

lonnet::allowed() can now take a fourth optional argument ($role) which allows privs to be investigated for roles other than the user's currently active role

&blockcheck, &parse_block_record(), and &build_block_table() moved from lonmsgdisplay to loncommon, so they are available for evaluation of blocking state for other communication functions besides COM.

Each block record for a blocking event in a course is now a hash, with key=values of the hash being setter = username:domain of user who set block, title=event title for block, and blocks = hash of blocked features ('com','chat','boards','port','groups').

Backwards compatibility retained with previous : separated text for block record value.

bug 5018.  Username,domain separator in additional recipients changed from @ to : to support usernames containing @, and also to reduce likelihood of someone entering an e-mail address here.  Also change format expected in uploaded file when generating messages from a file.  Maybe add client side javascript to validate additional recipients entry?

Eliminate $_

Style

- backport 1.41

- https ism (from ticket #5489)

- backport 1.40

- broadcast messages need to have this input in order for things to work correctly

- backport 1.39

Removing sorting liks for now.  Remove debug line.

- backport 1.37 1.38

Group members with sgb privilege can broadcast e-mail to a group and can select from a list of group members to receive the e-mail.  Those with only sgm privilege can enter username:domain of recipient(s), but will not get a list to pick from.

Form element name changed from selectedusers.forminput to selectedusers_forminput so attributes can be obtained via javascript calls for this element.

- backport 1.36

- BUG# 4880, fix up the replying to critical messages so it doesn't look werid

- hiding course type idea for 2.2

- BUG#4856

- typo

- switching the course type accessor

- morph to use new lonnet provided error detector

- braak at the notes adding lines, for use elsewhere

Adding thin veneer to support "ANGEL-style" groups.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

If user's role is restricted to a section only allow students in that
section to be recipients of a course 'broadcast message'.

- style police

Removed old style student prompting.

Use new student email display format... now need to do some cleanup.

Include keylist as argument passed to loncoursedata::get_group_memberships().  Used to add comma-separated list of active groups to a students classlist data in $classlist->{$student}->[index], where index is set so as to add to the end of the existing array.

Notification links

- upadte breadcrumbs calls

- xhtml
- style police
- death to $_

Can select message recipients based on group affiliation.

- removing leftover debug lines
- use the more correcter way to get the dom/num info from a course id

- did the data tabling incorrectly, fixed that
- eliminate some $_

- xhtml

- switch nested tables to LC_data_table

- blocking didn't work on students in section it now does
- additionaly modifed the returned structure so no futher parsing is needed
- add a function for parsng the block record to make it so  further updates are easy to deal with

- change display of username@domain to username:domain
- blocks were storing username@domain:title, changed to username:domain:title
  added code to support both old and new formats

- some random cleanups to the code

- sending a critical message with a msgforward address set would cause messages to not get added to the users sent message folder

- sort the username doamin based on the reiever address when in the sent folder

- localize some messages

- BUG#4741, a complete failure to check any aspect of moving a message
            between folders  meant it was very easy to completly lose
            messages
   - checks if source and target folder are the same
   - checks for any error mesages from get / put and stops as soon as
     something goes wrong
   - requires the msgid to be moved to actually have a msg body to be moved

- additionally, was failing to move messages to the trash in &storechange
  because of a double unescape of the msgid

- more properly hadle the bmsgiid subject (it is normally enocded then escaped, take care of undoing tat in the unpackmsgid now)

- always clear out all bad html in the subject/title line

- BUG #4676, in the sent message screen show the username/domains of the recipents not the sender cause after all that's always the same

- adding LC_error and LC_success classes

- revamp msg display with css

- correcting some vestiges of the lonmsg/lonmsgdisplay splitup

- remove msgcount

- moving most of lonmsg into a new lonmsgdisplay module
- lonmsg now only contains the actual functions to send messages in the system and can now be ewasily used by now mod_pelr routines